127089 2014-01-16 02:10:04 -0800 [GTK] Add CSS Grid Layout as experimental feature 2014-01-17 12:51:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rego rego cgarcia commit-queue gustavo mrobinson svillar oldest_to_newest 968657 0 rego 2014-01-16 02:10:04 -0800 We have a mechanism to enable experimental settings via a environment variable called WEBKITGTK_EXPERIMENTAL_FEATURES. It seems like CSS Grid Layout could be something to be enabled this way at this moment. JFYI, there's not compilation flag for it. 968659 1 221349 rego 2014-01-16 02:18:01 -0800 Created attachment 221349 Patch 968660 2 commit-queue 2014-01-16 02:18:52 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 968756 3 mrobinson 2014-01-16 07:52:07 -0800 Why not just make it enabled by default when it's compiled in? Are there tests that depend on it being turned off? 968771 4 svillar 2014-01-16 08:27:53 -0800 (In reply to comment #3) > Why not just make it enabled by default when it's compiled in? Are there tests that depend on it being turned off? The thing I guess is that it's always built as it isn't behind any preprocessor guard. Knowing that it's a spec in WD status, that it's still prefixed in WebKit, and provided we have this ExperimentalFeatures thingy, I think it's a good idea to add it there. 968784 5 rego 2014-01-16 09:21:34 -0800 (In reply to comment #3) > Why not just make it enabled by default when it's compiled in? Are there tests that depend on it being turned off? Like Sergio says the preprocessor guard was removed a while ago in r117613 (May 2012). So grid layout support is always compiled. There're tests turning on this feature but any of them turning it off. 969220 6 221349 commit-queue 2014-01-17 12:51:50 -0800 Comment on attachment 221349 Patch Clearing flags on attachment: 221349 Committed r162215: <http://trac.webkit.org/changeset/162215> 969221 7 commit-queue 2014-01-17 12:51:52 -0800 All reviewed patches have been landed. Closing bug. 221349 2014-01-16 02:18:01 -0800 2014-01-17 12:51:49 -0800 Patch bug-127089-20140116111800.patch text/plain 3143 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzZlNjNiYjc4ZmQ3MjRm NjAzZWYxZWIxNmZlNDFlMDM2NTMxYTBiNy4uZGRiOTUyNjk0ZmQ3NTY4NTRhMjI1MDY3NDgyNzc3 MGY4MGJkOWE0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAxLTE2ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFk ZCBDU1MgR3JpZCBMYXlvdXQgYXMgZXhwZXJpbWVudGFsIGZlYXR1cmUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzA4OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbG93IENTUyBHcmlkIExheW91dCB0 byBiZSBlbmFibGVkIHRocm91Z2ggdGhlIGVudmlyb25tZW50IHZhcmlhYmxlIFdFQktJVEdUS19F WFBFUklNRU5UQUxfRkVBVFVSRVMuCisKKyAgICAgICAgRXhhbXBsZTogV0VCS0lUR1RLX0VYUEVS SU1FTlRBTF9GRUFUVVJFUz0iQ1NTX0dSSURfTEFZT1VUPTEiCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAgICh3ZWJLaXRTZXR0aW5nc0Nv bnN0cnVjdGVkKTogVXNlIG5ldyBleHBlcmltZW50YWwgZmVhdHVyZSB0byBlbmFibGUgb3IgZGlz YWJsZSBDU1MgR3JpZCBMYXlvdXQuCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9FeHBlcmltZW50 YWxGZWF0dXJlcy5jcHA6IEFkZCBuZXcgZXhwZXJpbWVudGFsIGZlYXR1cmUuCisgICAgICAgICog VUlQcm9jZXNzL2d0ay9FeHBlcmltZW50YWxGZWF0dXJlcy5oOiBEaXR0by4KKwogMjAxNC0wMS0x NSAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgogCiAgICAgICAgIFtTT1VQXSBb V0syXSAtIERpc2FibGUgTWVtb3J5Q2FjaGUgd2hlbiB0aGUgRE9DVU1FTlRfVklFV0VSIGNhY2hl IG1vZGVsIGlzIHNldApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0U2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0U2V0dGluZ3MuY3BwCmluZGV4IDM1OTgwMmVkYjE1MGE4MGIxYjJhNTJiNTU1OWMzMDIz NDE2YzliZGIuLmU4YTFmMzdlMjJmZTNhZTI1ZTk1ZDc2MTdjMWJlYjM2MDMxODQxY2MgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5j cHAKQEAgLTE0Nyw2ICsxNDcsOSBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRTZXR0aW5nc0NvbnN0cnVj dGVkKEdPYmplY3QqIG9iamVjdCkKIAogICAgIFdlYlByZWZlcmVuY2VzKiBwcmVmcyA9IFdFQktJ VF9TRVRUSU5HUyhvYmplY3QpLT5wcml2LT5wcmVmZXJlbmNlcy5nZXQoKTsKICAgICBFeHBlcmlt ZW50YWxGZWF0dXJlcyBmZWF0dXJlczsKKyAgICBib29sIGNzc0dyaWRMYXlvdXRFbmFibGVkID0g ZmVhdHVyZXMuaXNFbmFibGVkKEV4cGVyaW1lbnRhbEZlYXR1cmVzOjpDU1NHcmlkTGF5b3V0KTsK KyAgICBpZiAocHJlZnMtPmNzc0dyaWRMYXlvdXRFbmFibGVkKCkgIT0gY3NzR3JpZExheW91dEVu YWJsZWQpCisgICAgICAgIHByZWZzLT5zZXRDU1NHcmlkTGF5b3V0RW5hYmxlZChjc3NHcmlkTGF5 b3V0RW5hYmxlZCk7CiAgICAgYm9vbCByZWdpb25CYXNlZENvbHVtbnNFbmFibGVkID0gZmVhdHVy ZXMuaXNFbmFibGVkKEV4cGVyaW1lbnRhbEZlYXR1cmVzOjpSZWdpb25CYXNlZENvbHVtbnMpOwog ICAgIGlmIChwcmVmcy0+cmVnaW9uQmFzZWRDb2x1bW5zRW5hYmxlZCgpICE9IHJlZ2lvbkJhc2Vk Q29sdW1uc0VuYWJsZWQpCiAgICAgICAgIHByZWZzLT5zZXRSZWdpb25CYXNlZENvbHVtbnNFbmFi bGVkKHJlZ2lvbkJhc2VkQ29sdW1uc0VuYWJsZWQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2d0ay9FeHBlcmltZW50YWxGZWF0dXJlcy5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvZ3RrL0V4cGVyaW1lbnRhbEZlYXR1cmVzLmNwcAppbmRleCAyYjQ1ZmI2MWYy ODc2MmFjM2Q4MzU4NmMwZjQxMDllNGY5Yjg0NzQ0Li4xYjY5MzAyYWNjNTQ4NTQyMmMxODFmYjg3 YTA2ZjNlNDM5ZjVlN2U1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3Rr L0V4cGVyaW1lbnRhbEZlYXR1cmVzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv Z3RrL0V4cGVyaW1lbnRhbEZlYXR1cmVzLmNwcApAQCAtMzksNiArMzksNyBAQCBzdHJ1Y3QgU2V0 dGluZyB7CiB9OwogCiBzdGF0aWMgU2V0dGluZyBzZXR0aW5nc1tdID0geworICAgIHsgRXhwZXJp bWVudGFsRmVhdHVyZXM6OkNTU0dyaWRMYXlvdXQsICJDU1NfR1JJRF9MQVlPVVQiLCBmYWxzZSB9 LAogICAgIHsgRXhwZXJpbWVudGFsRmVhdHVyZXM6OlJlZ2lvbkJhc2VkQ29sdW1ucywgIlJFR0lP Tl9CQVNFRF9DT0xVTU5TIiwgZmFsc2UgfQogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2d0ay9FeHBlcmltZW50YWxGZWF0dXJlcy5oIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2d0ay9FeHBlcmltZW50YWxGZWF0dXJlcy5oCmluZGV4IGViMDQyMjg4NDBjZmVj ZmNmOTgxNjM0NzkyYTg5Y2RhNmMyYzgxODQuLjU5NjAzY2JmODUwYzFjYWQ0NjgzMWVlYzAyODU2 NzY1NzIxNWY5MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvRXhw ZXJpbWVudGFsRmVhdHVyZXMuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL0V4 cGVyaW1lbnRhbEZlYXR1cmVzLmgKQEAgLTM3LDYgKzM3LDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7 CiBjbGFzcyBFeHBlcmltZW50YWxGZWF0dXJlcyB7CiBwdWJsaWM6CiAgICAgZW51bSBGZWF0dXJl IHsKKyAgICAgICAgQ1NTR3JpZExheW91dCwKICAgICAgICAgUmVnaW9uQmFzZWRDb2x1bW5zCiAg ICAgfTsKIAo=