126927 2014-01-13 12:23:37 -0800 [GTK] Multiple definitions of PluginPackage symbols when only enabling Wayland target 2016-09-06 05:03:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 81456 1 zan zan berto cgarcia gyuyoung.kim mcatanzaro tgergely.u-szeged oldest_to_newest 967447 0 zan 2014-01-13 12:23:37 -0800 [GTK] Multiple definitions of PluginPackage symbols when only enabling Wayland target 967448 1 221073 zan 2014-01-13 12:24:32 -0800 Created attachment 221073 Patch 968271 2 berto 2014-01-15 04:26:43 -0800 *** Bug 126426 has been marked as a duplicate of this bug. *** 968274 3 berto 2014-01-15 04:29:56 -0800 (In reply to comment #1) > Created an attachment (id=221073) [details] This is a revert of r159999, so this would probably reopen bug 123997 968318 4 zan 2014-01-15 07:33:16 -0800 The GTK port doesn't support disabling ENABLE_NETSCAPE_PLUGIN_API because AFAIR the WK2 plugin process doesn't build, and the support for building without the plugin process was removed (at least for the GTK port). That's why the GTK port always includes PluginPackage.cpp into the build, and then either uses PluginPackageGtk.cpp when the X11 target is enabled, PluginPackageWin.cpp when the Win32 target is enabled, and PluginPackageNone.cpp when only the Wayland target is enabled. The proposed patch works for us, but would probably indeed reopen bug #123997. I won't force any port into specific configurations, so I'll add the ENABLE(NETSCAPE_PLUGIN_API) guards around the added code. This should work out OK for everyone. 968626 5 221337 zan 2014-01-15 23:42:47 -0800 Created attachment 221337 Patch 1151975 6 mcatanzaro 2016-01-02 09:14:41 -0800 This patch adds a FIXME relevant to the EFL port. 1226090 7 cgarcia 2016-09-02 22:53:36 -0700 Did this patch land? or is this still a problem with current trunk? 1226656 8 cgarcia 2016-09-06 05:03:02 -0700 I know some people are building wayland only and nobody else complained about this. Feel free to reopen if this is still a problem with current trunk. 221073 2014-01-13 12:24:32 -0800 2014-01-15 23:42:42 -0800 Patch bug-126927-20140113122432.patch text/plain 1593 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxODgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmM3YmQwOGRkZDU1ODcy NWE1NWViNjFiMzVjNGIxNWZkMjRjM2Y3ZC4uYWZiNTFiYTA5YTA4N2Q5ZTkzMzFkZGY5NjM3ZDAw YjMyZTg2ODU5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAxLTEzICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBNdWx0aXBs ZSBkZWZpbml0aW9ucyBvZiBQbHVnaW5QYWNrYWdlIHN5bWJvbHMgd2hlbiBvbmx5IGVuYWJsaW5n IFdheWxhbmQgdGFyZ2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjY5MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwOiBSZW1vdmUgZHVwbGljYXRl IGRlZmluaXRpb25zIG9mIFBsdWdpblBhY2thZ2UgbWV0aG9kcy4KKyAgICAgICAgQWxsIG9mIHRo ZXNlIGFyZSBhbHJlYWR5IGRlZmluZWQgaW4gUGx1Z2luUGFja2FnZS5jcHAuCisKIDIwMTQtMDEt MTMgIFRpYm9yIE1lc3phcm9zICA8dG1lc3phcm9zLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTYxNzE1KTogVXNlIG9mIHVuaW5pdGlhbGl6ZWQg dmFsdWUgJEVOVnsiUExBVEZPUk1fTkFNRSJ9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bHVnaW5zL1BsdWdpblBhY2thZ2VOb25lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1 Z2luUGFja2FnZU5vbmUuY3BwCmluZGV4IDU1YjYwNjYwNTZiMGYyMmY5MjczMjdkMWJlYTkyNTYz NDFkZjQ4MzYuLmY3ZTJhNmIxYWY5Nzc5NjdiYWRhODgyNmRiNzJjMDUwYmRkY2Q2ZTMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCkBAIC00OSwyOCAr NDksNCBAQCB1aW50MTZfdCBQbHVnaW5QYWNrYWdlOjpOUFZlcnNpb24oKSBjb25zdAogfQogI2Vu ZGlmCiAKLVBhc3NSZWZQdHI8UGx1Z2luUGFja2FnZT4gUGx1Z2luUGFja2FnZTo6Y3JlYXRlUGFj a2FnZShjb25zdCBTdHJpbmcmLCBjb25zdCB0aW1lX3QmKQotewotICAgIHJldHVybiAwOwotfQot Ci11bnNpZ25lZCBQbHVnaW5QYWNrYWdlOjpoYXNoKCkgY29uc3QKLXsKLSAgICByZXR1cm4gMDsK LX0KLQotYm9vbCBQbHVnaW5QYWNrYWdlOjplcXVhbChjb25zdCBQbHVnaW5QYWNrYWdlJiwgY29u c3QgUGx1Z2luUGFja2FnZSYpCi17Ci0gICAgcmV0dXJuIHRydWU7Ci19Ci0KLWludCBQbHVnaW5Q YWNrYWdlOjpjb21wYXJlKGNvbnN0IFBsdWdpblBhY2thZ2UmKSBjb25zdAotewotICAgIHJldHVy biAwOwotfQotCi1QbHVnaW5QYWNrYWdlOjp+UGx1Z2luUGFja2FnZSgpCi17Ci19Ci0KIH0K 221337 2014-01-15 23:42:47 -0800 2016-01-02 09:14:50 -0800 Patch bug-126927-20140115234246.patch text/plain 2317 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTE0MDMyZjM4YjQxNGQ4 YTk4Njg5NTI0NDZhMDNiNTNiYjY5OWU0ZC4uMzA2NzhiNWZjNjc3MjFhMGE3ODMyYTBmYTllNWUy NDlkZTJlZTgyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAxLTE1ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBNdWx0aXBs ZSBkZWZpbml0aW9ucyBvZiBQbHVnaW5QYWNrYWdlIHN5bWJvbHMgd2hlbiBvbmx5IGVuYWJsaW5n IFdheWxhbmQgdGFyZ2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjY5MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgUGx1Z2luUGFja2FnZSBzdHViIGltcGxlbWVudGF0aW9ucyBhZGRlZCBpbiBy MTU5OTk5IGFyZSBvbmx5IHVzZWZ1bCBpbiB0aGUgY2FzZSB3aGVyZSB0aGUKKyAgICAgICAgcG9y dCBpcyBkaXNhYmxpbmcgRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEkuIEluIHRoZSBjYXNlIG9m IHRoZSBHVEsgcG9ydCB0aGF0J3MgY29uZmlndXJlZCB0bworICAgICAgICBzdXBwb3J0IG9ubHkg dGhlIFdheWxhbmQgdGFyZ2V0LCB0aGlzIGNhdXNlcyBtdWx0aXBsZSBkZWZpbml0aW9ucyBhcyB0 aGUgR1RLIHBvcnQgYWxzbyBjb21waWxlcworICAgICAgICB0aGUgZGVmaW5pdGlvbnMgaW4gUGx1 Z2luUGFja2FnZS5jcHAuCisKKyAgICAgICAgRm9yIG5vdyB0aGUgc3R1YnMgYXJlIGd1YXJkZWQg d2l0aCAhRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpIHRvIGFwcGVhc2UgYm90aCBwb3J0cywg YnV0IGl0CisgICAgICAgIHRoZSBFRkwgcG9ydCBzaG91bGQgcHJvYmFibHkgc3RhcnQgYnVpbGRp bmcgUGx1Z2luUGFja2FnZS5jcHAgZXZlbiBpZiB0aGUgTmV0c2NhcGUgcGx1Z2luIEFQSQorICAg ICAgICBzdXBwb3J0IGlzIGRpc2FibGVkLgorCisgICAgICAgICogcGx1Z2lucy9QbHVnaW5QYWNr YWdlTm9uZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5QYWNrYWdlOjpOUFZlcnNpb24p OiBSZW1vdmUgdGhlIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKSBndWFyZHMgYXJvdW5kIHRo aXMKKyAgICAgICAgZGVmaW5pdGlvbiBhcyB0aGV5IGFyZW4ndCB1c2VkIGluIGRlY2xhcmF0aW9u IGVpdGhlci4KKwogMjAxNC0wMS0xNSAgTWloYWkgVGljYSAgPG1pdGljYUBhZG9iZS5jb20+CiAK ICAgICAgICAgUmVhcHBseWluZzoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMv UGx1Z2luUGFja2FnZU5vbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNr YWdlTm9uZS5jcHAKaW5kZXggNTViNjA2NjA1NmIwZjIyZjkyNzMyN2QxYmVhOTI1NjM0MWRmNDgz Ni4uNWY4MjY1OGIyNmU1MzEzMWZjYzAwYWI0MDM1MmNmMWIzZjg4ODg4OCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9uZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9uZS5jcHAKQEAgLTQyLDEzICs0MiwxNCBA QCBib29sIFBsdWdpblBhY2thZ2U6OmxvYWQoKQogICAgIHJldHVybiBmYWxzZTsKIH0KIAotI2lm IEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQogdWludDE2X3QgUGx1Z2luUGFja2FnZTo6TlBW ZXJzaW9uKCkgY29uc3QKIHsKICAgICByZXR1cm4gMDsKIH0KLSNlbmRpZgogCisvLyBGSVhNRTog VGhlIEVGTCBwb3J0IGRvZXNuJ3QgYnVpbGQgUGx1Z2luUGFja2FnZS5jcHAgd2hlbiBFTkFCTEVf TkVUU0NBUEVfUExVR0lOX0FQSQorLy8gaXMgZGlzYWJsZWQsIHNvIHRoZXNlIHN0dWIgaW1wbGVt ZW50YXRpb25zIGFyZSBwbGFjZWQgaGVyZS4KKyNpZiAhRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9B UEkpCiBQYXNzUmVmUHRyPFBsdWdpblBhY2thZ2U+IFBsdWdpblBhY2thZ2U6OmNyZWF0ZVBhY2th Z2UoY29uc3QgU3RyaW5nJiwgY29uc3QgdGltZV90JikKIHsKICAgICByZXR1cm4gMDsKQEAgLTcy LDUgKzczLDYgQEAgaW50IFBsdWdpblBhY2thZ2U6OmNvbXBhcmUoY29uc3QgUGx1Z2luUGFja2Fn ZSYpIGNvbnN0CiBQbHVnaW5QYWNrYWdlOjp+UGx1Z2luUGFja2FnZSgpCiB7CiB9CisjZW5kaWYg Ly8gIUVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQogCiB9Cg==