126899 2014-01-13 07:37:48 -0800 Subpixel layout: IntRect::infiniteRect() overflows when subpixel layout is enabled. 2014-01-19 10:51:36 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126283 1 zalan zalan commit-queue sam simon.fraser thorton oldest_to_newest 967302 0 zalan 2014-01-13 07:37:48 -0800 svg/custom/masking-clipping-hidpi.svg 968882 1 zalan 2014-01-16 12:46:47 -0800 overflow caused by IntRect::infiniteRect() (static IntRect infiniteRect(-std::numeric_limits<int>::max() / 2, -std::numeric_limits<int>::max() / 2, std::numeric_limits<int>::max(), std::numeric_limits<int>::max()); ) causes unexpected clipping -> missing content. 968893 2 zalan 2014-01-16 13:04:56 -0800 This should help diff --git a/Source/WebCore/platform/graphics/IntRect.h b/Source/WebCore/platform/graphics/IntRect.h index 0a6d4aa..130fd83 100644 --- a/Source/WebCore/platform/graphics/IntRect.h +++ b/Source/WebCore/platform/graphics/IntRect.h @@ -27,6 +27,7 @@ #define IntRect_h #include "IntPoint.h" +#include "LayoutUnit.h" #include <wtf/Vector.h> #if USE(CG) @@ -236,7 +237,8 @@ inline bool operator!=(const IntRect& a, const IntRect& b) inline IntRect IntRect::infiniteRect() { - static IntRect infiniteRect(-std::numeric_limits<int>::max() / 2, -std::numeric_limits<int>::max() / 2, std::numeric_limits<int>::max(), std::numeric_limits<int>::max()); + static IntRect infiniteRect(-LayoutUnit::max() / 2, -LayoutUnit::max() / 2, LayoutUnit::max(), LayoutUnit::max()); return infiniteRect; } 968922 3 thorton 2014-01-16 13:56:39 -0800 Oh, yes, one of the other ports noticed that we should do this (I didn't want to, but eventually became resigned to it) but closed their bug in a different way so I forgot about it. r+ if you post a patch. 969461 4 221555 zalan 2014-01-18 10:17:29 -0800 Created attachment 221555 Patch 969512 5 221555 commit-queue 2014-01-18 13:20:08 -0800 Comment on attachment 221555 Patch Clearing flags on attachment: 221555 Committed r162273: <http://trac.webkit.org/changeset/162273> 969513 6 commit-queue 2014-01-18 13:20:10 -0800 All reviewed patches have been landed. Closing bug. 969604 7 sam 2014-01-19 10:51:36 -0800 This doesn't sit right with me (why should something called infiniteRect() have anything to do with LayoutUnits?) Can we at least add a comment explaining this weirdness? 221555 2014-01-18 10:17:29 -0800 2014-01-18 13:20:07 -0800 Patch bug-126899-20140118101729.patch text/plain 3287 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmFjMTM2YzRhOTM1OWEx MDFiMDgwMjMxZjA4MjI4ZWRjMzk2NGI2NS4uNjBiMWQzN2IwYWZjNjZhZWFmMDcwNDc0MjkwZmY4 NWFiOGFmZTZmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAxLTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3VicGl4ZWwgbGF5b3V0OiBJ bnRSZWN0OjppbmZpbml0ZVJlY3QoKSBvdmVyZmxvd3Mgd2hlbiBzdWJwaXhlbCBsYXlvdXQgaXMg ZW5hYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNjg5OQorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24uCisKKyAgICAgICAgVXNl IExheW91dFVuaXRzIHdoZW4gc2V0dGluZyB0aGUgaW5maW5pdGUgdmFsdWVzIG9uIEludFJlY3Q6 OmluZmluaXRlUmVjdCgpIHRvIGVuc3VyZQorICAgICAgICBpdCB3b24ndCBvdmVyZmxvdyBsYXRl ciB3aGVuIHRoZSBJbnRSZWN0IGdldHMgY29udmVydGVkIHRvIExheW91dFJlY3QuCisKKyAgICAg ICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL0ludFJlY3QuaDoKKyAgICAgICAgKFdlYkNvcmU6OkludFJlY3Q6OmluZmluaXRlUmVjdCk6 CisKIDIwMTQtMDEtMTggIExhdXJvIE5ldG8gIDxsYXVyby5uZXRvQG9wZW5ib3NzYS5vcmc+CiAK ICAgICAgICAgUmVtb3ZlIE5peCBmaWxlcyBmcm9tIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFJlY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0ludFJlY3QuaAppbmRleCAwYTZkNGFhZGM0OThhNmQ5ODhhYWJmOTdi YzhlMDk1ZDU0NWVkZTA3Li4wNDNjYTBlMWY2ZjU5ZTk1YThjOWIzNjY5Y2M5Mzc1ZDJmYWZiMjNk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRSZWN0LmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UmVjdC5oCkBAIC0yNyw2 ICsyNyw3IEBACiAjZGVmaW5lIEludFJlY3RfaAogCiAjaW5jbHVkZSAiSW50UG9pbnQuaCIKKyNp bmNsdWRlICJMYXlvdXRVbml0LmgiCiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCiAjaWYgVVNF KENHKQpAQCAtMjM2LDcgKzIzNyw3IEBAIGlubGluZSBib29sIG9wZXJhdG9yIT0oY29uc3QgSW50 UmVjdCYgYSwgY29uc3QgSW50UmVjdCYgYikKIAogaW5saW5lIEludFJlY3QgSW50UmVjdDo6aW5m aW5pdGVSZWN0KCkKIHsKLSAgICBzdGF0aWMgSW50UmVjdCBpbmZpbml0ZVJlY3QoLXN0ZDo6bnVt ZXJpY19saW1pdHM8aW50Pjo6bWF4KCkgLyAyLCAtc3RkOjpudW1lcmljX2xpbWl0czxpbnQ+Ojpt YXgoKSAvIDIsIHN0ZDo6bnVtZXJpY19saW1pdHM8aW50Pjo6bWF4KCksIHN0ZDo6bnVtZXJpY19s aW1pdHM8aW50Pjo6bWF4KCkpOworICAgIHN0YXRpYyBJbnRSZWN0IGluZmluaXRlUmVjdCgtTGF5 b3V0VW5pdDo6bWF4KCkgLyAyLCAtTGF5b3V0VW5pdDo6bWF4KCkgLyAyLCBMYXlvdXRVbml0Ojpt YXgoKSwgTGF5b3V0VW5pdDo6bWF4KCkpOwogICAgIHJldHVybiBpbmZpbml0ZVJlY3Q7CiB9CiAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5OTFlMzQ3ZTUzYTFlZTliMTAwY2QxNTlkMzVkZjU1ZTE3MDE1MGJmLi5iZDcyMzA0 NGEwZWQ1ZThiMTE1YWViYjljOGJjY2M5MWY3NGI3N2FjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTQtMDEtMTggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBT dWJwaXhlbCBsYXlvdXQ6IEludFJlY3Q6OmluZmluaXRlUmVjdCgpIG92ZXJmbG93cyB3aGVuIHN1 YnBpeGVsIGxheW91dCBpcyBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRv bi4KKworICAgICAgICBVc2UgTGF5b3V0VW5pdHMgd2hlbiBzZXR0aW5nIHRoZSBpbmZpbml0ZSB2 YWx1ZXMgb24gSW50UmVjdDo6aW5maW5pdGVSZWN0KCkgdG8gZW5zdXJlCisgICAgICAgIGl0IHdv bid0IG92ZXJmbG93IGxhdGVyIHdoZW4gdGhlIEludFJlY3QgZ2V0cyBjb252ZXJ0ZWQgdG8gTGF5 b3V0UmVjdC4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOiBVbnNr aXBwaW5nIHN2ZyB0ZXN0IChmYWlsZWQgd2l0aCBzdWJwaXhlbCBvbikKKwogMjAxNC0wMS0xNyAg QmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgTmVlZCBhIHdheSB0byB0 ZXN0IHRoZSB0aWxlIGNhY2hlIHdpdGggbWFyZ2lucyBlbmFibGVkCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGUwZjg0ZmEwZjU3MWI2M2NlY2I2Nzc3MTlm ZWZiODRlMzcyZDFjZDMuLjQ5OTRlYmQ3ZGVmMzc1OTc4ZGM4YTk0ZmE2ZTg1ZWRjOTEyYWZmYzMg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMzU3LDgg KzEzNTcsNSBAQCB3ZWJraXQub3JnL2IvMTI2ODk3IG1hdGhtbC9wcmVzZW50YXRpb24vYnVnOTUw MTUuaHRtbAogIyBTdWJwaXhlbDogLXdlYmtpdC1mbGV4IG9mZi1ieS1vbmUgcHgKIHdlYmtpdC5v cmcvYi8xMjY4OTggY3NzMy9mbGV4Ym94L2ltYWdlLXBlcmNlbnQtbWF4LWhlaWdodC5odG1sCiAK LSMgU3VicGl4ZWw6IG1pc3NpbmcgdGV4dCBiZXR3ZWVuIHN2ZyBjb250ZW50cwotd2Via2l0Lm9y Zy9iLzEyNjg5OSBzdmcvY3VzdG9tL21hc2tpbmctY2xpcHBpbmctaGlkcGkuc3ZnCi0KICMgU3Vi cGl4ZWw6IG1pc3BsYWNlZCB6b29tZWQgc3ZnIGNvbnRlbnQuCiB3ZWJraXQub3JnL2IvMTI2OTAw IHN2Zy96b29tL3BhZ2Uvem9vbS16b29tLWNvb3Jkcy54aHRtbAo=