<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126453</bug_id>
          
          <creation_ts>2014-01-03 12:54:01 -0800</creation_ts>
          <short_desc>[GTK] [CMake] Improve the way that translations are built with the built-in gettext support CMake</short_desc>
          <delta_ts>2014-01-06 13:48:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>116379</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Martin Robinson">mrobinson</reporter>
          <assigned_to name="Martin Robinson">mrobinson</assigned_to>
          <cc>bunhere</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>rakuco</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>964231</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-01-03 12:54:01 -0800</bug_when>
    <thetext>CMake has some very handy built-in support for gettext that can simplify our build and automatically take care of installation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964233</commentid>
    <comment_count>1</comment_count>
      <attachid>220329</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-01-03 12:56:36 -0800</bug_when>
    <thetext>Created attachment 220329
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964741</commentid>
    <comment_count>2</comment_count>
      <attachid>220329</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2014-01-06 13:45:17 -0800</bug_when>
    <thetext>Comment on attachment 220329
Patch

hah, nice; I don&apos;t think we want po files to be update automatically, it often triggered issues with merge conflicts and buildbots would break</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964744</commentid>
    <comment_count>3</comment_count>
      <attachid>220329</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-01-06 13:48:43 -0800</bug_when>
    <thetext>Comment on attachment 220329
Patch

Clearing flags on attachment: 220329

Committed r161370: &lt;http://trac.webkit.org/changeset/161370&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964745</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-01-06 13:48:46 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220329</attachid>
            <date>2014-01-03 12:56:36 -0800</date>
            <delta_ts>2014-01-06 13:48:43 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-126453-20140103125634.patch</filename>
            <type>text/plain</type>
            <size>2543</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9ndGsvcG8vQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL3Bv
L0NoYW5nZUxvZwppbmRleCAyZWVhZWJlMDQzNmU0YzAzNmM5YzY1YTZmYjM1MDhjNjk2ODExODgz
Li4zNDg1NWYwNTBiYWExZmY1NTBmOGM3NDcyOWNhOWY0ZmIyODQyN2MzIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvcG8vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2d0ay9wby9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNC0wMS0w
MyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dU
S10gW0NNYWtlXSBJbXByb3ZlIHRoZSB3YXkgdGhhdCB0cmFuc2xhdGlvbnMgYXJlIGJ1aWx0IHdp
dGggdGhlIGJ1aWx0LWluIGdldHRleHQgc3VwcG9ydCBDTWFrZQorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2NDUzCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogVXNlIHRoZSBi
dWlsdC1pbiBDTWFrZSBzdXBwb3J0IGZvciBnZXR0ZXh0IHRvIHNpbXBsaWZ5IHRoZSB3YXkgd2UK
KyAgICAgICAgYnVpbGQgdHJhbnNsYXRpb24gZmlsZXMgYW5kIHRvIGF1dG9tYXRpY2FsbHkgdGFr
ZSBjYXJlIG9mIGluc3RhbGxpbmcgdGhlbS4gQWxzbyBhZGp1c3QKKyAgICAgICAgdGhlIHBvdCBm
aWxlIGJ1aWxkIGxvY2F0aW9uIHRvIG1ha2UgdGhlIENNYWtlIGJ1aWxkIG1vcmUgc2ltaWxhciB0
byBhdXRvdG9vbHMuCisKIDIwMTMtMTItMjkgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBp
Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW0NNYWtlXSBUcmFuc2xhdGlvbnMgbXVzdCBiZSBi
dWlsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL3BvL0NNYWtlTGlz
dHMudHh0IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL3BvL0NNYWtlTGlzdHMudHh0Cmlu
ZGV4IGFlMTkxMTExMzhlMmMxNjk3Zjg2N2JiZjc2MTUwYzAzZGEzN2ZmY2QuLmM1Zjc4ODg3OTQ4
OGExMmQ5YWEyM2ZlNmZmY2IwOTVjNmRkN2EyMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL2d0ay9wby9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9ndGsvcG8vQ01ha2VMaXN0cy50eHQKQEAgLTEsNSArMSwxMiBAQAoraW5jbHVkZShGaW5k
R2V0dGV4dCkKKworIyBHRVRURVhUX0NSRUFURV9UUkFOU0xBVElPTlMgYXV0b21hdGljYWxseSBy
dW5zIG1zZ21lcmdlLCB3aGljaCBpcyBzb21ldGhpbmcgd2UKKyMgZGlkbid0IGRvIGluIHRoZSBv
bGQgYXV0b3Rvb2xzIGJ1aWxkLiBUaGlzIG92ZXJ3cml0ZXMgYWxsIHRoZSBwbyBmaWxlcyBpbiB0
aGUKKyMgU291cmNlIGRpcmVjdG9yeS4gUGVyaGFwcyB3ZSB3YW50IHRoaXMsIGJ1dCBmb3Igbm93
IGRpc2FibGUgaXQgdG8gbWFpbnRhaW4gY29tcGF0aWJpbGl0eS4KK3NldChHRVRURVhUX01TR01F
UkdFX0VYRUNVVEFCTEUgOikKKwogc2V0KGRvbWFpbiBXZWJLaXRHVEstMy4wKQotc2V0KGJ1aWxk
X2RpcmVjdG9yeSAke0NNQUtFX0JJTkFSWV9ESVJ9L3BvKQorc2V0KGJ1aWxkX2RpcmVjdG9yeSAk
e0NNQUtFX0JJTkFSWV9ESVJ9L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wbykKIHNldChw
b3RfZmlsZSAke2J1aWxkX2RpcmVjdG9yeX0vJHtkb21haW59LnBvdCkKIHNldChwb3RmaWxlc19m
aWxlICR7YnVpbGRfZGlyZWN0b3J5fS9QT1RGSUxFUykKIApAQCAtMjMsMjUgKzMwLDQgQEAgYWRk
X2N1c3RvbV9jb21tYW5kKAogKQogCiBmaWxlKEdMT0IgcG9fZmlsZXMgKi5wbykKLWZvcmVhY2gg
KGZpbGUgJHtwb19maWxlc30pCi0gICAgZ2V0X2ZpbGVuYW1lX2NvbXBvbmVudChsYW5ndWFnZSAk
e2ZpbGV9IE5BTUVfV0UpCi0gICAgc2V0KG1vX2ZpbGUgJHtidWlsZF9kaXJlY3Rvcnl9LyR7bGFu
Z3VhZ2V9Lm1vKQotICAgIGxpc3QoQVBQRU5EIG1vX2ZpbGVzICR7bW9fZmlsZX0pCi0KLSAgICBh
ZGRfY3VzdG9tX2NvbW1hbmQoCi0gICAgICAgIE9VVFBVVCAke21vX2ZpbGV9Ci0gICAgICAgIERF
UEVORFMgJHtmaWxlfQotICAgICAgICBERVBFTkRTICR7cG90X2ZpbGV9Ci0gICAgICAgIENPTU1B
TkQgbXNnZm10IC1jIC1vICR7bW9fZmlsZX0gJHtmaWxlfQotICAgICkKLWVuZGZvcmVhY2ggKCkK
LQotYWRkX2N1c3RvbV90YXJnZXQodXBkYXRlLW1vLWZpbGVzIEFMTAotICAgICAgICAgICAgICAg
ICAgREVQRU5EUyAke21vX2ZpbGVzfQotKQotCi1hZGRfY3VzdG9tX3RhcmdldCh1cGRhdGUtcG8g
QUxMCi0gICAgICAgICAgICAgICAgICBERVBFTkRTIHVwZGF0ZS1tby1maWxlcwotICAgICAgICAg
ICAgICAgICAgREVQRU5EUyAke3BvdF9maWxlfQotKQotCitHRVRURVhUX0NSRUFURV9UUkFOU0xB
VElPTlMoJHtwb3RfZmlsZX0gQUxMICR7cG9fZmlsZXN9KQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>