126232 2013-12-25 10:59:15 -0800 [GTK] [CMake] Convenience libraries that export API should be compiled with --whole-archive on Unix 2013-12-29 10:46:29 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 115966 1 mrobinson mrobinson cdumez commit-queue gustavo gyuyoung.kim rakuco oldest_to_newest 962849 0 mrobinson 2013-12-25 10:59:15 -0800 CMake doesn't automatically add --whole-archive when linking convenience libraries, so we need to add it to the linker command line manually. Without the flag, the linker will trim unused symbols from the final shared object. 963037 1 mrobinson 2013-12-26 16:11:56 -0800 An example of this issue for me is that after linking, $ objdump -T lib/libwebkitgtk-3.0.so | grep webkit_dom_css_value_get_type does not show any output. With this change, I see: 0000000001fdefc0 g DF .text 0000000000000090 Base webkit_dom_css_value_get_type This change may seem a bit mysterious, but I've confirmed that libtool (which isn't used in the CMake build) does this as well. 963038 2 220037 mrobinson 2013-12-26 16:12:39 -0800 Created attachment 220037 Patch 963217 3 220037 mrobinson 2013-12-29 10:46:26 -0800 Comment on attachment 220037 Patch Clearing flags on attachment: 220037 Committed r161121: <http://trac.webkit.org/changeset/161121> 963218 4 mrobinson 2013-12-29 10:46:29 -0800 All reviewed patches have been landed. Closing bug. 220037 2013-12-26 16:12:39 -0800 2013-12-29 10:46:26 -0800 Patch bug-126232-20131226161238.patch text/plain 2959 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM0ODc2M2Y3OWE5ZDViYzQ3 MGEyMjgwYzA1ZDkxYjIzN2ZiZmYxYmIuLjU4OWI3ZThmNWMwZjZjMjA0MGYyZmJhNzljYTFkNDMy MDkwZDFkYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTItMjYgIE1hcnRpbiBS b2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFtDTWFrZV0g Q29udmVuaWVuY2UgbGlicmFyaWVzIHRoYXQgZXhwb3J0IEFQSSBzaG91bGQgYmUgY29tcGlsZWQg d2l0aCAtLXdob2xlLWFyY2hpdmUgb24gVW5peAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MjMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZTogUHJlZml4IGxpYkdPYmpl Y3RET01CaW5kaW5ncyB3aXRoIC0td2hvbGUtYXJjaGl2ZSBzbyB0aGF0CisgICAgICAgIHN5bWJv bHMgYXJlIG5vdCBvbWl0dGVkIGR1cmluZyBmaW5hbCBsaW5raW5nLgorCiAyMDEzLTEyLTI1ICBN YXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBb Q01ha2VdIENsZWFuIHVwIGdlbmVyYXRlZCBzb3VyY2VzIGRpcmVjdG9yaWVzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggMTVmMjQxZWUyNTEyNjVkM2JmMjQzYzAzZjMyZmQ3NGQ2N2I5ZDgxZS4uNTk1YzAyODA2MzU3 YjlhMzY3MjhmOTUzZTBmNjg4ZTRjZDY4Zjk1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTEyLTI2ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKwor ICAgICAgICBbR1RLXSBbQ01ha2VdIENvbnZlbmllbmNlIGxpYnJhcmllcyB0aGF0IGV4cG9ydCBB UEkgc2hvdWxkIGJlIGNvbXBpbGVkIHdpdGggLS13aG9sZS1hcmNoaXZlIG9uIFVuaXgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjIzMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUGxhdGZvcm1HVEsu Y21ha2U6IFByZWZpeCBsaWJHT2JqZWN0RE9NQmluZGluZ3Mgd2l0aCAtLXdob2xlLWFyY2hpdmUg c28gdGhhdAorICAgICAgICBzeW1ib2xzIGFyZSBub3Qgb21pdHRlZCBkdXJpbmcgZmluYWwgbGlu a2luZy4KKwogMjAxMy0xMi0yNiAgVGhpYWdvIGRlIEJhcnJvcyBMYWNlcmRhICA8dGhpYWdvLmxh Y2VyZGFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbV0syXVtDb29yZGluYXRlZEdyYXBoaWNz XSBSZW1vdmluZyBkdXBsaWNhdGUgc2NhbGUgaW5mb3JtYXRpb24gZnJvbSBXZWJWSWV3LmNwcApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZSBiL1NvdXJjZS9XZWJL aXQvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggYTUwMzA0OTdiNzI4MGVkNzFhZmExN2Q5OTEwN2Qx NmVmMTI5MDM4OC4uMmM2NTQxY2E2YmYyYjMwMzQ4Y2I2OWIyODhhYzU4NzgyNzJmNjgxNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0xMjksOCArMTI5LDEwIEBAIGxpc3QoQVBQRU5EIFdl YktpdEdUS19JTlNUQUxMRURfSEVBREVSUwogICAgICR7V0VCS0lUX0RJUn0vZ3RrL3dlYmtpdC93 ZWJraXR3ZWJ3aW5kb3dmZWF0dXJlcy5oCiApCiAKKyMgU2luY2UgdGhlIEdPYmplY3RET01CaW5k aW5ncyBjb252ZW5pZW5jZSBsaWJyYXJ5IGV4cG9ydHMgQVBJIHRoYXQgaXMgdW51c2VkIGV4Y2Vw dAorIyBpbiBlbWJlZGRpbmcgYXBwbGljYXRpb25zIHdlIG5lZWQgdG8gaW5zdHJ1Y3QgdGhlIGxp bmtlciB0byBsaW5rIGFsbCBzeW1ib2xzIGV4cGxpY2l0bHkuCiBsaXN0KEFQUEVORCBXZWJLaXRf TElCUkFSSUVTCi0gICAgR09iamVjdERPTUJpbmRpbmdzCisgICAgLVdsLC0td2hvbGUtYXJjaGl2 ZSBHT2JqZWN0RE9NQmluZGluZ3MgLVdsLC0tbm8td2hvbGUtYXJjaGl2ZQogICAgIFdlYkNvcmVQ bGF0Zm9ybUdUSwogKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdUSy5j bWFrZSBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IGRlMDg5ZGZkYTky M2JhMWI4MjJmYzc5NTdmYTAxYmUyZjMyZjQ3OWQuLjZhNzUxMjQ5MDE5YWI4YmZiYTVhZjAxOGUz OTBiYjExYmZhNjZjMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNt YWtlCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC00MjYsOCArNDI2 LDEwIEBAIHNldChTaGFyZWRXZWJLaXQyTGlicmFyaWVzCiAgICAgJHtXZWJLaXQyX0xJQlJBUklF U30KICkKIAorIyBTaW5jZSB0aGUgR09iamVjdERPTUJpbmRpbmdzIGNvbnZlbmllbmNlIGxpYnJh cnkgZXhwb3J0cyBBUEkgdGhhdCBpcyB1bnVzZWQgZXhjZXB0CisjIGluIGVtYmVkZGluZyBhcHBs aWNhdGlvbnMgd2UgbmVlZCB0byBpbnN0cnVjdCB0aGUgbGlua2VyIHRvIGxpbmsgYWxsIHN5bWJv bHMgZXhwbGljaXRseS4KIGxpc3QoQVBQRU5EIFdlYktpdDJfTElCUkFSSUVTCi0gICAgR09iamVj dERPTUJpbmRpbmdzCisgICAgLVdsLC0td2hvbGUtYXJjaGl2ZSBHT2JqZWN0RE9NQmluZGluZ3Mg LVdsLC0tbm8td2hvbGUtYXJjaGl2ZQogICAgIFdlYkNvcmVQbGF0Zm9ybUdUSwogKQogCg==