126131 2013-12-22 03:13:11 -0800 [GTK] Downloads are broken with the network process enabled 2013-12-28 00:32:57 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 126258 108832 126114 1 cgarcia webkit-unassigned cdumez commit-queue danw gustavo mrobinson rakuco oldest_to_newest 962311 0 cgarcia 2013-12-22 03:13:11 -0800 All unit tests crash or timeout. $ ../../Tools/Scripts/run-gtk-tests --verbose --no-xvfb Programs/WebKit2APITests/TestDownloads TEST: Programs/WebKit2APITests/TestDownloads... (pid=2843) /webkit2/Downloads/local-file: OK /webkit2/Downloads/local-file-error: OK /webkit2/Downloads/remote-file: OK /webkit2/Downloads/remote-file-error: OK /webkit2/Downloads/policy-decision-download: OK /webkit2/WebKitWebView/download-uri: OK PASS: Programs/WebKit2APITests/TestDownloads $ WEBKIT_USE_NETWORK_PROCESS=1 ../../Tools/Scripts/run-gtk-tests --verbose --no-xvfb Programs/WebKit2APITests/TestDownloads TEST: Programs/WebKit2APITests/TestDownloads... (pid=2926) /webkit2/Downloads/local-file: FAIL GTester: last random seed: R02S57a2eee4f1b241d7699b7ee2d77abf61 (pid=2930) /webkit2/Downloads/local-file-error: FAIL GTester: last random seed: R02S33e0866d248195d78c521eff0e438e79 (pid=2933) /webkit2/Downloads/remote-file: FAIL GTester: last random seed: R02S8f9b1ae1ed5aa43f290021a8f26b9d88 (pid=2936) /webkit2/Downloads/remote-file-error: FAIL GTester: last random seed: R02S0c7a293ca9e38eb50b55799878cc2906 (pid=2939) TEST: Programs/WebKit2APITests/TestDownloads: TIMEOUT 963096 1 cgarcia 2013-12-27 01:22:16 -0800 Patch in bug https://bugs.webkit.org/show_bug.cgi?id=126258 fixes all test cases except /webkit2/Downloads/policy-decision-download that still times out: $ WEBKIT_USE_NETWORK_PROCESS=1 Programs/WebKit2APITests/TestDownloads -s /webkit2/Downloads/policy-decision-download /webkit2/Downloads/local-file: OK /webkit2/Downloads/local-file-error: OK /webkit2/Downloads/remote-file: OK /webkit2/Downloads/remote-file-error: OK /webkit2/WebKitWebView/download-uri: OK 963106 2 220056 cgarcia 2013-12-27 03:12:01 -0800 Created attachment 220056 Patch $ WEBKIT_USE_NETWORK_PROCESS=1 Programs/WebKit2APITests/TestDownloads -p /webkit2/Downloads/policy-decision-download /webkit2/Downloads/policy-decision-download: OK 963145 3 220056 mrobinson 2013-12-27 16:41:32 -0800 Comment on attachment 220056 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220056&action=review > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:729 > if (d->client()->usesAsyncCallbacks()) > handle->client()->didReceiveResponseAsync(handle.get(), d->m_response); > - else > + else { > handle->client()->didReceiveResponse(handle.get(), d->m_response); > + continueAfterDidReceiveResponse(handle.get()); > + } Early return here maybe? 963159 4 cgarcia 2013-12-28 00:32:57 -0800 Committed r161109: <http://trac.webkit.org/changeset/161109> 220056 2013-12-27 03:12:01 -0800 2013-12-27 16:41:31 -0800 Patch wk2-convert-to-download-network-process.diff text/plain 5391 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMzk3M2EyLi42NzE1ODA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTMtMTItMjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIERvd25sb2FkcyBhcmUgYnJva2VuIHdpdGggdGhlIG5ldHdvcmsg cHJvY2VzcyBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjYxMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgcHJvYmxlbSBpcyB0aGF0IHRoZSBuZXR3b3JrIHByb2Nlc3MgY3Jhc2hlcyB3 aGVuIHRyeWluZyB0bworICAgICAgICBjb252ZXJ0IHRoZSBoYW5kbGUgdG8gYSBkb3dubG9hZCwg YmVjYXVzZSBhdCB0aGF0IHBvaW50IHRoZQorICAgICAgICBkb3dubG9hZCBoYXMgZmluaXNoZWQg YW5kIHRoZSBoYW5kbGUgaXMgTlVMTC4gVGhpcyBoYXBwZW5zIGJlY2F1c2UKKyAgICAgICAgd2Ug YXJlIG5vdCBpbXBsZW1lbnRpbmcgUmVzb3VyY2VIYW5kbGU6OmNvbnRpbnVlRGlkUmVjZWl2ZVJl c3BvbnNlKCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5k bGVTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om5leHRNdWx0aXBhcnRSZXNwb25zZVBhcnRD YWxsYmFjayk6IENhbGwKKyAgICAgICAgY29udGludWVBZnRlckRpZFJlY2VpdmVSZXNwb25zZSgp IHdoZW4gbm90IHVzaW5nIGFzeW5jIGNhbGxiYWNrcy4KKyAgICAgICAgKFdlYkNvcmU6OnNlbmRS ZXF1ZXN0Q2FsbGJhY2spOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OmNvbnRpbnVlQWZ0ZXJE aWRSZWNlaXZlUmVzcG9uc2UpOiBIZWxwZXIgZnVuY3Rpb24gdGhhdAorICAgICAgICBjb250aW51 ZXMgdGhlIGxvYWQgYWZ0ZXIgZGlkUmVjZWl2ZVJlc3BvbnNlLgorICAgICAgICAoV2ViQ29yZTo6 UmVzb3VyY2VIYW5kbGU6OmNvbnRpbnVlRGlkUmVjZWl2ZVJlc3BvbnNlKTogQ2FsbAorICAgICAg ICBjb250aW51ZUFmdGVyRGlkUmVjZWl2ZVJlc3BvbnNlKCkuCisKIDIwMTMtMTItMjYgIFNhbSBX ZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBDb252ZXJ0IHNvbWUgb2YgV2ViQ29y ZS9kb20gb3ZlciB0byByYW5nZS1mb3IgbG9vcHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKaW5kZXgg NDNmNDNkNy4uZGU3ODkwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKQEAgLTIzNiw2ICsyMzYs NyBAQCBzdGF0aWMgZ2Jvb2xlYW4gcmVxdWVzdFRpbWVvdXRDYWxsYmFjayh2b2lkKik7CiAjaWYg RU5BQkxFKFdFQl9USU1JTkcpCiBzdGF0aWMgaW50ICBtaWxpc2Vjb25kc1NpbmNlUmVxdWVzdChk b3VibGUgcmVxdWVzdFRpbWUpOwogI2VuZGlmCitzdGF0aWMgdm9pZCBjb250aW51ZUFmdGVyRGlk UmVjZWl2ZVJlc3BvbnNlKFJlc291cmNlSGFuZGxlKik7CiAKIHN0YXRpYyBib29sIGdJZ25vcmVT U0xFcnJvcnMgPSBmYWxzZTsKIApAQCAtNjUyLDIxICs2NTMsMTQgQEAgc3RhdGljIHZvaWQgbmV4 dE11bHRpcGFydFJlc3BvbnNlUGFydENhbGxiYWNrKEdPYmplY3QqIC8qc291cmNlKi8sIEdBc3lu Y1Jlc3VsdCoKICAgICBkLT5tX3Jlc3BvbnNlLnNldFVSTChoYW5kbGUtPmZpcnN0UmVxdWVzdCgp LnVybCgpKTsKICAgICBkLT5tX3Jlc3BvbnNlLnVwZGF0ZUZyb21Tb3VwTWVzc2FnZUhlYWRlcnMo c291cF9tdWx0aXBhcnRfaW5wdXRfc3RyZWFtX2dldF9oZWFkZXJzKGQtPm1fbXVsdGlwYXJ0SW5w dXRTdHJlYW0uZ2V0KCkpKTsKIAorICAgIGQtPm1fcHJldmlvdXNQb3NpdGlvbiA9IDA7CisKICAg ICBpZiAoaGFuZGxlLT5jbGllbnQoKS0+dXNlc0FzeW5jQ2FsbGJhY2tzKCkpCiAgICAgICAgIGhh bmRsZS0+Y2xpZW50KCktPmRpZFJlY2VpdmVSZXNwb25zZUFzeW5jKGhhbmRsZS5nZXQoKSwgZC0+ bV9yZXNwb25zZSk7Ci0gICAgZWxzZQorICAgIGVsc2UgewogICAgICAgICBoYW5kbGUtPmNsaWVu dCgpLT5kaWRSZWNlaXZlUmVzcG9uc2UoaGFuZGxlLmdldCgpLCBkLT5tX3Jlc3BvbnNlKTsKLQot ICAgIGlmIChoYW5kbGUtPmNhbmNlbGxlZE9yQ2xpZW50bGVzcygpKSB7Ci0gICAgICAgIGNsZWFu dXBTb3VwUmVxdWVzdE9wZXJhdGlvbihoYW5kbGUuZ2V0KCkpOwotICAgICAgICByZXR1cm47Cisg ICAgICAgIGNvbnRpbnVlQWZ0ZXJEaWRSZWNlaXZlUmVzcG9uc2UoaGFuZGxlLmdldCgpKTsKICAg ICB9Ci0KLSAgICBkLT5tX3ByZXZpb3VzUG9zaXRpb24gPSAwOwotCi0gICAgaGFuZGxlLT5lbnN1 cmVSZWFkQnVmZmVyKCk7Ci0gICAgZ19pbnB1dF9zdHJlYW1fcmVhZF9hc3luYyhkLT5tX2lucHV0 U3RyZWFtLmdldCgpLCBjb25zdF9jYXN0PGNoYXIqPihkLT5tX3NvdXBCdWZmZXItPmRhdGEpLCBk LT5tX3NvdXBCdWZmZXItPmxlbmd0aCwKLSAgICAgICAgR19QUklPUklUWV9ERUZBVUxULCBkLT5t X2NhbmNlbGxhYmxlLmdldCgpLCByZWFkQ2FsbGJhY2ssIGhhbmRsZS5nZXQoKSk7CiB9CiAKIHN0 YXRpYyB2b2lkIHNlbmRSZXF1ZXN0Q2FsbGJhY2soR09iamVjdCosIEdBc3luY1Jlc3VsdCogcmVz dWx0LCBncG9pbnRlciBkYXRhKQpAQCAtNzIyLDI4ICs3MTYsMzcgQEAgc3RhdGljIHZvaWQgc2Vu ZFJlcXVlc3RDYWxsYmFjayhHT2JqZWN0KiwgR0FzeW5jUmVzdWx0KiByZXN1bHQsIGdwb2ludGVy IGRhdGEpCiAgICAgICAgIGQtPm1fcmVzcG9uc2Uuc2V0RXhwZWN0ZWRDb250ZW50TGVuZ3RoKHNv dXBfcmVxdWVzdF9nZXRfY29udGVudF9sZW5ndGgoZC0+bV9zb3VwUmVxdWVzdC5nZXQoKSkpOwog ICAgIH0KIAorICAgIGlmIChzb3VwTWVzc2FnZSAmJiBkLT5tX3Jlc3BvbnNlLmlzTXVsdGlwYXJ0 KCkpCisgICAgICAgIGQtPm1fbXVsdGlwYXJ0SW5wdXRTdHJlYW0gPSBhZG9wdEdSZWYoc291cF9t dWx0aXBhcnRfaW5wdXRfc3RyZWFtX25ldyhzb3VwTWVzc2FnZSwgaW5wdXRTdHJlYW0uZ2V0KCkp KTsKKyAgICBlbHNlCisgICAgICAgIGQtPm1faW5wdXRTdHJlYW0gPSBpbnB1dFN0cmVhbTsKKwog ICAgIGlmIChkLT5jbGllbnQoKS0+dXNlc0FzeW5jQ2FsbGJhY2tzKCkpCiAgICAgICAgIGhhbmRs ZS0+Y2xpZW50KCktPmRpZFJlY2VpdmVSZXNwb25zZUFzeW5jKGhhbmRsZS5nZXQoKSwgZC0+bV9y ZXNwb25zZSk7Ci0gICAgZWxzZQorICAgIGVsc2UgewogICAgICAgICBoYW5kbGUtPmNsaWVudCgp LT5kaWRSZWNlaXZlUmVzcG9uc2UoaGFuZGxlLmdldCgpLCBkLT5tX3Jlc3BvbnNlKTsKKyAgICAg ICAgY29udGludWVBZnRlckRpZFJlY2VpdmVSZXNwb25zZShoYW5kbGUuZ2V0KCkpOworICAgIH0K K30KIAorc3RhdGljIHZvaWQgY29udGludWVBZnRlckRpZFJlY2VpdmVSZXNwb25zZShSZXNvdXJj ZUhhbmRsZSogaGFuZGxlKQorewogICAgIGlmIChoYW5kbGUtPmNhbmNlbGxlZE9yQ2xpZW50bGVz cygpKSB7Ci0gICAgICAgIGNsZWFudXBTb3VwUmVxdWVzdE9wZXJhdGlvbihoYW5kbGUuZ2V0KCkp OworICAgICAgICBjbGVhbnVwU291cFJlcXVlc3RPcGVyYXRpb24oaGFuZGxlKTsKICAgICAgICAg cmV0dXJuOwogICAgIH0KIAotICAgIGlmIChzb3VwTWVzc2FnZSAmJiBkLT5tX3Jlc3BvbnNlLmlz TXVsdGlwYXJ0KCkpIHsKLSAgICAgICAgZC0+bV9tdWx0aXBhcnRJbnB1dFN0cmVhbSA9IGFkb3B0 R1JlZihzb3VwX211bHRpcGFydF9pbnB1dF9zdHJlYW1fbmV3KHNvdXBNZXNzYWdlLCBpbnB1dFN0 cmVhbS5nZXQoKSkpOworICAgIFJlc291cmNlSGFuZGxlSW50ZXJuYWwqIGQgPSBoYW5kbGUtPmdl dEludGVybmFsKCk7CisgICAgaWYgKGQtPm1fc291cE1lc3NhZ2UgJiYgZC0+bV9tdWx0aXBhcnRJ bnB1dFN0cmVhbSAmJiAhZC0+bV9pbnB1dFN0cmVhbSkgewogICAgICAgICBzb3VwX211bHRpcGFy dF9pbnB1dF9zdHJlYW1fbmV4dF9wYXJ0X2FzeW5jKGQtPm1fbXVsdGlwYXJ0SW5wdXRTdHJlYW0u Z2V0KCksIEdfUFJJT1JJVFlfREVGQVVMVCwKLSAgICAgICAgICAgIGQtPm1fY2FuY2VsbGFibGUu Z2V0KCksIG5leHRNdWx0aXBhcnRSZXNwb25zZVBhcnRDYWxsYmFjaywgaGFuZGxlLmdldCgpKTsK KyAgICAgICAgICAgIGQtPm1fY2FuY2VsbGFibGUuZ2V0KCksIG5leHRNdWx0aXBhcnRSZXNwb25z ZVBhcnRDYWxsYmFjaywgaGFuZGxlKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGQt Pm1faW5wdXRTdHJlYW0gPSBpbnB1dFN0cmVhbTsKLQorICAgIEFTU0VSVChkLT5tX2lucHV0U3Ry ZWFtKTsKICAgICBoYW5kbGUtPmVuc3VyZVJlYWRCdWZmZXIoKTsKICAgICBnX2lucHV0X3N0cmVh bV9yZWFkX2FzeW5jKGQtPm1faW5wdXRTdHJlYW0uZ2V0KCksIGNvbnN0X2Nhc3Q8Y2hhcio+KGQt Pm1fc291cEJ1ZmZlci0+ZGF0YSksIGQtPm1fc291cEJ1ZmZlci0+bGVuZ3RoLAotICAgICAgICBH X1BSSU9SSVRZX0RFRkFVTFQsIGQtPm1fY2FuY2VsbGFibGUuZ2V0KCksIHJlYWRDYWxsYmFjaywg aGFuZGxlLmdldCgpKTsKKyAgICAgICAgR19QUklPUklUWV9ERUZBVUxULCBkLT5tX2NhbmNlbGxh YmxlLmdldCgpLCByZWFkQ2FsbGJhY2ssIGhhbmRsZSk7CiB9CiAKIHN0YXRpYyBib29sIGFkZEZp bGVUb1NvdXBNZXNzYWdlQm9keShTb3VwTWVzc2FnZSogbWVzc2FnZSwgY29uc3QgU3RyaW5nJiBm aWxlTmFtZVN0cmluZywgc2l6ZV90IG9mZnNldCwgc2l6ZV90IGxlbmd0aFRvU2VuZCwgdW5zaWdu ZWQgbG9uZyYgdG90YWxCb2R5U2l6ZSkKQEAgLTEzOTAsNyArMTM5Myw3IEBAIHZvaWQgUmVzb3Vy Y2VIYW5kbGU6OmNvbnRpbnVlRGlkUmVjZWl2ZVJlc3BvbnNlKCkKIHsKICAgICBBU1NFUlQoY2xp ZW50KCkpOwogICAgIEFTU0VSVChjbGllbnQoKS0+dXNlc0FzeW5jQ2FsbGJhY2tzKCkpOwotICAg IC8vIEZJWE1FOiBJbXBsZW1lbnQgdGhpcyBtZXRob2QgaWYgbmVlZGVkOiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MTE0LgorICAgIGNvbnRpbnVlQWZ0ZXJEaWRS ZWNlaXZlUmVzcG9uc2UodGhpcyk7CiB9CiAKIHZvaWQgUmVzb3VyY2VIYW5kbGU6OmNvbnRpbnVl U2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UoYm9vbCkK