125581 2013-12-11 09:18:37 -0800 JS broken on ARMv6 because of dmb instruction 2015-06-29 02:35:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 108645 1 tomeu webkit-unassigned changseok jbriance ossy oldest_to_newest 958755 0 tomeu 2013-12-11 09:18:37 -0800 DMB was added in ARMv7, build is broken like this (sorry, no proper output handy): /tmp/ccXgxs8q.s:4813: Error: selected processor does not support ARM mode `dmb sy' tomeu`: jbrianceau: regarding http://trac.webkit.org/changeset/159571 , I noticed that the implementation of memoryFence() fails to build on armv6 because dmb isn't available tomeu`: is that intentional? jbrianceau: tomeu`: no, not intentional jbrianceau: tomeu`: I didn't notice that because I have an armv7 target without thumb2 instruction set support jbrianceau: tomeu`: but if it fails to build, it should comes from LLINT and not http://trac.webkit.org/changeset/159571 tomeu`: jbrianceau: ok, I was getting /tmp/ccXgxs8q.s:4813: Error: selected processor does not support ARM mode `dmb sy' and git log -Sdmb pointed to that commit jbrianceau: tomeu`: actually this commit would lead to runtime issues, not build jbrianceau: tomeu`: and your build issue should come from jbrianceau: tomeu`: this one : http://trac.webkit.org/changeset/159545 jbrianceau: tomeu`: if you remove "$asm.puts "dmb sy"" from arm.rb file, it will build (but you'll have issues at runtime because of r159571) tomeu`: jbrianceau: ok, I know close to nothing about ARM assembler, but I have been told that on ARMv6 that can safely be a nop or at most a mcr? jbrianceau: tomeu`: ok. If a nop is fine, then you might want to replace "dmb sy" by "nop" in arm.rb file, and also jbrianceau: tomeu`: replace m_assembler.dmbSY() by m_assembler.nop() in MacroAssemblerARM.h file jbrianceau: tomeu`: it should build and run properly if what you've been told is ok :) tomeu`: jbrianceau: oh, I solved my particular issue by rebasing my branch before the commit that introduced the fence :) tomeu`: was just saying for the future tomeu`: will open a bug with our conversation jbrianceau: tomeu`: allright 1037945 1 ossy 2014-09-29 08:44:58 -0700 FYI: The "fancy fencing" isn't needed anymore after https://trac.webkit.org/changeset/159798. So it's safe to remove this code. But I'm not sure if JavaScriptCore maintainers would like to keep it in trunk for future use. 1067077 2 246097 ossy 2015-02-05 04:50:17 -0800 Created attachment 246097 WIP patch remove unused fencing mechanism, WIP patch, not tested anywhere 246097 2015-02-05 04:50:17 -0800 2015-02-05 04:50:17 -0800 WIP patch bug-125581-20150205045014.patch text/plain 14148 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz OTRmOGYzYTE4MjBmZmM0ZjJjMjBkY2Q0MjBiNDYzOTUyMjk0NTQzLi5mMTE0MTE3Y2VhNzFjNGZk YTE5ZDc2NDViNzQ3NmI2ZTAyZDNmMjMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSw0NyBAQAorMjAxNS0wMi0wNSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEpTIGJyb2tlbiBvbiBBUk12NiBiZWNhdXNlIG9mIGRtYiBpbnN0cnVj dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1 NTgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBh c3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIuaDoKKyAgICAgICAgKEpTQzo6QVJNNjRBc3NlbWJsZXI6 OmZpbGxOb3BzKToKKyAgICAgICAgKEpTQzo6QVJNNjRBc3NlbWJsZXI6OmRtYlNZKTogRGVsZXRl ZC4KKyAgICAgICAgKiBhc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6OkFS TUFzc2VtYmxlcjo6ZG1iU1kpOiBEZWxldGVkLgorICAgICAgICAqIGFzc2VtYmxlci9BUk12N0Fz c2VtYmxlci5oOgorICAgICAgICAoSlNDOjpBUk12N0Fzc2VtYmxlcjo6bm9wdyk6CisgICAgICAg IChKU0M6OkFSTXY3QXNzZW1ibGVyOjpkbWJTWSk6IERlbGV0ZWQuCisgICAgICAgICogYXNzZW1i bGVyL01JUFNBc3NlbWJsZXIuaDoKKyAgICAgICAgKEpTQzo6TUlQU0Fzc2VtYmxlcjo6c3luYyk6 IERlbGV0ZWQuCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6CisgICAg ICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjptZW1vcnlGZW5jZSk6IERlbGV0ZWQuCisgICAg ICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaDoKKyAgICAgICAgKEpTQzo6TWFj cm9Bc3NlbWJsZXJBUk02NDo6bm9wKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk02 NDo6bWVtb3J5RmVuY2UpOiBEZWxldGVkLgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2Vt YmxlckFSTXY3Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNdjc6Om1lbW9yeUZl bmNlKTogRGVsZXRlZC4KKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6 CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6bWVtb3J5RmVuY2UpOiBEZWxldGVk LgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oOgorICAgICAgICAoSlND OjpNYWNyb0Fzc2VtYmxlclNINDo6bWVtb3J5RmVuY2UpOiBEZWxldGVkLgorICAgICAgICAqIGFz c2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fz c2VtYmxlclg4NkNvbW1vbjo6bm9wKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZD b21tb246Om1lbW9yeUZlbmNlKTogRGVsZXRlZC4KKyAgICAgICAgKiBhc3NlbWJsZXIvU0g0QXNz ZW1ibGVyLmg6CisgICAgICAgIChKU0M6OlNINEFzc2VtYmxlcjo6c3luY28pOiBEZWxldGVkLgor ICAgICAgICAqIGFzc2VtYmxlci9YODZBc3NlbWJsZXIuaDoKKyAgICAgICAgKEpTQzo6WDg2QXNz ZW1ibGVyOjpwcmVkaWN0Tm90VGFrZW4pOgorICAgICAgICAoSlNDOjpYODZBc3NlbWJsZXI6Om1m ZW5jZSk6IERlbGV0ZWQuCisgICAgICAgICogb2ZmbGluZWFzbS9hcm0ucmI6CisgICAgICAgICog b2ZmbGluZWFzbS9hcm02NC5yYjoKKyAgICAgICAgKiBvZmZsaW5lYXNtL2Nsb29wLnJiOgorICAg ICAgICAqIG9mZmxpbmVhc20vaW5zdHJ1Y3Rpb25zLnJiOgorICAgICAgICAqIG9mZmxpbmVhc20v bWlwcy5yYjoKKyAgICAgICAgKiBvZmZsaW5lYXNtL3NoNC5yYjoKKyAgICAgICAgKiBvZmZsaW5l YXNtL3g4Ni5yYjoKKwogMjAxNS0wMi0wNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRA Y3JmLmNhbm9uLmZyPiBhbmQgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgPGNhbHZhcmlzQGlnYWxp YS5jb20+CiAKICAgICAgICAgW1N0cmVhbXMgQVBJXSBJbXBsZW1lbnQgYSBiYXJlYm9uZSBSZWFk YWJsZVN0cmVhbSBpbnRlcmZhY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvQVJNNjRBc3NlbWJsZXIuaAppbmRleCAwZDIyZTgxODU0MTdkNTBhYTZjMWUzZDNmZDQ2NTVi OWVlMmM5Y2ZlLi5hZTM0YTI3YWMwNWVjY2VhNGI3Y2VlYjQ1ZjljYjNmNmI3NGMxZmZhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTTY0QXNzZW1ibGVyLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk02NEFzc2VtYmxlci5oCkBA IC0xNjc5LDExICsxNjc5LDYgQEAgcHVibGljOgogICAgICAgICBmb3IgKGludDMyX3QqIHB0ciA9 IHN0YXRpY19jYXN0PGludDMyX3QqPihiYXNlKTsgbi0tOykKICAgICAgICAgICAgICpwdHIrKyA9 IG5vcFBzZXVkbygpOwogICAgIH0KLSAgICAKLSAgICBBTFdBWVNfSU5MSU5FIHZvaWQgZG1iU1ko KQotICAgIHsKLSAgICAgICAgaW5zbigweGQ1MDMzZmJmKTsKLSAgICB9CiAKICAgICB0ZW1wbGF0 ZTxpbnQgZGF0YXNpemU+CiAgICAgQUxXQVlTX0lOTElORSB2b2lkIG9ybihSZWdpc3RlcklEIHJk LCBSZWdpc3RlcklEIHJuLCBSZWdpc3RlcklEIHJtKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgKaW5kZXggNTc5Yzg0YzJjYzFiNTljMDI1Y2JmZDlk ODk0ZDVjMDA4YzFiYjRhNC4uYmYxNGMzYzBkYjRhNjMzYTdkNWIwYWExMjkxYzIxYmQ3YzY2NTg2 MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJs ZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5o CkBAIC02ODIsMTEgKzY4Miw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAgbV9idWZm ZXIucHV0SW50KE5PUCk7CiAgICAgICAgIH0KIAotICAgICAgICB2b2lkIGRtYlNZKCkKLSAgICAg ICAgewotICAgICAgICAgICAgbV9idWZmZXIucHV0SW50KERNQl9TWSk7Ci0gICAgICAgIH0KLQog ICAgICAgICB2b2lkIGJ4KGludCBybSwgQ29uZGl0aW9uIGNjID0gQUwpCiAgICAgICAgIHsKICAg ICAgICAgICAgIGVtaXRJbnN0cnVjdGlvbih0b0FSTVdvcmQoY2MpIHwgQlgsIDAsIDAsIFJNKHJt KSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTXY3QXNz ZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVy LmgKaW5kZXggMDRlNTZjZTgyZDYzNDMwNDg1ZGY2YTJhZDY2ZjFlNDg1MDNjY2UzMi4uYzIzMDdl ZWVlZTQyYjliNWJmNzkzYmJmZWU4OTk4MTA3YTI0YjEzNyAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNdjdBc3NlbWJsZXIuaApAQCAtMTk5NiwxMSArMTk5Niw2 IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIG1fZm9ybWF0dGVyLnR3b1dvcmRPcDE2T3AxNihP UF9OT1BfVDJhLCBPUF9OT1BfVDJiKTsKICAgICB9Ci0gICAgCi0gICAgdm9pZCBkbWJTWSgpCi0g ICAgewotICAgICAgICBtX2Zvcm1hdHRlci50d29Xb3JkT3AxNk9wMTYoT1BfRE1CX1NZX1QyYSwg T1BfRE1CX1NZX1QyYik7Ci0gICAgfQogCiAgICAgQXNzZW1ibGVyTGFiZWwgbGFiZWxJZ25vcmlu Z1dhdGNocG9pbnRzKCkKICAgICB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTUlQU0Fzc2VtYmxlci5oCmluZGV4IGNhYWQxNTI0ZDg2NWU5MWE2ZjA5YWM2MTFmN2QyMTEz M2QxODY3YzguLjliYTJmOTAyYjMxODhkYTI1NzZjNjNmMjc5YWYxZGVhMzljZmQ2MzUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCkBAIC0x OTMsMTEgKzE5Myw2IEBAIHB1YmxpYzoKICAgICAgICAgZW1pdEluc3QoMHgwMDAwMDAwMCk7CiAg ICAgfQogCi0gICAgdm9pZCBzeW5jKCkKLSAgICB7Ci0gICAgICAgIGVtaXRJbnN0KDB4MDAwMDAw MGYpOwotICAgIH0KLQogICAgIC8qIE5lZWQgdG8gaW5zZXJ0IG9uZSBsb2FkIGRhdGEgZGVsYXkg bm9wIGZvciBtaXBzMS4gICovCiAgICAgdm9pZCBsb2FkRGVsYXlOb3AoKQogICAgIHsKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0u aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaApp bmRleCA1YjY2OWJkOWQyYzMxNTk3YzEwNjVlNTBlZWRjN2YzMzhlMWI0N2Q2Li42YjlmZWFhMWVj ZjNlMDE5ZWY3MjcxN2Q5NWU5NzE1Y2Y5MTA2YmM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCkBAIC0xMzc2LDExICsxMzc2 LDYgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxlci5ub3AoKTsKICAgICB9CiAKLSAgICB2 b2lkIG1lbW9yeUZlbmNlKCkKLSAgICB7Ci0gICAgICAgIG1fYXNzZW1ibGVyLmRtYlNZKCk7Ci0g ICAgfQotCiAgICAgc3RhdGljIEZ1bmN0aW9uUHRyIHJlYWRDYWxsVGFyZ2V0KENvZGVMb2NhdGlv bkNhbGwgY2FsbCkKICAgICB7CiAgICAgICAgIHJldHVybiBGdW5jdGlvblB0cihyZWludGVycHJl dF9jYXN0PHZvaWQoKikoKT4oQVJNQXNzZW1ibGVyOjpyZWFkQ2FsbFRhcmdldChjYWxsLmRhdGFM b2NhdGlvbigpKSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlckFSTTY0LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyQVJNNjQuaAppbmRleCAwYTZkY2VhNmI0YjFmYmYxYzFkMzIzZjg1NGE3 ODI4ZWU3MjlhNGRhLi5mZTZhMmNjY2EzYjZhNjhhYWNhOWU3MzEwOTUyNGIzNDA2NmNmNWY1IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy QVJNNjQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyQVJNNjQuaApAQCAtMjM5MywxMiArMjM5Myw2IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAg IG1fYXNzZW1ibGVyLm5vcCgpOwogICAgIH0KLSAgICAKLSAgICB2b2lkIG1lbW9yeUZlbmNlKCkK LSAgICB7Ci0gICAgICAgIG1fYXNzZW1ibGVyLmRtYlNZKCk7Ci0gICAgfQotCiAKICAgICAvLyBN aXNjIGhlbHBlciBmdW5jdGlvbnMuCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3LmgKaW5kZXggZjliMTU3YjdhYzNkNTRhZjY5 NGU3MDZjMWQwZDA5NmY3MDQ1ODUxYy4uYmU4NTgzMWM0YTBmOGRhZjkyY2ZhZjk5M2VlMzgzMGMy MTQwNmQ2YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlckFSTXY3LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlckFSTXY3LmgKQEAgLTEyNjksMTIgKzEyNjksNyBAQCBwdWJsaWM6CiAgICAg ewogICAgICAgICBtX2Fzc2VtYmxlci5ub3AoKTsKICAgICB9Ci0gICAgCi0gICAgdm9pZCBtZW1v cnlGZW5jZSgpCi0gICAgewotICAgICAgICBtX2Fzc2VtYmxlci5kbWJTWSgpOwotICAgIH0KLSAg ICAKKwogICAgIHN0YXRpYyB2b2lkIHJlcGxhY2VXaXRoSnVtcChDb2RlTG9jYXRpb25MYWJlbCBp bnN0cnVjdGlvblN0YXJ0LCBDb2RlTG9jYXRpb25MYWJlbCBkZXN0aW5hdGlvbikKICAgICB7CiAg ICAgICAgIEFSTXY3QXNzZW1ibGVyOjpyZXBsYWNlV2l0aEp1bXAoaW5zdHJ1Y3Rpb25TdGFydC5k YXRhTG9jYXRpb24oKSwgZGVzdGluYXRpb24uZGF0YUxvY2F0aW9uKCkpOwpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKaW5kZXgg Mjc4ZTA5NDM3YzI5ZTI0Y2NiYTdmNTE0ZmM5MjI2ZjI0ZTVjNWVkOS4uNjQxYjA2ZDhkMzkxZjU0 NWYyYWM2MjUzZGMyYmNkODViM2Y0YjIzMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCkBAIC0yNzQ1LDExICsyNzQ1LDYg QEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxlci5ub3AoKTsKICAgICB9CiAKLSAgICB2b2lk IG1lbW9yeUZlbmNlKCkKLSAgICB7Ci0gICAgICAgIG1fYXNzZW1ibGVyLnN5bmMoKTsKLSAgICB9 Ci0KICAgICBzdGF0aWMgRnVuY3Rpb25QdHIgcmVhZENhbGxUYXJnZXQoQ29kZUxvY2F0aW9uQ2Fs bCBjYWxsKQogICAgIHsKICAgICAgICAgcmV0dXJuIEZ1bmN0aW9uUHRyKHJlaW50ZXJwcmV0X2Nh c3Q8dm9pZCgqKSgpPihNSVBTQXNzZW1ibGVyOjpyZWFkQ2FsbFRhcmdldChjYWxsLmRhdGFMb2Nh dGlvbigpKSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlclNINC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlclNINC5oCmluZGV4IDRiMmZiZTQ2NzE2MjJkZTIwNDI4NjFmNmZjNDcxZDU0OWNl NTE1MjcuLjk2ZDRlMmQzNzNmYmI0Zjg0ZDI0YTEzMWNmMzI0MmUxYzc5M2E4NjIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmgK QEAgLTI1MjQsMTEgKzI1MjQsNiBAQCBwdWJsaWM6CiAgICAgICAgIG1fYXNzZW1ibGVyLm5vcCgp OwogICAgIH0KIAotICAgIHZvaWQgbWVtb3J5RmVuY2UoKQotICAgIHsKLSAgICAgICAgbV9hc3Nl bWJsZXIuc3luY28oKTsKLSAgICB9Ci0KICAgICB2b2lkIGFib3J0V2l0aFJlYXNvbihBYm9ydFJl YXNvbiByZWFzb24pCiAgICAgewogICAgICAgICBtb3ZlKFRydXN0ZWRJbW0zMihyZWFzb24pLCBT SDRSZWdpc3RlcnM6OnIwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaAppbmRleCBjOTgzMGEyYzA0Zjg1Yzc1 MTI2YzQxYTYyYjAzNGI5MTQ1NmEyZWM1Li4yYTE5ZTRiNDA0NjgyY2I1YmJkYTg1OTA3ZmUwN2Yz YmQwYTBlMDhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01h Y3JvQXNzZW1ibGVyWDg2Q29tbW9uLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oCkBAIC0xNDUzLDExICsxNDUzLDYgQEAgcHVi bGljOgogICAgIHsKICAgICAgICAgbV9hc3NlbWJsZXIubm9wKCk7CiAgICAgfQotICAgIAotICAg IHZvaWQgbWVtb3J5RmVuY2UoKQotICAgIHsKLSAgICAgICAgbV9hc3NlbWJsZXIubWZlbmNlKCk7 Ci0gICAgfQogCiAgICAgc3RhdGljIHZvaWQgcmVwbGFjZVdpdGhKdW1wKENvZGVMb2NhdGlvbkxh YmVsIGluc3RydWN0aW9uU3RhcnQsIENvZGVMb2NhdGlvbkxhYmVsIGRlc3RpbmF0aW9uKQogICAg IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvU0g0QXNzZW1i bGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1NINEFzc2VtYmxlci5oCmlu ZGV4IGQzMjYyNzljNTFkYTM1YTdlNTgwMzg3ZTAwYTBhNWQyYjQ1MzYxYTMuLmE5NjdhNWRmZmQ4 YmNmZWJmMDI1ZjI2YzE5ZTAxZjE3NDg1NWJiZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvU0g0QXNzZW1ibGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9TSDRBc3NlbWJsZXIuaApAQCAtMTgzLDcgKzE4Myw2IEBAIGVudW0gewog ICAgIEZTUVJUX09QQ09ERSA9IDB4ZjA2ZCwKICAgICBGU0NIR19PUENPREUgPSAweGYzZmQsCiAg ICAgQ0xSVF9PUENPREUgPSA4LAotICAgIFNZTkNPX09QQ09ERSA9IDB4MDBhYiwKIH07CiAKIG5h bWVzcGFjZSBTSDRSZWdpc3RlcnMgewpAQCAtNzIyLDExICs3MjEsNiBAQCBwdWJsaWM6CiAgICAg ICAgIG9uZVNob3J0T3AoTk9QX09QQ09ERSwgZmFsc2UpOwogICAgIH0KIAotICAgIHZvaWQgc3lu Y28oKQotICAgIHsKLSAgICAgICAgb25lU2hvcnRPcChTWU5DT19PUENPREUpOwotICAgIH0KLQog ICAgIHZvaWQgc2V0dCgpCiAgICAgewogICAgICAgICBvbmVTaG9ydE9wKFNFVFRfT1BDT0RFKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvWDg2QXNzZW1ibGVy LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5oCmluZGV4 IDJjOGQ4NjdjMzE1NjdkNDhjYzI2Y2Y0YzM0NWFjYmIxNTAzZmVjYjIuLmYyZjgyMTMzZGY1Nzhj N2UyNDM3MjkxYjlhNDBlZjc4ZTM0YzNiMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaApAQCAtMTk2MSwxMSArMTk2MSw2IEBAIHB1YmxpYzoK ICAgICB7CiAgICAgICAgIG1fZm9ybWF0dGVyLnByZWZpeChQUkVfUFJFRElDVF9CUkFOQ0hfTk9U X1RBS0VOKTsKICAgICB9Ci0gICAgCi0gICAgdm9pZCBtZmVuY2UoKQotICAgIHsKLSAgICAgICAg bV9mb3JtYXR0ZXIudGhyZWVCeXRlT3AoT1AzX01GRU5DRSk7Ci0gICAgfQogCiAgICAgLy8gQXNz ZW1ibGVyIGFkbWluIG1ldGhvZHM6CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9vZmZsaW5lYXNtL2FybS5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Fy bS5yYgppbmRleCA0NGNmYmU1YzkwNmVjODJiNWQwMDI0NmQ3ZDE4MzBiN2U4MDAwNDY4Li5kMGE2 NDg2ZjE2OGU4N2Y5ZmEwYWMyNzQxOTYyNGYwM2Y3NGVlMGJiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hcm0ucmIKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL29mZmxpbmVhc20vYXJtLnJiCkBAIC01OTQsOCArNTk0LDYgQEAgY2xhc3MgSW5zdHJ1Y3Rp b24KICAgICAgICAgd2hlbiAic211bGxpIgogICAgICAgICAgICAgcmFpc2UgIldyb25nIG51bWJl ciBvZiBhcmd1bWVudHMgdG8gc211bGwgaW4gI3tzZWxmLmluc3BlY3R9IGF0ICN7Y29kZU9yaWdp blN0cmluZ30iIHVubGVzcyBvcGVyYW5kcy5sZW5ndGggPT0gNAogICAgICAgICAgICAgJGFzbS5w dXRzICJzbXVsbCAje29wZXJhbmRzWzJdLmFybU9wZXJhbmR9LCAje29wZXJhbmRzWzNdLmFybU9w ZXJhbmR9LCAje29wZXJhbmRzWzBdLmFybU9wZXJhbmR9LCAje29wZXJhbmRzWzFdLmFybU9wZXJh bmR9IgotICAgICAgICB3aGVuICJtZW1mZW5jZSIKLSAgICAgICAgICAgICRhc20ucHV0cyAiZG1i IHN5IgogICAgICAgICB3aGVuICJjbHJicCIKICAgICAgICAgICAgICRhc20ucHV0cyAiYmljICN7 b3BlcmFuZHNbMl0uYXJtT3BlcmFuZH0sICN7b3BlcmFuZHNbMF0uYXJtT3BlcmFuZH0sICN7b3Bl cmFuZHNbMV0uYXJtT3BlcmFuZH0iCiAgICAgICAgIGVsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FybTY0LnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L29mZmxpbmVhc20vYXJtNjQucmIKaW5kZXggM2EwZDc4NmM4Zjg0OThhMDE3OGRmMzM5MjIzYjc5 NGUxZTkxOGIxMC4uMWE5ZTZmZWZiYzJlNWExZGQ3OThmZWQxNmE4ZTc4YzEyMTYyNjMzNyAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXJtNjQucmIKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXJtNjQucmIKQEAgLTg2Myw4ICs4NjMs NiBAQCBjbGFzcyBJbnN0cnVjdGlvbgogICAgICAgICAgICAgb3BlcmFuZHNbMF0uYXJtNjRFbWl0 TGVhKG9wZXJhbmRzWzFdLCA6cHRyKQogICAgICAgICB3aGVuICJzbXVsbGkiCiAgICAgICAgICAg ICAkYXNtLnB1dHMgInNtYWRkbCAje29wZXJhbmRzWzJdLmFybTY0T3BlcmFuZCg6cHRyKX0sICN7 b3BlcmFuZHNbMF0uYXJtNjRPcGVyYW5kKDppbnQpfSwgI3tvcGVyYW5kc1sxXS5hcm02NE9wZXJh bmQoOmludCl9LCB4enIiCi0gICAgICAgIHdoZW4gIm1lbWZlbmNlIgotICAgICAgICAgICAgJGFz bS5wdXRzICJkbWIgc3kiCiAgICAgICAgIHdoZW4gInBjcnRvYWRkciIKICAgICAgICAgICAgICRh c20ucHV0cyAiYWRyICN7b3BlcmFuZHNbMV0uYXJtNjRPcGVyYW5kKDpwdHIpfSwgI3tvcGVyYW5k c1swXS52YWx1ZX0iCiAgICAgICAgIHdoZW4gIm5vcENvcnRleEE1M0ZpeDgzNTc2OSIKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Nsb29wLnJiIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vY2xvb3AucmIKaW5kZXggMDRhNjk5ODE0NDc4NmRl YzU1YzQzNmY2Yjk5MTU0ZmQxNmIwN2IyZi4uZDI5ODdiNDYxNjhhMjE1ZWZiZjQ4YWE4M2ViZDBi ODQwZDAzMWE3MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v Y2xvb3AucmIKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vY2xvb3AucmIK QEAgLTEwOTAsOCArMTA5MCw2IEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgICAgICBjbG9v cEVtaXRPcEFuZEJyYW5jaChvcGVyYW5kcywgInwiLCA6aW50MzIsICI9PSAwIikKICAgICAgICAg d2hlbiAiYm9ycmlueiIKICAgICAgICAgICAgIGNsb29wRW1pdE9wQW5kQnJhbmNoKG9wZXJhbmRz LCAifCIsIDppbnQzMiwgIiE9IDAiKQotICAgICAgICAgICAgCi0gICAgICAgIHdoZW4gIm1lbWZl bmNlIgogCiAgICAgICAgIHdoZW4gInB1c2giCiAgICAgICAgICAgICBvcGVyYW5kcy5lYWNoIHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2luc3RydWN0aW9u cy5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYgpp bmRleCAxZDBkODY3NmE2MmE2MjY0ZGMwMWZmMjZiMGU3YmMyZGFlYjVlYjdjLi45NjIxNWZlYjRk OGMwMGM5NzU2ZWJiODM5NzQxMzE5ZTEzOThiZDA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvb2ZmbGluZWFzbS9pbnN0cnVjdGlvbnMucmIKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL29mZmxpbmVhc20vaW5zdHJ1Y3Rpb25zLnJiCkBAIC0yNDgsOCArMjQ4LDcgQEAgTUFD Uk9fSU5TVFJVQ1RJT05TID0KICAgICAgImJ6IiwKICAgICAgImJueiIsCiAgICAgICJsZWFpIiwK LSAgICAgImxlYXAiLAotICAgICAibWVtZmVuY2UiCisgICAgICJsZWFwIgogICAgIF0KIAogWDg2 X0lOU1RSVUNUSU9OUyA9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGlu ZWFzbS9taXBzLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYgpp bmRleCBjYzEwN2VjMzc1MGI2MjQ1NDdlY2ZlNzQ1ZmMyYThmNjNjOTMyZmM3Li4zOGJiZWE1ODlk NzY3ZTJkZWRkOTE3ZTM5YjIyNTRiZTI3ZmNjMzA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9v ZmZsaW5lYXNtL21pcHMucmIKQEAgLTEwMDgsOCArMTAwOCw2IEBAIGNsYXNzIEluc3RydWN0aW9u CiAgICAgICAgIHdoZW4gInBpY2hkciIKICAgICAgICAgICAgICRhc20ucHV0U3RyKCJPRkZMSU5F X0FTTV9DUExPQUQoI3tNSVBTX0NBTExfUkVHLm1pcHNPcGVyYW5kfSkiKQogICAgICAgICAgICAg JGFzbS5wdXRzICJtb3ZlICN7TUlQU19HUFNBVkVfUkVHLm1pcHNPcGVyYW5kfSwgI3tNSVBTX0dQ X1JFRy5taXBzT3BlcmFuZH0iCi0gICAgICAgIHdoZW4gIm1lbWZlbmNlIgotICAgICAgICAgICAg JGFzbS5wdXRzICJzeW5jIgogICAgICAgICBlbHNlCiAgICAgICAgICAgICBsb3dlckRlZmF1bHQK ICAgICAgICAgZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFz bS9zaDQucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9zaDQucmIKaW5kZXgg MDI0MWYzOGQ4OWViZGIyOGUzZjQwZWJkNzk3OTMzZjE0NmM3NzA2NC4uMDQ0YTI3Y2ZkYWQyNGRj M2ZiNzgxOGY4NzFmNzZkMzUzN2RiZjIxMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL29mZmxpbmVhc20vc2g0LnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5l YXNtL3NoNC5yYgpAQCAtMTA3Nyw4ICsxMDc3LDYgQEAgY2xhc3MgSW5zdHJ1Y3Rpb24KICAgICAg ICAgICAgICRhc20ucHV0cyAibGRzICN7c2g0T3BlcmFuZHMob3BlcmFuZHMpfSwgcHIiCiAgICAg ICAgIHdoZW4gInN0c3ByIgogICAgICAgICAgICAgJGFzbS5wdXRzICJzdHMgcHIsICN7c2g0T3Bl cmFuZHMob3BlcmFuZHMpfSIKLSAgICAgICAgd2hlbiAibWVtZmVuY2UiCi0gICAgICAgICAgICAk YXNtLnB1dHMgInN5bmNvIgogICAgICAgICB3aGVuICJwb3AiCiAgICAgICAgICAgICBpZiBvcGVy YW5kc1swXS5zaDRPcGVyYW5kID09ICJwciIKICAgICAgICAgICAgICAgICAkYXNtLnB1dHMgImxk cy5sIEByMTUrLCAje3NoNE9wZXJhbmRzKG9wZXJhbmRzKX0iCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS94ODYucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv b2ZmbGluZWFzbS94ODYucmIKaW5kZXggODgzMGUzZDQxZDJhYjA5NDMyYTJhNDdkNjkzNWMwOGM0 ZjhjZjNhMS4uOWY2ZGUwNDk2ZTAyNTk4YjczM2M4OWMzMjE2NTI3YjlmYjBhMzAzNSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2LnJiCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3g4Ni5yYgpAQCAtMTUxNiw4ICsxNTE2LDYgQEAg Y2xhc3MgSW5zdHJ1Y3Rpb24KICAgICAgICAgICAgICRhc20ucHV0cyAibGVhI3t4ODZTdWZmaXgo OmludCl9ICN7b3JkZXJPcGVyYW5kcyhvcGVyYW5kc1swXS54ODZBZGRyZXNzT3BlcmFuZCg6aW50 KSwgb3BlcmFuZHNbMV0ueDg2T3BlcmFuZCg6aW50KSl9IgogICAgICAgICB3aGVuICJsZWFwIgog ICAgICAgICAgICAgJGFzbS5wdXRzICJsZWEje3g4NlN1ZmZpeCg6cHRyKX0gI3tvcmRlck9wZXJh bmRzKG9wZXJhbmRzWzBdLng4NkFkZHJlc3NPcGVyYW5kKDpwdHIpLCBvcGVyYW5kc1sxXS54ODZP cGVyYW5kKDpwdHIpKX0iCi0gICAgICAgIHdoZW4gIm1lbWZlbmNlIgotICAgICAgICAgICAgJGFz bS5wdXRzICJtZmVuY2UiCiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGxvd2VyRGVmYXVsdAog ICAgICAgICBlbmQK