125277 2013-12-04 19:41:02 -0800 [CSS Shapes] Fix inset when only a subset of the arguments are defined 2013-12-05 08:45:17 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 125112 98664 1 zoltan zoltan commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard oldest_to_newest 956758 0 zoltan 2013-12-04 19:41:02 -0800 I thought Length's default value is fixed 0, but actually it's auto-0. For the optional arguments of inset shape, we need to use fixed-0, so I updated the code and the tests to use that explicitly. 956760 1 218484 zoltan 2013-12-04 19:46:33 -0800 Created attachment 218484 Patch 956907 2 218484 hyatt 2013-12-05 08:17:34 -0800 Comment on attachment 218484 Patch r=me 956915 3 218484 commit-queue 2013-12-05 08:45:14 -0800 Comment on attachment 218484 Patch Clearing flags on attachment: 218484 Committed r160176: <http://trac.webkit.org/changeset/160176> 956916 4 commit-queue 2013-12-05 08:45:17 -0800 All reviewed patches have been landed. Closing bug. 218484 2013-12-04 19:46:33 -0800 2013-12-05 08:45:14 -0800 Patch insetfix.patch text/plain 3701 zoltan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzZTIyN2U0Li42NzkxZTQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMTIt MDQgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NTUyBT aGFwZXNdIEZpeCBpbnNldCB3aGVuIG9ubHkgYSBzdWJzZXQgb2YgdGhlIGFyZ3VtZW50cyBhcmUg ZGVmaW5lZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI1Mjc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBmYXN0L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1p bnNldC5odG1sOgorCiAyMDEzLTEyLTA0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+ CiAKICAgICAgICAgRm9sZCBjb25zdGFudCB0eXBlZCBhcnJheXMKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxv YXRzLWluc2V0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZs b2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1pbnNldC5odG1sCmluZGV4IGVkYmVmMjkuLmIxMWE5 YWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxv YXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLWluc2V0Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9zaGFwZXMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtaW5zZXQu aHRtbApAQCAtMTcsMTMgKzE3LDEzIEBACiAgICAgICAgIGhlaWdodDogNDBweDsKICAgICB9CiAg ICAgLnRvcCB7Ci0gICAgICAgIC13ZWJraXQtc2hhcGUtb3V0c2lkZTogaW5zZXQoMjBweCAwIDAg MCk7CisgICAgICAgIC13ZWJraXQtc2hhcGUtb3V0c2lkZTogaW5zZXQoMjBweCk7CiAgICAgfQog ICAgIC5yaWdodCB7Ci0gICAgICAgIC13ZWJraXQtc2hhcGUtb3V0c2lkZTogaW5zZXQoMCAyMHB4 IDAgMCk7CisgICAgICAgIC13ZWJraXQtc2hhcGUtb3V0c2lkZTogaW5zZXQoMCAyMHB4KTsKICAg ICB9CiAgICAgLmJvdHRvbSB7Ci0gICAgICAgIC13ZWJraXQtc2hhcGUtb3V0c2lkZTogaW5zZXQo MCAwIDIwcHggMCk7CisgICAgICAgIC13ZWJraXQtc2hhcGUtb3V0c2lkZTogaW5zZXQoMCAwIDIw cHgpOwogICAgIH0KICAgICAubGVmdCB7CiAgICAgICAgIC13ZWJraXQtc2hhcGUtb3V0c2lkZTog aW5zZXQoMCAwIDAgMjBweCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2IwNDIzZC4uYjA2Yjk0YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTEyLTA0ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRh bkB3ZWJraXQub3JnPgorCisgICAgICAgIFtDU1MgU2hhcGVzXSBGaXggaW5zZXQgd2hlbiBvbmx5 IGEgc3Vic2V0IG9mIHRoZSBhcmd1bWVudHMgYXJlIGRlZmluZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTI3NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgSSB0aG91Z2h0IExlbmd0aCdzIGRlZmF1bHQg dmFsdWUgaXMgZml4ZWQtMCwgYnV0IGFjdHVhbGx5IGl0J3MgYXV0by0wLiBGb3IgdGhlIG9wdGlv bmFsIGFyZ3VtZW50cworICAgICAgIG9mIGluc2V0IHNoYXBlLCB3ZSBuZWVkIHRvIHVzZSBmaXhl ZC0wLCBzbyBJIHVwZGF0ZWQgdGhlIGNvZGUgYW5kIHRoZSB0ZXN0cyB0byB1c2UgdGhhdCBleHBs aWNpdGx5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgSSB1cGRhdGVkIHRoZSBvbGQgb25lcy4K KworICAgICAgICAqIGNzcy9CYXNpY1NoYXBlRnVuY3Rpb25zLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OmJhc2ljU2hhcGVGb3JWYWx1ZSk6CisKIDIwMTMtMTItMDQgIEJlbmphbWluIFBvdWxhaW4g IDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHNwYWNlcyBvbiBhIGJsYW5r IGxpbmUgdG8gaGF2ZSBSZXNvdXJjZUhhbmRsZUNGTmV0LmNwcCBpZGVudGljYWwgdG8gaU9TCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQmFzaWNTaGFwZUZ1bmN0aW9ucy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQmFzaWNTaGFwZUZ1bmN0aW9ucy5jcHAKaW5kZXggYzM4MmIwOS4u NGRlZjcwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0Jhc2ljU2hhcGVGdW5jdGlv bnMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9CYXNpY1NoYXBlRnVuY3Rpb25zLmNwcApA QCAtNDA0LDE2ICs0MDQsMjYgQEAgUGFzc1JlZlB0cjxCYXNpY1NoYXBlPiBiYXNpY1NoYXBlRm9y VmFsdWUoY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlLCBjb25zdCBSZW5kZXIKICAgICAgICAgY29u c3QgQ1NTQmFzaWNTaGFwZUluc2V0KiByZWN0VmFsdWUgPSBzdGF0aWNfY2FzdDxjb25zdCBDU1NC YXNpY1NoYXBlSW5zZXQqID4oYmFzaWNTaGFwZVZhbHVlKTsKICAgICAgICAgUmVmUHRyPEJhc2lj U2hhcGVJbnNldD4gcmVjdCA9IEJhc2ljU2hhcGVJbnNldDo6Y3JlYXRlKCk7CiAKLSAgICAgICAg aWYgKHJlY3RWYWx1ZS0+bGVmdCgpKQorICAgICAgICBpZiAocmVjdFZhbHVlLT50b3AoKSkKICAg ICAgICAgICAgIHJlY3QtPnNldFRvcChjb252ZXJ0VG9MZW5ndGgoc3R5bGUsIHJvb3RTdHlsZSwg cmVjdFZhbHVlLT50b3AoKSkpOwotICAgICAgICBlbHNlCisgICAgICAgIGVsc2UgeworICAgICAg ICAgICAgcmVjdC0+c2V0VG9wKExlbmd0aCgwLCBGaXhlZCkpOwogICAgICAgICAgICAgcmV0dXJu IHJlY3Q7CisgICAgICAgIH0KICAgICAgICAgaWYgKHJlY3RWYWx1ZS0+cmlnaHQoKSkKICAgICAg ICAgICAgIHJlY3QtPnNldFJpZ2h0KGNvbnZlcnRUb0xlbmd0aChzdHlsZSwgcm9vdFN0eWxlLCBy ZWN0VmFsdWUtPnJpZ2h0KCkpKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgcmVjdC0+c2V0 UmlnaHQoTGVuZ3RoKDAsIEZpeGVkKSk7CisKICAgICAgICAgaWYgKHJlY3RWYWx1ZS0+Ym90dG9t KCkpCiAgICAgICAgICAgICByZWN0LT5zZXRCb3R0b20oY29udmVydFRvTGVuZ3RoKHN0eWxlLCBy b290U3R5bGUsIHJlY3RWYWx1ZS0+Ym90dG9tKCkpKTsKKyAgICAgICAgZWxzZQorICAgICAgICAg ICAgcmVjdC0+c2V0Qm90dG9tKExlbmd0aCgwLCBGaXhlZCkpOworCiAgICAgICAgIGlmIChyZWN0 VmFsdWUtPmxlZnQoKSkKICAgICAgICAgICAgIHJlY3QtPnNldExlZnQoY29udmVydFRvTGVuZ3Ro KHN0eWxlLCByb290U3R5bGUsIHJlY3RWYWx1ZS0+bGVmdCgpKSk7CisgICAgICAgIGVsc2UKKyAg ICAgICAgICAgIHJlY3QtPnNldExlZnQoTGVuZ3RoKDAsIEZpeGVkKSk7CiAKICAgICAgICAgaWYg KHJlY3RWYWx1ZS0+dG9wTGVmdFJhZGl1cygpKSB7CiAgICAgICAgICAgICBQYWlyKiB0b3BMZWZ0 UmFkaXVzID0gcmVjdFZhbHVlLT50b3BMZWZ0UmFkaXVzKCktPmdldFBhaXJWYWx1ZSgpOwo=