125196 2013-12-03 15:19:39 -0800 [Win] run-jsc-stress-tests failures 2015-11-12 21:21:37 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 125111 1 bfulgham bfulgham bfulgham fpizlo joepeck mark.lam mhahnenberg msaboff ossy peavo oldest_to_newest 956169 0 bfulgham 2013-12-03 15:19:39 -0800 The Apple Windows build has 34 Failures: ** The following JSC stress test failures have been introduced: profiler-test.yaml/tests/sunspider-1.0/3d-cube.js.profiler profiler-test.yaml/tests/sunspider-1.0/3d-morph.js.profiler profiler-test.yaml/tests/sunspider-1.0/3d-raytrace.js.profiler profiler-test.yaml/tests/sunspider-1.0/access-binary-trees.js.profiler profiler-test.yaml/tests/sunspider-1.0/access-fannkuch.js.profiler profiler-test.yaml/tests/sunspider-1.0/access-nbody.js.profiler profiler-test.yaml/tests/sunspider-1.0/access-nsieve.js.profiler profiler-test.yaml/tests/sunspider-1.0/bitops-3bit-bits-in-byte.js.profiler profiler-test.yaml/tests/sunspider-1.0/bitops-bits-in-byte.js.profiler profiler-test.yaml/tests/sunspider-1.0/bitops-bitwise-and.js.profiler profiler-test.yaml/tests/sunspider-1.0/bitops-nsieve-bits.js.profiler profiler-test.yaml/tests/sunspider-1.0/controlflow-recursive.js.profiler profiler-test.yaml/tests/sunspider-1.0/crypto-aes.js.profiler profiler-test.yaml/tests/sunspider-1.0/crypto-md5.js.profiler profiler-test.yaml/tests/sunspider-1.0/crypto-sha1.js.profiler profiler-test.yaml/tests/sunspider-1.0/date-format-tofte.js.profiler profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler profiler-test.yaml/tests/sunspider-1.0/math-cordic.js.profiler profiler-test.yaml/tests/sunspider-1.0/math-partial-sums.js.profiler profiler-test.yaml/tests/sunspider-1.0/math-spectral-norm.js.profiler profiler-test.yaml/tests/sunspider-1.0/regexp-dna.js.profiler profiler-test.yaml/tests/sunspider-1.0/string-base64.js.profiler profiler-test.yaml/tests/sunspider-1.0/string-fasta.js.profiler profiler-test.yaml/tests/sunspider-1.0/string-tagcloud.js.profiler profiler-test.yaml/tests/sunspider-1.0/string-unpack-code.js.profiler profiler-test.yaml/tests/sunspider-1.0/string-validate-input.js.profiler jsc-layout-tests.yaml/js/script-tests/math.js.layout jsc-layout-tests.yaml/js/script-tests/math.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/math.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/math.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-dfg-eager-no-cjit 956228 1 bfulgham 2013-12-03 17:42:28 -0800 The sunspider tests may be failing due to path issues. The test harness is run from Cygwin, but the JSC executable is a Windows binary that expects paths to be in DOS/Windows format. If I modify the "run-jsc-stress-tests" to pass a Windows-style path to the test input, I now get a series of files containing ">quit" in them. 956229 2 218368 bfulgham 2013-12-03 17:47:15 -0800 Created attachment 218368 Patch 956230 3 bfulgham 2013-12-03 17:47:44 -0800 The attached patch gets things working, but may not be good idiomatic Ruby code. 956231 4 bfulgham 2013-12-03 17:48:51 -0800 With this patch, I get the following results: ** The following JSC stress test failures have been introduced: jsc-layout-tests.yaml/js/script-tests/math.js.layout jsc-layout-tests.yaml/js/script-tests/math.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/math.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/math.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-dfg-eager-no-cjit Results for JSC stress tests: 8 failures found. It doesn't seem like the profiling output is being incorporated into the "failure" part of the testing. 956440 5 218368 mhahnenberg 2013-12-04 10:41:12 -0800 Comment on attachment 218368 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218368&action=review > Tools/Scripts/run-jsc-stress-tests:87 > + if $? == 0 > + $isCygwin = 1 > + else > + $isCygwin = 0 > + end How about: $isCygwin = $? == 0 Also, in Ruby booleans are distinct from numbers (unlike, e.g., perl). > Tools/Scripts/run-jsc-stress-tests:89 > + $isCygwin = 0 $isCygwin = false > Tools/Scripts/run-jsc-stress-tests:596 > + if $isCygwin == 1 if $isCygwin I'm surprised that this is the only place where you need to do this. I guess profilerOutput is the only absolute path generated by the script? If so it might make sense to just change this to a relative path so that we don't need any cygwin specific stuff. 1130945 6 ossy 2015-10-06 06:48:22 -0700 Windows bots already run jsc stress tests long long time ago. 1141759 7 joepeck 2015-11-12 21:21:32 -0800 Clearing review flag, this bug has already been marked as closed anyways. 218368 2013-12-03 17:47:15 -0800 2015-11-12 21:21:37 -0800 Patch bug-125196-20131203174715.patch text/plain 2201 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MDA2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEzLTEyLTAzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIERlYWwgd2l0aCBDeWd3aW4vV2luZG93cyBwYXRoIGRpZmZlcmVu Y2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUx OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHM6IENvbnZlcnQgQ3lnd2luIHN0eWxlIHBhdGhzIHRv IFdpbmRvd3MgcGF0aHMgd2hlbgorICAgICAgICBwYXNzaW5nIHRoZW0gdG8gdGhlIGpzYyBleGVj dXRhYmxlLgorCiAyMDEzLTEyLTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTjogcmVwcm8gc2NyaXB0cyBkaXNhcHBlYXIgd2hlbiB5b3UgcmVy dW4gdGVzdHMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkocmV2aXNpb24gMTYw MDYyKQorKysgVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkod29ya2luZyBjb3B5 KQpAQCAtNzgsNiArNzgsMTcgQEAgcmVzY3VlCiAgICAgJG51bVByb2Nlc3NvcnMgPSAwCiBlbmQK IAorYmVnaW4KKyAgICB2ZXJzaW9uID0gYGN5Z3BhdGggLS12ZXJzaW9uYAorICAgIGlmICQ/ID09 IDAKKyAgICAgICAgJGlzQ3lnd2luID0gMQorICAgIGVsc2UKKyAgICAgICAgJGlzQ3lnd2luID0g MAorICAgIGVuZAorcmVzY3VlCisgICAgJGlzQ3lnd2luID0gMAorZW5kCisKIGlmICRudW1Qcm9j ZXNzb3JzID09IDAKICAgICAkbnVtUHJvY2Vzc29ycyA9IGBucHJvYyAtLWFsbCAyPi9kZXYvbnVs bGAudG9faQogZW5kCkBAIC01ODEsMTEgKzU5MiwxNSBAQCBlbmQKIAogZGVmIHJ1blByb2ZpbGVy CiAgICAgcHJvZmlsZXJPdXRwdXQgPSB1bmlxdWVGaWxlbmFtZSgiLmpzb24iKQorICAgIG91dHB1 dFBhdGggPSBwcm9maWxlck91dHB1dC50b19zCisgICAgaWYgJGlzQ3lnd2luID09IDEKKyAgICAg ICAgb3V0cHV0UGF0aCA9IGBjeWdwYXRoIC13ICN7cHJvZmlsZXJPdXRwdXQudG9fc31gLmNob21w CisgICAgZW5kCiAgICAgaWYgJGNhblJ1bkRpc3BsYXlQcm9maWxlck91dHB1dAotICAgICAgICBh ZGRSdW5Db21tYW5kKCJwcm9maWxlciIsIFsicnVieSIsIChIRUxQRVJTX1BBVEggKyAicHJvZmls ZXItdGVzdC1oZWxwZXIiKS50b19zLCAoU0NSSVBUU19QQVRIICsgImRpc3BsYXktcHJvZmlsZXIt b3V0cHV0IikudG9fcywgcHJvZmlsZXJPdXRwdXQudG9fcywgcGF0aFRvVk0udG9fcywgIi1wIiwg cHJvZmlsZXJPdXRwdXQudG9fcywgJGJlbmNobWFyay50b19zXSwgc2lsZW50T3V0cHV0SGFuZGxl ciwgc2ltcGxlRXJyb3JIYW5kbGVyKQorICAgICAgICBhZGRSdW5Db21tYW5kKCJwcm9maWxlciIs IFsicnVieSIsIChIRUxQRVJTX1BBVEggKyAicHJvZmlsZXItdGVzdC1oZWxwZXIiKS50b19zLCAo U0NSSVBUU19QQVRIICsgImRpc3BsYXktcHJvZmlsZXItb3V0cHV0IikudG9fcywgcHJvZmlsZXJP dXRwdXQudG9fcywgcGF0aFRvVk0udG9fcywgIi1wIiwgb3V0cHV0UGF0aC50b19zLCAkYmVuY2ht YXJrLnRvX3NdLCBzaWxlbnRPdXRwdXRIYW5kbGVyLCBzaW1wbGVFcnJvckhhbmRsZXIpCiAgICAg ZWxzZQogICAgICAgICBwdXRzICJSdW5uaW5nIHNpbXBsZSB2ZXJzaW9uIG9mICN7JGNvbGxlY3Rp b25OYW1lfS8jeyRiZW5jaG1hcmt9IGJlY2F1c2Ugc29tZSByZXF1aXJlZCBSdWJ5IGZlYXR1cmVz IGFyZSB1bmF2YWlsYWJsZS4iCi0gICAgICAgIHJ1bigicHJvZmlsZXItc2ltcGxlIiwgIi1wIiwg cHJvZmlsZXJPdXRwdXQudG9fcykKKyAgICAgICAgcnVuKCJwcm9maWxlci1zaW1wbGUiLCAiLXAi LCBvdXRwdXRQYXRoLnRvX3MpCiAgICAgZW5kCiBlbmQKIAo=