124649 2013-11-20 02:48:25 -0800 [arm_traditional] Build fails since r159545 2013-11-20 10:30:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 jbriance webkit-unassigned commit-queue fpizlo msaboff ossy rgabor sam zherczeg oldest_to_newest 952513 0 jbriance 2013-11-20 02:48:25 -0800 The following implementations are missing in ARM_TRADITIONAL macro assembler since r159545: - void memoryFence() - void load8(const void*, RegisterID) - void load8(const void*, RegisterID) 952514 1 jbriance 2013-11-20 02:49:21 -0800 - void store8(RegisterID, const void*) 952515 2 217412 jbriance 2013-11-20 02:54:07 -0800 Created attachment 217412 Add missing implementations in ARM_TRADITIONAL macro assembler. 952516 3 commit-queue 2013-11-20 02:55:27 -0800 Attachment 217412 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/ARMAssembler.h', u'Source/JavaScriptCore/assembler/MacroAssemblerARM.h']" exit_code: 1 Source/JavaScriptCore/assembler/ARMAssembler.h:233: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 952666 4 217412 commit-queue 2013-11-20 10:30:14 -0800 Comment on attachment 217412 Add missing implementations in ARM_TRADITIONAL macro assembler. Clearing flags on attachment: 217412 Committed r159571: <http://trac.webkit.org/changeset/159571> 952667 5 commit-queue 2013-11-20 10:30:16 -0800 All reviewed patches have been landed. Closing bug. 217412 2013-11-20 02:54:07 -0800 2013-11-20 10:30:14 -0800 Add missing implementations in ARM_TRADITIONAL macro assembler. bug-124649.patch text/plain 3337 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5NTU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEzLTExLTIwICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIEZpeCBDUFUoQVJNX1RSQURJVElPTkFMKSBidWlsZCBhZnRlciByMTU5NTQ1LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NjQ5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1pc3Npbmcg bWVtb3J5RmVuY2UsIGxvYWQ4IGFuZCBzdG9yZTggaW1wbGVtZW50YXRpb25zIGluIG1hY3JvIGFz c2VtYmxlci4KKworICAgICAgICAqIGFzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaDoKKyAgICAgICAg KEpTQzo6QVJNQXNzZW1ibGVyOjpkbWJTWSk6CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyQVJNLmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpsb2FkOCk6Cisg ICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpzdG9yZTgpOgorICAgICAgICAoSlNDOjpN YWNyb0Fzc2VtYmxlckFSTTo6bWVtb3J5RmVuY2UpOgorCiAyMDEzLTExLTE5ICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEVuYWJsZSBIVE1MVGVtcGxhdGVFbGVt ZW50IG9uIE1hYyBwb3J0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FS TUFzc2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvQVJNQXNzZW1ibGVyLmgJKHJldmlzaW9uIDE1OTU1MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTIzMCw2ICsy MzAsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIE1PVlQgPSAweDAzNDAwMDAwLAog I2VuZGlmCiAgICAgICAgICAgICBOT1AgPSAweGUxYTAwMDAwLAorICAgICAgICAgICAgRE1CX1NZ ID0gMHhmNTdmZjA1ZiwKICAgICAgICAgfTsKIAogICAgICAgICBlbnVtIHsKQEAgLTY5Niw2ICs2 OTcsMTEgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAgICBtX2J1ZmZlci5wdXRJbnQoTk9Q KTsKICAgICAgICAgfQogCisgICAgICAgIHZvaWQgZG1iU1koKQorICAgICAgICB7CisgICAgICAg ICAgICBtX2J1ZmZlci5wdXRJbnQoRE1CX1NZKTsKKyAgICAgICAgfQorCiAgICAgICAgIHZvaWQg YngoaW50IHJtLCBDb25kaXRpb24gY2MgPSBBTCkKICAgICAgICAgewogICAgICAgICAgICAgZW1p dEluc3RydWN0aW9uKHRvQVJNV29yZChjYykgfCBCWCwgMCwgMCwgUk0ocm0pKTsKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN LmgJKHJldmlzaW9uIDE1OTU1MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJBUk0uaAkod29ya2luZyBjb3B5KQpAQCAtMzY0LDYgKzM2NCwxMiBAQCBw dWJsaWM6CiAgICAgICAgIG1fYXNzZW1ibGVyLmJhc2VJbmRleFRyYW5zZmVyMzIoQVJNQXNzZW1i bGVyOjpMb2FkVWludDgsIGRlc3QsIGFkZHJlc3MuYmFzZSwgYWRkcmVzcy5pbmRleCwgc3RhdGlj X2Nhc3Q8aW50PihhZGRyZXNzLnNjYWxlKSwgYWRkcmVzcy5vZmZzZXQpOwogICAgIH0KIAorICAg IHZvaWQgbG9hZDgoY29uc3Qgdm9pZCogYWRkcmVzcywgUmVnaXN0ZXJJRCBkZXN0KQorICAgIHsK KyAgICAgICAgbW92ZShUcnVzdGVkSW1tUHRyKGFkZHJlc3MpLCBBUk1SZWdpc3RlcnM6OlMwKTsK KyAgICAgICAgbV9hc3NlbWJsZXIuZGF0YVRyYW5zZmVyMzIoQVJNQXNzZW1ibGVyOjpMb2FkVWlu dDgsIGRlc3QsIEFSTVJlZ2lzdGVyczo6UzAsIDApOworICAgIH0KKwogICAgIHZvaWQgbG9hZDhT aWduZWQoQmFzZUluZGV4IGFkZHJlc3MsIFJlZ2lzdGVySUQgZGVzdCkKICAgICB7CiAgICAgICAg IG1fYXNzZW1ibGVyLmJhc2VJbmRleFRyYW5zZmVyMTYoQVJNQXNzZW1ibGVyOjpMb2FkSW50OCwg ZGVzdCwgYWRkcmVzcy5iYXNlLCBhZGRyZXNzLmluZGV4LCBzdGF0aWNfY2FzdDxpbnQ+KGFkZHJl c3Muc2NhbGUpLCBhZGRyZXNzLm9mZnNldCk7CkBAIC00NTMsNiArNDU5LDEyIEBAIHB1YmxpYzoK ICAgICAgICAgbV9hc3NlbWJsZXIuYmFzZUluZGV4VHJhbnNmZXIzMihBUk1Bc3NlbWJsZXI6OlN0 b3JlVWludDgsIHNyYywgYWRkcmVzcy5iYXNlLCBhZGRyZXNzLmluZGV4LCBzdGF0aWNfY2FzdDxp bnQ+KGFkZHJlc3Muc2NhbGUpLCBhZGRyZXNzLm9mZnNldCk7CiAgICAgfQogCisgICAgdm9pZCBz dG9yZTgoUmVnaXN0ZXJJRCBzcmMsIGNvbnN0IHZvaWQqIGFkZHJlc3MpCisgICAgeworICAgICAg ICBtb3ZlKFRydXN0ZWRJbW1QdHIoYWRkcmVzcyksIEFSTVJlZ2lzdGVyczo6UzApOworICAgICAg ICBtX2Fzc2VtYmxlci5kdHJVcChBUk1Bc3NlbWJsZXI6OlN0b3JlVWludDgsIHNyYywgQVJNUmVn aXN0ZXJzOjpTMCwgMCk7CisgICAgfQorCiAgICAgdm9pZCBzdG9yZTgoVHJ1c3RlZEltbTMyIGlt bSwgY29uc3Qgdm9pZCogYWRkcmVzcykKICAgICB7CiAgICAgICAgIG1vdmUoVHJ1c3RlZEltbTMy KHJlaW50ZXJwcmV0X2Nhc3Q8QVJNV29yZD4oYWRkcmVzcykpLCBBUk1SZWdpc3RlcnM6OlMwKTsK QEAgLTEzMDIsNiArMTMxNCwxMSBAQCBwdWJsaWM6CiAgICAgICAgIG1fYXNzZW1ibGVyLm5vcCgp OwogICAgIH0KIAorICAgIHZvaWQgbWVtb3J5RmVuY2UoKQorICAgIHsKKyAgICAgICAgbV9hc3Nl bWJsZXIuZG1iU1koKTsKKyAgICB9CisKICAgICBzdGF0aWMgRnVuY3Rpb25QdHIgcmVhZENhbGxU YXJnZXQoQ29kZUxvY2F0aW9uQ2FsbCBjYWxsKQogICAgIHsKICAgICAgICAgcmV0dXJuIEZ1bmN0 aW9uUHRyKHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCgqKSgpPihBUk1Bc3NlbWJsZXI6OnJlYWRDYWxs VGFyZ2V0KGNhbGwuZGF0YUxvY2F0aW9uKCkpKSk7Cg==