124396 2013-11-15 00:12:50 -0800 Few webpages flicker(shift in offset) while scrolling 2014-02-13 03:45:43 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 118548 P2 Normal --- 125943 1 praveen.j webkit-unassigned cmarcelo commit-queue dev_sachin enmi.lee gyuyoung.kim kenneth luiz marcelo.lira noam sergio zeno oldest_to_newest 950977 0 praveen.j 2013-11-15 00:12:50 -0800 In a few webpages where content scale factor is not equal to 1, UI position of content(visible rectangle offset) in webpage is saved after scaling. So, the display offset and content position as saved in WebView are not equal. Whenever there is a request to update viewsize port, the values stored as content position are passed for displaying without rescaling it back. This changes display offset and hence flickers. 950979 1 217019 praveen.j 2013-11-15 00:21:41 -0800 Created attachment 217019 P 950981 2 217021 praveen.j 2013-11-15 00:23:37 -0800 Created attachment 217021 Patch Patch to recalculate WebPage viewsize port with content scalefactor. 952004 3 gyuyoung.kim 2013-11-19 01:41:30 -0800 CC'ing Noam. This patch needs to be reviewed by Noam. 952005 4 noam 2013-11-19 02:03:54 -0800 Marcelo, does this seem right? It seems sensible to me. 952010 5 sergio 2013-11-19 02:41:00 -0800 Pra(In reply to comment #0) > In a few webpages where content scale factor is not equal to 1, UI position of content(visible rectangle offset) in webpage is saved after scaling. So, the display offset and content position as saved in WebView are not equal. Whenever there is a request to update viewsize port, the values stored as content position are passed for displaying without rescaling it back. This changes display offset and hence flickers. Would you have any website to give as an example, that demonstrate this problem? 952011 6 praveen.j 2013-11-19 02:50:59 -0800 (In reply to comment #5) > Pra(In reply to comment #0) > > In a few webpages where content scale factor is not equal to 1, UI position of content(visible rectangle offset) in webpage is saved after scaling. So, the display offset and content position as saved in WebView are not equal. Whenever there is a request to update viewsize port, the values stored as content position are passed for displaying without rescaling it back. This changes display offset and hence flickers. > Would you have any website to give as an example, that demonstrate this problem? I was going through http://www.rediff.com. While scrolling, we can observe blinking effect mentioned in this bug. I have tested this patch on EFL port and it seems to have fixed the problem. 952043 7 sergio 2013-11-19 05:29:22 -0800 (In reply to comment #6) > (In reply to comment #5) > > Pra(In reply to comment #0) > > > In a few webpages where content scale factor is not equal to 1, UI position of content(visible rectangle offset) in webpage is saved after scaling. So, the display offset and content position as saved in WebView are not equal. Whenever there is a request to update viewsize port, the values stored as content position are passed for displaying without rescaling it back. This changes display offset and hence flickers. > > Would you have any website to give as an example, that demonstrate this problem? > > I was going through http://www.rediff.com. While scrolling, we can observe blinking effect mentioned in this bug. I have tested this patch on EFL port and it seems to have fixed the problem. Thanks. I am going to test it on EFL and Nix Minibrowser (as we also use Coordinated Graphics). I have added EunMi Lee, since his patch at https://bugs.webkit.org/show_bug.cgi?id=118548 is almost identical to this one. He might have insights on this issue. 952297 8 gyuyoung.kim 2013-11-19 16:21:48 -0800 (In reply to comment #7) > Thanks. I am going to test it on EFL and Nix Minibrowser (as we also use Coordinated Graphics). I have added EunMi Lee, since his patch at https://bugs.webkit.org/show_bug.cgi?id=118548 is almost identical to this one. He might have insights on this issue. Yes, this patch seems same one with Eunmi's patch in Bug 118548. Eunmi, what do you think ? 952399 9 enmi.lee 2013-11-19 20:53:50 -0800 (In reply to comment #8) > (In reply to comment #7) > > > Thanks. I am going to test it on EFL and Nix Minibrowser (as we also use Coordinated Graphics). I have added EunMi Lee, since his patch at https://bugs.webkit.org/show_bug.cgi?id=118548 is almost identical to this one. He might have insights on this issue. > > Yes, this patch seems same one with Eunmi's patch in Bug 118548. Eunmi, what do you think ? Yes, this patch is same with Bug 118548. The m_contentPosition(= contentPosition()) is scaled value with contentsScaleFactor, so we have to be careful to use it. The transformToScene() also should be fixed with same reason, so I think it is better to merge Bug 118548. Noam, would you review Bug 118548? I've fixed for your comments. 954383 10 praveen.j 2013-11-26 16:51:29 -0800 Lets follow up this issue in https://bugs.webkit.org/show_bug.cgi?id=118548. Patch in Bug 118548 consider more scenarios than that proposed in this bug. *** This bug has been marked as a duplicate of bug 118548 *** 980212 11 217021 ossy 2014-02-13 03:45:43 -0800 Comment on attachment 217021 Patch Cleared review? from attachment 217021 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 217019 2013-11-15 00:21:41 -0800 2013-11-15 00:23:37 -0800 P WebKit2-124396.txt text/plain 1971 praveen.j SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTMyOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTExLTE1ICBQcmF2ZWVu IFIgSmFkaGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZldyB3ZWJwYWdl cyBmbGlja2VyKHNoaWZ0IGluIG9mZnNldCkgd2hpbGUgc2Nyb2xsaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzOTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPZmZzZXQgc2hvdWxkIGJlIHJlY2Fs Y3VsYXRlZCB3aXRoIGNvbnRlbnRTY2FsZUZhY3RvciB3aGlsZQorICAgICAgICB1cGRhdGluZyB2 aWV3cG9ydC4gVGhpcyB3aWxsIGVuc3VyZSBubyBmbGlja2VyaW5nIGluIGNhc2Ugb2YKKyAgICAg ICAgd2VicGFnZXMgd2l0aCBjb250ZW50U2NhbGVGYWN0b3Igb3RoZXIgdGhhbiAxLgorCisgICAg ICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlZpZXc6OnVwZGF0ZVZpZXdwb3J0U2l6ZSk6CisKIDIwMTMtMTEtMTQgIERh biBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIFdLQnJvd3Np bmdDb250ZXh0Q29udHJvbGxlcidzIHBvbGljeSBjbGllbnQgaW1wbGVtZW50YXRpb24gb3Zlci1y ZWxlYXNlcyBXS1VSTFJlcXVlc3RzIGFuZCBXS1VSTFJlc3BvbnNlcwpJbmRleDogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmll dy5jcHAJKHJldmlzaW9uIDE1OTMyNykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29y ZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTgsNyArMjU4 LDkgQEAgdm9pZCBXZWJWaWV3Ojp1cGRhdGVWaWV3cG9ydFNpemUoKQogICAgIGlmIChDb29yZGlu YXRlZERyYXdpbmdBcmVhUHJveHkqIGRyYXdpbmdBcmVhID0gc3RhdGljX2Nhc3Q8Q29vcmRpbmF0 ZWREcmF3aW5nQXJlYVByb3h5Kj4ocGFnZSgpLT5kcmF3aW5nQXJlYSgpKSkgewogICAgICAgICAv LyBXZWIgUHJvY2VzcyBleHBlY3RzIHNpemVzIGluIFVJIHVuaXRzLCBhbmQgbm90IHJhdyBkZXZp Y2UgdW5pdHMuCiAgICAgICAgIGRyYXdpbmdBcmVhLT5zZXRTaXplKHJvdW5kZWRJbnRTaXplKGRp cFNpemUoKSksIEludFNpemUoKSwgSW50U2l6ZSgpKTsKLSAgICAgICAgRmxvYXRSZWN0IHZpc2li bGVDb250ZW50c1JlY3QoY29udGVudFBvc2l0aW9uKCksIHZpc2libGVDb250ZW50c1NpemUoKSk7 CisgICAgICAgIEZsb2F0UG9pbnQgdWlQb3NpdGlvbihjb250ZW50UG9zaXRpb24oKSk7CisgICAg ICAgIHVpUG9zaXRpb24uc2NhbGUoMSAvIGNvbnRlbnRTY2FsZUZhY3RvcigpLCAxIC8gY29udGVu dFNjYWxlRmFjdG9yKCkpOworICAgICAgICBGbG9hdFJlY3QgdmlzaWJsZUNvbnRlbnRzUmVjdCh1 aVBvc2l0aW9uLCB2aXNpYmxlQ29udGVudHNTaXplKCkpOwogICAgICAgICB2aXNpYmxlQ29udGVu dHNSZWN0LmludGVyc2VjdChGbG9hdFJlY3QoRmxvYXRQb2ludCgpLCBjb250ZW50c1NpemUoKSkp OwogICAgICAgICBkcmF3aW5nQXJlYS0+c2V0VmlzaWJsZUNvbnRlbnRzUmVjdCh2aXNpYmxlQ29u dGVudHNSZWN0LCBGbG9hdFBvaW50KCkpOwogICAgIH0K 217021 2013-11-15 00:23:37 -0800 2014-02-13 03:45:43 -0800 Patch WebKit2-124396.txt text/plain 1971 praveen.j SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTMyOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTExLTE1ICBQcmF2ZWVu IFIgSmFkaGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZldyB3ZWJwYWdl cyBmbGlja2VyKHNoaWZ0IGluIG9mZnNldCkgd2hpbGUgc2Nyb2xsaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzOTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPZmZzZXQgc2hvdWxkIGJlIHJlY2Fs Y3VsYXRlZCB3aXRoIGNvbnRlbnRTY2FsZUZhY3RvciB3aGlsZQorICAgICAgICB1cGRhdGluZyB2 aWV3cG9ydC4gVGhpcyB3aWxsIGVuc3VyZSBubyBmbGlja2VyaW5nIGluIGNhc2Ugb2YKKyAgICAg ICAgd2VicGFnZXMgd2l0aCBjb250ZW50U2NhbGVGYWN0b3Igb3RoZXIgdGhhbiAxLgorCisgICAg ICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlZpZXc6OnVwZGF0ZVZpZXdwb3J0U2l6ZSk6CisKIDIwMTMtMTEtMTQgIERh biBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIFdLQnJvd3Np bmdDb250ZXh0Q29udHJvbGxlcidzIHBvbGljeSBjbGllbnQgaW1wbGVtZW50YXRpb24gb3Zlci1y ZWxlYXNlcyBXS1VSTFJlcXVlc3RzIGFuZCBXS1VSTFJlc3BvbnNlcwpJbmRleDogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmll dy5jcHAJKHJldmlzaW9uIDE1OTMyNykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29y ZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTgsNyArMjU4 LDkgQEAgdm9pZCBXZWJWaWV3Ojp1cGRhdGVWaWV3cG9ydFNpemUoKQogICAgIGlmIChDb29yZGlu YXRlZERyYXdpbmdBcmVhUHJveHkqIGRyYXdpbmdBcmVhID0gc3RhdGljX2Nhc3Q8Q29vcmRpbmF0 ZWREcmF3aW5nQXJlYVByb3h5Kj4ocGFnZSgpLT5kcmF3aW5nQXJlYSgpKSkgewogICAgICAgICAv LyBXZWIgUHJvY2VzcyBleHBlY3RzIHNpemVzIGluIFVJIHVuaXRzLCBhbmQgbm90IHJhdyBkZXZp Y2UgdW5pdHMuCiAgICAgICAgIGRyYXdpbmdBcmVhLT5zZXRTaXplKHJvdW5kZWRJbnRTaXplKGRp cFNpemUoKSksIEludFNpemUoKSwgSW50U2l6ZSgpKTsKLSAgICAgICAgRmxvYXRSZWN0IHZpc2li bGVDb250ZW50c1JlY3QoY29udGVudFBvc2l0aW9uKCksIHZpc2libGVDb250ZW50c1NpemUoKSk7 CisgICAgICAgIEZsb2F0UG9pbnQgdWlQb3NpdGlvbihjb250ZW50UG9zaXRpb24oKSk7CisgICAg ICAgIHVpUG9zaXRpb24uc2NhbGUoMSAvIGNvbnRlbnRTY2FsZUZhY3RvcigpLCAxIC8gY29udGVu dFNjYWxlRmFjdG9yKCkpOworICAgICAgICBGbG9hdFJlY3QgdmlzaWJsZUNvbnRlbnRzUmVjdCh1 aVBvc2l0aW9uLCB2aXNpYmxlQ29udGVudHNTaXplKCkpOwogICAgICAgICB2aXNpYmxlQ29udGVu dHNSZWN0LmludGVyc2VjdChGbG9hdFJlY3QoRmxvYXRQb2ludCgpLCBjb250ZW50c1NpemUoKSkp OwogICAgICAgICBkcmF3aW5nQXJlYS0+c2V0VmlzaWJsZUNvbnRlbnRzUmVjdCh2aXNpYmxlQ29u dGVudHNSZWN0LCBGbG9hdFBvaW50KCkpOwogICAgIH0K