124169 2013-11-11 14:55:27 -0800 Remove ConstantFoldingPhase's weirdo compile-time optimization 2013-11-11 15:00:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 124138 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 949462 0 fpizlo 2013-11-11 14:55:27 -0800 It's not needed anymore now that the compiler is concurrent - we're just not sensitive to such compile-time hacks anymore. 949463 1 fpizlo 2013-11-11 14:56:59 -0800 This blocks https://bugs.webkit.org/show_bug.cgi?id=124138 because I'm pretty sure the fix to that requires making ConstantFoldingPhase do some special things for folded GetLocal's. Currently it's already doing *really insane* special things for folded GetLocal's, and I don't want to put special things on top of special things. 949464 2 216615 fpizlo 2013-11-11 14:57:51 -0800 Created attachment 216615 the patch 949465 3 216615 mhahnenberg 2013-11-11 14:58:44 -0800 Comment on attachment 216615 the patch r=me assuming benchmarks look good. 949466 4 fpizlo 2013-11-11 15:00:02 -0800 Landed in http://trac.webkit.org/changeset/159074 216615 2013-11-11 14:57:51 -0800 2013-11-11 14:58:44 -0800 the patch blah.patch text/plain 3047 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5MDczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTExLTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UmVtb3ZlIENvbnN0YW50Rm9sZGluZ1BoYXNlJ3Mgd2VpcmRvIGNvbXBpbGUtdGltZSBvcHRpbWl6 YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NDE2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAg ICAgICAgSXQgdHVybnMgb3V0IHRoYXQgdGhpcyBjb21waWxlLXRpbWUgb3B0aW1pemF0aW9uIGRv ZXNuJ3Qgb3B0aW1pemUgY29tcGlsZSB0aW1lcworICAgICAgICBhbnltb3JlLiBLaWxsIGl0IHdp dGggZmlyZS4KKworICAgICAgICAqIGRmZy9ERkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHA6Cisg ICAgICAgIChKU0M6OkRGRzo6Q29uc3RhbnRGb2xkaW5nUGhhc2U6OmZvbGRDb25zdGFudHMpOgor CiAyMDEzLTExLTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAg TWFrZSBieXRlY29kZSBkdW1waW5nIHVzZSB0aGUgcmlnaHQgb3Bjb2RlIG5hbWVzIGZvciBpbmMv ZGVjLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb25zdGFudEZvbGRpbmdQ aGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb25z dGFudEZvbGRpbmdQaGFzZS5jcHAJKHJldmlzaW9uIDE1OTA2MykKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zNDksMzcgKzM0OSw5IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBDb2RlT3JpZ2luIGNvZGVP cmlnaW4gPSBub2RlLT5jb2RlT3JpZ2luOwogICAgICAgICAgICAgQWRqYWNlbmN5TGlzdCBjaGls ZHJlbiA9IG5vZGUtPmNoaWxkcmVuOwogICAgICAgICAgICAgCi0gICAgICAgICAgICBpZiAobm9k ZS0+b3AoKSA9PSBHZXRMb2NhbCkgewotICAgICAgICAgICAgICAgIC8vIEdldExvY2FscyB3aXRo b3V0IGEgUGhpIGNoaWxkIGFyZSBndWFyYW50ZWVkIGRlYWQuIFdlIGRvbid0IGhhdmUgdG8KLSAg ICAgICAgICAgICAgICAvLyBkbyBhbnl0aGluZyBhYm91dCB0aGVtLgotICAgICAgICAgICAgICAg IGlmICghbm9kZS0+Y2hpbGQxKCkpCi0gICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwotICAg ICAgICAgICAgICAgIAotICAgICAgICAgICAgICAgIGlmIChtX2dyYXBoLm1fZm9ybSAhPSBMb2Fk U3RvcmUpIHsKLSAgICAgICAgICAgICAgICAgICAgVmFyaWFibGVBY2Nlc3NEYXRhKiB2YXJpYWJs ZSA9IG5vZGUtPnZhcmlhYmxlQWNjZXNzRGF0YSgpOwotICAgICAgICAgICAgICAgICAgICBOb2Rl KiBwaGkgPSBub2RlLT5jaGlsZDEoKS5ub2RlKCk7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChw aGktPm9wKCkgPT0gUGhpCi0gICAgICAgICAgICAgICAgICAgICAgICAmJiBibG9jay0+dmFyaWFi bGVzQXRIZWFkLm9wZXJhbmQodmFyaWFibGUtPmxvY2FsKCkpID09IHBoaQotICAgICAgICAgICAg ICAgICAgICAgICAgJiYgYmxvY2stPnZhcmlhYmxlc0F0VGFpbC5vcGVyYW5kKHZhcmlhYmxlLT5s b2NhbCgpKSA9PSBub2RlKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICAKLSAgICAgICAgICAg ICAgICAgICAgICAgIC8vIEtlZXAgdGhlIGdyYXBoIHRocmVhZGVkIGZvciBlYXN5IGNhc2VzLiBU aGlzIGlzIGltcHJvdmVzIGNvbXBpbGUKLSAgICAgICAgICAgICAgICAgICAgICAgIC8vIHRpbWVz LiBJdCB3b3VsZCBiZSBjb3JyZWN0IHRvIGp1c3QgZGV0aHJlYWQgaGVyZS4KLSAgICAgICAgICAg ICAgICAgICAgICAgIAotICAgICAgICAgICAgICAgICAgICAgICAgbV9ncmFwaC5jb252ZXJ0VG9D b25zdGFudChub2RlLCB2YWx1ZSk7Ci0gICAgICAgICAgICAgICAgICAgICAgICBOb2RlKiBwaGFu dG9tID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0Tm9kZSgKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICBpbmRleEluQmxvY2ssIFNwZWNOb25lLCBQaGFudG9tTG9jYWwsICBjb2RlT3JpZ2luLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgIE9wSW5mbyh2YXJpYWJsZSksIEVkZ2UocGhpKSk7 Ci0gICAgICAgICAgICAgICAgICAgICAgICBibG9jay0+dmFyaWFibGVzQXRIZWFkLm9wZXJhbmQo dmFyaWFibGUtPmxvY2FsKCkpID0gcGhhbnRvbTsKLSAgICAgICAgICAgICAgICAgICAgICAgIGJs b2NrLT52YXJpYWJsZXNBdFRhaWwub3BlcmFuZCh2YXJpYWJsZS0+bG9jYWwoKSkgPSBwaGFudG9t OwotICAgICAgICAgICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAgICAgICAgICBjaGFu Z2VkID0gdHJ1ZTsKLSAgICAgICAgICAgICAgICAgICAgICAgIAotICAgICAgICAgICAgICAgICAg ICAgICAgY29udGludWU7Ci0gICAgICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICAg ICAgCi0gICAgICAgICAgICAgICAgICAgIG1fZ3JhcGguZGV0aHJlYWQoKTsKLSAgICAgICAgICAg ICAgICB9Ci0gICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIGlmIChub2RlLT5vcCgpID09 IEdldExvY2FsKQorICAgICAgICAgICAgICAgIG1fZ3JhcGguZGV0aHJlYWQoKTsKKyAgICAgICAg ICAgIGVsc2UKICAgICAgICAgICAgICAgICBBU1NFUlQoIW5vZGUtPmhhc1ZhcmlhYmxlQWNjZXNz RGF0YShtX2dyYXBoKSk7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIG1fZ3JhcGguY29udmVy dFRvQ29uc3RhbnQobm9kZSwgdmFsdWUpOwo=