124086 2013-11-08 16:45:50 -0800 FTL should support AllocatePropertyStorage 2013-11-08 17:43:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 948933 0 fpizlo 2013-11-08 16:45:50 -0800 Patch forthcoming. 948949 1 216467 fpizlo 2013-11-08 17:20:15 -0800 Created attachment 216467 the patch 948955 2 216467 oliver 2013-11-08 17:33:10 -0800 Comment on attachment 216467 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=216467&action=review r=me > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4513 > + m_jit.addPtr(JITCompiler::TrustedImm32(sizeof(IndexingHeader)), scratchGPR); This seems like a good change 948963 3 fpizlo 2013-11-08 17:43:27 -0800 Landed in http://trac.webkit.org/changeset/158983 216467 2013-11-08 17:20:15 -0800 2013-11-08 17:33:10 -0800 the patch blah.patch text/plain 6172 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4OTc3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDEzLTExLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIHNob3VsZCBzdXBwb3J0IEFsbG9jYXRlUHJvcGVydHlTdG9yYWdlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQwODYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEFsc28gcmF0aW9uYWxp emVkIHNvbWUgb2Zmc2V0cyBpbiB0aGUgREZHLgorCisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0 aXZlSklULmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZUFs bG9jYXRlUHJvcGVydHlTdG9yYWdlKToKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJ VDo6Y29tcGlsZVJlYWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2UpOgorICAgICAgICAqIGZ0bC9GVExD YXBhYmlsaXRpZXMuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OmNhbkNvbXBpbGUpOgorICAgICAg ICAqIGZ0bC9GVExJbnRyaW5zaWNSZXBvc2l0b3J5Lmg6CisgICAgICAgICogZnRsL0ZUTExvd2Vy REZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGls ZU5vZGUpOgorICAgICAgICAoSlNDOjpGVEw6Okxvd2VyREZHVG9MTFZNOjpjb21waWxlQWxsb2Nh dGVQcm9wZXJ0eVN0b3JhZ2UpOgorCiAyMDEzLTExLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgRlRMIHNob3VsZCBzdXBwb3J0IE5ld0FycmF5QnVmZmVyCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNw cAkocmV2aXNpb24gMTU4OTc3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj dWxhdGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1MTAsNyArNDUxMCw3IEBAIHZvaWQg U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVBbGxvY2F0ZVByb3AKICAgICAgICAgZW1pdEFsbG9jYXRl QmFzaWNTdG9yYWdlKAogICAgICAgICAgICAgVHJ1c3RlZEltbTMyKGluaXRpYWxPdXRPZkxpbmVD YXBhY2l0eSAqIHNpemVvZihKU1ZhbHVlKSksIHNjcmF0Y2hHUFIpOwogCi0gICAgbV9qaXQuYWRk UHRyKEpJVENvbXBpbGVyOjpUcnVzdGVkSW1tMzIoc2l6ZW9mKEpTVmFsdWUpKSwgc2NyYXRjaEdQ Uik7CisgICAgbV9qaXQuYWRkUHRyKEpJVENvbXBpbGVyOjpUcnVzdGVkSW1tMzIoc2l6ZW9mKElu ZGV4aW5nSGVhZGVyKSksIHNjcmF0Y2hHUFIpOwogICAgICAgICAKICAgICBhZGRTbG93UGF0aEdl bmVyYXRvcigKICAgICAgICAgc2xvd1BhdGhDYWxsKHNsb3dQYXRoLCB0aGlzLCBvcGVyYXRpb25B bGxvY2F0ZVByb3BlcnR5U3RvcmFnZVdpdGhJbml0aWFsQ2FwYWNpdHksIHNjcmF0Y2hHUFIpKTsK QEAgLTQ1NTMsNyArNDU1Myw3IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVSZWFsbG9j YXRlUHIKICAgICBKSVRDb21waWxlcjo6SnVtcCBzbG93UGF0aCA9CiAgICAgICAgIGVtaXRBbGxv Y2F0ZUJhc2ljU3RvcmFnZShUcnVzdGVkSW1tMzIobmV3U2l6ZSksIHNjcmF0Y2hHUFIyKTsKIAot ICAgIG1faml0LmFkZFB0cihKSVRDb21waWxlcjo6VHJ1c3RlZEltbTMyKHNpemVvZihKU1ZhbHVl KSksIHNjcmF0Y2hHUFIyKTsKKyAgICBtX2ppdC5hZGRQdHIoSklUQ29tcGlsZXI6OlRydXN0ZWRJ bW0zMihzaXplb2YoSW5kZXhpbmdIZWFkZXIpKSwgc2NyYXRjaEdQUjIpOwogICAgICAgICAKICAg ICBhZGRTbG93UGF0aEdlbmVyYXRvcigKICAgICAgICAgc2xvd1BhdGhDYWxsKHNsb3dQYXRoLCB0 aGlzLCBvcGVyYXRpb25BbGxvY2F0ZVByb3BlcnR5U3RvcmFnZSwgc2NyYXRjaEdQUjIsIG5ld1Np emUgLyBzaXplb2YoSlNWYWx1ZSkpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwv RlRMQ2FwYWJpbGl0aWVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZnRsL0ZUTENhcGFiaWxpdGllcy5jcHAJKHJldmlzaW9uIDE1ODk3NykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9mdGwvRlRMQ2FwYWJpbGl0aWVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAy LDYgKzEwMiw3IEBAIGlubGluZSBDYXBhYmlsaXR5TGV2ZWwgY2FuQ29tcGlsZShOb2RlKiAKICAg ICBjYXNlIFN0cmluZ0NoYXJBdDoKICAgICBjYXNlIENoZWNrRnVuY3Rpb246CiAgICAgY2FzZSBT dHJpbmdDaGFyQ29kZUF0OgorICAgIGNhc2UgQWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2U6CiAgICAg ICAgIC8vIFRoZXNlIGFyZSBPSy4KICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBHZXRCeUlkOgpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExJbnRyaW5zaWNSZXBvc2l0b3J5LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExJbnRyaW5zaWNSZXBv c2l0b3J5LmgJKHJldmlzaW9uIDE1ODk3NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwv RlRMSW50cmluc2ljUmVwb3NpdG9yeS5oCSh3b3JraW5nIGNvcHkpCkBAIC01Niw3ICs1Niw5IEBA IG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgRlRMIHsKICAgICBtYWNybyhKX0pJVE9wZXJhdGlv bl9FSnNzWiwgZnVuY3Rpb25UeXBlKGludDY0LCBpbnRQdHIsIGludFB0ciwgaW50MzIpKSBcCiAg ICAgbWFjcm8oSl9KSVRPcGVyYXRpb25fRVNzaUpJLCBmdW5jdGlvblR5cGUoaW50NjQsIGludFB0 ciwgaW50UHRyLCBpbnQ2NCwgaW50UHRyKSkgXAogICAgIG1hY3JvKEpzc19KSVRPcGVyYXRpb25f RVosIGZ1bmN0aW9uVHlwZShpbnRQdHIsIGludFB0ciwgaW50MzIpKSBcCisgICAgbWFjcm8oUF9K SVRPcGVyYXRpb25fRSwgZnVuY3Rpb25UeXBlKGludFB0ciwgaW50UHRyKSkgXAogICAgIG1hY3Jv KFBfSklUT3BlcmF0aW9uX0VDLCBmdW5jdGlvblR5cGUoaW50UHRyLCBpbnRQdHIsIGludFB0cikp IFwKKyAgICBtYWNybyhQX0pJVE9wZXJhdGlvbl9FTywgZnVuY3Rpb25UeXBlKGludFB0ciwgaW50 UHRyLCBpbnRQdHIpKSBcCiAgICAgbWFjcm8oUF9KSVRPcGVyYXRpb25fRVN0LCBmdW5jdGlvblR5 cGUoaW50UHRyLCBpbnRQdHIsIGludFB0cikpIFwKICAgICBtYWNybyhQX0pJVE9wZXJhdGlvbl9F U3RQUywgZnVuY3Rpb25UeXBlKGludFB0ciwgaW50UHRyLCBpbnRQdHIsIGludFB0ciwgaW50UHRy KSkgXAogICAgIG1hY3JvKFBfSklUT3BlcmF0aW9uX0VTdFNTLCBmdW5jdGlvblR5cGUoaW50UHRy LCBpbnRQdHIsIGludFB0ciwgaW50UHRyLCBpbnRQdHIpKSBcCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTU4OTc3 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTM3Nyw2ICszNzcsOSBAQCBwcml2YXRlOgogICAgICAgICBjYXNlIE5l d0FycmF5QnVmZmVyOgogICAgICAgICAgICAgY29tcGlsZU5ld0FycmF5QnVmZmVyKCk7CiAgICAg ICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBBbGxvY2F0ZVByb3BlcnR5U3RvcmFnZToKKyAg ICAgICAgICAgIGNvbXBpbGVBbGxvY2F0ZVByb3BlcnR5U3RvcmFnZSgpOworICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIGNhc2UgU3RyaW5nQ2hhckF0OgogICAgICAgICAgICAgY29tcGlsZVN0 cmluZ0NoYXJBdCgpOwogICAgICAgICAgICAgYnJlYWs7CkBAIC0xODk0LDYgKzE4OTcsNDggQEAg cHJpdmF0ZToKICAgICAgICAgICAgIG1fb3V0LmNvbnN0SW50UHRyKG1fbm9kZS0+bnVtQ29uc3Rh bnRzKCkpKSk7CiAgICAgfQogICAgIAorICAgIHZvaWQgY29tcGlsZUFsbG9jYXRlUHJvcGVydHlT dG9yYWdlKCkKKyAgICB7CisgICAgICAgIFN0cnVjdHVyZVRyYW5zaXRpb25EYXRhJiBkYXRhID0g bV9ub2RlLT5zdHJ1Y3R1cmVUcmFuc2l0aW9uRGF0YSgpOworICAgICAgICAKKyAgICAgICAgTFZh bHVlIG9iamVjdCA9IGxvd0NlbGwobV9ub2RlLT5jaGlsZDEoKSk7CisgICAgICAgIAorICAgICAg ICBpZiAoZGF0YS5wcmV2aW91c1N0cnVjdHVyZS0+Y291bGRIYXZlSW5kZXhpbmdIZWFkZXIoKSkg eworICAgICAgICAgICAgc2V0U3RvcmFnZSh2bUNhbGwoCisgICAgICAgICAgICAgICAgbV9vdXQu b3BlcmF0aW9uKAorICAgICAgICAgICAgICAgICAgICBvcGVyYXRpb25SZWFsbG9jYXRlQnV0dGVy Zmx5VG9IYXZlUHJvcGVydHlTdG9yYWdlV2l0aEluaXRpYWxDYXBhY2l0eSksCisgICAgICAgICAg ICAgICAgbV9jYWxsRnJhbWUsIG9iamVjdCkpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAg ICB9CisgICAgICAgIAorICAgICAgICBMQmFzaWNCbG9jayBzbG93UGF0aCA9IEZUTF9ORVdfQkxP Q0sobV9vdXQsICgiQWxsb2NhdGVQcm9wZXJ0eVN0b3JhZ2Ugc2xvdyBwYXRoIikpOworICAgICAg ICBMQmFzaWNCbG9jayBjb250aW51YXRpb24gPSBGVExfTkVXX0JMT0NLKG1fb3V0LCAoIkFsbG9j YXRlUHJvcGVydHlTdG9yYWdlIGNvbnRpbnVhdGlvbiIpKTsKKyAgICAgICAgCisgICAgICAgIExC YXNpY0Jsb2NrIGxhc3ROZXh0ID0gbV9vdXQuaW5zZXJ0TmV3QmxvY2tzQmVmb3JlKHNsb3dQYXRo KTsKKyAgICAgICAgCisgICAgICAgIExWYWx1ZSBlbmRPZlN0b3JhZ2UgPSBhbGxvY2F0ZUJhc2lj U3RvcmFnZUFuZEdldEVuZCgKKyAgICAgICAgICAgIG1fb3V0LmNvbnN0SW50UHRyKGluaXRpYWxP dXRPZkxpbmVDYXBhY2l0eSAqIHNpemVvZihKU1ZhbHVlKSksIHNsb3dQYXRoKTsKKyAgICAgICAg CisgICAgICAgIFZhbHVlRnJvbUJsb2NrIGZhc3RCdXR0ZXJmbHkgPSBtX291dC5hbmNob3IoCisg ICAgICAgICAgICBtX291dC5hZGQobV9vdXQuY29uc3RJbnRQdHIoc2l6ZW9mKEluZGV4aW5nSGVh ZGVyKSksIGVuZE9mU3RvcmFnZSkpOworICAgICAgICAKKyAgICAgICAgbV9vdXQuanVtcChjb250 aW51YXRpb24pOworICAgICAgICAKKyAgICAgICAgbV9vdXQuYXBwZW5kVG8oc2xvd1BhdGgsIGNv bnRpbnVhdGlvbik7CisgICAgICAgIAorICAgICAgICBWYWx1ZUZyb21CbG9jayBzbG93QnV0dGVy Zmx5ID0gbV9vdXQuYW5jaG9yKHZtQ2FsbCgKKyAgICAgICAgICAgIG1fb3V0Lm9wZXJhdGlvbihv cGVyYXRpb25BbGxvY2F0ZVByb3BlcnR5U3RvcmFnZVdpdGhJbml0aWFsQ2FwYWNpdHkpLCBtX2Nh bGxGcmFtZSkpOworICAgICAgICAKKyAgICAgICAgbV9vdXQuanVtcChjb250aW51YXRpb24pOwor ICAgICAgICAKKyAgICAgICAgbV9vdXQuYXBwZW5kVG8oY29udGludWF0aW9uLCBsYXN0TmV4dCk7 CisgICAgICAgIAorICAgICAgICBMVmFsdWUgcmVzdWx0ID0gbV9vdXQucGhpKG1fb3V0LmludFB0 ciwgZmFzdEJ1dHRlcmZseSwgc2xvd0J1dHRlcmZseSk7CisgICAgICAgIG1fb3V0LnN0b3JlUHRy KHJlc3VsdCwgb2JqZWN0LCBtX2hlYXBzLkpTT2JqZWN0X2J1dHRlcmZseSk7CisgICAgICAgIAor ICAgICAgICBzZXRTdG9yYWdlKHJlc3VsdCk7CisgICAgfQorICAgIAogICAgIHZvaWQgY29tcGls ZVN0cmluZ0NoYXJBdCgpCiAgICAgewogICAgICAgICBMVmFsdWUgYmFzZSA9IGxvd0NlbGwobV9u b2RlLT5jaGlsZDEoKSk7Cg==