124050 2013-11-08 10:02:51 -0800 Make base64url decoding actually work 2013-11-08 11:36:08 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 122679 1 ap ap benjamin cmarcelo commit-queue sam oldest_to_newest 948709 0 ap 2013-11-08 10:02:51 -0800 I swapped the table, but there was also a hardcoded check. 948715 1 216407 ap 2013-11-08 10:18:06 -0800 Created attachment 216407 proposed fix Will be tested with WebCrypto tests. 948767 2 ap 2013-11-08 11:36:08 -0800 Committed <http://trac.webkit.org/r158933>. 216407 2013-11-08 10:18:06 -0800 2013-11-08 10:18:43 -0800 proposed fix FindBase64UTF.txt text/plain 6490 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTg5MjQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTExLTA4ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgYmFzZTY0dXJsIGRlY29kaW5nIGFjdHVh bGx5IHdvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNDA1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogd3RmL3RleHQvQmFzZTY0LmNwcDogKFdURjo6YmFzZTY0RGVjb2RlSW50ZXJuYWwpOiBEb24n dCBoYXJkY29kZSBrbm93bGVkZ2UgYWJvdXQKKyAgICAgICAgYWxwaGFiZXQsIHB1dCBpdCBpbnRv IHRoZSBtYXAuCisKIDIwMTMtMTEtMDcgIERlbmlzIE5vbWl5YW1hICA8ZC5ub21peWFtYUBzYW1z dW5nLmNvbT4KIAogICAgICAgICBbR1RLXSBHbHlwaHMgaW4gdmVydGljYWwgdGV4dCB0ZXN0cyBh cmUgcm90YXRlZCA5MCBkZWdyZWVzIGNsb2Nrd2lzZQpJbmRleDogU291cmNlL1dURi93dGYvdGV4 dC9CYXNlNjQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3RleHQvQmFzZTY0LmNw cAkocmV2aXNpb24gMTU4OTI0KQorKysgU291cmNlL1dURi93dGYvdGV4dC9CYXNlNjQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zMCw2ICszMCw4IEBACiAKIG5hbWVzcGFjZSBXVEYgewogCitjb25z dCBjaGFyIG5vbkFscGhhYmV0ID0gLTE7CisKIHN0YXRpYyBjb25zdCBjaGFyIGJhc2U2NEVuY01h cFs2NF0gPSB7CiAgICAgMHg0MSwgMHg0MiwgMHg0MywgMHg0NCwgMHg0NSwgMHg0NiwgMHg0Nywg MHg0OCwKICAgICAweDQ5LCAweDRBLCAweDRCLCAweDRDLCAweDRELCAweDRFLCAweDRGLCAweDUw LApAQCAtNDIsMjIgKzQ0LDIyIEBAIHN0YXRpYyBjb25zdCBjaGFyIGJhc2U2NEVuY01hcFs2NF0g PSB7CiB9OwogCiBzdGF0aWMgY29uc3QgY2hhciBiYXNlNjREZWNNYXBbMTI4XSA9IHsKLSAgICAw eDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLAotICAgIDB4MDAs IDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsCi0gICAgMHgwMCwgMHgw MCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwKLSAgICAweDAwLCAweDAwLCAw eDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLAotICAgIDB4MDAsIDB4MDAsIDB4MDAs IDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsCi0gICAgMHgwMCwgMHgwMCwgMHgwMCwgMHgz RSwgMHgwMCwgMHgwMCwgMHgwMCwgMHgzRiwKKyAgICBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQs IG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25B bHBoYWJldCwgbm9uQWxwaGFiZXQsCisgICAgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25B bHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFi ZXQsIG5vbkFscGhhYmV0LAorICAgIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFi ZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBu b25BbHBoYWJldCwKKyAgICBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBu b25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxw aGFiZXQsCisgICAgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxw aGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0 LAorICAgIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIDB4M0UsIG5vbkFs cGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIDB4M0YsCiAgICAgMHgzNCwgMHgzNSwg MHgzNiwgMHgzNywgMHgzOCwgMHgzOSwgMHgzQSwgMHgzQiwKLSAgICAweDNDLCAweDNELCAweDAw LCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLAotICAgIDB4MDAsIDB4MDAsIDB4MDEsIDB4 MDIsIDB4MDMsIDB4MDQsIDB4MDUsIDB4MDYsCisgICAgMHgzQywgMHgzRCwgbm9uQWxwaGFiZXQs IG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25B bHBoYWJldCwKKyAgICBub25BbHBoYWJldCwgMHgwMCwgMHgwMSwgMHgwMiwgMHgwMywgMHgwNCwg MHgwNSwgMHgwNiwKICAgICAweDA3LCAweDA4LCAweDA5LCAweDBBLCAweDBCLCAweDBDLCAweDBE LCAweDBFLAogICAgIDB4MEYsIDB4MTAsIDB4MTEsIDB4MTIsIDB4MTMsIDB4MTQsIDB4MTUsIDB4 MTYsCi0gICAgMHgxNywgMHgxOCwgMHgxOSwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwK LSAgICAweDAwLCAweDFBLCAweDFCLCAweDFDLCAweDFELCAweDFFLCAweDFGLCAweDIwLAorICAg IDB4MTcsIDB4MTgsIDB4MTksIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQs IG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwKKyAgICBub25BbHBoYWJldCwgMHgxQSwgMHgxQiwg MHgxQywgMHgxRCwgMHgxRSwgMHgxRiwgMHgyMCwKICAgICAweDIxLCAweDIyLCAweDIzLCAweDI0 LCAweDI1LCAweDI2LCAweDI3LCAweDI4LAogICAgIDB4MjksIDB4MkEsIDB4MkIsIDB4MkMsIDB4 MkQsIDB4MkUsIDB4MkYsIDB4MzAsCi0gICAgMHgzMSwgMHgzMiwgMHgzMywgMHgwMCwgMHgwMCwg MHgwMCwgMHgwMCwgMHgwMAorICAgIDB4MzEsIDB4MzIsIDB4MzMsIG5vbkFscGhhYmV0LCBub25B bHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldAogfTsKIAogc3Rh dGljIGNvbnN0IGNoYXIgYmFzZTY0VVJMRW5jTWFwWzY0XSA9IHsKQEAgLTcyLDIyICs3NCwyMiBA QCBzdGF0aWMgY29uc3QgY2hhciBiYXNlNjRVUkxFbmNNYXBbNjRdID0gCiB9OwogCiBzdGF0aWMg Y29uc3QgY2hhciBiYXNlNjRVUkxEZWNNYXBbMTI4XSA9IHsKLSAgICAweDAwLCAweDAwLCAweDAw LCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLAotICAgIDB4MDAsIDB4MDAsIDB4MDAsIDB4 MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsCi0gICAgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwg MHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwKLSAgICAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAw LCAweDAwLCAweDAwLCAweDAwLAotICAgIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4 MDAsIDB4MDAsIDB4MDAsCi0gICAgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgzRSwg MHgwMCwgMHgwMCwKKyAgICBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBu b25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxw aGFiZXQsCisgICAgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxw aGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0 LAorICAgIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0 LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwKKyAg ICBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9u QWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsCisgICAgbm9u QWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhh YmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LAorICAgIG5vbkFscGhh YmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwg MHgzRSwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LAogICAgIDB4MzQsIDB4MzUsIDB4MzYsIDB4 MzcsIDB4MzgsIDB4MzksIDB4M0EsIDB4M0IsCi0gICAgMHgzQywgMHgzRCwgMHgwMCwgMHgwMCwg MHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwKLSAgICAweDAwLCAweDAwLCAweDAxLCAweDAyLCAweDAz LCAweDA0LCAweDA1LCAweDA2LAorICAgIDB4M0MsIDB4M0QsIG5vbkFscGhhYmV0LCBub25BbHBo YWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQs CisgICAgbm9uQWxwaGFiZXQsIDB4MDAsIDB4MDEsIDB4MDIsIDB4MDMsIDB4MDQsIDB4MDUsIDB4 MDYsCiAgICAgMHgwNywgMHgwOCwgMHgwOSwgMHgwQSwgMHgwQiwgMHgwQywgMHgwRCwgMHgwRSwK ICAgICAweDBGLCAweDEwLCAweDExLCAweDEyLCAweDEzLCAweDE0LCAweDE1LCAweDE2LAotICAg IDB4MTcsIDB4MTgsIDB4MTksIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4M0YsCi0gICAgMHgw MCwgMHgxQSwgMHgxQiwgMHgxQywgMHgxRCwgMHgxRSwgMHgxRiwgMHgyMCwKKyAgICAweDE3LCAw eDE4LCAweDE5LCBub25BbHBoYWJldCwgbm9uQWxwaGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBo YWJldCwgMHgzRiwKKyAgICBub25BbHBoYWJldCwgMHgxQSwgMHgxQiwgMHgxQywgMHgxRCwgMHgx RSwgMHgxRiwgMHgyMCwKICAgICAweDIxLCAweDIyLCAweDIzLCAweDI0LCAweDI1LCAweDI2LCAw eDI3LCAweDI4LAogICAgIDB4MjksIDB4MkEsIDB4MkIsIDB4MkMsIDB4MkQsIDB4MkUsIDB4MkYs IDB4MzAsCi0gICAgMHgzMSwgMHgzMiwgMHgzMywgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgw MAorICAgIDB4MzEsIDB4MzIsIDB4MzMsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldCwgbm9uQWxw aGFiZXQsIG5vbkFscGhhYmV0LCBub25BbHBoYWJldAogfTsKIAogaW5saW5lIHZvaWQgYmFzZTY0 RW5jb2RlSW50ZXJuYWwoY29uc3QgY2hhciogZGF0YSwgdW5zaWduZWQgbGVuLCBWZWN0b3I8Y2hh cj4mIG91dCwgQmFzZTY0RW5jb2RlUG9saWN5IHBvbGljeSwgY29uc3QgY2hhciogZW5jb2RlTWFw KQpAQCAtMTk0LDEzICsxOTYsMTYgQEAgc3RhdGljIGlubGluZSBib29sIGJhc2U2NERlY29kZUlu dGVybmFsKAogICAgICAgICAgICAgLy8gc2hvdWxkIG5ldmVyIGJlIG1vcmUgdGhhbiAyIHBhZGRp bmcgY2hhcmFjdGVycy4KICAgICAgICAgICAgIGlmIChwb2xpY3kgPT0gQmFzZTY0RmFpbE9uSW52 YWxpZENoYXJhY3Rlck9yRXhjZXNzUGFkZGluZyAmJiAobGVuZ3RoICUgNCB8fCBlcXVhbHNTaWdu Q291bnQgPiAyKSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIH0gZWxz ZSBpZiAoKCcwJyA8PSBjaCAmJiBjaCA8PSAnOScpIHx8ICgnQScgPD0gY2ggJiYgY2ggPD0gJ1on KSB8fCAoJ2EnIDw9IGNoICYmIGNoIDw9ICd6JykgfHwgY2ggPT0gJysnIHx8IGNoID09ICcvJykg ewotICAgICAgICAgICAgaWYgKGVxdWFsc1NpZ25Db3VudCkKKyAgICAgICAgfSBlbHNlIHsKKyAg ICAgICAgICAgIGNoYXIgZGVjb2RlZENoYXJhY3RlciA9IGRlY29kZU1hcFtjaF07CisgICAgICAg ICAgICBpZiAoZGVjb2RlZENoYXJhY3RlciAhPSBub25BbHBoYWJldCkgeworICAgICAgICAgICAg ICAgIGlmIChlcXVhbHNTaWduQ291bnQpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxz ZTsKKyAgICAgICAgICAgICAgICBvdXRbb3V0TGVuZ3RoXSA9IGRlY29kZWRDaGFyYWN0ZXI7Cisg ICAgICAgICAgICAgICAgKytvdXRMZW5ndGg7CisgICAgICAgICAgICB9IGVsc2UgaWYgKHBvbGlj eSA9PSBCYXNlNjRGYWlsT25JbnZhbGlkQ2hhcmFjdGVyT3JFeGNlc3NQYWRkaW5nIHx8IHBvbGlj eSA9PSBCYXNlNjRGYWlsT25JbnZhbGlkQ2hhcmFjdGVyIHx8IChwb2xpY3kgPT0gQmFzZTY0SWdu b3JlV2hpdGVzcGFjZSAmJiAhaXNTcGFjZU9yTmV3bGluZShjaCkpKQogICAgICAgICAgICAgICAg IHJldHVybiBmYWxzZTsKLSAgICAgICAgICAgIG91dFtvdXRMZW5ndGhdID0gZGVjb2RlTWFwW2No XTsKLSAgICAgICAgICAgICsrb3V0TGVuZ3RoOwotICAgICAgICB9IGVsc2UgaWYgKHBvbGljeSA9 PSBCYXNlNjRGYWlsT25JbnZhbGlkQ2hhcmFjdGVyT3JFeGNlc3NQYWRkaW5nIHx8IHBvbGljeSA9 PSBCYXNlNjRGYWlsT25JbnZhbGlkQ2hhcmFjdGVyIHx8IChwb2xpY3kgPT0gQmFzZTY0SWdub3Jl V2hpdGVzcGFjZSAmJiAhaXNTcGFjZU9yTmV3bGluZShjaCkpKQotICAgICAgICAgICAgcmV0dXJu IGZhbHNlOworICAgICAgICB9CiAgICAgfQogCiAgICAgaWYgKCFvdXRMZW5ndGgpCg==