123831 2013-11-05 14:46:18 -0800 REGRESSION (r154375): Image is oriented incorrectly 2013-11-07 19:53:33 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton gyuyoung.kim bdakin commit-queue esprehn+autocc glenn gyuyoung.kim kondapallykalyan thorton tonikitoo oldest_to_newest 947366 0 thorton 2013-11-05 14:46:18 -0800 Somehow, http://trac.webkit.org/changeset/154375 caused some images to be incorrectly oriented. Steps to Reproduce: 1. Go to http://www.dpreview.com/galleries/reviewsamples/photos/2736127/pa275561?inalbum=olympus-stylus-1-preview-samples in Safari with ToT WebKit. 2. Click on the eighth picture (the one of the car). 3. Click "original" in the size chooser below. You'll be taken to an ImageDocument. Expected: The image should load in the correct orientation, car right-side-up, as it did before this revision. Actual: The image loads sideways, and squished. Unclear to me how this broke without breaking any tests. <rdar://problem/15352728> 947422 1 gyuyoung.kim 2013-11-05 17:07:10 -0800 Let me take a look this issue. 948123 2 216272 gyuyoung.kim 2013-11-07 01:03:58 -0800 Created attachment 216272 Patch 948126 3 gyuyoung.kim 2013-11-07 01:05:49 -0800 In r154375, I missed to set shouldRespectImageOrientation value when css-image-orientation is disabled. This patch fixes it. 948476 4 thorton 2013-11-07 16:57:49 -0800 (In reply to comment #0) > Unclear to me how this broke without breaking any tests. Do you plan to resolve this part too? 948524 5 gyuyoung.kim 2013-11-07 19:27:05 -0800 (In reply to comment #4) > (In reply to comment #0) > > Unclear to me how this broke without breaking any tests. > > Do you plan to resolve this part too? Let me check why there was no break in layout test. 948527 6 216272 commit-queue 2013-11-07 19:53:30 -0800 Comment on attachment 216272 Patch Clearing flags on attachment: 216272 Committed r158900: <http://trac.webkit.org/changeset/158900> 948528 7 commit-queue 2013-11-07 19:53:33 -0800 All reviewed patches have been landed. Closing bug. 216272 2013-11-07 01:03:58 -0800 2013-11-07 19:53:30 -0800 Patch bug-123831-20131107180354.patch text/plain 3083 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4ODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUwODgwZjRhN2RlNjZh YWVjNzczYjFiYmRhYzYwNmYyYzBiZjg4ZC4uZDUxZTQ5ZWIxNTUzZDU2NjE5MjJjZmZmYTU1ZjNm ZTY1N2NmYjMxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTExLTA3ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TiAocjE1NDM3NSk6IEltYWdlIGlzIG9yaWVudGVkIGluY29ycmVjdGx5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM4MzEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMTU0Mzc1IG1hZGUgdGhhdCBzaG91 bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbigpIGlzbid0IHVzZWQgYnkgZHJhd0ltYWdlKCkuCisg ICAgICAgIEl0IGNhdXNlcyBhbiBpbWFnZSBpc24ndCBvcmllbnRlZCBjb3JyZWN0bHkuIFRoaXMg cGF0Y2ggc2V0cyBzaG91bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbigpCisgICAgICAgIHZhbHVl IGJ5IGRlZmF1bHQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVySW1hZ2U6OnBhaW50UmVwbGFjZWQpOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVySW1hZ2U6OnBhaW50SW50b1JlY3QpOgorCiAyMDEzLTExLTA2ICBWYW5pIEhl Z2RlICA8dmFuaS5oZWdkZUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBBcHBsaWVkIGJhY2tncm91 bmQgY29sb3IgaXMgbm90IHJldGFpbmVkIGFmdGVyIHR5cGluZyBhIGNoYXJhY3RlcnMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCmluZGV4IGRjMDg2YjMzOTUwNzJkMzU0 ZjExNTBhMjRlM2E3ZjJhNWNmNjllMzcuLmRlODkyNWZmYTA4MzcyOTg1MTE1ODM5M2ViMTZiNzdj M2FhNTU2YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFn ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdlLmNwcApAQCAt MzkxLDEwICszOTEsOSBAQCB2b2lkIFJlbmRlckltYWdlOjpwYWludFJlcGxhY2VkKFBhaW50SW5m byYgcGFpbnRJbmZvLCBjb25zdCBMYXlvdXRQb2ludCYgcGFpbnRPZgogICAgICAgICAgICAgICAg ICAgICBjZW50ZXJZID0gMDsKICAgICAgICAgICAgICAgICBpbWFnZU9mZnNldCA9IExheW91dFNp emUobGVmdEJvcmRlciArIGxlZnRQYWQgKyBjZW50ZXJYICsgYm9yZGVyV2lkdGgsIHRvcEJvcmRl ciArIHRvcFBhZCArIGNlbnRlclkgKyBib3JkZXJXaWR0aCk7CiAKLSAgICAgICAgICAgICAgICBJ bWFnZU9yaWVudGF0aW9uRGVzY3JpcHRpb24gb3JpZW50YXRpb25EZXNjcmlwdGlvbjsKKyAgICAg ICAgICAgICAgICBJbWFnZU9yaWVudGF0aW9uRGVzY3JpcHRpb24gb3JpZW50YXRpb25EZXNjcmlw dGlvbihzaG91bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbigpKTsKICNpZiBFTkFCTEUoQ1NTX0lN QUdFX09SSUVOVEFUSU9OKQogICAgICAgICAgICAgICAgIG9yaWVudGF0aW9uRGVzY3JpcHRpb24u c2V0SW1hZ2VPcmllbnRhdGlvbkVudW0oc3R5bGUoKS5pbWFnZU9yaWVudGF0aW9uKCkpOwotICAg ICAgICAgICAgICAgIG9yaWVudGF0aW9uRGVzY3JpcHRpb24uc2V0UmVzcGVjdEltYWdlT3JpZW50 YXRpb24oc2hvdWxkUmVzcGVjdEltYWdlT3JpZW50YXRpb24oKSk7CiAjZW5kaWYKICAgICAgICAg ICAgICAgICBjb250ZXh0LT5kcmF3SW1hZ2UoaW1hZ2UuZ2V0KCksIHN0eWxlKCkuY29sb3JTcGFj ZSgpLCBwaXhlbFNuYXBwZWRJbnRSZWN0KExheW91dFJlY3QocGFpbnRPZmZzZXQgKyBpbWFnZU9m ZnNldCwgaW1hZ2VTaXplKSksIENvbXBvc2l0ZVNvdXJjZU92ZXIsIG9yaWVudGF0aW9uRGVzY3Jp cHRpb24pOwogICAgICAgICAgICAgICAgIGVycm9yUGljdHVyZURyYXduID0gdHJ1ZTsKQEAgLTUy MywxMCArNTIyLDkgQEAgdm9pZCBSZW5kZXJJbWFnZTo6cGFpbnRJbnRvUmVjdChHcmFwaGljc0Nv bnRleHQqIGNvbnRleHQsIGNvbnN0IExheW91dFJlY3QmIHJlY3QKICAgICBDb21wb3NpdGVPcGVy YXRvciBjb21wb3NpdGVPcGVyYXRvciA9IGltYWdlRWx0ID8gaW1hZ2VFbHQtPmNvbXBvc2l0ZU9w ZXJhdG9yKCkgOiBDb21wb3NpdGVTb3VyY2VPdmVyOwogICAgIEltYWdlKiBpbWFnZSA9IG1faW1h Z2VSZXNvdXJjZS0+aW1hZ2UoKS5nZXQoKTsKICAgICBib29sIHVzZUxvd1F1YWxpdHlTY2FsaW5n ID0gc2hvdWxkUGFpbnRBdExvd1F1YWxpdHkoY29udGV4dCwgaW1hZ2UsIGltYWdlLCBhbGlnbmVk UmVjdC5zaXplKCkpOwotICAgIEltYWdlT3JpZW50YXRpb25EZXNjcmlwdGlvbiBvcmllbnRhdGlv bkRlc2NyaXB0aW9uOworICAgIEltYWdlT3JpZW50YXRpb25EZXNjcmlwdGlvbiBvcmllbnRhdGlv bkRlc2NyaXB0aW9uKHNob3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uKCkpOwogI2lmIEVOQUJM RShDU1NfSU1BR0VfT1JJRU5UQVRJT04pCiAgICAgb3JpZW50YXRpb25EZXNjcmlwdGlvbi5zZXRJ bWFnZU9yaWVudGF0aW9uRW51bShzdHlsZSgpLmltYWdlT3JpZW50YXRpb24oKSk7Ci0gICAgb3Jp ZW50YXRpb25EZXNjcmlwdGlvbi5zZXRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbihzaG91bGRSZXNw ZWN0SW1hZ2VPcmllbnRhdGlvbigpKTsKICNlbmRpZgogICAgIGNvbnRleHQtPmRyYXdJbWFnZSht X2ltYWdlUmVzb3VyY2UtPmltYWdlKGFsaWduZWRSZWN0LndpZHRoKCksIGFsaWduZWRSZWN0Lmhl aWdodCgpKS5nZXQoKSwgc3R5bGUoKS5jb2xvclNwYWNlKCksIGFsaWduZWRSZWN0LCBjb21wb3Np dGVPcGVyYXRvciwgb3JpZW50YXRpb25EZXNjcmlwdGlvbiwgdXNlTG93UXVhbGl0eVNjYWxpbmcp OwogfQo=