123473 2013-10-29 14:41:30 -0700 Explicitly initialize base class in MediStreamTrackPrivate copy constructor 2013-10-31 14:03:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 123443 1 thiago.lacerda thiago.lacerda bfulgham commit-queue eric.carlson glenn hta jer.noble kling pnormand tommyw oldest_to_newest 944617 0 thiago.lacerda 2013-10-29 14:41:30 -0700 Ports that enable Wextra and Werror must do that to compile. 944619 1 215429 thiago.lacerda 2013-10-29 14:43:21 -0700 Created attachment 215429 Patch 944624 2 215429 darin 2013-10-29 14:50:42 -0700 Comment on attachment 215429 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215429&action=review > Source/WebCore/ChangeLog:10 > + Ports that enable Wextra and Werror must do that to compile. Why? This is very surprising. Are you sure this is not a compiler bug? > Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:46 > + : RefCounted<MediaStreamTrackPrivate>() I think you can also just do: : RefCounted() But do we really need this? I’m extremely surprised. We definitely use -Wextra and -Werror in the Mac port. 944626 3 thiago.lacerda 2013-10-29 14:54:53 -0700 (In reply to comment #2) > (From update of attachment 215429 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215429&action=review > > > Source/WebCore/ChangeLog:10 > > + Ports that enable Wextra and Werror must do that to compile. > > Why? This is very surprising. Are you sure this is not a compiler bug? > > > Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:46 > > + : RefCounted<MediaStreamTrackPrivate>() > > I think you can also just do: > > : RefCounted() > > But do we really need this? I’m extremely surprised. > > We definitely use -Wextra and -Werror in the Mac port. Sorry, the correct flag is -Werror=extra, I'm using gcc 4.8.2 944634 4 215434 thiago.lacerda 2013-10-29 15:01:46 -0700 Created attachment 215434 Patch for landing 944936 5 pnormand 2013-10-30 09:37:42 -0700 The patch for landing should have Reviewed by filled, and no need to set review flag. 945026 6 thiago.lacerda 2013-10-30 11:01:20 -0700 (In reply to comment #5) > The patch for landing should have Reviewed by filled, and no need to set review flag. Sorry, I forgot that 945042 7 215531 thiago.lacerda 2013-10-30 11:09:50 -0700 Created attachment 215531 Patch for landing 945094 8 215531 commit-queue 2013-10-30 11:54:43 -0700 Comment on attachment 215531 Patch for landing Clearing flags on attachment: 215531 Committed r158296: <http://trac.webkit.org/changeset/158296> 945679 9 215429 bfulgham 2013-10-31 14:02:20 -0700 Comment on attachment 215429 Patch Clearing flag to remove from review queue. 945681 10 215434 bfulgham 2013-10-31 14:02:58 -0700 Comment on attachment 215434 Patch for landing Clearing flags to remove from review queue. 945682 11 bfulgham 2013-10-31 14:03:17 -0700 All reviewed patches are landed. 215429 2013-10-29 14:43:21 -0700 2013-10-31 14:02:18 -0700 Patch bug-123473-20131029184320.patch text/plain 1600 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4MjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGU2NzBlOTJhZWZmNWJi ODZmOGQzMDExYzQ4YmNhN2Y4YzdjY2YxYi4uYjQwYzUzNDgxOWEzMzUwMGUxM2NjOTE0ZWVkOTkz ZDU2OGQzZTA4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEwLTI5ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEV4cGxpY2l0bHkgaW5pdGlhbGl6ZSBiYXNlIGNsYXNzIGluIE1lZGlTdHJlYW1UcmFj a1ByaXZhdGUgY29weSBjb25zdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICBQb3J0cyB0 aGF0IGVuYWJsZSBXZXh0cmEgYW5kIFdlcnJvciBtdXN0IGRvIHRoYXQgdG8gY29tcGlsZS4KKwor ICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtVHJhY2tQcml2YXRlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtVHJhY2tQcml2YXRlOjpNZWRpYVN0cmVh bVRyYWNrUHJpdmF0ZSk6CisKIDIwMTMtMTAtMjkgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRv bkBhcHBsZS5jb20+CiAKICAgICAgICAgTW9yZSBjb3JyZWN0IGJ1aWxkIGZpeCBhZnRlciAxNTgy MjMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRp YVN0cmVhbVRyYWNrUHJpdmF0ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9NZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZS5jcHAKaW5kZXggMzI5YTBlNmZlZTQxMzZmNTVk MTVjZTMzZDYzYTQ1ZDU4MDE1MzA2ZC4uYzkwOGQxMjQ1MWU5ODM3ZGFhM2QwNzNiMzMwZTM3MDc1 ZmY2NTY3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v TWVkaWFTdHJlYW1UcmFja1ByaXZhdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21lZGlhc3RyZWFtL01lZGlhU3RyZWFtVHJhY2tQcml2YXRlLmNwcApAQCAtNDMsNyArNDMsOCBA QCBQYXNzUmVmUHRyPE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlPiBNZWRpYVN0cmVhbVRyYWNrUHJp dmF0ZTo6Y3JlYXRlKFBhc3NSZWZQdHI8TQogfQogCiBNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZTo6 TWVkaWFTdHJlYW1UcmFja1ByaXZhdGUoY29uc3QgTWVkaWFTdHJlYW1UcmFja1ByaXZhdGUmIG90 aGVyKQotICAgIDogbV9jbGllbnQobnVsbHB0cikKKyAgICA6IFJlZkNvdW50ZWQ8TWVkaWFTdHJl YW1UcmFja1ByaXZhdGU+KCkKKyAgICAsIG1fY2xpZW50KG51bGxwdHIpCiB7CiAgICAgbV9pZ25v cmVNdXRhdGlvbnMgPSB0cnVlOwogICAgIG1faWQgPSBjcmVhdGVDYW5vbmljYWxVVUlEU3RyaW5n KCk7Cg== 215434 2013-10-29 15:01:46 -0700 2013-10-31 14:02:58 -0700 Patch for landing bug-123473-20131029190145.patch text/plain 1571 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4MjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGU2NzBlOTJhZWZmNWJi ODZmOGQzMDExYzQ4YmNhN2Y4YzdjY2YxYi4uMWUyMTc5YzIyN2UxN2NkYjhjY2Q0MjhhYTM0MjRm Mzk1Y2E3MWE0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEwLTI5ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEV4cGxpY2l0bHkgaW5pdGlhbGl6ZSBiYXNlIGNsYXNzIGluIE1lZGlTdHJlYW1UcmFj a1ByaXZhdGUgY29weSBjb25zdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICBQb3J0cyB0 aGF0IGVuYWJsZSAtV2Vycm9yPWV4dHJhIG11c3QgZG8gdGhhdCB0byBjb21waWxlLgorCisgICAg ICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1UcmFja1ByaXZhdGUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFTdHJlYW1UcmFja1ByaXZhdGU6Ok1lZGlhU3RyZWFtVHJh Y2tQcml2YXRlKToKKwogMjAxMy0xMC0yOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFw cGxlLmNvbT4KIAogICAgICAgICBNb3JlIGNvcnJlY3QgYnVpbGQgZml4IGFmdGVyIDE1ODIyMy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3Ry ZWFtVHJhY2tQcml2YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L01lZGlhU3RyZWFtVHJhY2tQcml2YXRlLmNwcAppbmRleCAzMjlhMGU2ZmVlNDEzNmY1NWQxNWNl MzNkNjNhNDVkNTgwMTUzMDZkLi42YTg2MTgxYjg5OTQ1ZjQ1YWM4MWM5NTkyMTc2NGFkODc2NDIz ZjA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRp YVN0cmVhbVRyYWNrUHJpdmF0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk aWFzdHJlYW0vTWVkaWFTdHJlYW1UcmFja1ByaXZhdGUuY3BwCkBAIC00Myw3ICs0Myw4IEBAIFBh c3NSZWZQdHI8TWVkaWFTdHJlYW1UcmFja1ByaXZhdGU+IE1lZGlhU3RyZWFtVHJhY2tQcml2YXRl OjpjcmVhdGUoUGFzc1JlZlB0cjxNCiB9CiAKIE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlOjpNZWRp YVN0cmVhbVRyYWNrUHJpdmF0ZShjb25zdCBNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZSYgb3RoZXIp Ci0gICAgOiBtX2NsaWVudChudWxscHRyKQorICAgIDogUmVmQ291bnRlZCgpCisgICAgLCBtX2Ns aWVudChudWxscHRyKQogewogICAgIG1faWdub3JlTXV0YXRpb25zID0gdHJ1ZTsKICAgICBtX2lk ID0gY3JlYXRlQ2Fub25pY2FsVVVJRFN0cmluZygpOwo= 215531 2013-10-30 11:09:50 -0700 2013-10-30 11:54:43 -0700 Patch for landing bug-123473-20131030150949.patch text/plain 1581 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4Mjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTVjZWE4MjEyZmIyNmI1 Nzk4ZTQ3MzEyYTg0NmM2ZDM5MDM2OGNlOC4uZmM5NzBjYzkxOWYxYTRjNjU3NTM4NTc1NDU4YmVk MmRhMTBlODg1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEwLTMwICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEV4cGxpY2l0bHkgaW5pdGlhbGl6ZSBiYXNlIGNsYXNzIGluIE1lZGlTdHJlYW1UcmFj a1ByaXZhdGUgY29weSBjb25zdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJs c29uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgUG9ydHMgdGhh dCBlbmFibGUgLVdlcnJvcj1leHRyYSBtdXN0IGRvIHRoYXQgdG8gY29tcGlsZS4KKworICAgICAg ICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtVHJhY2tQcml2YXRlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtVHJhY2tQcml2YXRlOjpNZWRpYVN0cmVhbVRyYWNr UHJpdmF0ZSk6CisKIDIwMTMtMTAtMzAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29t PgogCiAgICAgICAgIElEQkN1cnNvckJhY2tlbmRMZXZlbERCIHNob3VsZCBiZSBtYWRlIGNyb3Nz LXBsYXRmb3JtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9NZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t ZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZS5jcHAKaW5kZXggMzI5YTBlNmZlZTQx MzZmNTVkMTVjZTMzZDYzYTQ1ZDU4MDE1MzA2ZC4uNmE4NjE4MWI4OTk0NWY0NWFjODFjOTU5MjE3 NjRhZDg3NjQyM2YwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFz dHJlYW0vTWVkaWFTdHJlYW1UcmFja1ByaXZhdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtVHJhY2tQcml2YXRlLmNwcApAQCAtNDMsNyAr NDMsOCBAQCBQYXNzUmVmUHRyPE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlPiBNZWRpYVN0cmVhbVRy YWNrUHJpdmF0ZTo6Y3JlYXRlKFBhc3NSZWZQdHI8TQogfQogCiBNZWRpYVN0cmVhbVRyYWNrUHJp dmF0ZTo6TWVkaWFTdHJlYW1UcmFja1ByaXZhdGUoY29uc3QgTWVkaWFTdHJlYW1UcmFja1ByaXZh dGUmIG90aGVyKQotICAgIDogbV9jbGllbnQobnVsbHB0cikKKyAgICA6IFJlZkNvdW50ZWQoKQor ICAgICwgbV9jbGllbnQobnVsbHB0cikKIHsKICAgICBtX2lnbm9yZU11dGF0aW9ucyA9IHRydWU7 CiAgICAgbV9pZCA9IGNyZWF0ZUNhbm9uaWNhbFVVSURTdHJpbmcoKTsK