123464 2013-10-29 13:58:14 -0700 Node shouldn't be selected if it's not a draggable element and has -webkit-user-select: none set 2025-05-30 16:25:00 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 208682 P2 Normal --- 0 haizhang webkit-unassigned ahmad.saleem792 ntim staikos tonikitoo oldest_to_newest 944590 0 haizhang 2013-10-29 13:58:14 -0700 As the comment says, if it's a draggable element, then it should be allowed to be selected, so drag & drop action can be performed, if it's not, and has -webkit-user-select: none set, then it shouldn't be allowed. 944603 1 215425 haizhang 2013-10-29 14:10:31 -0700 Created attachment 215425 patch patch. 944604 2 haizhang 2013-10-29 14:16:12 -0700 Add Antonio to cc list. 944618 3 215425 haizhang 2013-10-29 14:42:23 -0700 Comment on attachment 215425 patch Need have a second thought. 2033209 4 ahmad.saleem792 2024-05-03 16:42:13 -0700 This patch was modifying this: https://searchfox.org/wubkat/rev/3f1a725ef3d3f0a0ee05b56aff41fbfdae90f34f/Source/WebCore/dom/Node.cpp#1288 - It seems blink did the change: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/node.cc;l=1654;drc=5180d4deb2bee0cc22d14ced5ac540e51135a2e5 ** Blink: // We allow selections to begin within |user-select: text/all| sub trees // but not if the element is draggable. if (style.UserDrag() != EUserDrag::kElement && (user_select == EUserSelect::kText || user_select == EUserSelect::kAll)) return true; ** WebKit: // We allow selections to begin within an element that has -webkit-user-select: none set, // but if the element is draggable then dragging should take priority over selection. if (style.userDrag() == UserDrag::Element && style.usedUserSelect() == UserSelect::None) return false; } __ 2120827 5 ntim 2025-05-30 16:25:00 -0700 *** This bug has been marked as a duplicate of bug 208682 *** 215425 2013-10-29 14:10:31 -0700 2013-10-29 14:42:23 -0700 patch 0001-2013-10-29-Crystal-Zhang-haizhang-blackberry.com.patch text/plain 2553 haizhang RnJvbSBhMzEwYTEzYjkyNmEzNjRiZGI2NWUwNmI0NjQ0NjhjNGQ1MjY3ZTcwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxoYWl6aGFuZ0BibGFja2JlcnJ5LmNv bT4KRGF0ZTogVHVlLCAyOSBPY3QgMjAxMyAxNzowNTowNCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hd IDIwMTMtMTAtMjkgIENyeXN0YWwgWmhhbmcgIDxoYWl6aGFuZ0BibGFja2JlcnJ5LmNvbT4KCiAg ICAgICAgTm9kZSBzaG91bGRuJ3QgYmUgc2VsZWN0ZWQgaWYgaXQncyBub3QgYSBkcmFnZ2FibGUg ZWxlbWVudCBhbmQgaGFzIC13ZWJraXQtdXNlci1zZWxlY3Q6IG5vbmUgc2V0LgogICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM0NjQKCiAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEFzIHRoZSBjb21tZW50IHNheXMsIGlm IGl0J3MgYSBkcmFnZ2FibGUgZWxlbWVudCwgdGhlbiBpdCBzaG91bGQgYmUgYWxsb3dlZCB0byBi ZSBzZWxlY3RlZCwgc28KICAgICAgICBkcmFnICYgZHJvcCBhY3Rpb24gY2FuIGJlIHBlcmZvcm1l ZCwgaWYgaXQncyBub3QsIGFuZCBoYXMgLXdlYmtpdC11c2VyLXNlbGVjdDogbm9uZSBzZXQsIHRo ZW4gaXQKICAgICAgICBzaG91bGRuJ3QgYmUgYWxsb3dlZC4KCiAgICAgICAgSklSQSAxNDM1MS4K CiAgICAgICAgKiBkb20vTm9kZS5jcHA6CiAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmNhblN0YXJ0 U2VsZWN0aW9uKToKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgfCAxNCArKysrKysr KysrKysrKwogU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwIHwgIDIgKy0KIDIgZmlsZXMgY2hh bmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMmQ5 YzE5Li40NTY2NGE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMTAtMjkgIENy eXN0YWwgWmhhbmcgIDxoYWl6aGFuZ0BibGFja2JlcnJ5LmNvbT4KKworICAgICAgICBOb2RlIHNo b3VsZG4ndCBiZSBzZWxlY3RlZCBpZiBpdCdzIG5vdCBhIGRyYWdnYWJsZSBlbGVtZW50IGFuZCBo YXMgLXdlYmtpdC11c2VyLXNlbGVjdDogbm9uZSBzZXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM0NjQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyB0aGUgY29tbWVudCBzYXlzLCBpZiBpdCdzIGEg ZHJhZ2dhYmxlIGVsZW1lbnQsIHRoZW4gaXQgc2hvdWxkIGJlIGFsbG93ZWQgdG8gYmUgc2VsZWN0 ZWQsIHNvCisgICAgICAgIGRyYWcgJiBkcm9wIGFjdGlvbiBjYW4gYmUgcGVyZm9ybWVkLCBpZiBp dCdzIG5vdCwgYW5kIGhhcyAtd2Via2l0LXVzZXItc2VsZWN0OiBub25lIHNldCwgdGhlbiBpdAor ICAgICAgICBzaG91bGRuJ3QgYmUgYWxsb3dlZC4KKworICAgICAgICAqIGRvbS9Ob2RlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmNhblN0YXJ0U2VsZWN0aW9uKToKKwogMjAxMy0xMC0x NiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBjb2Rl IGZvciBmaW5kaW5nIHJlbmRlcmVkIGNoYXJhY3RlciBvZmZzZXQgdG8gUmVuZGVyVGV4dExpbmVC b3hlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwIGIvU291cmNlL1dl YkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IGZmM2IzOTIuLjEzM2YxZWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5j cHAKQEAgLTkzOCw3ICs5MzgsNyBAQCBib29sIE5vZGU6OmNhblN0YXJ0U2VsZWN0aW9uKCkgY29u c3QKICAgICAgICAgUmVuZGVyU3R5bGUqIHN0eWxlID0gcmVuZGVyZXIoKS0+c3R5bGUoKTsKICAg ICAgICAgLy8gV2UgYWxsb3cgc2VsZWN0aW9ucyB0byBiZWdpbiB3aXRoaW4gYW4gZWxlbWVudCB0 aGF0IGhhcyAtd2Via2l0LXVzZXItc2VsZWN0OiBub25lIHNldCwKICAgICAgICAgLy8gYnV0IGlm IHRoZSBlbGVtZW50IGlzIGRyYWdnYWJsZSB0aGVuIGRyYWdnaW5nIHNob3VsZCB0YWtlIHByaW9y aXR5IG92ZXIgc2VsZWN0aW9uLgotICAgICAgICBpZiAoc3R5bGUtPnVzZXJEcmFnKCkgPT0gRFJB R19FTEVNRU5UICYmIHN0eWxlLT51c2VyU2VsZWN0KCkgPT0gU0VMRUNUX05PTkUpCisgICAgICAg IGlmIChzdHlsZS0+dXNlckRyYWcoKSAhPSBEUkFHX0VMRU1FTlQgJiYgc3R5bGUtPnVzZXJTZWxl Y3QoKSA9PSBTRUxFQ1RfTk9ORSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAg ICAgcmV0dXJuIHBhcmVudE9yU2hhZG93SG9zdE5vZGUoKSA/IHBhcmVudE9yU2hhZG93SG9zdE5v ZGUoKS0+Y2FuU3RhcnRTZWxlY3Rpb24oKSA6IHRydWU7Ci0tIAoxLjguNAoK