123456 2013-10-29 11:44:39 -0700 StringImpl::adopt() should return PassRef. 2023-09-06 14:13:06 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kling kling benjamin cmarcelo commit-queue webkit-bug-importer oldest_to_newest 944516 0 kling 2013-10-29 11:44:39 -0700 StringImpl::adopt() should return PassRef. 944518 1 215409 kling 2013-10-29 11:46:36 -0700 Created attachment 215409 Patch 944548 2 215409 commit-queue 2013-10-29 13:00:20 -0700 Comment on attachment 215409 Patch Clearing flags on attachment: 215409 Committed r158213: <http://trac.webkit.org/changeset/158213> 944549 3 commit-queue 2013-10-29 13:00:23 -0700 All reviewed patches have been landed. Closing bug. 1975915 4 webkit-bug-importer 2023-09-06 14:13:06 -0700 <rdar://problem/115075917> 215409 2013-10-29 11:46:36 -0700 2013-10-29 13:00:20 -0700 Patch bug-123456.diff text/plain 3155 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggOTI5ZDJjOS4uMTJkMDQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0xMC0yOSAg QW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CisKKyAgICAgICAgU3RyaW5nSW1wbDo6 YWRvcHQoKSBzaG91bGQgcmV0dXJuIFBhc3NSZWYuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8xMjM0NTY+CisKKyAgICAgICAgTWFrZSB0aGUgU3RyaW5nSW1wbDo6YWRvcHQoKSBmdW5j dGlvbnMgcmV0dXJuIGEgUGFzc1JlZjxTdHJpbmdJbXBsPi4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKwogMjAxMy0xMC0yOSAgSmlud29vIFNvbmcgIDxqaW53b283LnNv bmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmUtZW5hYmxlIHNpbXBsZSBsaW5lIGxheW91dCBm b3IgRUZMCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwIGIv U291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAppbmRleCBlMjY2MzY0Li5hNTJlMDgx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCisrKyBiL1Nv dXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAKQEAgLTE5ODksMjAgKzE5ODksMjAgQEAg VUNoYXJEaXJlY3Rpb24gU3RyaW5nSW1wbDo6ZGVmYXVsdFdyaXRpbmdEaXJlY3Rpb24oYm9vbCog aGFzU3Ryb25nRGlyZWN0aW9uYWxpdHkKICAgICByZXR1cm4gVV9MRUZUX1RPX1JJR0hUOwogfQog Ci1QYXNzUmVmUHRyPFN0cmluZ0ltcGw+IFN0cmluZ0ltcGw6OmFkb3B0KFN0cmluZ0J1ZmZlcjxM Q2hhcj4mIGJ1ZmZlcikKK1Bhc3NSZWY8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6YWRvcHQoU3Ry aW5nQnVmZmVyPExDaGFyPiYgYnVmZmVyKQogewotdW5zaWduZWQgbGVuZ3RoID0gYnVmZmVyLmxl bmd0aCgpOwotaWYgKCFsZW5ndGgpCi0gICAgcmV0dXJuIGVtcHR5KCk7Ci1yZXR1cm4gYWRvcHRS ZWYobmV3IFN0cmluZ0ltcGwoYnVmZmVyLnJlbGVhc2UoKSwgbGVuZ3RoKSk7CisgICAgdW5zaWdu ZWQgbGVuZ3RoID0gYnVmZmVyLmxlbmd0aCgpOworICAgIGlmICghbGVuZ3RoKQorICAgICAgICBy ZXR1cm4gKmVtcHR5KCk7CisgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgU3RyaW5nSW1wbChidWZm ZXIucmVsZWFzZSgpLCBsZW5ndGgpKTsKIH0KIAotUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBTdHJp bmdJbXBsOjphZG9wdChTdHJpbmdCdWZmZXI8VUNoYXI+JiBidWZmZXIpCitQYXNzUmVmPFN0cmlu Z0ltcGw+IFN0cmluZ0ltcGw6OmFkb3B0KFN0cmluZ0J1ZmZlcjxVQ2hhcj4mIGJ1ZmZlcikKIHsK ICAgICB1bnNpZ25lZCBsZW5ndGggPSBidWZmZXIubGVuZ3RoKCk7CiAgICAgaWYgKCFsZW5ndGgp Ci0gICAgICAgIHJldHVybiBlbXB0eSgpOwotICAgIHJldHVybiBhZG9wdFJlZihuZXcgU3RyaW5n SW1wbChidWZmZXIucmVsZWFzZSgpLCBsZW5ndGgpKTsKKyAgICAgICAgcmV0dXJuICplbXB0eSgp OworICAgIHJldHVybiBhZG9wdFJlZigqbmV3IFN0cmluZ0ltcGwoYnVmZmVyLnJlbGVhc2UoKSwg bGVuZ3RoKSk7CiB9CiAKIHNpemVfdCBTdHJpbmdJbXBsOjpzaXplSW5CeXRlcygpIGNvbnN0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaCBiL1NvdXJjZS9XVEYv d3RmL3RleHQvU3RyaW5nSW1wbC5oCmluZGV4IDViNmQzZWQuLmI5Nzk3OTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3Rl eHQvU3RyaW5nSW1wbC5oCkBAIC00MzUsMTkgKzQzNSwxOSBAQCBwdWJsaWM6CiAgICAgc3RhdGlj IHVuc2lnbmVkIGRhdGFPZmZzZXQoKSB7IHJldHVybiBPQkpFQ1RfT0ZGU0VUT0YoU3RyaW5nSW1w bCwgbV9kYXRhOCk7IH0KIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIENoYXJUeXBlLCBzaXplX3Qg aW5saW5lQ2FwYWNpdHksIHR5cGVuYW1lIE92ZXJmbG93SGFuZGxlcj4KLSAgICBzdGF0aWMgUGFz c1JlZlB0cjxTdHJpbmdJbXBsPiBhZG9wdChWZWN0b3I8Q2hhclR5cGUsIGlubGluZUNhcGFjaXR5 LCBPdmVyZmxvd0hhbmRsZXI+JiB2ZWN0b3IpCisgICAgc3RhdGljIFBhc3NSZWY8U3RyaW5nSW1w bD4gYWRvcHQoVmVjdG9yPENoYXJUeXBlLCBpbmxpbmVDYXBhY2l0eSwgT3ZlcmZsb3dIYW5kbGVy PiYgdmVjdG9yKQogICAgIHsKICAgICAgICAgaWYgKHNpemVfdCBzaXplID0gdmVjdG9yLnNpemUo KSkgewogICAgICAgICAgICAgQVNTRVJUKHZlY3Rvci5kYXRhKCkpOwogICAgICAgICAgICAgaWYg KHNpemUgPiBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2lnbmVkPjo6bWF4KCkpCiAgICAgICAgICAg ICAgICAgQ1JBU0goKTsKLSAgICAgICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgU3RyaW5nSW1w bCh2ZWN0b3IucmVsZWFzZUJ1ZmZlcigpLCBzaXplKSk7CisgICAgICAgICAgICByZXR1cm4gYWRv cHRSZWYoKm5ldyBTdHJpbmdJbXBsKHZlY3Rvci5yZWxlYXNlQnVmZmVyKCksIHNpemUpKTsKICAg ICAgICAgfQotICAgICAgICByZXR1cm4gZW1wdHkoKTsKKyAgICAgICAgcmV0dXJuICplbXB0eSgp OwogICAgIH0KIAotICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBzdGF0aWMgUGFzc1JlZlB0cjxT dHJpbmdJbXBsPiBhZG9wdChTdHJpbmdCdWZmZXI8VUNoYXI+Jik7Ci0gICAgV1RGX0VYUE9SVF9T VFJJTkdfQVBJIHN0YXRpYyBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IGFkb3B0KFN0cmluZ0J1ZmZl cjxMQ2hhcj4mKTsKKyAgICBXVEZfRVhQT1JUX1NUUklOR19BUEkgc3RhdGljIFBhc3NSZWY8U3Ry aW5nSW1wbD4gYWRvcHQoU3RyaW5nQnVmZmVyPFVDaGFyPiYpOworICAgIFdURl9FWFBPUlRfU1RS SU5HX0FQSSBzdGF0aWMgUGFzc1JlZjxTdHJpbmdJbXBsPiBhZG9wdChTdHJpbmdCdWZmZXI8TENo YXI+Jik7CiAKICAgICB1bnNpZ25lZCBsZW5ndGgoKSBjb25zdCB7IHJldHVybiBtX2xlbmd0aDsg fQogICAgIGJvb2wgaXM4Qml0KCkgY29uc3QgeyByZXR1cm4gbV9oYXNoQW5kRmxhZ3MgJiBzX2hh c2hGbGFnOEJpdEJ1ZmZlcjsgfQo=