123023 2013-10-18 07:51:37 -0700 [mips][arm EABI] Fix J_JITOperation_EAapJ call in JIT. 2013-10-21 08:30:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 jbriance webkit-unassigned commit-queue kilvadyb msaboff ossy yong.li.webkit oldest_to_newest 941196 0 jbriance 2013-10-18 07:51:37 -0700 EABI_32BIT_DUMMY_ARG is not expected in the following function, the EncodedJSValue parameter is already aligned to even registers for MIPS and ARM EABI (in 3rd and 4th argument registers): ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(J_JITOperation_EAapJ operation, int dst, ArrayAllocationProfile* arg1, GPRReg arg2Tag, GPRReg arg2Payload) { setupArgumentsWithExecState(TrustedImmPtr(arg1), EABI_32BIT_DUMMY_ARG arg2Payload, arg2Tag); return appendCallWithExceptionCheckSetJSValueResult(operation, dst); } 941198 1 214572 jbriance 2013-10-18 07:55:35 -0700 Created attachment 214572 Fix J_JITOperation_EAapJ call for MIPS and ARM EABI. 941205 2 214572 commit-queue 2013-10-18 08:22:14 -0700 Comment on attachment 214572 Fix J_JITOperation_EAapJ call for MIPS and ARM EABI. Clearing flags on attachment: 214572 Committed r157633: <http://trac.webkit.org/changeset/157633> 941206 3 commit-queue 2013-10-18 08:22:16 -0700 All reviewed patches have been landed. Closing bug. 214572 2013-10-18 07:55:35 -0700 2013-10-18 08:22:14 -0700 Fix J_JITOperation_EAapJ call for MIPS and ARM EABI. bug-123023.patch text/plain 1406 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NjMxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTEwLTE4ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIEZpeCBKX0pJVE9wZXJhdGlvbl9FQWFwSiBjYWxsIGZvciBNSVBTIGFuZCBBUk0gRUFC SS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzAy MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaml0 L0pJVElubGluZXMuaDoKKyAgICAgICAgKEpTQzo6SklUOjpjYWxsT3BlcmF0aW9uKTogRW5jb2Rl ZEpTVmFsdWUgcGFyYW1ldGVyIGRvIG5vdCBuZWVkIGFsaWdubWVudAorICAgICAgICB1c2luZyBF QUJJXzMyQklUX0RVTU1ZX0FSRyBoZXJlLgorCiAyMDEzLTEwLTE3ICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYW5vdGhlciBBUk02NCBidWls ZCBmaXguCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZXMuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZXMuaAkocmV2aXNp b24gMTU3NjMxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRJbmxpbmVzLmgJKHdv cmtpbmcgY29weSkKQEAgLTQ2NSw3ICs0NjUsNyBAQCBBTFdBWVNfSU5MSU5FIE1hY3JvQXNzZW1i bGVyOjpDYWxsIEpJVDo6CiAKIEFMV0FZU19JTkxJTkUgTWFjcm9Bc3NlbWJsZXI6OkNhbGwgSklU OjpjYWxsT3BlcmF0aW9uKEpfSklUT3BlcmF0aW9uX0VBYXBKIG9wZXJhdGlvbiwgaW50IGRzdCwg QXJyYXlBbGxvY2F0aW9uUHJvZmlsZSogYXJnMSwgR1BSUmVnIGFyZzJUYWcsIEdQUlJlZyBhcmcy UGF5bG9hZCkKIHsKLSAgICBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoVHJ1c3RlZEltbVB0 cihhcmcxKSwgRUFCSV8zMkJJVF9EVU1NWV9BUkcgYXJnMlBheWxvYWQsIGFyZzJUYWcpOworICAg IHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShUcnVzdGVkSW1tUHRyKGFyZzEpLCBhcmcyUGF5 bG9hZCwgYXJnMlRhZyk7CiAgICAgcmV0dXJuIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2tT ZXRKU1ZhbHVlUmVzdWx0KG9wZXJhdGlvbiwgZHN0KTsKIH0KIAo=