123021 2013-10-18 07:49:40 -0700 Crash when requesting properties of sourcebuffer 2013-10-24 00:49:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified UNCONFIRMED P2 Normal --- 0 sjadaud webkit-unassigned cdumez commit-queue david.corvoysier eric.carlson esprehn+autocc glenn jer.noble kondapallykalyan pnormand oldest_to_newest 941193 0 sjadaud 2013-10-18 07:49:40 -0700 After activating media-source feature, a crash appears when requesting properties of source buffer list with Web Inspector. It looks to be caused by inheriting directly from EventTarget. It appears since integration of bug #118752. 941199 1 214573 sjadaud 2013-10-18 07:56:14 -0700 Created attachment 214573 Patch 941301 2 214573 jer.noble 2013-10-18 12:47:58 -0700 Comment on attachment 214573 Patch Yep, I've seen this too. I think there's a deeper problem in the generator, as other IDLs inherit from EventTarget, though not without also being ActiveDOMObjects. In the meantime, this is a good fix. 942742 3 214573 ap 2013-10-23 10:50:26 -0700 Comment on attachment 214573 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214573&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Is this covered by existing regression tests? How will we know to not break this again in the future? 943014 4 sjadaud 2013-10-24 00:49:05 -0700 (In reply to comment #3) > (From update of attachment 214573 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214573&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > Is this covered by existing regression tests? How will we know to not break this again in the future? It is covered by the media-source tests that are currently skipped. Media-source tests will be activated with bug #99065 214573 2013-10-18 07:56:14 -0700 2013-10-23 10:50:26 -0700 Patch bug-123021-20131018165612.patch text/plain 5936 sjadaud U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3NjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTM1NDQ2OWRiOWZlZDNl ODNjMmZlMThkM2Y3MDNlYzA0YzIzMjIwYy4uODc1NGZmNmExZmU5YWE3YWY1NGJhYTBhOWQ4MGMz Y2Q0YTA1ZGU4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTEwLTE4ICBTdGVw aGFuZSBKYWRhdWQgIDxzamFkYXVkQHNpaS5mcj4KKworICAgICAgICBDcmFzaCB3aGVuIHJlcXVl c3RpbmcgcHJvcGVydGllcyBvZiBzb3VyY2VidWZmZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzAyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEpLgorCisgICAgICAg ICogTW9kdWxlcy9tZWRpYXNvdXJjZS9NZWRpYVNvdXJjZS5pZGw6CisgICAgICAgICogTW9kdWxl cy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuaWRsOgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFz b3VyY2UvU291cmNlQnVmZmVyTGlzdC5pZGw6CisgICAgICAgICogTW9kdWxlcy9tZWRpYXNvdXJj ZS9XZWJLaXRNZWRpYVNvdXJjZS5pZGw6CisgICAgICAgICogTW9kdWxlcy9tZWRpYXNvdXJjZS9X ZWJLaXRTb3VyY2VCdWZmZXJMaXN0LmlkbDoKKwogMjAxMy0xMC0xOCAgRGVuaXMgTm9taXlhbWEg IDxkLm5vbWl5YW1hQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtBVEtdIEZpeCBpbnZhbGlkIHNp Z25hbCB0byBzZXQgb2JqZWN0cyB0byBhbiB1bmtub3duIHN0YXRlICJsYXlvdXQtY29tcGxldGUi CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL01lZGlhU291 cmNlLmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2Uu aWRsCmluZGV4IDZhODk2NTQ3ZjU3NDk3MWY5MWZjMmFkZDI4OGNkNWFlYmQxMjAxZTIuLmEyYzdk MWVjNjc0YzQ5NTVmOTZhODRiYTViZTNlZjVmMzVlOGZhODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuaWRsCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuaWRsCkBAIC0zMiw2ICszMiw3 IEBACiAgICAgQ29uZGl0aW9uYWw9TUVESUFfU09VUkNFLAogICAgIEFjdGl2ZURPTU9iamVjdCwK ICAgICBFdmVudFRhcmdldCwKKyAgICBKU0dlbmVyYXRlVG9KU09iamVjdCwKICAgICBKU0dlbmVy YXRlVG9OYXRpdmVPYmplY3QsCiAgICAgQ29uc3RydWN0b3IsCiAgICAgQ29uc3RydWN0b3JDYWxs V2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuaWRsCmluZGV4IDVlMDZiM2RiMTZiNDEyNjQ5 Y2EzODFiNjA2NjM0Y2Q2ZmY4MDlkMDUuLmI5OWVhYTUyMmUwMTM3Mjk4ZmRkOTgxMjE1MzQ0YzNk ZjRlMjFhYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2Uv U291cmNlQnVmZmVyLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNl L1NvdXJjZUJ1ZmZlci5pZGwKQEAgLTM1LDcgKzM1LDcgQEAKICAgICBFdmVudFRhcmdldCwKICAg ICBKU0dlbmVyYXRlVG9OYXRpdmVPYmplY3QsCiAgICAgT3BlcmF0aW9uc05vdERlbGV0YWJsZQot XSBpbnRlcmZhY2UgU291cmNlQnVmZmVyIDogRXZlbnRUYXJnZXQgeworXSBpbnRlcmZhY2UgU291 cmNlQnVmZmVyIHsKIAogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFuIHVwZGF0aW5nOwog ICAKQEAgLTUxLDUgKzUxLDE0IEBACiAKICAgICAvLyBBYm9ydCB0aGUgY3VycmVudCBzZWdtZW50 IGFwcGVuZCBzZXF1ZW5jZS4KICAgICBbUmFpc2VzRXhjZXB0aW9uXSB2b2lkIGFib3J0KCk7CisK KyAgICAvLyBFdmVudFRhcmdldCBpbnRlcmZhY2UKKyAgICB2b2lkIGFkZEV2ZW50TGlzdGVuZXIo RE9NU3RyaW5nIHR5cGUsCisgICAgICAgICAgICAgICAgICAgICAgICAgIEV2ZW50TGlzdGVuZXIg bGlzdGVuZXIsCisgICAgICAgICAgICAgICAgICAgICAgICAgIG9wdGlvbmFsIGJvb2xlYW4gdXNl Q2FwdHVyZSk7CisgICAgdm9pZCByZW1vdmVFdmVudExpc3RlbmVyKERPTVN0cmluZyB0eXBlLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBFdmVudExpc3RlbmVyIGxpc3RlbmVyLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBvcHRpb25hbCBib29sZWFuIHVzZUNhcHR1cmUpOwor ICAgIFtSYWlzZXNFeGNlcHRpb25dIGJvb2xlYW4gZGlzcGF0Y2hFdmVudChFdmVudCBldmVudCk7 CiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1Nv dXJjZUJ1ZmZlckxpc3QuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9T b3VyY2VCdWZmZXJMaXN0LmlkbAppbmRleCBjZmQ3NjM5Y2IzNDgxZGVjZmVlMzVhN2QxMmY3MDBj M2U5YzA5MmQ4Li5hZjU3NWRlMDZmNjUyMjdlNmIzZmFlNzJhZjRhNTU4ZGNjZTE4MzJjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlckxp c3QuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVm ZmVyTGlzdC5pZGwKQEAgLTM1LDggKzM1LDE3IEBACiAgICAgSlNHZW5lcmF0ZVRvTmF0aXZlT2Jq ZWN0LAogICAgIENhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCiAgICAgT3BlcmF0aW9u c05vdERlbGV0YWJsZQotXSBpbnRlcmZhY2UgU291cmNlQnVmZmVyTGlzdCA6IEV2ZW50VGFyZ2V0 IHsKK10gaW50ZXJmYWNlIFNvdXJjZUJ1ZmZlckxpc3QgewogICAgIHJlYWRvbmx5IGF0dHJpYnV0 ZSB1bnNpZ25lZCBsb25nIGxlbmd0aDsKICAgICBnZXR0ZXIgU291cmNlQnVmZmVyIGl0ZW0odW5z aWduZWQgbG9uZyBpbmRleCk7CisKKyAgICAvLyBFdmVudFRhcmdldCBpbnRlcmZhY2UKKyAgICB2 b2lkIGFkZEV2ZW50TGlzdGVuZXIoRE9NU3RyaW5nIHR5cGUsCisgICAgICAgICAgICAgICAgICAg ICAgICAgIEV2ZW50TGlzdGVuZXIgbGlzdGVuZXIsCisgICAgICAgICAgICAgICAgICAgICAgICAg IG9wdGlvbmFsIGJvb2xlYW4gdXNlQ2FwdHVyZSk7CisgICAgdm9pZCByZW1vdmVFdmVudExpc3Rl bmVyKERPTVN0cmluZyB0eXBlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBFdmVudExp c3RlbmVyIGxpc3RlbmVyLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvcHRpb25hbCBi b29sZWFuIHVzZUNhcHR1cmUpOworICAgIFtSYWlzZXNFeGNlcHRpb25dIGJvb2xlYW4gZGlzcGF0 Y2hFdmVudChFdmVudCBldmVudCk7CiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc291cmNlL1dlYktpdE1lZGlhU291cmNlLmlkbCBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFzb3VyY2UvV2ViS2l0TWVkaWFTb3VyY2UuaWRsCmluZGV4IGRhODQ2MTRi NWMzZmUyNjQ3ZGMwOTZkMmExMTNhMDg5Y2U0NGMyNzQuLmVjYTEwMWEyZTFhNmVlOGVlYjE3NzAy ZmNjOTRkYWE5YjlhZWUyNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzb3VyY2UvV2ViS2l0TWVkaWFTb3VyY2UuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFzb3VyY2UvV2ViS2l0TWVkaWFTb3VyY2UuaWRsCkBAIC0zNiw3ICszNiw3IEBACiAg ICAgQ29uc3RydWN0b3IsCiAgICAgQ29uc3RydWN0b3JDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25D b250ZXh0LAogICAgIE9wZXJhdGlvbnNOb3REZWxldGFibGUKLV0gaW50ZXJmYWNlIFdlYktpdE1l ZGlhU291cmNlIDogRXZlbnRUYXJnZXQgeworXSBpbnRlcmZhY2UgV2ViS2l0TWVkaWFTb3VyY2Ug ewogICAgIC8vIEFsbCB0aGUgc291cmNlIGJ1ZmZlcnMgY3JlYXRlZCBieSB0aGlzIG9iamVjdC4K ICAgICByZWFkb25seSBhdHRyaWJ1dGUgV2ViS2l0U291cmNlQnVmZmVyTGlzdCBzb3VyY2VCdWZm ZXJzOwogCkBAIC01Myw1ICs1MywxMyBAQAogICAgIFtSYWlzZXNFeGNlcHRpb25dIHZvaWQgZW5k T2ZTdHJlYW0oW0RlZmF1bHQ9TnVsbFN0cmluZ10gb3B0aW9uYWwgRE9NU3RyaW5nIGVycm9yKTsK IAogICAgIHN0YXRpYyBib29sZWFuIGlzVHlwZVN1cHBvcnRlZCAoRE9NU3RyaW5nIHR5cGUpOwot fTsKIAorICAgIC8vIEV2ZW50VGFyZ2V0IGludGVyZmFjZQorICAgIHZvaWQgYWRkRXZlbnRMaXN0 ZW5lcihET01TdHJpbmcgdHlwZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgRXZlbnRMaXN0 ZW5lciBsaXN0ZW5lciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgb3B0aW9uYWwgYm9vbGVh biB1c2VDYXB0dXJlKTsKKyAgICB2b2lkIHJlbW92ZUV2ZW50TGlzdGVuZXIoRE9NU3RyaW5nIHR5 cGUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEV2ZW50TGlzdGVuZXIgbGlzdGVuZXIs CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9wdGlvbmFsIGJvb2xlYW4gdXNlQ2FwdHVy ZSk7CisgICAgW1JhaXNlc0V4Y2VwdGlvbl0gYm9vbGVhbiBkaXNwYXRjaEV2ZW50KEV2ZW50IGV2 ZW50KTsKK307CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNl L1dlYktpdFNvdXJjZUJ1ZmZlckxpc3QuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXNvdXJjZS9XZWJLaXRTb3VyY2VCdWZmZXJMaXN0LmlkbAppbmRleCA5NWRiNThjMGU3NzA4MGNl OWI3NWE4MTgwMDliNjZlNzU5ZWE4MzRhLi41YmZhZjM3ZTNkNTk3ZDMwZmZmZjM4MDNmNGU0MDY0 ZDIzYmM1MjNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNl L1dlYktpdFNvdXJjZUJ1ZmZlckxpc3QuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzb3VyY2UvV2ViS2l0U291cmNlQnVmZmVyTGlzdC5pZGwKQEAgLTMyLDkgKzMyLDE5IEBA CiAgICAgQ29uZGl0aW9uYWw9TUVESUFfU09VUkNFLAogICAgIEV2ZW50VGFyZ2V0LAogICAgIEpT R2VuZXJhdGVUb05hdGl2ZU9iamVjdCwKKyAgICBDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250 ZXh0LAogICAgIE9wZXJhdGlvbnNOb3REZWxldGFibGUKLV0gaW50ZXJmYWNlIFdlYktpdFNvdXJj ZUJ1ZmZlckxpc3QgOiBFdmVudFRhcmdldCB7CitdIGludGVyZmFjZSBXZWJLaXRTb3VyY2VCdWZm ZXJMaXN0IHsKICAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5zaWduZWQgbG9uZyBsZW5ndGg7CiAg ICAgZ2V0dGVyIFdlYktpdFNvdXJjZUJ1ZmZlciBpdGVtKHVuc2lnbmVkIGxvbmcgaW5kZXgpOwor CisgICAgLy8gRXZlbnRUYXJnZXQgaW50ZXJmYWNlCisgICAgdm9pZCBhZGRFdmVudExpc3RlbmVy KERPTVN0cmluZyB0eXBlLAorICAgICAgICAgICAgICAgICAgICAgICAgICBFdmVudExpc3RlbmVy IGxpc3RlbmVyLAorICAgICAgICAgICAgICAgICAgICAgICAgICBvcHRpb25hbCBib29sZWFuIHVz ZUNhcHR1cmUpOworICAgIHZvaWQgcmVtb3ZlRXZlbnRMaXN0ZW5lcihET01TdHJpbmcgdHlwZSwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRXZlbnRMaXN0ZW5lciBsaXN0ZW5lciwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgb3B0aW9uYWwgYm9vbGVhbiB1c2VDYXB0dXJlKTsK KyAgICBbUmFpc2VzRXhjZXB0aW9uXSBib29sZWFuIGRpc3BhdGNoRXZlbnQoRXZlbnQgZXZlbnQp OwogfTsKIAo=