122972 2013-10-17 10:30:32 -0700 Don't add an include for return type of a [Custom] function in generated bindings code 2013-10-17 17:51:20 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 122679 1 ap ap cdumez commit-queue ggaren mhahnenberg sam oldest_to_newest 940827 0 ap 2013-10-17 10:30:32 -0700 Custom functions are not implemented in generated files, so there is no reason to include headers for their types. We already have this behavior for their argument types. This is a minor roadblock for WebCrypto, where I have custom functions that return promises, but no matching headers for promise types. And a desirable behavior in any case, I think. 940828 1 214470 ap 2013-10-17 10:32:05 -0700 Created attachment 214470 proposed patch 941068 2 214470 commit-queue 2013-10-17 17:51:17 -0700 Comment on attachment 214470 proposed patch Clearing flags on attachment: 214470 Committed r157615: <http://trac.webkit.org/changeset/157615> 941069 3 commit-queue 2013-10-17 17:51:20 -0700 All reviewed patches have been landed. Closing bug. 214470 2013-10-17 10:32:05 -0700 2013-10-17 17:51:17 -0700 proposed patch CustomFunctionReturnType.txt text/plain 1760 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzU3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTEwLTE3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IGFkZCBhbiBpbmNs dWRlIGZvciByZXR1cm4gdHlwZSBvZiBhIFtDdXN0b21dIGZ1bmN0aW9uIGluIGdlbmVyYXRlZCBi aW5kaW5ncyBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjI5NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOiAoR2VuZXJhdGVJbXBs ZW1lbnRhdGlvbik6IERvbid0LgorCiAyMDEzLTEwLTE3ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5n QGFwcGxlLmNvbT4KIAogICAgICAgICBTdHlsZVJ1bGVGb286Om11dGFibGVQcm9wZXJ0aWVzKCkg c2hvdWxkIHJldHVybiBhIHJlZmVyZW5jZS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCShyZXZpc2lvbiAxNTc0NzApCisr KyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQkod29y a2luZyBjb3B5KQpAQCAtMjMzMCwxNCArMjMzMCwxNCBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRh dGlvbgogICAgICMgRnVuY3Rpb25zCiAgICAgaWYgKCRudW1GdW5jdGlvbnMgPiAwKSB7CiAgICAg ICAgIGZvcmVhY2ggbXkgJGZ1bmN0aW9uIChAeyRpbnRlcmZhY2UtPmZ1bmN0aW9uc30pIHsKLSAg ICAgICAgICAgIEFkZEluY2x1ZGVzRm9yVHlwZUluSW1wbCgkZnVuY3Rpb24tPnNpZ25hdHVyZS0+ dHlwZSk7Ci0KICAgICAgICAgICAgIG15ICRpc0N1c3RvbSA9IEhhc0N1c3RvbU1ldGhvZCgkZnVu Y3Rpb24tPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzKTsKICAgICAgICAgICAgIG15ICRp c092ZXJsb2FkZWQgPSAkZnVuY3Rpb24tPntvdmVybG9hZHN9ICYmIEB7JGZ1bmN0aW9uLT57b3Zl cmxvYWRzfX0gPiAxOwogICAgICAgICAgICAgbXkgJHJhaXNlc0V4Y2VwdGlvbiA9ICRmdW5jdGlv bi0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiUmFpc2VzRXhjZXB0aW9uIn07CiAK ICAgICAgICAgICAgIG5leHQgaWYgJGlzQ3VzdG9tICYmICRpc092ZXJsb2FkZWQgJiYgJGZ1bmN0 aW9uLT57b3ZlcmxvYWRJbmRleH0gPiAxOwogCisgICAgICAgICAgICBBZGRJbmNsdWRlc0ZvclR5 cGVJbkltcGwoJGZ1bmN0aW9uLT5zaWduYXR1cmUtPnR5cGUpIHVubGVzcyAkaXNDdXN0b207CisK ICAgICAgICAgICAgIG15ICRmdW5jdGlvbk5hbWUgPSBHZXRGdW5jdGlvbk5hbWUoJGNsYXNzTmFt ZSwgJGZ1bmN0aW9uKTsKIAogICAgICAgICAgICAgbXkgJGNvbmRpdGlvbmFsID0gJGZ1bmN0aW9u LT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDb25kaXRpb25hbCJ9Owo=