122832 2013-10-15 07:43:54 -0700 [GStreamer] use a smart pointer for ::setStreamVolumeElement() 2013-10-17 05:52:57 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 79203 1 pnormand webkit-unassigned commit-queue eflews.bot eric.carlson glenn gtk-ews gustavo gyuyoung.kim jer.noble menard mrobinson pnormand xan.lopez oldest_to_newest 939962 0 pnormand 2013-10-15 07:43:54 -0700 SSIA 939967 1 214260 pnormand 2013-10-15 08:30:06 -0700 Created attachment 214260 patch 939970 2 214260 eflews.bot 2013-10-15 08:33:23 -0700 Comment on attachment 214260 patch Attachment 214260 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/4099038 939971 3 214260 eflews.bot 2013-10-15 08:34:49 -0700 Comment on attachment 214260 patch Attachment 214260 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/4099039 939973 4 214260 gtk-ews 2013-10-15 08:39:43 -0700 Comment on attachment 214260 patch Attachment 214260 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/4099042 939974 5 214264 pnormand 2013-10-15 08:40:37 -0700 Created attachment 214264 patch 940102 6 214264 darin 2013-10-15 13:21:38 -0700 Comment on attachment 214264 patch View in context: https://bugs.webkit.org/attachment.cgi?id=214264&action=review > Source/WebCore/ChangeLog:10 > + Use a smart pointer all the way from call site to member variable storage. Why? 940376 7 pnormand 2013-10-16 08:09:01 -0700 (In reply to comment #6) > (From update of attachment 214264 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214264&action=review > > > Source/WebCore/ChangeLog:10 > > + Use a smart pointer all the way from call site to member variable storage. > > Why? Oh well I thought it'd simply be cleaner but I can't find other reasons and there's no ref leak in the current code. So I think I'll end up not doing this change. 214260 2013-10-15 08:30:06 -0700 2013-10-15 08:40:37 -0700 patch patch.patch text/plain 1868 pnormand RnJvbSAwMmZmMzk2NjQ2OTJiNzE3MWFiOWVjNzJiNTZkMGYwNzUwMDE0YjIyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDE1IE9jdCAyMDEzIDE3OjI2OjM2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB8IDExICsrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwICAgIHwgIDIgKy0KIDIgZmlsZXMg Y2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAy M2U3ZGMyLi45M2VjOGY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMTAtMTUg IFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHU3Ry ZWFtZXJdIHVzZSBhIHNtYXJ0IHBvaW50ZXIgZm9yIDo6c2V0U3RyZWFtVm9sdW1lRWxlbWVudCgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI4MzIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OnNl dFN0cmVhbVZvbHVtZUVsZW1lbnQpOgorICAgICAgICBVc2UgYSBzbWFydCBwb2ludGVyIGFsbCB0 aGUgd2F5IGZyb20gY2FsbCBzaXRlIHRvIG1lbWJlciB2YXJpYWJsZSBzdG9yYWdlLgorCiAyMDEz LTEwLTE1ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBGaWxl SWNvbkxvYWRlciBzaG91bGQgbm90IGJlIHJlZi1jb3VudGVkLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lckJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCmluZGV4IDQ0MTdkODEuLjc4 MjRlYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyQmFzZS5jcHAKQEAgLTYxNSw3ICs2MTUsNyBAQCBHc3RFbGVtZW50KiBNZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXJCYXNlOjpjcmVhdGVWaWRlb1NpbmsoR3N0RWxlbWVudCogcGlwZWxpbgog I2VuZGlmCiB9CiAKLXZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6c2V0U3Ry ZWFtVm9sdW1lRWxlbWVudChHc3RTdHJlYW1Wb2x1bWUqIHZvbHVtZSkKK3ZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6c2V0U3RyZWFtVm9sdW1lRWxlbWVudChHUmVmUHRyPEdz dFN0cmVhbVZvbHVtZT4gdm9sdW1lKQogewogICAgIEFTU0VSVCghbV92b2x1bWVFbGVtZW50KTsK ICAgICBtX3ZvbHVtZUVsZW1lbnQgPSB2b2x1bWU7Ci0tIAoxLjguNC5yYzM= 214264 2013-10-15 08:40:37 -0700 2013-10-17 05:52:31 -0700 patch patch.patch text/plain 2676 pnormand RnJvbSA2NGIxOTRhODFiODAyZGZlZWI1MDY1YjE0OTQzYTE0NjM1OGY3ZmU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDE1IE9jdCAyMDEzIDE3OjI2OjM2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB8IDExICsrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwICAgIHwgIDIgKy0KIC4uLi9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5oICAgICAgfCAg MiArLQogMyBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyM2U3ZGMyLi45M2VjOGY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTMtMTAtMTUgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHU3RyZWFtZXJdIHVzZSBhIHNtYXJ0IHBvaW50ZXIgZm9yIDo6c2V0U3RyZWFt Vm9sdW1lRWxlbWVudCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjI4MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXJCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lckJhc2U6OnNldFN0cmVhbVZvbHVtZUVsZW1lbnQpOgorICAgICAgICBVc2UgYSBzbWFy dCBwb2ludGVyIGFsbCB0aGUgd2F5IGZyb20gY2FsbCBzaXRlIHRvIG1lbWJlciB2YXJpYWJsZSBz dG9yYWdlLgorCiAyMDEzLTEwLTE1ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4K IAogICAgICAgICBGaWxlSWNvbkxvYWRlciBzaG91bGQgbm90IGJlIHJlZi1jb3VudGVkLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCmlu ZGV4IDQ0MTdkODEuLjc4MjRlYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKQEAgLTYxNSw3ICs2MTUsNyBAQCBHc3RFbGVtZW50 KiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjcmVhdGVWaWRlb1NpbmsoR3N0RWxl bWVudCogcGlwZWxpbgogI2VuZGlmCiB9CiAKLXZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyQmFzZTo6c2V0U3RyZWFtVm9sdW1lRWxlbWVudChHc3RTdHJlYW1Wb2x1bWUqIHZvbHVtZSkK K3ZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6c2V0U3RyZWFtVm9sdW1lRWxl bWVudChHUmVmUHRyPEdzdFN0cmVhbVZvbHVtZT4gdm9sdW1lKQogewogICAgIEFTU0VSVCghbV92 b2x1bWVFbGVtZW50KTsKICAgICBtX3ZvbHVtZUVsZW1lbnQgPSB2b2x1bWU7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyQmFzZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuaAppbmRleCAwMDhiOTIx Li5jOGUxYjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXJCYXNlLmgKQEAgLTExMiw3ICsxMTIsNyBAQCBwdWJsaWM6CiBwcm90ZWN0ZWQ6CiAgICAg TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZShNZWRpYVBsYXllciopOwogICAgIEdzdEVs ZW1lbnQqIGNyZWF0ZVZpZGVvU2luayhHc3RFbGVtZW50KiBwaXBlbGluZSk7Ci0gICAgdm9pZCBz ZXRTdHJlYW1Wb2x1bWVFbGVtZW50KEdzdFN0cmVhbVZvbHVtZSopOworICAgIHZvaWQgc2V0U3Ry ZWFtVm9sdW1lRWxlbWVudChHUmVmUHRyPEdzdFN0cmVhbVZvbHVtZT4pOwogICAgIHZpcnR1YWwg R3N0RWxlbWVudCogYXVkaW9TaW5rKCkgY29uc3QgeyByZXR1cm4gMDsgfQogICAgIEdSZWZQdHI8 R3N0Q2Fwcz4gY3VycmVudFZpZGVvU2lua0NhcHMoKSBjb25zdDsKIAotLSAKMS44LjQucmMz