<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>122831</bug_id>
          
          <creation_ts>2013-10-15 07:41:24 -0700</creation_ts>
          <short_desc>[GStreamer] Store video-sink in a bin</short_desc>
          <delta_ts>2013-10-30 03:35:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>79203</blocked>
    
    <blocked>123437</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Philippe Normand">pnormand</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>calvaris</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>glenn</cc>
    
    <cc>gustavo</cc>
    
    <cc>jer.noble</cc>
    
    <cc>menard</cc>
    
    <cc>mrobinson</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>939961</commentid>
    <comment_count>0</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-10-15 07:41:24 -0700</bug_when>
    <thetext>It&apos;s already done for the dead NATIVE_VIDEO_FULLSCREEN code path but we need the video-sink in a bin for mediastream too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>939966</commentid>
    <comment_count>1</comment_count>
      <attachid>214259</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-10-15 08:25:50 -0700</bug_when>
    <thetext>Created attachment 214259
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>944040</commentid>
    <comment_count>2</comment_count>
      <attachid>214259</attachid>
    <who name="Andy Wingo">wingo</who>
    <bug_when>2013-10-28 02:35:44 -0700</bug_when>
    <thetext>Comment on attachment 214259
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214259&amp;action=review

Drive-by review.

&gt; Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:539
&gt; +    m_videoSinkBin = gst_bin_new(0);

nullptr

&gt; Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:581
&gt;                  g_object_set(m_fpsSink, &quot;video-sink&quot;, m_webkitVideoSink.get(), NULL);

nullptr here, and elsewhere too

&gt; Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:606
&gt; +    // Add a ghostpad to the bin so it can proxy to tee.

&quot;ghost pad&quot;.  Also I don&apos;t think the comment is correct any more -- here we are adding a sink pad to the video sink bin, no?  And the child that it proxies to is not necessarily a tee it seems.  I would remove the comment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>944372</commentid>
    <comment_count>3</comment_count>
      <attachid>215374</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-10-29 03:23:25 -0700</bug_when>
    <thetext>Created attachment 215374
[player] make video-sink a bin</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>944385</commentid>
    <comment_count>4</comment_count>
      <attachid>215374</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2013-10-29 04:58:15 -0700</bug_when>
    <thetext>Comment on attachment 215374
[player] make video-sink a bin

View in context: https://bugs.webkit.org/attachment.cgi?id=215374&amp;action=review

LGTM in general, but it lacks a changelog entry.

&gt; Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:589
&gt;      }
&gt;  
&gt;      if (!m_fpsSink) {

This should be an else block. I think the actualVideoSink name is misleading because it may be something that is not the actual video sink heh. Is videoSink taken?

&gt; Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:603
&gt; -    return actualVideoSink;
&gt; +    firstChild = actualVideoSink;

You could initialize firstChild to this instead of doing it in the else block, just a nit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>944395</commentid>
    <comment_count>5</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-10-29 05:31:34 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 215374 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=215374&amp;action=review
&gt; 
&gt; LGTM in general, but it lacks a changelog entry.
&gt; 

OOPS :)

&gt; &gt; Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:589
&gt; &gt;      }
&gt; &gt;  
&gt; &gt;      if (!m_fpsSink) {
&gt; 
&gt; This should be an else block. 

Hum, I don&apos;t think so because the variable is set in the if() branch in some cases, so checking it again here makes sense, I believe.

&gt; I think the actualVideoSink name is misleading because it may be something that is not the actual video sink heh. Is videoSink taken?
&gt; 

Good point, videoSink is not taken, yet!

&gt; &gt; Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:603
&gt; &gt; -    return actualVideoSink;
&gt; &gt; +    firstChild = actualVideoSink;
&gt; 
&gt; You could initialize firstChild to this instead of doing it in the else block, just a nit.

Right.

I&apos;ll upload a new version after lunch. Thanks for the review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>944417</commentid>
    <comment_count>6</comment_count>
      <attachid>215386</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-10-29 07:15:42 -0700</bug_when>
    <thetext>Created attachment 215386
[player] make video-sink a bin</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>944551</commentid>
    <comment_count>7</comment_count>
      <attachid>215386</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2013-10-29 13:08:34 -0700</bug_when>
    <thetext>Comment on attachment 215386
[player] make video-sink a bin

thanks =)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>944812</commentid>
    <comment_count>8</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-10-30 01:02:42 -0700</bug_when>
    <thetext>Committed r158258: &lt;http://trac.webkit.org/changeset/158258&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>944847</commentid>
    <comment_count>9</comment_count>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2013-10-30 03:35:35 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; &gt; Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:539
&gt; &gt; +    m_videoSinkBin = gst_bin_new(0);
&gt; 
&gt; nullptr
&gt; 
&gt; &gt; Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:581
&gt; &gt;                  g_object_set(m_fpsSink, &quot;video-sink&quot;, m_webkitVideoSink.get(), NULL);
&gt; 
&gt; nullptr here, and elsewhere too

I am not sure we want to use nullptr here instead of NULL, because in this case we are not defining or using WebKit/WebCore API, but GStreamer one and that&apos;s NULL based.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>214259</attachid>
            <date>2013-10-15 08:25:50 -0700</date>
            <delta_ts>2013-10-29 03:23:25 -0700</delta_ts>
            <desc>patch</desc>
            <filename>patch.patch</filename>
            <type>text/plain</type>
            <size>6517</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSBhODMxMDlmYTBiZDIzMTE0MzAwODIyMDM4ZTMyM2IyYzNiZGNlOGYzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBUdWUsIDE1IE9jdCAyMDEzIDE3OjIwOjE5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg
ICAgICAgfCAxNSArKysrKysrKysrKysKIC4uLi9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRl
R1N0cmVhbWVyLmNwcCAgICAgIHwgIDQgKystLQogLi4uL2dzdHJlYW1lci9NZWRpYVBsYXllclBy
aXZhdGVHU3RyZWFtZXJCYXNlLmNwcCAgfCAyNyArKysrKysrKy0tLS0tLS0tLS0tLS0tCiAuLi4v
Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuaCAgICB8ICAyICstCiA0
IGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQoKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv
ZwppbmRleCAyM2U3ZGMyLi40NDNlZDBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFu
Z2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIw
MTMtMTAtMTUgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAg
ICAgIFtHU3RyZWFtZXJdIFN0b3JlIHZpZGVvLXNpbmsgaW4gYSBiaW4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjgzMQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBwYXRj
aCBoYXMgbm8gZWZmZWN0IG9uIGV4aXN0aW5nIGZ1bmN0aW9uYWxpdGllcworICAgICAgICBvZiB0
aGUgcGxheWVyLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh
UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv
Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwOgorICAgICAgICAo
V2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6Y3JlYXRlVmlkZW9TaW5r
KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2
YXRlR1N0cmVhbWVyQmFzZS5oOgorCiAyMDEzLTEwLTE1ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5n
QGFwcGxlLmNvbT4KIAogICAgICAgICBGaWxlSWNvbkxvYWRlciBzaG91bGQgbm90IGJlIHJlZi1j
b3VudGVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0
cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNw
cAppbmRleCBlN2UyZDliLi5kNDI5ZTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAor
KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5
ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMTgzNSw5ICsxODM1LDkgQEAgdm9pZCBNZWRpYVBs
YXllclByaXZhdGVHU3RyZWFtZXI6OmNyZWF0ZUdTVFBsYXlCaW4oKQogICAgIH0KICNlbmRpZgog
Ci0gICAgR3N0RWxlbWVudCogdmlkZW9FbGVtZW50ID0gY3JlYXRlVmlkZW9TaW5rKG1fcGxheUJp
bi5nZXQoKSk7CisgICAgY3JlYXRlVmlkZW9TaW5rKG1fcGxheUJpbi5nZXQoKSk7CiAKLSAgICBn
X29iamVjdF9zZXQobV9wbGF5QmluLmdldCgpLCAidmlkZW8tc2luayIsIHZpZGVvRWxlbWVudCwg
TlVMTCk7CisgICAgZ19vYmplY3Rfc2V0KG1fcGxheUJpbi5nZXQoKSwgInZpZGVvLXNpbmsiLCBt
X3ZpZGVvU2lua0Jpbi5nZXQoKSwgTlVMTCk7CiAKICAgICBHUmVmUHRyPEdzdFBhZD4gdmlkZW9T
aW5rUGFkID0gYWRvcHRHUmVmKGdzdF9lbGVtZW50X2dldF9zdGF0aWNfcGFkKG1fd2Via2l0Vmlk
ZW9TaW5rLmdldCgpLCAic2luayIpKTsKICAgICBpZiAodmlkZW9TaW5rUGFkKQpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVy
UHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp
Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCmluZGV4IDQ0
MTdkODEuLjlhNWY0MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo
aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2
YXRlR1N0cmVhbWVyQmFzZS5jcHAKQEAgLTUyMSwxMiArNTIxLDEwIEBAIEdSZWZQdHI8R3N0Q2Fw
cz4gTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6Y3VycmVudFZpZGVvU2lua0NhcHMo
KSBjb25zdAogICAgIHJldHVybiBhZG9wdEdSZWYoY3VycmVudENhcHMpOwogfQogCi0vLyBUaGlz
IGZ1bmN0aW9uIGNyZWF0ZXMgYW5kIGluaXRpYWxpemVzIHNvbWUgaW50ZXJuYWwgdmFyaWFibGVz
LCBhbmQgcmV0dXJucyBhCi0vLyBwb2ludGVyIHRvIHRoZSBlbGVtZW50IHRoYXQgc2hvdWxkIHJl
Y2VpdmUgdGhlIGRhdGEgZmxvdyBmaXJzdAotR3N0RWxlbWVudCogTWVkaWFQbGF5ZXJQcml2YXRl
R1N0cmVhbWVyQmFzZTo6Y3JlYXRlVmlkZW9TaW5rKEdzdEVsZW1lbnQqIHBpcGVsaW5lKQordm9p
ZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjcmVhdGVWaWRlb1NpbmsoR3N0RWxl
bWVudCogcGlwZWxpbmUpCiB7CiAgICAgaWYgKCFpbml0aWFsaXplR1N0cmVhbWVyKCkpCi0gICAg
ICAgIHJldHVybiAwOworICAgICAgICByZXR1cm47CiAKICNpZiBVU0UoTkFUSVZFX0ZVTExTQ1JF
RU5fVklERU8pCiAgICAgbV9nc3RHV29ybGQgPSBHU3RyZWFtZXJHV29ybGQ6OmNyZWF0ZUdXb3Js
ZChwaXBlbGluZSk7CkBAIC01MzgsMTQgKzUzNiwxNCBAQCBHc3RFbGVtZW50KiBNZWRpYVBsYXll
clByaXZhdGVHU3RyZWFtZXJCYXNlOjpjcmVhdGVWaWRlb1NpbmsoR3N0RWxlbWVudCogcGlwZWxp
bgogCiAgICAgbV9yZXBhaW50SGFuZGxlciA9IGdfc2lnbmFsX2Nvbm5lY3QobV93ZWJraXRWaWRl
b1NpbmsuZ2V0KCksICJyZXBhaW50LXJlcXVlc3RlZCIsIEdfQ0FMTEJBQ0sobWVkaWFQbGF5ZXJQ
cml2YXRlUmVwYWludENhbGxiYWNrKSwgdGhpcyk7CiAKKyAgICBtX3ZpZGVvU2lua0JpbiA9IGdz
dF9iaW5fbmV3KDApOworCiAjaWYgVVNFKE5BVElWRV9GVUxMU0NSRUVOX1ZJREVPKQogICAgIC8v
IEJ1aWxkIGEgbmV3IHZpZGVvIHNpbmsgY29uc2lzdGluZyBvZiBhIGJpbiBjb250YWluaW5nIGEg
dGVlCiAgICAgLy8gKG1lYW50IHRvIGRpc3RyaWJ1dGUgZGF0YSB0byBtdWx0aXBsZSB2aWRlbyBz
aW5rcykgYW5kIG91cgogICAgIC8vIGludGVybmFsIHZpZGVvIHNpbmsuIEZvciBmdWxsc2NyZWVu
IHdlIGNyZWF0ZSBhbiBhdXRvdmlkZW9zaW5rCiAgICAgLy8gYW5kIGluaXRpYWxseSBibG9jayB0
aGUgZGF0YSBmbG93IHRvd2FyZHMgaXQgYW5kIGNvbmZpZ3VyZSBpdAogCi0gICAgbV92aWRlb1Np
bmtCaW4gPSBnc3RfYmluX25ldygidmlkZW8tc2luayIpOwotCiAgICAgR3N0RWxlbWVudCogdmlk
ZW9UZWUgPSBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoInRlZSIsICJ2aWRlb1RlZSIpOwogICAg
IEdzdEVsZW1lbnQqIHF1ZXVlID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJxdWV1ZSIsIDAp
OwogCkBAIC01ODEsOSArNTc5LDcgQEAgR3N0RWxlbWVudCogTWVkaWFQbGF5ZXJQcml2YXRlR1N0
cmVhbWVyQmFzZTo6Y3JlYXRlVmlkZW9TaW5rKEdzdEVsZW1lbnQqIHBpcGVsaW4KIAogICAgICAg
ICAgICAgaWYgKGdfb2JqZWN0X2NsYXNzX2ZpbmRfcHJvcGVydHkoR19PQkpFQ1RfR0VUX0NMQVNT
KG1fZnBzU2luayksICJ2aWRlby1zaW5rIikpIHsKICAgICAgICAgICAgICAgICBnX29iamVjdF9z
ZXQobV9mcHNTaW5rLCAidmlkZW8tc2luayIsIG1fd2Via2l0VmlkZW9TaW5rLmdldCgpLCBOVUxM
KTsKLSNpZiBVU0UoTkFUSVZFX0ZVTExTQ1JFRU5fVklERU8pCiAgICAgICAgICAgICAgICAgZ3N0
X2Jpbl9hZGQoR1NUX0JJTihtX3ZpZGVvU2lua0Jpbi5nZXQoKSksIG1fZnBzU2luayk7Ci0jZW5k
aWYKICAgICAgICAgICAgICAgICBhY3R1YWxWaWRlb1NpbmsgPSBtX2Zwc1Npbms7CiAgICAgICAg
ICAgICB9IGVsc2UKICAgICAgICAgICAgICAgICBtX2Zwc1NpbmsgPSAwOwpAQCAtNTkyLDI3ICs1
ODgsMjQgQEAgR3N0RWxlbWVudCogTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6Y3Jl
YXRlVmlkZW9TaW5rKEdzdEVsZW1lbnQqIHBpcGVsaW4KICAgICB9CiAKICAgICBpZiAoIW1fZnBz
U2luaykgewotI2lmIFVTRShOQVRJVkVfRlVMTFNDUkVFTl9WSURFTykKICAgICAgICAgZ3N0X2Jp
bl9hZGQoR1NUX0JJTihtX3ZpZGVvU2lua0Jpbi5nZXQoKSksIG1fd2Via2l0VmlkZW9TaW5rLmdl
dCgpKTsKLSNlbmRpZgogICAgICAgICBhY3R1YWxWaWRlb1NpbmsgPSBtX3dlYmtpdFZpZGVvU2lu
ay5nZXQoKTsKICAgICB9CiAKICAgICBBU1NFUlQoYWN0dWFsVmlkZW9TaW5rKTsKIAorICAgIEdz
dEVsZW1lbnQqIGZpcnN0Q2hpbGQgPSAwOwogI2lmIFVTRShOQVRJVkVfRlVMTFNDUkVFTl9WSURF
TykKICAgICAvLyBGYXN0ZXIgZWxlbWVudHMgbGlua2luZy4KICAgICBnc3RfZWxlbWVudF9saW5r
X3BhZHNfZnVsbChxdWV1ZSwgInNyYyIsIGFjdHVhbFZpZGVvU2luaywgInNpbmsiLCBHU1RfUEFE
X0xJTktfQ0hFQ0tfTk9USElORyk7CiAKLSAgICAvLyBBZGQgYSBnaG9zdHBhZCB0byB0aGUgYmlu
IHNvIGl0IGNhbiBwcm94eSB0byB0ZWUuCi0gICAgR1JlZlB0cjxHc3RQYWQ+IHBhZCA9IGFkb3B0
R1JlZihnc3RfZWxlbWVudF9nZXRfc3RhdGljX3BhZCh2aWRlb1RlZSwgInNpbmsiKSk7Ci0gICAg
Z3N0X2VsZW1lbnRfYWRkX3BhZChtX3ZpZGVvU2lua0Jpbi5nZXQoKSwgZ3N0X2dob3N0X3BhZF9u
ZXcoInNpbmsiLCBwYWQuZ2V0KCkpKTsKLQotICAgIC8vIFNldCB0aGUgYmluIGFzIHZpZGVvIHNp
bmsgb2YgcGxheWJpbi4KLSAgICByZXR1cm4gbV92aWRlb1NpbmtCaW4uZ2V0KCk7CisgICAgZmly
c3RDaGlsZCA9IHZpZGVvVGVlOwogI2Vsc2UKLSAgICByZXR1cm4gYWN0dWFsVmlkZW9TaW5rOwor
ICAgIGZpcnN0Q2hpbGQgPSBhY3R1YWxWaWRlb1Npbms7CiAjZW5kaWYKKyAgICAvLyBBZGQgYSBn
aG9zdHBhZCB0byB0aGUgYmluIHNvIGl0IGNhbiBwcm94eSB0byB0ZWUuCisgICAgR1JlZlB0cjxH
c3RQYWQ+IHBhZCA9IGFkb3B0R1JlZihnc3RfZWxlbWVudF9nZXRfc3RhdGljX3BhZChmaXJzdENo
aWxkLCAic2luayIpKTsKKyAgICBnc3RfZWxlbWVudF9hZGRfcGFkKG1fdmlkZW9TaW5rQmluLmdl
dCgpLCBnc3RfZ2hvc3RfcGFkX25ldygic2luayIsIHBhZC5nZXQoKSkpOwogfQogCiB2b2lkIE1l
ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OnNldFN0cmVhbVZvbHVtZUVsZW1lbnQoR3N0
U3RyZWFtVm9sdW1lKiB2b2x1bWUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5oIGIv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp
dmF0ZUdTdHJlYW1lckJhc2UuaAppbmRleCAwMDhiOTIxLi5kOGQ3YjRhIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2
YXRlR1N0cmVhbWVyQmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmgKQEAgLTExMSw3ICsx
MTEsNyBAQCBwdWJsaWM6CiAKIHByb3RlY3RlZDoKICAgICBNZWRpYVBsYXllclByaXZhdGVHU3Ry
ZWFtZXJCYXNlKE1lZGlhUGxheWVyKik7Ci0gICAgR3N0RWxlbWVudCogY3JlYXRlVmlkZW9TaW5r
KEdzdEVsZW1lbnQqIHBpcGVsaW5lKTsKKyAgICB2b2lkIGNyZWF0ZVZpZGVvU2luayhHc3RFbGVt
ZW50KiBwaXBlbGluZSk7CiAgICAgdm9pZCBzZXRTdHJlYW1Wb2x1bWVFbGVtZW50KEdzdFN0cmVh
bVZvbHVtZSopOwogICAgIHZpcnR1YWwgR3N0RWxlbWVudCogYXVkaW9TaW5rKCkgY29uc3QgeyBy
ZXR1cm4gMDsgfQogICAgIEdSZWZQdHI8R3N0Q2Fwcz4gY3VycmVudFZpZGVvU2lua0NhcHMoKSBj
b25zdDsKLS0gCjEuOC40LnJjMw==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215374</attachid>
            <date>2013-10-29 03:23:25 -0700</date>
            <delta_ts>2013-10-29 07:15:42 -0700</delta_ts>
            <desc>[player] make video-sink a bin</desc>
            <filename>player-make-video-sink-a-bin.patch</filename>
            <type>text/plain</type>
            <size>7463</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSA1ODgwODA2ZDNkOTUwMjgxYTg4MGNkYjhiOTcxM2RlODlkN2M5MGMwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBGcmksIDExIE9jdCAyMDEzIDE5OjE0OjE0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
W3BsYXllcl0gbWFrZSB2aWRlby1zaW5rIGEgYmluCgotLS0KIC4uLi9nc3RyZWFtZXIvTWVkaWFQ
bGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCAgICAgIHwgIDQgKy0KIC4uLi9nc3RyZWFtZXIvTWVk
aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAgIHwgNDYgKysrKysrKysrLS0tLS0tLS0t
LS0tLQogLi4uL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmggICAg
fCAgMiArLQogMyBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAzMCBkZWxldGlvbnMo
LSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt
ZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmlu
ZGV4IDIwYmFiNWUuLjFkMzA4MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBi
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclBy
aXZhdGVHU3RyZWFtZXIuY3BwCkBAIC0xODI2LDkgKzE4MjYsOSBAQCB2b2lkIE1lZGlhUGxheWVy
UHJpdmF0ZUdTdHJlYW1lcjo6Y3JlYXRlR1NUUGxheUJpbigpCiAgICAgfQogI2VuZGlmCiAKLSAg
ICBHc3RFbGVtZW50KiB2aWRlb0VsZW1lbnQgPSBjcmVhdGVWaWRlb1NpbmsobV9wbGF5QmluLmdl
dCgpKTsKKyAgICBjcmVhdGVWaWRlb1NpbmsobV9wbGF5QmluLmdldCgpKTsKIAotICAgIGdfb2Jq
ZWN0X3NldChtX3BsYXlCaW4uZ2V0KCksICJ2aWRlby1zaW5rIiwgdmlkZW9FbGVtZW50LCBOVUxM
KTsKKyAgICBnX29iamVjdF9zZXQobV9wbGF5QmluLmdldCgpLCAidmlkZW8tc2luayIsIG1fdmlk
ZW9TaW5rQmluLmdldCgpLCBOVUxMKTsKIAogICAgIEdSZWZQdHI8R3N0UGFkPiB2aWRlb1NpbmtQ
YWQgPSBhZG9wdEdSZWYoZ3N0X2VsZW1lbnRfZ2V0X3N0YXRpY19wYWQobV93ZWJraXRWaWRlb1Np
bmsuZ2V0KCksICJzaW5rIikpOwogICAgIGlmICh2aWRlb1NpbmtQYWQpCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2
YXRlR1N0cmVhbWVyQmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n
c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKaW5kZXggZmUxNzg0
ZS4uODM2NGE1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv
Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH
U3RyZWFtZXJCYXNlLmNwcApAQCAtNTIwLDEyICs1MjAsMTAgQEAgR1JlZlB0cjxHc3RDYXBzPiBN
ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjdXJyZW50VmlkZW9TaW5rQ2FwcygpIGNv
bnN0CiAgICAgcmV0dXJuIGN1cnJlbnRDYXBzOwogfQogCi0vLyBUaGlzIGZ1bmN0aW9uIGNyZWF0
ZXMgYW5kIGluaXRpYWxpemVzIHNvbWUgaW50ZXJuYWwgdmFyaWFibGVzLCBhbmQgcmV0dXJucyBh
Ci0vLyBwb2ludGVyIHRvIHRoZSBlbGVtZW50IHRoYXQgc2hvdWxkIHJlY2VpdmUgdGhlIGRhdGEg
ZmxvdyBmaXJzdAotR3N0RWxlbWVudCogTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6
Y3JlYXRlVmlkZW9TaW5rKEdzdEVsZW1lbnQqIHBpcGVsaW5lKQordm9pZCBNZWRpYVBsYXllclBy
aXZhdGVHU3RyZWFtZXJCYXNlOjpjcmVhdGVWaWRlb1NpbmsoR3N0RWxlbWVudCogcGlwZWxpbmUp
CiB7CiAgICAgaWYgKCFpbml0aWFsaXplR1N0cmVhbWVyKCkpCi0gICAgICAgIHJldHVybiAwOwor
ICAgICAgICByZXR1cm47CiAKICNpZiBVU0UoTkFUSVZFX0ZVTExTQ1JFRU5fVklERU8pCiAgICAg
bV9nc3RHV29ybGQgPSBHU3RyZWFtZXJHV29ybGQ6OmNyZWF0ZUdXb3JsZChwaXBlbGluZSk7CkBA
IC01MzcsMjkgKzUzNSwyOSBAQCBHc3RFbGVtZW50KiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt
ZXJCYXNlOjpjcmVhdGVWaWRlb1NpbmsoR3N0RWxlbWVudCogcGlwZWxpbgogCiAgICAgbV9yZXBh
aW50SGFuZGxlciA9IGdfc2lnbmFsX2Nvbm5lY3QobV93ZWJraXRWaWRlb1NpbmsuZ2V0KCksICJy
ZXBhaW50LXJlcXVlc3RlZCIsIEdfQ0FMTEJBQ0sobWVkaWFQbGF5ZXJQcml2YXRlUmVwYWludENh
bGxiYWNrKSwgdGhpcyk7CiAKKyAgICBtX3ZpZGVvU2lua0JpbiA9IGdzdF9iaW5fbmV3KG51bGxw
dHIpOworCiAjaWYgVVNFKE5BVElWRV9GVUxMU0NSRUVOX1ZJREVPKQogICAgIC8vIEJ1aWxkIGEg
bmV3IHZpZGVvIHNpbmsgY29uc2lzdGluZyBvZiBhIGJpbiBjb250YWluaW5nIGEgdGVlCiAgICAg
Ly8gKG1lYW50IHRvIGRpc3RyaWJ1dGUgZGF0YSB0byBtdWx0aXBsZSB2aWRlbyBzaW5rcykgYW5k
IG91cgogICAgIC8vIGludGVybmFsIHZpZGVvIHNpbmsuIEZvciBmdWxsc2NyZWVuIHdlIGNyZWF0
ZSBhbiBhdXRvdmlkZW9zaW5rCiAgICAgLy8gYW5kIGluaXRpYWxseSBibG9jayB0aGUgZGF0YSBm
bG93IHRvd2FyZHMgaXQgYW5kIGNvbmZpZ3VyZSBpdAogCi0gICAgbV92aWRlb1NpbmtCaW4gPSBn
c3RfYmluX25ldygidmlkZW8tc2luayIpOwotCiAgICAgR3N0RWxlbWVudCogdmlkZW9UZWUgPSBn
c3RfZWxlbWVudF9mYWN0b3J5X21ha2UoInRlZSIsICJ2aWRlb1RlZSIpOwotICAgIEdzdEVsZW1l
bnQqIHF1ZXVlID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJxdWV1ZSIsIDApOworICAgIEdz
dEVsZW1lbnQqIHF1ZXVlID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJxdWV1ZSIsIG51bGxw
dHIpOwogCiAjaWZkZWYgR1NUX0FQSV9WRVJTSU9OXzEKICAgICBHUmVmUHRyPEdzdFBhZD4gc2lu
a1BhZCA9IGFkb3B0R1JlZihnc3RfZWxlbWVudF9nZXRfc3RhdGljX3BhZCh2aWRlb1RlZSwgInNp
bmsiKSk7CiAgICAgR1NUX09CSkVDVF9GTEFHX1NFVChHU1RfT0JKRUNUKHNpbmtQYWQuZ2V0KCkp
LCBHU1RfUEFEX0ZMQUdfUFJPWFlfQUxMT0NBVElPTik7CiAjZW5kaWYKIAotICAgIGdzdF9iaW5f
YWRkX21hbnkoR1NUX0JJTihtX3ZpZGVvU2lua0Jpbi5nZXQoKSksIHZpZGVvVGVlLCBxdWV1ZSwg
TlVMTCk7CisgICAgZ3N0X2Jpbl9hZGRfbWFueShHU1RfQklOKG1fdmlkZW9TaW5rQmluLmdldCgp
KSwgdmlkZW9UZWUsIHF1ZXVlLCBudWxscHRyKTsKIAogICAgIC8vIExpbmsgYSBuZXcgc3JjIHBh
ZCBmcm9tIHRlZSB0byBxdWV1ZTEuCi0gICAgZ3N0X2VsZW1lbnRfbGlua19wYWRzX2Z1bGwodmlk
ZW9UZWUsIDAsIHF1ZXVlLCAic2luayIsIEdTVF9QQURfTElOS19DSEVDS19OT1RISU5HKTsKKyAg
ICBnc3RfZWxlbWVudF9saW5rX3BhZHNfZnVsbCh2aWRlb1RlZSwgbnVsbHB0ciwgcXVldWUsICJz
aW5rIiwgR1NUX1BBRF9MSU5LX0NIRUNLX05PVEhJTkcpOwogI2VuZGlmCiAKLSAgICBHc3RFbGVt
ZW50KiBhY3R1YWxWaWRlb1NpbmsgPSAwOworICAgIEdzdEVsZW1lbnQqIGFjdHVhbFZpZGVvU2lu
ayA9IG51bGxwdHI7CiAgICAgbV9mcHNTaW5rID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJm
cHNkaXNwbGF5c2luayIsICJzaW5rIik7CiAgICAgaWYgKG1fZnBzU2luaykgewogICAgICAgICAv
LyBUaGUgdmVyYm9zZSBwcm9wZXJ0eSBoYXMgYmVlbiBhZGRlZCBpbiAtYmFkIDAuMTAuMjIuIE1h
a2luZwpAQCAtNTY3LDUxICs1NjUsNDUgQEAgR3N0RWxlbWVudCogTWVkaWFQbGF5ZXJQcml2YXRl
R1N0cmVhbWVyQmFzZTo6Y3JlYXRlVmlkZW9TaW5rKEdzdEVsZW1lbnQqIHBpcGVsaW4KICAgICAg
ICAgLy8gZnBzZGlwbGF5c2luayB0byBzcGl0IGRhdGEgb24gc3Rkb3V0LgogICAgICAgICBHc3RF
bGVtZW50RmFjdG9yeSogZmFjdG9yeSA9IEdTVF9FTEVNRU5UX0ZBQ1RPUlkoR1NUX0VMRU1FTlRf
R0VUX0NMQVNTKG1fZnBzU2luayktPmVsZW1lbnRmYWN0b3J5KTsKICAgICAgICAgaWYgKGdzdF9w
bHVnaW5fZmVhdHVyZV9jaGVja192ZXJzaW9uKEdTVF9QTFVHSU5fRkVBVFVSRShmYWN0b3J5KSwg
MCwgMTAsIDIyKSkgewotICAgICAgICAgICAgZ19vYmplY3Rfc2V0KG1fZnBzU2luaywgInNpbGVu
dCIsIFRSVUUgLCBOVUxMKTsKKyAgICAgICAgICAgIGdfb2JqZWN0X3NldChtX2Zwc1NpbmssICJz
aWxlbnQiLCBUUlVFICwgbnVsbHB0cik7CiAKICAgICAgICAgICAgIC8vIFR1cm4gb2ZmIHRleHQg
b3ZlcmxheSB1bmxlc3MgbG9nZ2luZyBpcyBlbmFibGVkLgogI2lmIExPR19ESVNBQkxFRAotICAg
ICAgICAgICAgZ19vYmplY3Rfc2V0KG1fZnBzU2luaywgInRleHQtb3ZlcmxheSIsIEZBTFNFICwg
TlVMTCk7CisgICAgICAgICAgICBnX29iamVjdF9zZXQobV9mcHNTaW5rLCAidGV4dC1vdmVybGF5
IiwgRkFMU0UgLCBudWxscHRyKTsKICNlbHNlCiAgICAgICAgICAgICBXVEZMb2dDaGFubmVsKiBj
aGFubmVsID0gbG9nQ2hhbm5lbEJ5TmFtZSgiTWVkaWEiKTsKICAgICAgICAgICAgIGlmIChjaGFu
bmVsLT5zdGF0ZSAhPSBXVEZMb2dDaGFubmVsT24pCi0gICAgICAgICAgICAgICAgZ19vYmplY3Rf
c2V0KG1fZnBzU2luaywgInRleHQtb3ZlcmxheSIsIEZBTFNFICwgTlVMTCk7CisgICAgICAgICAg
ICAgICAgZ19vYmplY3Rfc2V0KG1fZnBzU2luaywgInRleHQtb3ZlcmxheSIsIEZBTFNFICwgbnVs
bHB0cik7CiAjZW5kaWYgLy8gTE9HX0RJU0FCTEVECiAKICAgICAgICAgICAgIGlmIChnX29iamVj
dF9jbGFzc19maW5kX3Byb3BlcnR5KEdfT0JKRUNUX0dFVF9DTEFTUyhtX2Zwc1NpbmspLCAidmlk
ZW8tc2luayIpKSB7Ci0gICAgICAgICAgICAgICAgZ19vYmplY3Rfc2V0KG1fZnBzU2luaywgInZp
ZGVvLXNpbmsiLCBtX3dlYmtpdFZpZGVvU2luay5nZXQoKSwgTlVMTCk7Ci0jaWYgVVNFKE5BVElW
RV9GVUxMU0NSRUVOX1ZJREVPKQorICAgICAgICAgICAgICAgIGdfb2JqZWN0X3NldChtX2Zwc1Np
bmssICJ2aWRlby1zaW5rIiwgbV93ZWJraXRWaWRlb1NpbmsuZ2V0KCksIG51bGxwdHIpOwogICAg
ICAgICAgICAgICAgIGdzdF9iaW5fYWRkKEdTVF9CSU4obV92aWRlb1NpbmtCaW4uZ2V0KCkpLCBt
X2Zwc1NpbmspOwotI2VuZGlmCiAgICAgICAgICAgICAgICAgYWN0dWFsVmlkZW9TaW5rID0gbV9m
cHNTaW5rOwogICAgICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICAgICAgbV9mcHNTaW5rID0g
MDsKKyAgICAgICAgICAgICAgICBtX2Zwc1NpbmsgPSBudWxscHRyOwogICAgICAgICB9IGVsc2UK
LSAgICAgICAgICAgIG1fZnBzU2luayA9IDA7CisgICAgICAgICAgICBtX2Zwc1NpbmsgPSBudWxs
cHRyOwogICAgIH0KIAogICAgIGlmICghbV9mcHNTaW5rKSB7Ci0jaWYgVVNFKE5BVElWRV9GVUxM
U0NSRUVOX1ZJREVPKQogICAgICAgICBnc3RfYmluX2FkZChHU1RfQklOKG1fdmlkZW9TaW5rQmlu
LmdldCgpKSwgbV93ZWJraXRWaWRlb1NpbmsuZ2V0KCkpOwotI2VuZGlmCiAgICAgICAgIGFjdHVh
bFZpZGVvU2luayA9IG1fd2Via2l0VmlkZW9TaW5rLmdldCgpOwogICAgIH0KIAogICAgIEFTU0VS
VChhY3R1YWxWaWRlb1NpbmspOwogCisgICAgR3N0RWxlbWVudCogZmlyc3RDaGlsZCA9IG51bGxw
dHI7CiAjaWYgVVNFKE5BVElWRV9GVUxMU0NSRUVOX1ZJREVPKQogICAgIC8vIEZhc3RlciBlbGVt
ZW50cyBsaW5raW5nLgogICAgIGdzdF9lbGVtZW50X2xpbmtfcGFkc19mdWxsKHF1ZXVlLCAic3Jj
IiwgYWN0dWFsVmlkZW9TaW5rLCAic2luayIsIEdTVF9QQURfTElOS19DSEVDS19OT1RISU5HKTsK
IAotICAgIC8vIEFkZCBhIGdob3N0cGFkIHRvIHRoZSBiaW4gc28gaXQgY2FuIHByb3h5IHRvIHRl
ZS4KLSAgICBHUmVmUHRyPEdzdFBhZD4gcGFkID0gYWRvcHRHUmVmKGdzdF9lbGVtZW50X2dldF9z
dGF0aWNfcGFkKHZpZGVvVGVlLCAic2luayIpKTsKLSAgICBnc3RfZWxlbWVudF9hZGRfcGFkKG1f
dmlkZW9TaW5rQmluLmdldCgpLCBnc3RfZ2hvc3RfcGFkX25ldygic2luayIsIHBhZC5nZXQoKSkp
OwotCi0gICAgLy8gU2V0IHRoZSBiaW4gYXMgdmlkZW8gc2luayBvZiBwbGF5YmluLgotICAgIHJl
dHVybiBtX3ZpZGVvU2lua0Jpbi5nZXQoKTsKKyAgICBmaXJzdENoaWxkID0gdmlkZW9UZWU7CiAj
ZWxzZQotICAgIHJldHVybiBhY3R1YWxWaWRlb1Npbms7CisgICAgZmlyc3RDaGlsZCA9IGFjdHVh
bFZpZGVvU2luazsKICNlbmRpZgorICAgIEdSZWZQdHI8R3N0UGFkPiBwYWQgPSBhZG9wdEdSZWYo
Z3N0X2VsZW1lbnRfZ2V0X3N0YXRpY19wYWQoZmlyc3RDaGlsZCwgInNpbmsiKSk7CisgICAgZ3N0
X2VsZW1lbnRfYWRkX3BhZChtX3ZpZGVvU2lua0Jpbi5nZXQoKSwgZ3N0X2dob3N0X3BhZF9uZXco
InNpbmsiLCBwYWQuZ2V0KCkpKTsKIH0KIAogdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt
ZXJCYXNlOjpzZXRTdHJlYW1Wb2x1bWVFbGVtZW50KEdzdFN0cmVhbVZvbHVtZSogdm9sdW1lKQpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01l
ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmgKaW5k
ZXggMDA4YjkyMS4uZDhkN2I0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
Z3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuaAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ
cml2YXRlR1N0cmVhbWVyQmFzZS5oCkBAIC0xMTEsNyArMTExLDcgQEAgcHVibGljOgogCiBwcm90
ZWN0ZWQ6CiAgICAgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZShNZWRpYVBsYXllciop
OwotICAgIEdzdEVsZW1lbnQqIGNyZWF0ZVZpZGVvU2luayhHc3RFbGVtZW50KiBwaXBlbGluZSk7
CisgICAgdm9pZCBjcmVhdGVWaWRlb1NpbmsoR3N0RWxlbWVudCogcGlwZWxpbmUpOwogICAgIHZv
aWQgc2V0U3RyZWFtVm9sdW1lRWxlbWVudChHc3RTdHJlYW1Wb2x1bWUqKTsKICAgICB2aXJ0dWFs
IEdzdEVsZW1lbnQqIGF1ZGlvU2luaygpIGNvbnN0IHsgcmV0dXJuIDA7IH0KICAgICBHUmVmUHRy
PEdzdENhcHM+IGN1cnJlbnRWaWRlb1NpbmtDYXBzKCkgY29uc3Q7Ci0tIAoxLjguNC5yYzM=
</data>
<flag name="review"
          id="238080"
          type_id="1"
          status="-"
          setter="gustavo"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215386</attachid>
            <date>2013-10-29 07:15:42 -0700</date>
            <delta_ts>2013-10-29 13:08:33 -0700</delta_ts>
            <desc>[player] make video-sink a bin</desc>
            <filename>player-make-video-sink-a-bin.patch</filename>
            <type>text/plain</type>
            <size>8529</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSBjYmFlYTcxMDVhODM4ODBjY2MzYmMxMzAzZmI4ZDEyNGYzZDY0NjFjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBGcmksIDExIE9jdCAyMDEzIDE5OjE0OjE0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
W3BsYXllcl0gbWFrZSB2aWRlby1zaW5rIGEgYmluCgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTUgKysrKysrCiAuLi4vZ3N0cmVhbWVy
L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICAgICB8ICA0ICstCiAuLi4vZ3N0cmVh
bWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwICB8IDU0ICsrKysrKysrKy0t
LS0tLS0tLS0tLS0KIC4uLi9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFz
ZS5oICAgIHwgIDIgKy0KIDQgZmlsZXMgY2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwgMzUgZGVs
ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl
L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGJmOTViNzAuLjU1ZjE2YTAgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg
LTEsMyArMSwxOCBAQAorMjAxMy0xMC0yOSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln
YWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gU3RvcmUgdmlkZW8tc2luayBpbiBhIGJp
bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyODMx
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIHRo
ZSB1cGNvbWluZyBtZWRpYXN0cmVhbSBwbGF5YmFjayBzdXBwb3J0IHRoZSBwbGF5ZXIgd2lsbAor
ICAgICAgICBoYW5kbGUgYSBub24tcGxheWJpbi1iYXNlZCBwaXBlbGluZSB0aGF0IHdpbGwgcmVx
dWlyZSBhIHNsaWdodGx5CisgICAgICAgIGRpZmZlcmVudCB2aWRlbyByZW5kZXJpbmcgY2hhaW4u
IFRoaXMgcGF0Y2ggZ2VuZXJhbGl6ZXMgdGhlCisgICAgICAgIGVuY2Fwc3VsYXRpb24gb2YgdGhl
IHZpZGVvIHNpbmsgaW4gYSBiaW4sIGp1c3QgbGlrZSB0aGUgYXVkaW8gc2luaworICAgICAgICBj
YXNlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHku
CisKIDIwMTMtMTAtMjkgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgog
CiAgICAgICAgIFJlLWVuYWJsZSBzaW1wbGUgbGluZSBsYXlvdXQgZm9yIEVGTApkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVy
UHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n
c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCAyMGJhYjVlLi5l
OWE1ZTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry
ZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy
LmNwcApAQCAtMTgyNiw5ICsxODI2LDkgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt
ZXI6OmNyZWF0ZUdTVFBsYXlCaW4oKQogICAgIH0KICNlbmRpZgogCi0gICAgR3N0RWxlbWVudCog
dmlkZW9FbGVtZW50ID0gY3JlYXRlVmlkZW9TaW5rKG1fcGxheUJpbi5nZXQoKSk7CisgICAgY3Jl
YXRlVmlkZW9TaW5rKG1fcGxheUJpbi5nZXQoKSk7CiAKLSAgICBnX29iamVjdF9zZXQobV9wbGF5
QmluLmdldCgpLCAidmlkZW8tc2luayIsIHZpZGVvRWxlbWVudCwgTlVMTCk7CisgICAgZ19vYmpl
Y3Rfc2V0KG1fcGxheUJpbi5nZXQoKSwgInZpZGVvLXNpbmsiLCBtX3ZpZGVvU2lua0Jpbi5nZXQo
KSwgbnVsbHB0cik7CiAKICAgICBHUmVmUHRyPEdzdFBhZD4gdmlkZW9TaW5rUGFkID0gYWRvcHRH
UmVmKGdzdF9lbGVtZW50X2dldF9zdGF0aWNfcGFkKG1fd2Via2l0VmlkZW9TaW5rLmdldCgpLCAi
c2luayIpKTsKICAgICBpZiAodmlkZW9TaW5rUGFkKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l
ckJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01l
ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCmluZGV4IGZlMTc4NGUuLjM2YjI3MDYg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N
ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFz
ZS5jcHAKQEAgLTUyMCwxMiArNTIwLDEwIEBAIEdSZWZQdHI8R3N0Q2Fwcz4gTWVkaWFQbGF5ZXJQ
cml2YXRlR1N0cmVhbWVyQmFzZTo6Y3VycmVudFZpZGVvU2lua0NhcHMoKSBjb25zdAogICAgIHJl
dHVybiBjdXJyZW50Q2FwczsKIH0KIAotLy8gVGhpcyBmdW5jdGlvbiBjcmVhdGVzIGFuZCBpbml0
aWFsaXplcyBzb21lIGludGVybmFsIHZhcmlhYmxlcywgYW5kIHJldHVybnMgYQotLy8gcG9pbnRl
ciB0byB0aGUgZWxlbWVudCB0aGF0IHNob3VsZCByZWNlaXZlIHRoZSBkYXRhIGZsb3cgZmlyc3QK
LUdzdEVsZW1lbnQqIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmNyZWF0ZVZpZGVv
U2luayhHc3RFbGVtZW50KiBwaXBlbGluZSkKK3ZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh
bWVyQmFzZTo6Y3JlYXRlVmlkZW9TaW5rKEdzdEVsZW1lbnQqIHBpcGVsaW5lKQogewogICAgIGlm
ICghaW5pdGlhbGl6ZUdTdHJlYW1lcigpKQotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0
dXJuOwogCiAjaWYgVVNFKE5BVElWRV9GVUxMU0NSRUVOX1ZJREVPKQogICAgIG1fZ3N0R1dvcmxk
ID0gR1N0cmVhbWVyR1dvcmxkOjpjcmVhdGVHV29ybGQocGlwZWxpbmUpOwpAQCAtNTM3LDI5ICs1
MzUsMjkgQEAgR3N0RWxlbWVudCogTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6Y3Jl
YXRlVmlkZW9TaW5rKEdzdEVsZW1lbnQqIHBpcGVsaW4KIAogICAgIG1fcmVwYWludEhhbmRsZXIg
PSBnX3NpZ25hbF9jb25uZWN0KG1fd2Via2l0VmlkZW9TaW5rLmdldCgpLCAicmVwYWludC1yZXF1
ZXN0ZWQiLCBHX0NBTExCQUNLKG1lZGlhUGxheWVyUHJpdmF0ZVJlcGFpbnRDYWxsYmFjayksIHRo
aXMpOwogCisgICAgbV92aWRlb1NpbmtCaW4gPSBnc3RfYmluX25ldyhudWxscHRyKTsKKwogI2lm
IFVTRShOQVRJVkVfRlVMTFNDUkVFTl9WSURFTykKICAgICAvLyBCdWlsZCBhIG5ldyB2aWRlbyBz
aW5rIGNvbnNpc3Rpbmcgb2YgYSBiaW4gY29udGFpbmluZyBhIHRlZQogICAgIC8vIChtZWFudCB0
byBkaXN0cmlidXRlIGRhdGEgdG8gbXVsdGlwbGUgdmlkZW8gc2lua3MpIGFuZCBvdXIKICAgICAv
LyBpbnRlcm5hbCB2aWRlbyBzaW5rLiBGb3IgZnVsbHNjcmVlbiB3ZSBjcmVhdGUgYW4gYXV0b3Zp
ZGVvc2luawogICAgIC8vIGFuZCBpbml0aWFsbHkgYmxvY2sgdGhlIGRhdGEgZmxvdyB0b3dhcmRz
IGl0IGFuZCBjb25maWd1cmUgaXQKIAotICAgIG1fdmlkZW9TaW5rQmluID0gZ3N0X2Jpbl9uZXco
InZpZGVvLXNpbmsiKTsKLQogICAgIEdzdEVsZW1lbnQqIHZpZGVvVGVlID0gZ3N0X2VsZW1lbnRf
ZmFjdG9yeV9tYWtlKCJ0ZWUiLCAidmlkZW9UZWUiKTsKLSAgICBHc3RFbGVtZW50KiBxdWV1ZSA9
IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgicXVldWUiLCAwKTsKKyAgICBHc3RFbGVtZW50KiBx
dWV1ZSA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgicXVldWUiLCBudWxscHRyKTsKIAogI2lm
ZGVmIEdTVF9BUElfVkVSU0lPTl8xCiAgICAgR1JlZlB0cjxHc3RQYWQ+IHNpbmtQYWQgPSBhZG9w
dEdSZWYoZ3N0X2VsZW1lbnRfZ2V0X3N0YXRpY19wYWQodmlkZW9UZWUsICJzaW5rIikpOwogICAg
IEdTVF9PQkpFQ1RfRkxBR19TRVQoR1NUX09CSkVDVChzaW5rUGFkLmdldCgpKSwgR1NUX1BBRF9G
TEFHX1BST1hZX0FMTE9DQVRJT04pOwogI2VuZGlmCiAKLSAgICBnc3RfYmluX2FkZF9tYW55KEdT
VF9CSU4obV92aWRlb1NpbmtCaW4uZ2V0KCkpLCB2aWRlb1RlZSwgcXVldWUsIE5VTEwpOworICAg
IGdzdF9iaW5fYWRkX21hbnkoR1NUX0JJTihtX3ZpZGVvU2lua0Jpbi5nZXQoKSksIHZpZGVvVGVl
LCBxdWV1ZSwgbnVsbHB0cik7CiAKICAgICAvLyBMaW5rIGEgbmV3IHNyYyBwYWQgZnJvbSB0ZWUg
dG8gcXVldWUxLgotICAgIGdzdF9lbGVtZW50X2xpbmtfcGFkc19mdWxsKHZpZGVvVGVlLCAwLCBx
dWV1ZSwgInNpbmsiLCBHU1RfUEFEX0xJTktfQ0hFQ0tfTk9USElORyk7CisgICAgZ3N0X2VsZW1l
bnRfbGlua19wYWRzX2Z1bGwodmlkZW9UZWUsIG51bGxwdHIsIHF1ZXVlLCAic2luayIsIEdTVF9Q
QURfTElOS19DSEVDS19OT1RISU5HKTsKICNlbmRpZgogCi0gICAgR3N0RWxlbWVudCogYWN0dWFs
VmlkZW9TaW5rID0gMDsKKyAgICBHc3RFbGVtZW50KiB2aWRlb1NpbmsgPSBudWxscHRyOwogICAg
IG1fZnBzU2luayA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgiZnBzZGlzcGxheXNpbmsiLCAi
c2luayIpOwogICAgIGlmIChtX2Zwc1NpbmspIHsKICAgICAgICAgLy8gVGhlIHZlcmJvc2UgcHJv
cGVydHkgaGFzIGJlZW4gYWRkZWQgaW4gLWJhZCAwLjEwLjIyLiBNYWtpbmcKQEAgLTU2Nyw1MSAr
NTY1LDQzIEBAIEdzdEVsZW1lbnQqIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmNy
ZWF0ZVZpZGVvU2luayhHc3RFbGVtZW50KiBwaXBlbGluCiAgICAgICAgIC8vIGZwc2RpcGxheXNp
bmsgdG8gc3BpdCBkYXRhIG9uIHN0ZG91dC4KICAgICAgICAgR3N0RWxlbWVudEZhY3RvcnkqIGZh
Y3RvcnkgPSBHU1RfRUxFTUVOVF9GQUNUT1JZKEdTVF9FTEVNRU5UX0dFVF9DTEFTUyhtX2Zwc1Np
bmspLT5lbGVtZW50ZmFjdG9yeSk7CiAgICAgICAgIGlmIChnc3RfcGx1Z2luX2ZlYXR1cmVfY2hl
Y2tfdmVyc2lvbihHU1RfUExVR0lOX0ZFQVRVUkUoZmFjdG9yeSksIDAsIDEwLCAyMikpIHsKLSAg
ICAgICAgICAgIGdfb2JqZWN0X3NldChtX2Zwc1NpbmssICJzaWxlbnQiLCBUUlVFICwgTlVMTCk7
CisgICAgICAgICAgICBnX29iamVjdF9zZXQobV9mcHNTaW5rLCAic2lsZW50IiwgVFJVRSAsIG51
bGxwdHIpOwogCiAgICAgICAgICAgICAvLyBUdXJuIG9mZiB0ZXh0IG92ZXJsYXkgdW5sZXNzIGxv
Z2dpbmcgaXMgZW5hYmxlZC4KICNpZiBMT0dfRElTQUJMRUQKLSAgICAgICAgICAgIGdfb2JqZWN0
X3NldChtX2Zwc1NpbmssICJ0ZXh0LW92ZXJsYXkiLCBGQUxTRSAsIE5VTEwpOworICAgICAgICAg
ICAgZ19vYmplY3Rfc2V0KG1fZnBzU2luaywgInRleHQtb3ZlcmxheSIsIEZBTFNFICwgbnVsbHB0
cik7CiAjZWxzZQogICAgICAgICAgICAgV1RGTG9nQ2hhbm5lbCogY2hhbm5lbCA9IGxvZ0NoYW5u
ZWxCeU5hbWUoIk1lZGlhIik7CiAgICAgICAgICAgICBpZiAoY2hhbm5lbC0+c3RhdGUgIT0gV1RG
TG9nQ2hhbm5lbE9uKQotICAgICAgICAgICAgICAgIGdfb2JqZWN0X3NldChtX2Zwc1NpbmssICJ0
ZXh0LW92ZXJsYXkiLCBGQUxTRSAsIE5VTEwpOworICAgICAgICAgICAgICAgIGdfb2JqZWN0X3Nl
dChtX2Zwc1NpbmssICJ0ZXh0LW92ZXJsYXkiLCBGQUxTRSAsIG51bGxwdHIpOwogI2VuZGlmIC8v
IExPR19ESVNBQkxFRAogCiAgICAgICAgICAgICBpZiAoZ19vYmplY3RfY2xhc3NfZmluZF9wcm9w
ZXJ0eShHX09CSkVDVF9HRVRfQ0xBU1MobV9mcHNTaW5rKSwgInZpZGVvLXNpbmsiKSkgewotICAg
ICAgICAgICAgICAgIGdfb2JqZWN0X3NldChtX2Zwc1NpbmssICJ2aWRlby1zaW5rIiwgbV93ZWJr
aXRWaWRlb1NpbmsuZ2V0KCksIE5VTEwpOwotI2lmIFVTRShOQVRJVkVfRlVMTFNDUkVFTl9WSURF
TykKKyAgICAgICAgICAgICAgICBnX29iamVjdF9zZXQobV9mcHNTaW5rLCAidmlkZW8tc2luayIs
IG1fd2Via2l0VmlkZW9TaW5rLmdldCgpLCBudWxscHRyKTsKICAgICAgICAgICAgICAgICBnc3Rf
YmluX2FkZChHU1RfQklOKG1fdmlkZW9TaW5rQmluLmdldCgpKSwgbV9mcHNTaW5rKTsKLSNlbmRp
ZgotICAgICAgICAgICAgICAgIGFjdHVhbFZpZGVvU2luayA9IG1fZnBzU2luazsKKyAgICAgICAg
ICAgICAgICB2aWRlb1NpbmsgPSBtX2Zwc1Npbms7CiAgICAgICAgICAgICB9IGVsc2UKLSAgICAg
ICAgICAgICAgICBtX2Zwc1NpbmsgPSAwOworICAgICAgICAgICAgICAgIG1fZnBzU2luayA9IG51
bGxwdHI7CiAgICAgICAgIH0gZWxzZQotICAgICAgICAgICAgbV9mcHNTaW5rID0gMDsKKyAgICAg
ICAgICAgIG1fZnBzU2luayA9IG51bGxwdHI7CiAgICAgfQogCiAgICAgaWYgKCFtX2Zwc1Npbmsp
IHsKLSNpZiBVU0UoTkFUSVZFX0ZVTExTQ1JFRU5fVklERU8pCiAgICAgICAgIGdzdF9iaW5fYWRk
KEdTVF9CSU4obV92aWRlb1NpbmtCaW4uZ2V0KCkpLCBtX3dlYmtpdFZpZGVvU2luay5nZXQoKSk7
Ci0jZW5kaWYKLSAgICAgICAgYWN0dWFsVmlkZW9TaW5rID0gbV93ZWJraXRWaWRlb1NpbmsuZ2V0
KCk7CisgICAgICAgIHZpZGVvU2luayA9IG1fd2Via2l0VmlkZW9TaW5rLmdldCgpOwogICAgIH0K
IAotICAgIEFTU0VSVChhY3R1YWxWaWRlb1NpbmspOworICAgIEFTU0VSVCh2aWRlb1NpbmspOwog
CisgICAgR3N0RWxlbWVudCogZmlyc3RDaGlsZCA9IHZpZGVvU2luazsKICNpZiBVU0UoTkFUSVZF
X0ZVTExTQ1JFRU5fVklERU8pCiAgICAgLy8gRmFzdGVyIGVsZW1lbnRzIGxpbmtpbmcuCi0gICAg
Z3N0X2VsZW1lbnRfbGlua19wYWRzX2Z1bGwocXVldWUsICJzcmMiLCBhY3R1YWxWaWRlb1Npbmss
ICJzaW5rIiwgR1NUX1BBRF9MSU5LX0NIRUNLX05PVEhJTkcpOwotCi0gICAgLy8gQWRkIGEgZ2hv
c3RwYWQgdG8gdGhlIGJpbiBzbyBpdCBjYW4gcHJveHkgdG8gdGVlLgotICAgIEdSZWZQdHI8R3N0
UGFkPiBwYWQgPSBhZG9wdEdSZWYoZ3N0X2VsZW1lbnRfZ2V0X3N0YXRpY19wYWQodmlkZW9UZWUs
ICJzaW5rIikpOwotICAgIGdzdF9lbGVtZW50X2FkZF9wYWQobV92aWRlb1NpbmtCaW4uZ2V0KCks
IGdzdF9naG9zdF9wYWRfbmV3KCJzaW5rIiwgcGFkLmdldCgpKSk7CisgICAgZ3N0X2VsZW1lbnRf
bGlua19wYWRzX2Z1bGwocXVldWUsICJzcmMiLCB2aWRlb1NpbmssICJzaW5rIiwgR1NUX1BBRF9M
SU5LX0NIRUNLX05PVEhJTkcpOwogCi0gICAgLy8gU2V0IHRoZSBiaW4gYXMgdmlkZW8gc2luayBv
ZiBwbGF5YmluLgotICAgIHJldHVybiBtX3ZpZGVvU2lua0Jpbi5nZXQoKTsKLSNlbHNlCi0gICAg
cmV0dXJuIGFjdHVhbFZpZGVvU2luazsKKyAgICBmaXJzdENoaWxkID0gdmlkZW9UZWU7CiAjZW5k
aWYKKyAgICBHUmVmUHRyPEdzdFBhZD4gcGFkID0gYWRvcHRHUmVmKGdzdF9lbGVtZW50X2dldF9z
dGF0aWNfcGFkKGZpcnN0Q2hpbGQsICJzaW5rIikpOworICAgIGdzdF9lbGVtZW50X2FkZF9wYWQo
bV92aWRlb1NpbmtCaW4uZ2V0KCksIGdzdF9naG9zdF9wYWRfbmV3KCJzaW5rIiwgcGFkLmdldCgp
KSk7CiB9CiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6c2V0U3RyZWFt
Vm9sdW1lRWxlbWVudChHc3RTdHJlYW1Wb2x1bWUqIHZvbHVtZSkKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH
U3RyZWFtZXJCYXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt
ZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5oCmluZGV4IDAwOGI5MjEuLmQ4ZDdi
NGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l
ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJh
c2UuaApAQCAtMTExLDcgKzExMSw3IEBAIHB1YmxpYzoKIAogcHJvdGVjdGVkOgogICAgIE1lZGlh
UGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UoTWVkaWFQbGF5ZXIqKTsKLSAgICBHc3RFbGVtZW50
KiBjcmVhdGVWaWRlb1NpbmsoR3N0RWxlbWVudCogcGlwZWxpbmUpOworICAgIHZvaWQgY3JlYXRl
VmlkZW9TaW5rKEdzdEVsZW1lbnQqIHBpcGVsaW5lKTsKICAgICB2b2lkIHNldFN0cmVhbVZvbHVt
ZUVsZW1lbnQoR3N0U3RyZWFtVm9sdW1lKik7CiAgICAgdmlydHVhbCBHc3RFbGVtZW50KiBhdWRp
b1NpbmsoKSBjb25zdCB7IHJldHVybiAwOyB9CiAgICAgR1JlZlB0cjxHc3RDYXBzPiBjdXJyZW50
VmlkZW9TaW5rQ2FwcygpIGNvbnN0OwotLSAKMS44LjQucmMz
</data>
<flag name="review"
          id="238096"
          type_id="1"
          status="+"
          setter="gustavo"
    />
          </attachment>
      

    </bug>

</bugzilla>