122322 2013-10-04 02:26:54 -0700 MediaStreamTrack can't be FINAL 2013-10-07 05:26:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79203 1 pnormand webkit-unassigned eric.carlson pnormand oldest_to_newest 936143 0 pnormand 2013-10-04 02:26:54 -0700 Because AudioStreamTrack and VideoStreamTrack inherit from it. 936145 1 213343 pnormand 2013-10-04 02:29:58 -0700 Created attachment 213343 patch 936229 2 213343 ap 2013-10-04 10:20:18 -0700 Comment on attachment 213343 patch Are there any methods in these classes that can be final? 936460 3 213343 darin 2013-10-04 17:43:34 -0700 Comment on attachment 213343 patch How did this even compile? Can any of the virtual functions in MediaStreamTrack be FINAL? If the entire class isn’t FINAL, it then becomes helpful to mark the functions themselves FINAL if there is no need to override them. r=me but I suggest adding some FINAL to any functions we don’t need to override. 936946 4 eric.carlson 2013-10-06 20:47:15 -0700 I have a fix for this in the massive patch attached to https://bugs.webkit.org/show_bug.cgi?id=121940 if you want to let me take care of this. 936987 5 pnormand 2013-10-07 00:06:00 -0700 I was thinking of landing this patch with the updates Darin and Alexey suggested. (In reply to comment #3) > (From update of attachment 213343 [details]) > How did this even compile? > It didn't :) Currently no port enables mediastream in their default build. Last week I started working on the GStreamer mediastream backend some other folks started some months ago. One part is in Bug 110150 but I haven't yet uploaded the version that actually builds. 936991 6 pnormand 2013-10-07 00:28:31 -0700 Committed r157030: <http://trac.webkit.org/changeset/157030> 213343 2013-10-04 02:29:58 -0700 2013-10-04 17:43:34 -0700 patch patch.patch text/plain 3374 pnormand RnJvbSA2N2JmMjM5MmEzOGI0MDE5NGMxMzlhMzk1N2U1Y2U5MWU3ZTk5YjI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDQgT2N0IDIwMTMgMTE6Mjk6MjkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBw YXRjaAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8IDEzICsrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz dHJlYW0vQXVkaW9TdHJlYW1UcmFjay5oIHwgIDIgKy0KIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1UcmFjay5oIHwgIDIgKy0KIFNvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzdHJlYW0vVmlkZW9TdHJlYW1UcmFjay5oIHwgIDIgKy0KIDQgZmlsZXMgY2hh bmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNm ZGY4Ny4uNzg1ZWFlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEwLTA0ICBQ aGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBNZWRpYVN0 cmVhbVRyYWNrIGNhbid0IGJlIEZJTkFMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjIzMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNYXJrZWQgdGhlIE1lZGlhU3RyZWFtVHJhY2sgc3ViY2xhc3NlcyBh cyBmaW5hbC4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vQXVkaW9TdHJlYW1UcmFj ay5oOgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1UcmFjay5oOgor ICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vVmlkZW9TdHJlYW1UcmFjay5oOgorCiAyMDEz LTEwLTAzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAg QXNzZXJ0IHRoYXQgd2UgZG9uJ3QgdHJ5IHRvIGluZGV4IHBhc3QgdGhlIGVuZCBvZiB0aGUgbV9j b3JlVGV4dEluZGljZXMgYXJyYXkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzdHJlYW0vQXVkaW9TdHJlYW1UcmFjay5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYXN0cmVhbS9BdWRpb1N0cmVhbVRyYWNrLmgKaW5kZXggMDJiNWRkYS4uMzk5ODRhNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9BdWRpb1N0cmVhbVRy YWNrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9BdWRpb1N0cmVh bVRyYWNrLmgKQEAgLTM3LDcgKzM3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgTWVk aWFTdHJlYW1Tb3VyY2U7CiBjbGFzcyBTY3JpcHRFeGVjdXRpb25Db250ZXh0OwogCi1jbGFzcyBB dWRpb1N0cmVhbVRyYWNrIDogcHVibGljIE1lZGlhU3RyZWFtVHJhY2sgeworY2xhc3MgQXVkaW9T dHJlYW1UcmFjayBGSU5BTCA6IHB1YmxpYyBNZWRpYVN0cmVhbVRyYWNrIHsKIHB1YmxpYzoKICAg ICBzdGF0aWMgUGFzc1JlZlB0cjxBdWRpb1N0cmVhbVRyYWNrPiBjcmVhdGUoU2NyaXB0RXhlY3V0 aW9uQ29udGV4dCosIGNvbnN0IERpY3Rpb25hcnkmKTsKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxB dWRpb1N0cmVhbVRyYWNrPiBjcmVhdGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIE1lZGlhU3Ry ZWFtU291cmNlKik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry ZWFtL01lZGlhU3RyZWFtVHJhY2suaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vTWVkaWFTdHJlYW1UcmFjay5oCmluZGV4IDFmZTFmZmEuLjE1NDNmNzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1UcmFjay5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1UcmFjay5o CkBAIC00NCw3ICs0NCw3IEBAIGNsYXNzIERpY3Rpb25hcnk7CiBjbGFzcyBNZWRpYUNvbnN0cmFp bnRzOwogY2xhc3MgTWVkaWFTdHJlYW1UcmFja1NvdXJjZXNDYWxsYmFjazsKIAotY2xhc3MgTWVk aWFTdHJlYW1UcmFjayBGSU5BTCA6IHB1YmxpYyBSZWZDb3VudGVkPE1lZGlhU3RyZWFtVHJhY2s+ LCBwdWJsaWMgU2NyaXB0V3JhcHBhYmxlLCBwdWJsaWMgQWN0aXZlRE9NT2JqZWN0LCBwdWJsaWMg RXZlbnRUYXJnZXRXaXRoSW5saW5lRGF0YSwgcHVibGljIE1lZGlhU3RyZWFtU291cmNlOjpPYnNl cnZlciB7CitjbGFzcyBNZWRpYVN0cmVhbVRyYWNrIDogcHVibGljIFJlZkNvdW50ZWQ8TWVkaWFT dHJlYW1UcmFjaz4sIHB1YmxpYyBTY3JpcHRXcmFwcGFibGUsIHB1YmxpYyBBY3RpdmVET01PYmpl Y3QsIHB1YmxpYyBFdmVudFRhcmdldFdpdGhJbmxpbmVEYXRhLCBwdWJsaWMgTWVkaWFTdHJlYW1T b3VyY2U6Ok9ic2VydmVyIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5NZWRpYVN0cmVhbVRyYWNr KCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vVmlk ZW9TdHJlYW1UcmFjay5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9WaWRl b1N0cmVhbVRyYWNrLmgKaW5kZXggMWE1ZTk5Zi4uNTEzN2U4MSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9WaWRlb1N0cmVhbVRyYWNrLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9WaWRlb1N0cmVhbVRyYWNrLmgKQEAgLTM3 LDcgKzM3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgTWVkaWFTdHJlYW1Tb3VyY2U7 CiBjbGFzcyBTY3JpcHRFeGVjdXRpb25Db250ZXh0OwogCi1jbGFzcyBWaWRlb1N0cmVhbVRyYWNr IDogcHVibGljIE1lZGlhU3RyZWFtVHJhY2sgeworY2xhc3MgVmlkZW9TdHJlYW1UcmFjayBGSU5B TCA6IHB1YmxpYyBNZWRpYVN0cmVhbVRyYWNrIHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1Jl ZlB0cjxWaWRlb1N0cmVhbVRyYWNrPiBjcmVhdGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIGNv bnN0IERpY3Rpb25hcnkmKTsKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxWaWRlb1N0cmVhbVRyYWNr PiBjcmVhdGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIE1lZGlhU3RyZWFtU291cmNlKik7Ci0t IAoxLjguNC5yYzM=