122006 2013-09-26 22:34:03 -0700 [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing 2013-10-01 18:41:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 121859 InRadar P2 Normal --- 122035 122152 122176 121859 1 thorton thorton andersca ap commit-queue sam simon.fraser webkit-bug-importer oldest_to_newest 933847 0 thorton 2013-09-26 22:34:03 -0700 WebKitTestRunner's window snapshots are pure white no matter what's on screen when they're taken, if tiled drawing is on (possibly any time remote layer hosting is occurring?) and WKTR's window has a buffered backing store. This doesn't show up in ref tests because it's broken in both the ref and the actual result; pixel tests make it the most clear (but we don't have any tiled-drawing pixel tests, nor do we run the other ones very often). I've added a mismatch test to ensure this doesn't happen again, as I'm going to switch WKTR to tiled drawing 24/7 very soon, and it would be really bad if we lost all ref image coverage :| Conveniently, we're really mostly interested in testing unbuffered windows anyway. 933848 1 webkit-bug-importer 2013-09-26 22:34:26 -0700 <rdar://problem/15095197> 933853 2 212789 thorton 2013-09-26 22:52:47 -0700 Created attachment 212789 preliminary I'm seeing some tests that use the non-tiled path fail with this change, so it might require more investigation. 934055 3 thorton 2013-09-27 13:21:44 -0700 We can't override the window resolution with an unbuffered window, so this breaks the workaround we use to make tests work on Retina machines. I'll try to come up with something else. 934063 4 212837 thorton 2013-09-27 13:35:23 -0700 Created attachment 212837 patch 934071 5 thorton 2013-09-27 13:46:11 -0700 http://trac.webkit.org/changeset/156569 934103 6 commit-queue 2013-09-27 14:56:04 -0700 Re-opened since this is blocked by bug 122035 935114 7 thorton 2013-10-01 11:49:39 -0700 http://trac.webkit.org/changeset/156725 935173 8 commit-queue 2013-10-01 13:33:37 -0700 Re-opened since this is blocked by bug 122176 935305 9 thorton 2013-10-01 18:41:06 -0700 Meh, I'm just folding this into https://bugs.webkit.org/show_bug.cgi?id=121859 *** This bug has been marked as a duplicate of bug 121859 *** 212789 2013-09-26 22:52:47 -0700 2013-09-27 13:35:23 -0700 preliminary snapshots.diff text/plain 3903 thorton ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4MDI4MDg0Li42NmM1NzgyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDkt MjYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW3dr Ml0gV2ViS2l0VGVzdFJ1bm5lcidzIHdpbmRvdyBzbmFwc2hvdHMgYXJlIGJsYW5rIHdpdGggdGls ZWQgZHJhd2luZyBhbmQgYnVmZmVyZWQgd2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyMDA2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x NTA5NTE5Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgYSB0ZXN0IHRoYXQgZW5zdXJlcyB0aGF0IFdlYktpdFRlc3RSdW5uZXIncyBzbmFwc2hv dHMgYXJlIG5vdAorICAgICAgICBjb21wbGV0ZWx5IGJsYW5rIHdpdGggdGlsZWQgZHJhd2luZyBl bmFibGVkLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL3dpbmRv dy1zZXJ2ZXItc25hcHNob3RzLXdvcmstZXhwZWN0ZWQtbWlzbWF0Y2guaHRtbDogQWRkZWQuCisg ICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL3dpbmRvdy1zZXJ2ZXItc25h cHNob3RzLXdvcmsuaHRtbDogQWRkZWQuCisKIDIwMTMtMDktMjYgIEFudHRpIEtvaXZpc3RvICA8 YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgbV9zdHlsZSB0byBSZW5kZXJFbGVtZW50 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcv d2luZG93LXNlcnZlci1zbmFwc2hvdHMtd29yay1leHBlY3RlZC1taXNtYXRjaC5odG1sIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL3dpbmRvdy1zZXJ2ZXItc25h cHNob3RzLXdvcmstZXhwZWN0ZWQtbWlzbWF0Y2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi45MDUzMWE0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL3dpbmRvdy1zZXJ2ZXItc25hcHNob3RzLXdvcmst ZXhwZWN0ZWQtbWlzbWF0Y2guaHRtbApAQCAtMCwwICsxLDIgQEAKKzxodG1sPgorPC9odG1sPgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL3dp bmRvdy1zZXJ2ZXItc25hcHNob3RzLXdvcmsuaHRtbCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy13azIvdGlsZWQtZHJhd2luZy93aW5kb3ctc2VydmVyLXNuYXBzaG90cy13b3JrLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZjRkMjIwZgotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy93aW5kb3ctc2Vy dmVyLXNuYXBzaG90cy13b3JrLmh0bWwKQEAgLTAsMCArMSw1IEBACis8aHRtbD4KKzxib2R5IHN0 eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOiBibGFjazsgY29sb3I6IHdoaXRlOyI+CitJZiB0aGlzIHRl c3QgcGFzc2VzIChpZiBXZWJLaXRUZXN0UnVubmVyJ3Mgc25hcHNob3RzIGFyZSB3b3JraW5nIGNv cnJlY3RseSB3aXRoIHRpbGVkIGRyYXdpbmcpLCBpdCB3aWxsIG5vdCBtYXRjaCB0aGUgcHVyZS13 aGl0ZSBtaXNtYXRjaCBleHBlY3RhdGlvbi4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzYzU2YTFkLi5lZDJhYjgz IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTMtMDktMjYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBs ZS5jb20+CisKKyAgICAgICAgW3drMl0gV2ViS2l0VGVzdFJ1bm5lcidzIHdpbmRvdyBzbmFwc2hv dHMgYXJlIGJsYW5rIHdpdGggdGlsZWQgZHJhd2luZyBhbmQgYnVmZmVyZWQgd2luZG93cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyMDA2CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xNTA5NTE5Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3JtV2Vi Vmlld01hYy5tbToKKyAgICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3OjpQbGF0Zm9ybVdlYlZp ZXcpOgorICAgICAgICBVc2UgYW4gdW5idWZmZXJlZCB3aW5kb3cgZm9yIFdlYktpdFRlc3RSdW5u ZXIsIHRvIHdvcmsgYXJvdW5kIGEgYnVnCisgICAgICAgIHdoZXJlIHRoZSB3aW5kb3cgc2VydmVy IHNuYXBzaG90IEFQSSByZXR1cm5zIGJsYW5rIHNuYXBzaG90cy4KKwogMjAxMy0wOS0yNiAgRXJp YyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWVkaWFTdHJl YW1dIG1ha2UgTWVkaWFTdHJlYW0gdGVzdGFibGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbQppbmRleCBiYThkN2Y1Li43MWFiNWY5IDEwMDY0 NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0K KysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxhdGZvcm1XZWJWaWV3TWFjLm1tCkBA IC0xMjQsNiArMTI0LDEwIEBAIHVzaW5nIG5hbWVzcGFjZSBXVFI7CiAKIEBlbmQKIAorZW51bSB7 CisgICAgX05TQmFja2luZ1N0b3JlVW5idWZmZXJlZCA9IDMKK307CisKIG5hbWVzcGFjZSBXVFIg ewogCiBQbGF0Zm9ybVdlYlZpZXc6OlBsYXRmb3JtV2ViVmlldyhXS0NvbnRleHRSZWYgY29udGV4 dFJlZiwgV0tQYWdlR3JvdXBSZWYgcGFnZUdyb3VwUmVmLCBXS1BhZ2VSZWYgcmVsYXRlZFBhZ2Us IFdLRGljdGlvbmFyeVJlZiBvcHRpb25zKQpAQCAtMTQzLDcgKzE0Nyw3IEBAIFBsYXRmb3JtV2Vi Vmlldzo6UGxhdGZvcm1XZWJWaWV3KFdLQ29udGV4dFJlZiBjb250ZXh0UmVmLCBXS1BhZ2VHcm91 cFJlZiBwYWdlR3JvCiAgICAgW21fdmlldyBzZXRXaW5kb3dPY2NsdXNpb25EZXRlY3Rpb25FbmFi bGVkOk5PXTsKIAogICAgIE5TUmVjdCB3aW5kb3dSZWN0ID0gTlNPZmZzZXRSZWN0KHJlY3QsIC0x MDAwMCwgWyhOU1NjcmVlbiAqKVtbTlNTY3JlZW4gc2NyZWVuc10gb2JqZWN0QXRJbmRleDowXSBm cmFtZV0uc2l6ZS5oZWlnaHQgLSByZWN0LnNpemUuaGVpZ2h0ICsgMTAwMDApOwotICAgIG1fd2lu ZG93ID0gW1tXZWJLaXRUZXN0UnVubmVyV2luZG93IGFsbG9jXSBpbml0V2l0aENvbnRlbnRSZWN0 OndpbmRvd1JlY3Qgc3R5bGVNYXNrOk5TQm9yZGVybGVzc1dpbmRvd01hc2sgYmFja2luZzpOU0Jh Y2tpbmdTdG9yZUJ1ZmZlcmVkIGRlZmVyOllFU107CisgICAgbV93aW5kb3cgPSBbW1dlYktpdFRl c3RSdW5uZXJXaW5kb3cgYWxsb2NdIGluaXRXaXRoQ29udGVudFJlY3Q6d2luZG93UmVjdCBzdHls ZU1hc2s6TlNCb3JkZXJsZXNzV2luZG93TWFzayBiYWNraW5nOl9OU0JhY2tpbmdTdG9yZVVuYnVm ZmVyZWQgZGVmZXI6WUVTXTsKICAgICBtX3dpbmRvdy5wbGF0Zm9ybVdlYlZpZXcgPSB0aGlzOwog ICAgIFttX3dpbmRvdyBzZXRDb2xvclNwYWNlOltbTlNTY3JlZW4gbWFpblNjcmVlbl0gY29sb3JT cGFjZV1dOwogICAgIFttX3dpbmRvdyBzZXRDb2xsZWN0aW9uQmVoYXZpb3I6TlNXaW5kb3dDb2xs ZWN0aW9uQmVoYXZpb3JTdGF0aW9uYXJ5XTsK 212837 2013-09-27 13:35:23 -0700 2013-09-27 13:38:43 -0700 patch snapshots.diff text/plain 2410 thorton ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkZWE5MTI3Li4wNWEyNDVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDkt MjcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW3dr Ml0gV2ViS2l0VGVzdFJ1bm5lcidzIHdpbmRvdyBzbmFwc2hvdHMgYXJlIGJsYW5rIHdpdGggdGls ZWQgZHJhd2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTIyMDA2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNTA5NTE5Nz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IHRoYXQgZW5z dXJlcyB0aGF0IFdlYktpdFRlc3RSdW5uZXIncyBzbmFwc2hvdHMgYXJlIG5vdAorICAgICAgICBj b21wbGV0ZWx5IGJsYW5rIHdpdGggdGlsZWQgZHJhd2luZyBlbmFibGVkLgorCisgICAgICAgICog cGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL3dpbmRvdy1zZXJ2ZXItc25hcHNob3RzLXdv cmstZXhwZWN0ZWQtbWlzbWF0Y2guaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFj LXdrMi90aWxlZC1kcmF3aW5nL3dpbmRvdy1zZXJ2ZXItc25hcHNob3RzLXdvcmsuaHRtbDogQWRk ZWQuCisKIDIwMTMtMDktMjcgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgW01lZGlhU3RyZWFtIEFQSV0gdXBkYXRlIFNvdXJjZUluZm8gb2JqZWN0IHRv IG1hdGNoIHNwZWMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxv ZwppbmRleCA1ZWVhZTMxLi44OTMyMTFjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysr IGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDktMjcgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW3drMl0gV2ViS2l0VGVz dFJ1bm5lcidzIHdpbmRvdyBzbmFwc2hvdHMgYXJlIGJsYW5rIHdpdGggdGlsZWQgZHJhd2luZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyMDA2Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNTA5NTE5Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3Jt V2ViVmlld01hYy5tbToKKyAgICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3OjpQbGF0Zm9ybVdl YlZpZXcpOgorICAgICAgICBMYXllci1iYWNrIHRoZSByb290IHZpZXcgaW4gV2ViS2l0VGVzdFJ1 bm5lcidzIHdpbmRvdywgdG8gd29yayBhcm91bmQgYSBidWcKKyAgICAgICAgd2hlcmUgdGhlIHdp bmRvdyBzZXJ2ZXIgc25hcHNob3QgQVBJIHJldHVybnMgYmxhbmsgc25hcHNob3RzLgorCiAyMDEz LTA5LTI3ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CiAK ICAgICAgICAgW0dUS10gR1RLIGRvZXMgbm90IGV4cG9zZSBoZWFkaW5nIGxldmVsIGNvcnJlY3Rs eS4gV2FzOiBhY2Nlc3NpYmlsaXR5L2hlYWRpbmctbGV2ZWwuaHRtbCBpcyBmYWlsaW5nCmRpZmYg LS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0g Yi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0KaW5kZXgg YmE4ZDdmNS4uNTI3NTEyNSAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMv UGxhdGZvcm1XZWJWaWV3TWFjLm1tCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1Bs YXRmb3JtV2ViVmlld01hYy5tbQpAQCAtMTQ3LDYgKzE0Nyw3IEBAIFBsYXRmb3JtV2ViVmlldzo6 UGxhdGZvcm1XZWJWaWV3KFdLQ29udGV4dFJlZiBjb250ZXh0UmVmLCBXS1BhZ2VHcm91cFJlZiBw YWdlR3JvCiAgICAgbV93aW5kb3cucGxhdGZvcm1XZWJWaWV3ID0gdGhpczsKICAgICBbbV93aW5k b3cgc2V0Q29sb3JTcGFjZTpbW05TU2NyZWVuIG1haW5TY3JlZW5dIGNvbG9yU3BhY2VdXTsKICAg ICBbbV93aW5kb3cgc2V0Q29sbGVjdGlvbkJlaGF2aW9yOk5TV2luZG93Q29sbGVjdGlvbkJlaGF2 aW9yU3RhdGlvbmFyeV07CisgICAgW1ttX3dpbmRvdyBjb250ZW50Vmlld10gc2V0V2FudHNMYXll cjpZRVNdOwogICAgIFtbbV93aW5kb3cgY29udGVudFZpZXddIGFkZFN1YnZpZXc6bV92aWV3XTsK ICAgICBbbV93aW5kb3cgb3JkZXJCYWNrOm5pbF07CiAgICAgW21fd2luZG93IHNldFJlbGVhc2Vk V2hlbkNsb3NlZDpOT107Cg==