121690 2013-09-20 09:26:43 -0700 renderStyleOfEnclosingTextNode should update style before using a renderer 2013-09-20 10:31:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 120685 1 rniwa rniwa darin enrica kling koivisto oldest_to_newest 931401 0 rniwa 2013-09-20 09:26:43 -0700 renderStyleOfEnclosingTextNode should update style before using a renderer 931402 1 212181 rniwa 2013-09-20 09:27:40 -0700 Created attachment 212181 Cleanup 931416 2 212184 rniwa 2013-09-20 09:45:32 -0700 Created attachment 212184 Call the right function 931450 3 212184 enrica 2013-09-20 10:28:27 -0700 Comment on attachment 212184 Call the right function Looks good to me. 931452 4 rniwa 2013-09-20 10:31:04 -0700 Committed r156180: <http://trac.webkit.org/changeset/156180> 212181 2013-09-20 09:27:40 -0700 2013-09-20 09:29:26 -0700 Cleanup bug-121690-20130920092739.patch text/plain 2759 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjE2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA5LTIwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIHJlbmRlclN0eWxlT2ZFbmNsb3Np bmdUZXh0Tm9kZSBzaG91bGQgdXBkYXRlIHN0eWxlIGJlZm9yZSB1c2luZyBhIHJlbmRlcmVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE2OTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZXJnZSBodHRw czovL2Nocm9taXVtLmdvb2dsZXNvdXJjZS5jb20vY2hyb21pdW0vYmxpbmsvKy82NWYwODk1NDVl OGMxOGNiMjY4ZGZjYmU1NmNiYTFjZDgwNDU1MjdhCisKKyAgICAgICAgV2hlbiBhY2Nlc3Npbmcg YSByZW5kZXJlciBlZGl0aW5nIHNob3VsZCBhbHdheXMgbWFrZSBzdXJlIHRoYXQgdGhlIHN0eWxl IGhhcyBiZWVuIHVwZGF0ZWQgZm9yIHRoZSBub2RlLgorICAgICAgICBFZGl0aW5nIGNhbGxzIHNw bGl0VGV4dE5vZGUgaW4gYSBudW1iZXIgb2YgcGxhY2VzIGFuZCB0aGVuIGFjY2Vzc2VzIHRoZSBy ZW5kZXJlciBsYXRlci4gVGhpcyBwYXRjaCBpcworICAgICAgICB0aGUgZmlyc3Qgb2YgbWFueSB0 byBtYWtlIHN1cmUgZWRpdGluZyBhbHdheXMgdXBkYXRlcyB0aGUgc3R5bGUgYmVmb3JlIGF0dGVt cHRpbmcgdG8gYWNjZXNzIHRoZSByZW5kZXJlcgorICAgICAgICAob3Igc3R5bGUpIG9mIGEgbm9k ZSBhZnRlciBjYWxsaW5nIGEgbXV0YXRpb24gbWV0aG9kLgorCisgICAgICAgICogZWRpdGluZy9B cHBseUJsb2NrRWxlbWVudENvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBwbHlCbG9j a0VsZW1lbnRDb21tYW5kOjpyZW5kZXJTdHlsZU9mRW5jbG9zaW5nVGV4dE5vZGUpOgorICAgICAg ICAqIGVkaXRpbmcvQXBwbHlCbG9ja0VsZW1lbnRDb21tYW5kLmg6CisKIDIwMTMtMDktMjAgIFNh bSBXaGl0ZSAgPHNhbXVlbF93aGl0ZUBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IFdlYkFyZWEg Y2xhaW1zIHRvIGhhdmUgYSBzdWJyb2xlLCBidXQgYWx3YXlzIHJldHVybnMgbmlsLgpJbmRleDog U291cmNlL1dlYkNvcmUvZWRpdGluZy9BcHBseUJsb2NrRWxlbWVudENvbW1hbmQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQXBwbHlCbG9ja0VsZW1lbnRDb21tYW5k LmNwcAkocmV2aXNpb24gMTU2MTY3KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9BcHBseUJs b2NrRWxlbWVudENvbW1hbmQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjksOCArMTY5LDEwIEBA IHN0YXRpYyBib29sIGlzTmV3TGluZUF0UG9zaXRpb24oY29uc3QgUG8KICAgICByZXR1cm4gdGV4 dEF0UG9zaXRpb25bMF0gPT0gJ1xuJzsKIH0KIAotc3RhdGljIFJlbmRlclN0eWxlKiByZW5kZXJT dHlsZU9mRW5jbG9zaW5nVGV4dE5vZGUoY29uc3QgUG9zaXRpb24mIHBvc2l0aW9uKQorUmVuZGVy U3R5bGUqIEFwcGx5QmxvY2tFbGVtZW50Q29tbWFuZDo6cmVuZGVyU3R5bGVPZkVuY2xvc2luZ1Rl eHROb2RlKGNvbnN0IFBvc2l0aW9uJiBwb3NpdGlvbikKIHsKKyAgICBkb2N1bWVudCgpLnVwZGF0 ZUxheW91dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0cygpOworCiAgICAgaWYgKHBvc2l0aW9uLmFu Y2hvclR5cGUoKSAhPSBQb3NpdGlvbjo6UG9zaXRpb25Jc09mZnNldEluQW5jaG9yCiAgICAgICAg IHx8ICFwb3NpdGlvbi5jb250YWluZXJOb2RlKCkKICAgICAgICAgfHwgIXBvc2l0aW9uLmNvbnRh aW5lck5vZGUoKS0+aXNUZXh0Tm9kZSgpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0Fw cGx5QmxvY2tFbGVtZW50Q29tbWFuZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvQXBwbHlCbG9ja0VsZW1lbnRDb21tYW5kLmgJKHJldmlzaW9uIDE1NjE2NykKKysrIFNv dXJjZS9XZWJDb3JlL2VkaXRpbmcvQXBwbHlCbG9ja0VsZW1lbnRDb21tYW5kLmgJKHdvcmtpbmcg Y29weSkKQEAgLTQ4LDYgKzQ4LDcgQEAgcHJvdGVjdGVkOgogcHJpdmF0ZToKICAgICB2aXJ0dWFs IHZvaWQgZG9BcHBseSgpOwogICAgIHZpcnR1YWwgdm9pZCBmb3JtYXRSYW5nZShjb25zdCBQb3Np dGlvbiYgc3RhcnQsIGNvbnN0IFBvc2l0aW9uJiBlbmQsIGNvbnN0IFBvc2l0aW9uJiBlbmRPZlNl bGVjdGlvbiwgUmVmUHRyPEVsZW1lbnQ+JikgPSAwOworICAgIFJlbmRlclN0eWxlKiByZW5kZXJT dHlsZU9mRW5jbG9zaW5nVGV4dE5vZGUoY29uc3QgUG9zaXRpb24mKTsKICAgICB2b2lkIHJhbmdl Rm9yUGFyYWdyYXBoU3BsaXR0aW5nVGV4dE5vZGVzSWZOZWVkZWQoY29uc3QgVmlzaWJsZVBvc2l0 aW9uJiwgUG9zaXRpb24mLCBQb3NpdGlvbiYpOwogICAgIFZpc2libGVQb3NpdGlvbiBlbmRPZk5l eHRQYXJhZ3JhaFNwbGl0dGluZ1RleHROb2Rlc0lmTmVlZGVkKFZpc2libGVQb3NpdGlvbiYsIFBv c2l0aW9uJiwgUG9zaXRpb24mKTsKIAo= 212184 2013-09-20 09:45:32 -0700 2013-09-20 10:28:26 -0700 Call the right function bug-121690-20130920094532.patch text/plain 3226 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjE2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA5LTIwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIHJlbmRlclN0eWxlT2ZFbmNsb3Np bmdUZXh0Tm9kZSBzaG91bGQgdXBkYXRlIHN0eWxlIGJlZm9yZSB1c2luZyBhIHJlbmRlcmVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE2OTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZXJnZSBodHRw czovL2Nocm9taXVtLmdvb2dsZXNvdXJjZS5jb20vY2hyb21pdW0vYmxpbmsvKy82NWYwODk1NDVl OGMxOGNiMjY4ZGZjYmU1NmNiYTFjZDgwNDU1MjdhCisKKyAgICAgICAgV2hlbiBhY2Nlc3Npbmcg YSByZW5kZXJlciBlZGl0aW5nIHNob3VsZCBhbHdheXMgbWFrZSBzdXJlIHRoYXQgdGhlIHN0eWxl IGhhcyBiZWVuIHVwZGF0ZWQgZm9yIHRoZSBub2RlLgorICAgICAgICBFZGl0aW5nIGNhbGxzIHNw bGl0VGV4dE5vZGUgaW4gYSBudW1iZXIgb2YgcGxhY2VzIGFuZCB0aGVuIGFjY2Vzc2VzIHRoZSBy ZW5kZXJlciBsYXRlci4gVGhpcyBwYXRjaCBpcworICAgICAgICB0aGUgZmlyc3Qgb2YgbWFueSB0 byBtYWtlIHN1cmUgZWRpdGluZyBhbHdheXMgdXBkYXRlcyB0aGUgc3R5bGUgYmVmb3JlIGF0dGVt cHRpbmcgdG8gYWNjZXNzIHRoZSByZW5kZXJlcgorICAgICAgICAob3Igc3R5bGUpIG9mIGEgbm9k ZSBhZnRlciBjYWxsaW5nIGEgbXV0YXRpb24gbWV0aG9kLgorCisgICAgICAgICogZWRpdGluZy9B cHBseUJsb2NrRWxlbWVudENvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBwbHlCbG9j a0VsZW1lbnRDb21tYW5kOjpyZW5kZXJTdHlsZU9mRW5jbG9zaW5nVGV4dE5vZGUpOgorICAgICAg ICAqIGVkaXRpbmcvQXBwbHlCbG9ja0VsZW1lbnRDb21tYW5kLmg6CisKIDIwMTMtMDktMjAgIFNh bSBXaGl0ZSAgPHNhbXVlbF93aGl0ZUBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IFdlYkFyZWEg Y2xhaW1zIHRvIGhhdmUgYSBzdWJyb2xlLCBidXQgYWx3YXlzIHJldHVybnMgbmlsLgpJbmRleDog U291cmNlL1dlYkNvcmUvZWRpdGluZy9BcHBseUJsb2NrRWxlbWVudENvbW1hbmQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQXBwbHlCbG9ja0VsZW1lbnRDb21tYW5k LmNwcAkocmV2aXNpb24gMTU2MTY3KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9BcHBseUJs b2NrRWxlbWVudENvbW1hbmQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjksMTQgKzE2OSwyMCBA QCBzdGF0aWMgYm9vbCBpc05ld0xpbmVBdFBvc2l0aW9uKGNvbnN0IFBvCiAgICAgcmV0dXJuIHRl eHRBdFBvc2l0aW9uWzBdID09ICdcbic7CiB9CiAKLXN0YXRpYyBSZW5kZXJTdHlsZSogcmVuZGVy U3R5bGVPZkVuY2xvc2luZ1RleHROb2RlKGNvbnN0IFBvc2l0aW9uJiBwb3NpdGlvbikKK1JlbmRl clN0eWxlKiBBcHBseUJsb2NrRWxlbWVudENvbW1hbmQ6OnJlbmRlclN0eWxlT2ZFbmNsb3NpbmdU ZXh0Tm9kZShjb25zdCBQb3NpdGlvbiYgcG9zaXRpb24pCiB7CiAgICAgaWYgKHBvc2l0aW9uLmFu Y2hvclR5cGUoKSAhPSBQb3NpdGlvbjo6UG9zaXRpb25Jc09mZnNldEluQW5jaG9yCiAgICAgICAg IHx8ICFwb3NpdGlvbi5jb250YWluZXJOb2RlKCkKLSAgICAgICAgfHwgIXBvc2l0aW9uLmNvbnRh aW5lck5vZGUoKS0+aXNUZXh0Tm9kZSgpCi0gICAgICAgIHx8ICFwb3NpdGlvbi5jb250YWluZXJO b2RlKCktPnJlbmRlcmVyKCkpCisgICAgICAgIHx8ICFwb3NpdGlvbi5jb250YWluZXJOb2RlKCkt PmlzVGV4dE5vZGUoKSkKICAgICAgICAgcmV0dXJuIDA7Ci0gICAgcmV0dXJuIHBvc2l0aW9uLmNv bnRhaW5lck5vZGUoKS0+cmVuZGVyZXIoKS0+c3R5bGUoKTsKKworICAgIGRvY3VtZW50KCkudXBk YXRlU3R5bGVJZk5lZWRlZCgpOworCisgICAgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IHBvc2l0 aW9uLmNvbnRhaW5lck5vZGUoKS0+cmVuZGVyZXIoKTsKKyAgICBpZiAoIXJlbmRlcmVyKQorICAg ICAgICByZXR1cm4gMDsKKworICAgIHJldHVybiByZW5kZXJlci0+c3R5bGUoKTsKIH0KIAogdm9p ZCBBcHBseUJsb2NrRWxlbWVudENvbW1hbmQ6OnJhbmdlRm9yUGFyYWdyYXBoU3BsaXR0aW5nVGV4 dE5vZGVzSWZOZWVkZWQoY29uc3QgVmlzaWJsZVBvc2l0aW9uJiBlbmRPZkN1cnJlbnRQYXJhZ3Jh cGgsIFBvc2l0aW9uJiBzdGFydCwgUG9zaXRpb24mIGVuZCkKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvQXBwbHlCbG9ja0VsZW1lbnRDb21tYW5kLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvZWRpdGluZy9BcHBseUJsb2NrRWxlbWVudENvbW1hbmQuaAkocmV2aXNpb24gMTU2 MTY3KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9BcHBseUJsb2NrRWxlbWVudENvbW1hbmQu aAkod29ya2luZyBjb3B5KQpAQCAtNDgsNiArNDgsNyBAQCBwcm90ZWN0ZWQ6CiBwcml2YXRlOgog ICAgIHZpcnR1YWwgdm9pZCBkb0FwcGx5KCk7CiAgICAgdmlydHVhbCB2b2lkIGZvcm1hdFJhbmdl KGNvbnN0IFBvc2l0aW9uJiBzdGFydCwgY29uc3QgUG9zaXRpb24mIGVuZCwgY29uc3QgUG9zaXRp b24mIGVuZE9mU2VsZWN0aW9uLCBSZWZQdHI8RWxlbWVudD4mKSA9IDA7CisgICAgUmVuZGVyU3R5 bGUqIHJlbmRlclN0eWxlT2ZFbmNsb3NpbmdUZXh0Tm9kZShjb25zdCBQb3NpdGlvbiYpOwogICAg IHZvaWQgcmFuZ2VGb3JQYXJhZ3JhcGhTcGxpdHRpbmdUZXh0Tm9kZXNJZk5lZWRlZChjb25zdCBW aXNpYmxlUG9zaXRpb24mLCBQb3NpdGlvbiYsIFBvc2l0aW9uJik7CiAgICAgVmlzaWJsZVBvc2l0 aW9uIGVuZE9mTmV4dFBhcmFncmFoU3BsaXR0aW5nVGV4dE5vZGVzSWZOZWVkZWQoVmlzaWJsZVBv c2l0aW9uJiwgUG9zaXRpb24mLCBQb3NpdGlvbiYpOwogCg==