121593 2013-09-19 00:45:49 -0700 REGRESSION(r155543): accessibility/radio-button-title-label.html is failing on GTK 2023-01-25 19:30:17 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure, Regression P2 Normal --- 98347 1 zan webkit-unassigned aboxhall apinheiro bugs-noreply cdumez cfleizach commit-queue dmazzoni gyuyoung.kim jdiggs mario rakuco oldest_to_newest 930860 0 zan 2013-09-19 00:45:49 -0700 The accessibility/radio-button-title-label.html layout test is failing on the GTK port since r155543. http://trac.webkit.org/changeset/155543 http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fradio-button-title-label.html Diff: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/accessibility/radio-button-title-label-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/accessibility/radio-button-title-label-actual.txt @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS radio1.title is 'AXTitle: ' +FAIL radio1.title should be AXTitle: . Was AXTitle: LABEL. PASS titleUIElement.isEqual(accessibilityController.accessibleElementById('label1')) is true PASS radio2.description is 'AXDescription: LABEL2a' PASS radio2.title is 'AXTitle: ' 943536 1 215163 k.wolanski 2013-10-25 04:43:43 -0700 Created attachment 215163 proposed patch 943550 2 215163 mario 2013-10-25 05:34:03 -0700 Comment on attachment 215163 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=215163&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleUtil.cpp:-117 > - > - // FIXME: The title tag is used in certain cases for the title. This usage should > - // probably be in the description field since it's not "visible". > - if (text.textSource == TitleTagText && !titleTagShouldBeUsedInDescriptionField(coreObject)) > - return text.text; I'm not sure this is correct. If any, I think the change here should probably be to make it more similar to what the Mac wrapper currently does, which also runs away from using titleTagShouldBeUsedInDescriptionField() to make this decision, but also do some other things. > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:131 > - if (ATK_IS_TEXT(atkObject)) > + // If the embedded control is a text field, use its value. > + if (ATK_IS_TEXT(atkObject) && coreObject->isTextControl()) This is not correct, and I think Joanie will agree with me too: The problem is that here you are exposing the text inside the text control (that might be a text area, for instance, with a lot of text) as the name of the AtkObject, and that's not what ATs will expect at all for this cases. What ATs would expect here is more something like "if there's a explicit label for this control (aria-label, another element labelling it...) use it for the name, otherwise just don't put a name". And what this change does is a step more in the wrong direction, since the current situation is wrong anyway. Yes, I know that's what the W3C says in 2B, but it's definitely what ATK based ATs expect (embedded objects should be represented with the "object replacement character") and in any case that 2B feature is marked at risk, so it's not 100% clear that's the right thing to do anyway. Btw, this issue was already in my radar after a conversation with Joanie, but I was waiting for bug 123153 to get fixed first before changing that, since that will probably impact it. But in any case, if we wanted to move closer to the right direction already now, I would do something more like this: --- a/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp +++ b/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp @@ -131,6 +131,10 @@ static const gchar* webkitAccessibleGetName(AtkObject* object) return atk_text_get_text(ATK_TEXT(atkObject), 0, -1); } + // We don't return the text inside a text control as its name ever. + if (coreObject->isTextControl()) + return 0; + // Try text under the node. String textUnder = coreObject->textUnderElement(); if (textUnder.length()) [...] Anyway, there's definitely an issue here and I still think this patch should be fixed. Could you investigate whether the suggestions I commented above could help passing this test too? Thanks! 1928407 3 dpino 2023-01-25 19:30:12 -0800 There are no references to this bug in any TestExpectations. It's probable this bug was solved at some point but it wasn't marked as closed. I'm closing this bug now. If you think this bug report is still valid, please reopen it and add an entry to TestExpectations. 215163 2013-10-25 04:43:43 -0700 2013-10-25 05:34:02 -0700 proposed patch radio.patch text/plain 6414 k.wolanski ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5OGY3Y2JlLi5iNGZmNmUzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTMtMTAt MjUgIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5za2lAc2Ftc3VuZy5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTihyMTU1NTQzKTogYWNjZXNzaWJpbGl0eS9yYWRpby1idXR0b24tdGl0bGUt bGFiZWwuaHRtbCBpcyBmYWlsaW5nIG9uIEdUSworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwtd2sxL1Rlc3RFeHBlY3RhdGlvbnM6 CisgICAgICAgIGFjY2Vzc2liaWxpdHkvcmFkaW8tYnV0dG9uLXRpdGxlLWxhYmVsLmh0bWwgaXMg c3RpbGwgZmFpbGluZyBmb3Igb3RoZXIgcmVhc29ucworICAgICAgICAqIHBsYXRmb3JtL2VmbC9U ZXN0RXhwZWN0YXRpb25zOgorICAgICAgICBhY2Nlc3NpYmlsaXR5L3JhZGlvLWJ1dHRvbi10aXRs ZS1sYWJlbC5odG1sIGlzIG5vdyBwYXNzaW5nCisgICAgICAgICogcGxhdGZvcm0vZ3RrLXdrMS9U ZXN0RXhwZWN0YXRpb25zOgorICAgICAgICBhY2Nlc3NpYmlsaXR5L3JhZGlvLWJ1dHRvbi10aXRs ZS1sYWJlbC5odG1sIGlzIHN0aWxsIGZhaWxpbmcgZm9yIG90aGVyIHJlYXNvbnMKKyAgICAgICAg KiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgYWNjZXNzaWJpbGl0eS9y YWRpby1idXR0b24tdGl0bGUtbGFiZWwuaHRtbCBpcyBub3cgcGFzc2luZworCiAyMDEzLTEwLTI1 ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtD U1MgUmVnaW9uc10gUmVuYW1lIENTUyBjbGFzc2VzIGFuZCBKUyBtZXRob2RzIGluIHZlcnRpY2Fs IGxheW91dCB0ZXN0cyBhYm91dCBzZWxlY3Rpb24KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2VmbC13azEvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Vm bC13azEvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBhY2E0MzZiLi45NGIyNzc3IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25zCkBAIC0xNzAsNiArMTcw LDcgQEAgd2Via2l0Lm9yZy9iLzExMjAxNyBhY2Nlc3NpYmlsaXR5L3RleHRib3gtcm9sZS1yZXBv cnRzLXNlbGVjdGlvbi5odG1sIFsgRmFpbHVyZQogd2Via2l0Lm9yZy9iLzExMjAxOCBhY2Nlc3Np YmlsaXR5L3RoLWFzLXRpdGxlLXVpLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMTIw MTkgYWNjZXNzaWJpbGl0eS90aXRsZS11aS1lbGVtZW50LWNvcnJlY3RuZXNzLmh0bWwgWyBGYWls dXJlIF0KIHdlYmtpdC5vcmcvYi8xMTIwMjEgYWNjZXNzaWJpbGl0eS92aXNpYmxlLWVsZW1lbnRz Lmh0bWwgWyBGYWlsdXJlIENyYXNoIF0KK2FjY2Vzc2liaWxpdHkvcmFkaW8tYnV0dG9uLXRpdGxl LWxhYmVsLmh0bWwgWyBGYWlsdXJlIF0KIAogYWNjZXNzaWJpbGl0eS9hcmlhLWNoZWNrYm94LXNl bmRzLW5vdGlmaWNhdGlvbi5odG1sIFsgU2tpcCBdCiBhY2Nlc3NpYmlsaXR5L2RlbGV0aW5nLWlm cmFtZS1kZXN0cm95cy1heGNhY2hlLmh0bWwgWyBTa2lwIF0KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v ZWZsL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZTNlNGUwYi4uNWEzOGQ5NiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE0MTQsNyArMTQxNCw2IEBAIHdl YmtpdC5vcmcvYi8xMTU2NTkgYWNjZXNzaWJpbGl0eS9tZXRlci1lbGVtZW50Lmh0bWwgWyBNaXNz aW5nIF0KIAogd2Via2l0Lm9yZy9iLzEyMTY4NCBhY2Nlc3NpYmlsaXR5L2FyaWEtZGVzY3JpYmVk Ynktb24taW5wdXQuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzg0MDQ1IGFjY2Vzc2li aWxpdHkvaW1hZ2UtbWFwMS5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTIxNTkzIGFj Y2Vzc2liaWxpdHkvcmFkaW8tYnV0dG9uLXRpdGxlLWxhYmVsLmh0bWwgWyBGYWlsdXJlIF0KIAog IyBOZXdseSBhZGRlZCB0ZXN0IGF0IHIxMzkxMTEgaXMgZmFpbGluZy4KIHdlYmtpdC5vcmcvYi8x MDY0MzkgZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLW5vcGx1Z2luLmh0bWwgWyBGYWlsdXJlIF0K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay13azEvVGVzdEV4cGVjdGF0aW9u cyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay13azEvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAx NWRjMTJlLi5lMGUxYWQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGstd2sx L1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrLXdrMS9UZXN0 RXhwZWN0YXRpb25zCkBAIC0yNDgsNiArMjQ4LDggQEAgd2Via2l0Lm9yZy9iLzkwNTg5IGZhc3Qv Y3NzL3VzZXItZHJhZy1ub25lLmh0bWwgWyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzExOTcz MyBmYXN0L3JlZ2lvbnMvb3ZlcmZsb3ctc2Nyb2xsYWJsZS0yLmh0bWwgWyBJbWFnZU9ubHlGYWls dXJlIF0KIAorYWNjZXNzaWJpbGl0eS9yYWRpby1idXR0b24tdGl0bGUtbGFiZWwuaHRtbCBbIEZh aWx1cmUgXQorCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIyBFbmQgb2YgVGVz dHMgZmFpbGluZwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYzc1NTMyMC4uYzA5YTA3NCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE0MTQsOCArMTQx NCw2IEBAIHdlYmtpdC5vcmcvYi8xMjA4NDIgZmFzdC9yZWdpb25zL292ZXJmbG93LW1vdmluZy1i ZWxvdy1mbG9hdHMtaW4tdmFyaWFibGUtd2lkdGgtCiAKIHdlYmtpdC5vcmcvYi8xMjA4NDYgc3Zn L2N1c3RvbS9tYXNraW5nLWNsaXBwaW5nLWhpZHBpLnN2ZyBbIEltYWdlT25seUZhaWx1cmUgXQog Ci13ZWJraXQub3JnL2IvMTIxNTkzIGFjY2Vzc2liaWxpdHkvcmFkaW8tYnV0dG9uLXRpdGxlLWxh YmVsLmh0bWwgIFsgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xMjE5MDUgZmFzdC9pbWFnZXMv ZXhpZi1vcmllbnRhdGlvbi5odG1sIFsgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xMjIxNDcg ZmFzdC9jc3MvZHJvcC1zaGFkb3ctdmlld3BvcnQtaGVpZ2h0Lmh0bWwgWyBJbWFnZU9ubHlGYWls dXJlIF0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCA0YWNiMTU3Li42NDRhYWVkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMTMtMTAtMjUgIEtyenlzenRvZiBXb2xhbnNraSAgPGsud29sYW5za2lAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTU1NTQzKTogYWNjZXNzaWJpbGl0eS9y YWRpby1idXR0b24tdGl0bGUtbGFiZWwuaHRtbCBpcyBmYWlsaW5nIG9uIEdUSworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNTkzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvIGh0dHA6 Ly93d3cudzMub3JnL1dBSS9QRi9hcmlhL2NvbXBsZXRlI3RleHRhbHRlcm5hdGl2ZWNvbXB1dGF0 aW9uCisgICAgICAgIGlmIHRoZSBlbWJlZGRlZCBjb250cm9sIGlzIGEgdGV4dCBmaWVsZCwgdXNl IGl0cyB2YWx1ZS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2li bGVVdGlsLmNwcDoKKyAgICAgICAgKGFjY2Vzc2liaWxpdHlUaXRsZSk6CisgICAgICAgICogYWNj ZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwOgorICAgICAgICAo d2Via2l0QWNjZXNzaWJsZUdldE5hbWUpOgorCiAyMDEzLTEwLTI1ICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVzZSBhIFZlY3RvciBpbnN0ZWFk IG9mIEhhc2hTZXQgdG8gY29tcHV0ZWQgdGhlIG9yZGVyVmFsdWVzIGluIFJlbmRlckZsZXhpYmxl Qm94CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRB Y2Nlc3NpYmxlVXRpbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJL aXRBY2Nlc3NpYmxlVXRpbC5jcHAKaW5kZXggMzRhNzFmMS4uZjJhZmUzNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVV0aWwuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVV dGlsLmNwcApAQCAtMTEwLDExICsxMTAsNiBAQCBTdHJpbmcgYWNjZXNzaWJpbGl0eVRpdGxlKEFj Y2Vzc2liaWxpdHlPYmplY3QqIGNvcmVPYmplY3QpCiAgICAgICAgIC8vIEVsZW1lbnRzIG9mIHJv bGUgVG9vbGJhclJvbGUgd2lsbCByZXR1cm4gaXRzIHRpdGxlIGFzIEFsdGVybmF0aXZlVGV4dC4K ICAgICAgICAgaWYgKGNvcmVPYmplY3QtPnJvbGVWYWx1ZSgpID09IFRvb2xiYXJSb2xlICYmIHRl eHQudGV4dFNvdXJjZSA9PSBBbHRlcm5hdGl2ZVRleHQpCiAgICAgICAgICAgICByZXR1cm4gdGV4 dC50ZXh0OwotCi0gICAgICAgIC8vIEZJWE1FOiBUaGUgdGl0bGUgdGFnIGlzIHVzZWQgaW4gY2Vy dGFpbiBjYXNlcyBmb3IgdGhlIHRpdGxlLiBUaGlzIHVzYWdlIHNob3VsZAotICAgICAgICAvLyBw cm9iYWJseSBiZSBpbiB0aGUgZGVzY3JpcHRpb24gZmllbGQgc2luY2UgaXQncyBub3QgInZpc2li bGUiLgotICAgICAgICBpZiAodGV4dC50ZXh0U291cmNlID09IFRpdGxlVGFnVGV4dCAmJiAhdGl0 bGVUYWdTaG91bGRCZVVzZWRJbkRlc2NyaXB0aW9uRmllbGQoY29yZU9iamVjdCkpCi0gICAgICAg ICAgICByZXR1cm4gdGV4dC50ZXh0OwogICAgIH0KICAgICByZXR1cm4gU3RyaW5nKCk7CiB9CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3Np YmxlV3JhcHBlckF0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJL aXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHAKaW5kZXggYWFkMWEzMi4uYTAxOGFhZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdy YXBwZXJBdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktp dEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcApAQCAtMTI3LDcgKzEyNyw4IEBAIHN0YXRpYyBjb25z dCBnY2hhciogd2Via2l0QWNjZXNzaWJsZUdldE5hbWUoQXRrT2JqZWN0KiBvYmplY3QpCiAgICAg ICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIGxhYmVsID0gY29yZU9iamVjdC0+Y29ycmVzcG9uZGlu Z0xhYmVsRm9yQ29udHJvbEVsZW1lbnQoKTsKICAgICAgICAgaWYgKGxhYmVsKSB7CiAgICAgICAg ICAgICBBdGtPYmplY3QqIGF0a09iamVjdCA9IGxhYmVsLT53cmFwcGVyKCk7Ci0gICAgICAgICAg ICBpZiAoQVRLX0lTX1RFWFQoYXRrT2JqZWN0KSkKKyAgICAgICAgICAgIC8vIElmIHRoZSBlbWJl ZGRlZCBjb250cm9sIGlzIGEgdGV4dCBmaWVsZCwgdXNlIGl0cyB2YWx1ZS4KKyAgICAgICAgICAg IGlmIChBVEtfSVNfVEVYVChhdGtPYmplY3QpICYmIGNvcmVPYmplY3QtPmlzVGV4dENvbnRyb2wo KSkKICAgICAgICAgICAgICAgICByZXR1cm4gYXRrX3RleHRfZ2V0X3RleHQoQVRLX1RFWFQoYXRr T2JqZWN0KSwgMCwgLTEpOwogICAgICAgICB9CiAK