121287 2013-09-13 03:31:40 -0700 ARM EABI hardfp buildfix after r155675 2013-09-13 08:54:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 108645 117281 1 ossy ossy commit-queue mark.lam msaboff ossy youngho33.yoo zherczeg oldest_to_newest 928747 0 ossy 2013-09-13 03:31:40 -0700 http://trac.webkit.org/changeset/155675 added a JSVALUE32_64 implementation of this function: JITCompiler::Call callOperation(V_DFGOperation_EOZD operation, GPRReg arg1, GPRReg arg2, FPRReg arg3) { m_jit.setupArgumentsWithExecState(arg1, arg2, EABI_32BIT_DUMMY_ARG arg3); ------> !!! return appendCallWithExceptionCheck(operation); } But unfortunately it added only softfp implementation of the following function: ALWAYS_INLINE void setupArgumentsWithExecState(GPRReg arg1, GPRReg arg2, TrustedImm32 arg3, FPRReg arg4) We need hardfp implementation too, which should be same as the GPRReg arg1, GPRReg arg2, FPRReg arg3 implementation, but it should simple ignore the dummy third argument. Fix is coming immediately. 928752 1 211531 ossy 2013-09-13 03:56:06 -0700 Created attachment 211531 Patch I got it. It was only a typo. The third argument is the dummy one, not the first one, similar to the call and the softfp implementation. 928861 2 211531 ggaren 2013-09-13 08:27:03 -0700 Comment on attachment 211531 Patch r=me 928874 3 211531 commit-queue 2013-09-13 08:54:53 -0700 Comment on attachment 211531 Patch Clearing flags on attachment: 211531 Committed r155705: <http://trac.webkit.org/changeset/155705> 928875 4 commit-queue 2013-09-13 08:54:55 -0700 All reviewed patches have been landed. Closing bug. 211531 2013-09-13 03:56:06 -0700 2013-09-13 08:54:53 -0700 Patch bug-121287-20130913035625.patch text/plain 1615 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1Njc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 YmQ1OGNmOTcyMmUwY2I2YmY3ZmM2MTdkNzU5MGE4NDZjZGMzOTM0Li4zZDE5YTJmZWEwOGQxZDcx MjZiNzQ3YzM3NGU5NDQ2YzAyNDMzMWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0wOS0xMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEFSTSBFQUJJIGhhcmRmcCBidWlsZGZpeCBhZnRlciByMTU1Njc1Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjEyODcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdD Q2FsbEhlbHBlcnMuaDoKKyAgICAgICAgKEpTQzo6REZHOjpDQ2FsbEhlbHBlcnM6OnNldHVwQXJn dW1lbnRzV2l0aEV4ZWNTdGF0ZSk6CisKIDIwMTMtMDktMTMgIFlvdW5naG8gWW9vICA8eW91bmdo bzMzLnlvb0BsZ2UuY29tPgogCiAgICAgICAgIEZpeGVkIGNyYXNoIGluIFY4IGJlbmNobWFyayBz dWl0ZSBpbiBBUk0sc29mdHAsRUFCSSBlbnZpcm9ubWVudC4gCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0NDYWxsSGVscGVycy5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdDQ2FsbEhlbHBlcnMuaAppbmRleCBiMjUwNTkxNTZmZGExMzRlNDYzYjA2MDMz MzQwNjA2YzZmZmExMjRmLi5lODZiOWU1ZjA2NjhiMDBlNzY1ZDk5NzFlYjZiMTQ0N2Q1Y2U0MTky IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NDYWxsSGVscGVycy5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ0NhbGxIZWxwZXJzLmgKQEAgLTU3 MiwxMiArNTcyLDEzIEBAIHB1YmxpYzoKICAgICAgICAgbW92ZShHUFJJbmZvOjpjYWxsRnJhbWVS ZWdpc3RlciwgR1BSSW5mbzo6YXJndW1lbnRHUFIwKTsKICAgICB9CiAKLSAgICBBTFdBWVNfSU5M SU5FIHZvaWQgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJbW0zMiwgR1BSUmVn IGFyZzIsIEdQUlJlZyBhcmczLCBGUFJSZWcgYXJnNCkKKyAgICBBTFdBWVNfSU5MSU5FIHZvaWQg c2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKEdQUlJlZyBhcmcxLCBHUFJSZWcgYXJnMiwgVHJ1 c3RlZEltbTMyLCBGUFJSZWcgYXJnNCkKICAgICB7CiAgICAgICAgIG1vdmVEb3VibGUoYXJnNCwg RlBSSW5mbzo6YXJndW1lbnRGUFIwKTsKLSAgICAgICAgc2V0dXBTdHViQXJndW1lbnRzKGFyZzIs IGFyZzMpOworICAgICAgICBzZXR1cFN0dWJBcmd1bWVudHMoYXJnMSwgYXJnMik7CiAgICAgICAg IG1vdmUoR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIsIEdQUkluZm86OmFyZ3VtZW50R1BSMCk7 CiAgICAgfQorCiAjZWxzZQogICAgIEFMV0FZU19JTkxJTkUgdm9pZCBzZXR1cEFyZ3VtZW50cyhG UFJSZWcgYXJnMSkKICAgICB7Cg==