121252 2013-09-12 13:28:13 -0700 [CSS Shapes] Rename shapeContainingBlockHeight to shapeContainingBlockLogicalHeight 2013-09-12 15:55:03 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89256 1 zoltan zoltan commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 928456 0 zoltan 2013-09-12 13:28:13 -0700 We need to rename shapeContainingBlockHeight to shapeContainingBlockLogicalHeight, since it returns the containing block's logical height. 928458 1 211465 zoltan 2013-09-12 13:30:23 -0700 Created attachment 211465 proposed patch 928471 2 211469 zoltan 2013-09-12 13:48:03 -0700 Created attachment 211469 proposed patch 928540 3 211469 commit-queue 2013-09-12 15:55:01 -0700 Comment on attachment 211469 proposed patch Clearing flags on attachment: 211469 Committed r155655: <http://trac.webkit.org/changeset/155655> 928541 4 commit-queue 2013-09-12 15:55:03 -0700 All reviewed patches have been landed. Closing bug. 211465 2013-09-12 13:30:23 -0700 2013-09-12 13:48:03 -0700 proposed patch renameShapeContainingBlockHeight.patch text/plain 3704 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZGY5NDNkLi4wOGQ3NzI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDktMTIgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NTUyBTaGFwZXNdIFJlbmFtZSBzaGFwZUNvbnRhaW5pbmdCbG9ja0hlaWdodCB0byBz aGFwZUNvbnRhaW5pbmdCbG9ja0xvZ2ljYWxIZWlnaHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTI1MmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJs b2NrTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwdXNoU2hhcGVDb250ZW50T3Zl cmZsb3dCZWxvd1RoZUNvbnRlbnRCb3gpOgorICAgICAgICAqIHJlbmRlcmluZy9zaGFwZXMvU2hh cGVJbmZvLmg6CisgICAgICAgIChXZWJDb3JlOjpTaGFwZUluZm86OnNoYXBlQ29udGFpbmluZ0Js b2NrTG9naWNhbEhlaWdodCk6CisKIDIwMTMtMDktMTIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy c2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBTaGFyZWRCdWZmZXI6OmNyZWF0ZU5TRGF0YSBzaG91 bGQgcmV0dXJuIGEgUmV0YWluUHRyPE5TRGF0YT4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKaW5kZXggOTYxOGE4Zi4uZTBkYjQzZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91 dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91 dC5jcHAKQEAgLTE0MDcsMTggKzE0MDcsMTggQEAgc3RhdGljIGlubGluZSB2b2lkIHB1c2hTaGFw ZUNvbnRlbnRPdmVyZmxvd0JlbG93VGhlQ29udGVudEJveChSZW5kZXJCbG9jayogYmxvY2sKIAog ICAgIExheW91dFVuaXQgbG9naWNhbExpbmVCb3R0b20gPSBsaW5lVG9wICsgbGluZUhlaWdodDsK ICAgICBMYXlvdXRVbml0IHNoYXBlTG9naWNhbEJvdHRvbSA9IHNoYXBlSW5zaWRlSW5mby0+c2hh cGVMb2dpY2FsQm90dG9tKCk7Ci0gICAgTGF5b3V0VW5pdCBzaGFwZUNvbnRhaW5pbmdCbG9ja0hl aWdodCA9IHNoYXBlSW5zaWRlSW5mby0+c2hhcGVDb250YWluaW5nQmxvY2tIZWlnaHQoKTsKKyAg ICBMYXlvdXRVbml0IHNoYXBlQ29udGFpbmluZ0Jsb2NrTG9naWNhbEhlaWdodCA9IHNoYXBlSW5z aWRlSW5mby0+c2hhcGVDb250YWluaW5nQmxvY2tMb2dpY2FsSGVpZ2h0KCk7CiAKLSAgICBib29s IGlzT3ZlcmZsb3dQb3NpdGlvbmVkQWxyZWFkeSA9IChzaGFwZUNvbnRhaW5pbmdCbG9ja0hlaWdo dCAtIHNoYXBlSW5zaWRlSW5mby0+b3duZXIoKS0+Ym9yZGVyQW5kUGFkZGluZ0FmdGVyKCkgKyBs aW5lSGVpZ2h0KSA8PSBsaW5lVG9wOworICAgIGJvb2wgaXNPdmVyZmxvd1Bvc2l0aW9uZWRBbHJl YWR5ID0gKHNoYXBlQ29udGFpbmluZ0Jsb2NrTG9naWNhbEhlaWdodCAtIHNoYXBlSW5zaWRlSW5m by0+b3duZXIoKS0+Ym9yZGVyQW5kUGFkZGluZ0FmdGVyKCkgKyBsaW5lSGVpZ2h0KSA8PSBsaW5l VG9wOwogCiAgICAgLy8gSWYgdGhlIGxhc3QgbGluZSBvdmVybGFwcyB3aXRoIHRoZSBzaGFwZSwg d2UgZG9uJ3QgbmVlZCB0aGUgc2VnbWVudHMgYW55bW9yZQogICAgIGlmIChsaW5lVG9wIDwgc2hh cGVMb2dpY2FsQm90dG9tICYmIHNoYXBlTG9naWNhbEJvdHRvbSA8IGxvZ2ljYWxMaW5lQm90dG9t KQogICAgICAgICBzaGFwZUluc2lkZUluZm8tPmNsZWFyU2VnbWVudHMoKTsKIAotICAgIGlmIChs b2dpY2FsTGluZUJvdHRvbSA8PSBzaGFwZUxvZ2ljYWxCb3R0b20gfHwgIXNoYXBlQ29udGFpbmlu Z0Jsb2NrSGVpZ2h0IHx8IGlzT3ZlcmZsb3dQb3NpdGlvbmVkQWxyZWFkeSkKKyAgICBpZiAobG9n aWNhbExpbmVCb3R0b20gPD0gc2hhcGVMb2dpY2FsQm90dG9tIHx8ICFzaGFwZUNvbnRhaW5pbmdC bG9ja0xvZ2ljYWxIZWlnaHQgfHwgaXNPdmVyZmxvd1Bvc2l0aW9uZWRBbHJlYWR5KQogICAgICAg ICByZXR1cm47CiAKLSAgICBMYXlvdXRVbml0IG5ld0xvZ2ljYWxIZWlnaHQgPSBibG9jay0+bG9n aWNhbEhlaWdodCgpICsgKHNoYXBlQ29udGFpbmluZ0Jsb2NrSGVpZ2h0IC0gKGxpbmVUb3AgKyBz aGFwZUluc2lkZUluZm8tPm93bmVyKCktPmJvcmRlckFuZFBhZGRpbmdBZnRlcigpKSk7CisgICAg TGF5b3V0VW5pdCBuZXdMb2dpY2FsSGVpZ2h0ID0gYmxvY2stPmxvZ2ljYWxIZWlnaHQoKSArIChz aGFwZUNvbnRhaW5pbmdCbG9ja0xvZ2ljYWxIZWlnaHQgLSAobGluZVRvcCArIHNoYXBlSW5zaWRl SW5mby0+b3duZXIoKS0+Ym9yZGVyQW5kUGFkZGluZ0FmdGVyKCkpKTsKICAgICBibG9jay0+c2V0 TG9naWNhbEhlaWdodChuZXdMb2dpY2FsSGVpZ2h0KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3NoYXBlcy9TaGFwZUluZm8uaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zaGFwZXMvU2hhcGVJbmZvLmgKaW5kZXggYjVkODBiNy4uZTIxMTkxNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3NoYXBlcy9TaGFwZUluZm8uaAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVzL1NoYXBlSW5mby5oCkBAIC05Niw3ICs5Niw3 IEBAIHB1YmxpYzoKICAgICBMYXlvdXRVbml0IGxvZ2ljYWxMaW5lVG9wKCkgY29uc3QgeyByZXR1 cm4gbV9zaGFwZUxpbmVUb3AgKyBsb2dpY2FsVG9wT2Zmc2V0KCk7IH0KICAgICBMYXlvdXRVbml0 IGxvZ2ljYWxMaW5lQm90dG9tKCkgY29uc3QgeyByZXR1cm4gbV9zaGFwZUxpbmVUb3AgKyBtX2xp bmVIZWlnaHQgKyBsb2dpY2FsVG9wT2Zmc2V0KCk7IH0KIAotICAgIExheW91dFVuaXQgc2hhcGVD b250YWluaW5nQmxvY2tIZWlnaHQoKSBjb25zdCB7IHJldHVybiAobV9yZW5kZXJlci0+c3R5bGUo KS0+Ym94U2l6aW5nKCkgPT0gQ09OVEVOVF9CT1gpID8gKG1fc2hhcGVMb2dpY2FsU2l6ZS5oZWln aHQoKSArIG1fcmVuZGVyZXItPmJvcmRlckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCkpIDogbV9z aGFwZUxvZ2ljYWxTaXplLmhlaWdodCgpOyB9CisgICAgTGF5b3V0VW5pdCBzaGFwZUNvbnRhaW5p bmdCbG9ja0xvZ2ljYWxIZWlnaHQoKSBjb25zdCB7IHJldHVybiAobV9yZW5kZXJlci0+c3R5bGUo KS0+Ym94U2l6aW5nKCkgPT0gQ09OVEVOVF9CT1gpID8gKG1fc2hhcGVMb2dpY2FsU2l6ZS5oZWln aHQoKSArIG1fcmVuZGVyZXItPmJvcmRlckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCkpIDogbV9z aGFwZUxvZ2ljYWxTaXplLmhlaWdodCgpOyB9CiAKICAgICBib29sIGxpbmVPdmVybGFwc1NoYXBl Qm91bmRzKCkgY29uc3QgeyByZXR1cm4gbG9naWNhbExpbmVUb3AoKSA8IHNoYXBlTG9naWNhbEJv dHRvbSgpICYmIHNoYXBlTG9naWNhbFRvcCgpIDw9IGxvZ2ljYWxMaW5lQm90dG9tKCk7IH0KIAo= 211469 2013-09-12 13:48:03 -0700 2013-09-12 15:55:01 -0700 proposed patch renameShapeContainingBlockHeight.patch text/plain 3680 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZGY5NDNkLi4wOGQ3NzI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDktMTIgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NTUyBTaGFwZXNdIFJlbmFtZSBzaGFwZUNvbnRhaW5pbmdCbG9ja0hlaWdodCB0byBz aGFwZUNvbnRhaW5pbmdCbG9ja0xvZ2ljYWxIZWlnaHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTI1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdl LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpwdXNoU2hhcGVDb250ZW50T3ZlcmZsb3dCZWxvd1RoZUNvbnRlbnRCb3gp OgorICAgICAgICAqIHJlbmRlcmluZy9zaGFwZXMvU2hhcGVJbmZvLmg6CisgICAgICAgIChXZWJD b3JlOjpTaGFwZUluZm86OnNoYXBlQ29udGFpbmluZ0Jsb2NrTG9naWNhbEhlaWdodCk6CisKIDIw MTMtMDktMTIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAg ICBTaGFyZWRCdWZmZXI6OmNyZWF0ZU5TRGF0YSBzaG91bGQgcmV0dXJuIGEgUmV0YWluUHRyPE5T RGF0YT4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xp bmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxh eW91dC5jcHAKaW5kZXggOTYxOGE4Zi4uZTBkYjQzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKQEAgLTE0MDcsMTggKzE0MDcs MTggQEAgc3RhdGljIGlubGluZSB2b2lkIHB1c2hTaGFwZUNvbnRlbnRPdmVyZmxvd0JlbG93VGhl Q29udGVudEJveChSZW5kZXJCbG9jayogYmxvY2sKIAogICAgIExheW91dFVuaXQgbG9naWNhbExp bmVCb3R0b20gPSBsaW5lVG9wICsgbGluZUhlaWdodDsKICAgICBMYXlvdXRVbml0IHNoYXBlTG9n aWNhbEJvdHRvbSA9IHNoYXBlSW5zaWRlSW5mby0+c2hhcGVMb2dpY2FsQm90dG9tKCk7Ci0gICAg TGF5b3V0VW5pdCBzaGFwZUNvbnRhaW5pbmdCbG9ja0hlaWdodCA9IHNoYXBlSW5zaWRlSW5mby0+ c2hhcGVDb250YWluaW5nQmxvY2tIZWlnaHQoKTsKKyAgICBMYXlvdXRVbml0IHNoYXBlQ29udGFp bmluZ0Jsb2NrTG9naWNhbEhlaWdodCA9IHNoYXBlSW5zaWRlSW5mby0+c2hhcGVDb250YWluaW5n QmxvY2tMb2dpY2FsSGVpZ2h0KCk7CiAKLSAgICBib29sIGlzT3ZlcmZsb3dQb3NpdGlvbmVkQWxy ZWFkeSA9IChzaGFwZUNvbnRhaW5pbmdCbG9ja0hlaWdodCAtIHNoYXBlSW5zaWRlSW5mby0+b3du ZXIoKS0+Ym9yZGVyQW5kUGFkZGluZ0FmdGVyKCkgKyBsaW5lSGVpZ2h0KSA8PSBsaW5lVG9wOwor ICAgIGJvb2wgaXNPdmVyZmxvd1Bvc2l0aW9uZWRBbHJlYWR5ID0gKHNoYXBlQ29udGFpbmluZ0Js b2NrTG9naWNhbEhlaWdodCAtIHNoYXBlSW5zaWRlSW5mby0+b3duZXIoKS0+Ym9yZGVyQW5kUGFk ZGluZ0FmdGVyKCkgKyBsaW5lSGVpZ2h0KSA8PSBsaW5lVG9wOwogCiAgICAgLy8gSWYgdGhlIGxh c3QgbGluZSBvdmVybGFwcyB3aXRoIHRoZSBzaGFwZSwgd2UgZG9uJ3QgbmVlZCB0aGUgc2VnbWVu dHMgYW55bW9yZQogICAgIGlmIChsaW5lVG9wIDwgc2hhcGVMb2dpY2FsQm90dG9tICYmIHNoYXBl TG9naWNhbEJvdHRvbSA8IGxvZ2ljYWxMaW5lQm90dG9tKQogICAgICAgICBzaGFwZUluc2lkZUlu Zm8tPmNsZWFyU2VnbWVudHMoKTsKIAotICAgIGlmIChsb2dpY2FsTGluZUJvdHRvbSA8PSBzaGFw ZUxvZ2ljYWxCb3R0b20gfHwgIXNoYXBlQ29udGFpbmluZ0Jsb2NrSGVpZ2h0IHx8IGlzT3ZlcmZs b3dQb3NpdGlvbmVkQWxyZWFkeSkKKyAgICBpZiAobG9naWNhbExpbmVCb3R0b20gPD0gc2hhcGVM b2dpY2FsQm90dG9tIHx8ICFzaGFwZUNvbnRhaW5pbmdCbG9ja0xvZ2ljYWxIZWlnaHQgfHwgaXNP dmVyZmxvd1Bvc2l0aW9uZWRBbHJlYWR5KQogICAgICAgICByZXR1cm47CiAKLSAgICBMYXlvdXRV bml0IG5ld0xvZ2ljYWxIZWlnaHQgPSBibG9jay0+bG9naWNhbEhlaWdodCgpICsgKHNoYXBlQ29u dGFpbmluZ0Jsb2NrSGVpZ2h0IC0gKGxpbmVUb3AgKyBzaGFwZUluc2lkZUluZm8tPm93bmVyKCkt PmJvcmRlckFuZFBhZGRpbmdBZnRlcigpKSk7CisgICAgTGF5b3V0VW5pdCBuZXdMb2dpY2FsSGVp Z2h0ID0gYmxvY2stPmxvZ2ljYWxIZWlnaHQoKSArIChzaGFwZUNvbnRhaW5pbmdCbG9ja0xvZ2lj YWxIZWlnaHQgLSAobGluZVRvcCArIHNoYXBlSW5zaWRlSW5mby0+b3duZXIoKS0+Ym9yZGVyQW5k UGFkZGluZ0FmdGVyKCkpKTsKICAgICBibG9jay0+c2V0TG9naWNhbEhlaWdodChuZXdMb2dpY2Fs SGVpZ2h0KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3NoYXBl cy9TaGFwZUluZm8uaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zaGFwZXMvU2hhcGVJbmZv LmgKaW5kZXggYjVkODBiNy4uZTIxMTkxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3NoYXBlcy9TaGFwZUluZm8uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c2hhcGVzL1NoYXBlSW5mby5oCkBAIC05Niw3ICs5Niw3IEBAIHB1YmxpYzoKICAgICBMYXlvdXRV bml0IGxvZ2ljYWxMaW5lVG9wKCkgY29uc3QgeyByZXR1cm4gbV9zaGFwZUxpbmVUb3AgKyBsb2dp Y2FsVG9wT2Zmc2V0KCk7IH0KICAgICBMYXlvdXRVbml0IGxvZ2ljYWxMaW5lQm90dG9tKCkgY29u c3QgeyByZXR1cm4gbV9zaGFwZUxpbmVUb3AgKyBtX2xpbmVIZWlnaHQgKyBsb2dpY2FsVG9wT2Zm c2V0KCk7IH0KIAotICAgIExheW91dFVuaXQgc2hhcGVDb250YWluaW5nQmxvY2tIZWlnaHQoKSBj b25zdCB7IHJldHVybiAobV9yZW5kZXJlci0+c3R5bGUoKS0+Ym94U2l6aW5nKCkgPT0gQ09OVEVO VF9CT1gpID8gKG1fc2hhcGVMb2dpY2FsU2l6ZS5oZWlnaHQoKSArIG1fcmVuZGVyZXItPmJvcmRl ckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCkpIDogbV9zaGFwZUxvZ2ljYWxTaXplLmhlaWdodCgp OyB9CisgICAgTGF5b3V0VW5pdCBzaGFwZUNvbnRhaW5pbmdCbG9ja0xvZ2ljYWxIZWlnaHQoKSBj b25zdCB7IHJldHVybiAobV9yZW5kZXJlci0+c3R5bGUoKS0+Ym94U2l6aW5nKCkgPT0gQ09OVEVO VF9CT1gpID8gKG1fc2hhcGVMb2dpY2FsU2l6ZS5oZWlnaHQoKSArIG1fcmVuZGVyZXItPmJvcmRl ckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCkpIDogbV9zaGFwZUxvZ2ljYWxTaXplLmhlaWdodCgp OyB9CiAKICAgICBib29sIGxpbmVPdmVybGFwc1NoYXBlQm91bmRzKCkgY29uc3QgeyByZXR1cm4g bG9naWNhbExpbmVUb3AoKSA8IHNoYXBlTG9naWNhbEJvdHRvbSgpICYmIHNoYXBlTG9naWNhbFRv cCgpIDw9IGxvZ2ljYWxMaW5lQm90dG9tKCk7IH0KIAo=