120890 2013-09-06 13:12:56 -0700 Concurrent FTL causes !hasOptimizedReplacement() asserts in cti_optimize 2013-09-06 13:19:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 925805 0 fpizlo 2013-09-06 13:12:56 -0700 This is because the FTL may install an optimized replacement while the DFG has already been jettisoned - so then the baseline JIT's cti_optimize sees an on-going DFG compile to reoptimize the code while also seeing an FTL optimized replacement. 925807 1 210786 fpizlo 2013-09-06 13:13:51 -0700 Created attachment 210786 the patch 925809 2 210786 fpizlo 2013-09-06 13:17:16 -0700 Comment on attachment 210786 the patch r=mark 925812 3 fpizlo 2013-09-06 13:19:32 -0700 Landed in http://trac.webkit.org/changeset/155209 210786 2013-09-06 13:13:51 -0700 2013-09-06 13:17:16 -0700 the patch blah.patch text/plain 1661 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1MjA4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA5LTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Q29uY3VycmVudCBGVEwgY2F1c2VzICFoYXNPcHRpbWl6ZWRSZXBsYWNlbWVudCgpIGFzc2VydHMg aW4gY3RpX29wdGltaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjA4OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAg ICAgICAgCisgICAgICAgIERvbid0IGluc3RhbGwgYW4gRlRMIGNvZGUgYmxvY2sgaWYgdGhlIERG RyBjb2RlIGJsb2NrIGhhcyBhbHJlYWR5IGJlZW4gamV0dGlzb25lZC4KKworICAgICAgICAqIGRm Zy9ERkdUb0ZUTERlZmVycmVkQ29tcGlsYXRpb25DYWxsYmFjay5jcHA6CisgICAgICAgIChKU0M6 OkRGRzo6VG9GVExEZWZlcnJlZENvbXBpbGF0aW9uQ2FsbGJhY2s6OmNvbXBpbGF0aW9uRGlkQ29t cGxldGUpOgorCiAyMDEzLTA5LTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTigxNDk2MzYsIG1lcmdlZCBpbiAxNTMxNDUpOiBUb1RoaXMgY29u dmVyc2lvbiBkb2Vzbid0IHdvcmsgaW4gdGhlIERGRwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdUb0ZUTERlZmVycmVkQ29tcGlsYXRpb25DYWxsYmFjay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdUb0ZUTERlZmVycmVkQ29tcGlsYXRp b25DYWxsYmFjay5jcHAJKHJldmlzaW9uIDE1NTIwMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHVG9GVExEZWZlcnJlZENvbXBpbGF0aW9uQ2FsbGJhY2suY3BwCSh3b3JraW5nIGNv cHkpCkBAIC03MCw2ICs3MCwxNSBAQCB2b2lkIFRvRlRMRGVmZXJyZWRDb21waWxhdGlvbkNhbGxi YWNrOjpjCiAgICAgICAgICAgICAiKSByZXN1bHQ6ICIsIHJlc3VsdCwgIlxuIik7CiAgICAgfQog ICAgIAorICAgIGlmIChtX2RmZ0NvZGVCbG9jay0+cmVwbGFjZW1lbnQoKSAhPSBtX2RmZ0NvZGVC bG9jaykgeworICAgICAgICBpZiAoT3B0aW9uczo6dmVyYm9zZU9TUigpKSB7CisgICAgICAgICAg ICBkYXRhTG9nKAorICAgICAgICAgICAgICAgICJEcm9wcGluZyBGVEwgY29kZSBibG9jayAiLCAq Y29kZUJsb2NrLCAiIG9uIHRoZSBmbG9vciBiZWNhdXNlIHRoZSAiCisgICAgICAgICAgICAgICAg IkRGRyBjb2RlIGJsb2NrICIsICptX2RmZ0NvZGVCbG9jaywgIiB3YXMgamV0dGlzb25lZC5cbiIp OworICAgICAgICB9CisgICAgICAgIHJldHVybjsKKyAgICB9CisgICAgCiAgICAgaWYgKHJlc3Vs dCA9PSBDb21waWxhdGlvblN1Y2Nlc3NmdWwpCiAgICAgICAgIGNvZGVCbG9jay0+aW5zdGFsbCgp OwogICAgIAo=