120847 2013-09-06 03:55:20 -0700 [Qt] REGRESSION(r155140) Pixel tests is still broken on Qt with QT_WEBKIT_DISABLE_UIPROCESS_DUMPPIXELS=1 2013-09-06 06:34:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 120715 1 abrhm abrhm allan.jensen commit-queue ossy oldest_to_newest 925501 0 abrhm 2013-09-06 03:55:20 -0700 The whole force repaint code should be in if (PlatformWebView::windowShapshotEnabled()) block, as the previous Qt implementation. 925519 1 210723 abrhm 2013-09-06 05:51:43 -0700 Created attachment 210723 proposed fix 925522 2 210723 ossy 2013-09-06 05:59:59 -0700 Comment on attachment 210723 proposed fix LGTM, r=me. 925528 3 210723 ossy 2013-09-06 06:32:04 -0700 Comment on attachment 210723 proposed fix Clearing flags on attachment: 210723 Committed r155188: <http://trac.webkit.org/changeset/155188> 925530 4 ossy 2013-09-06 06:32:09 -0700 All reviewed patches have been landed. Closing bug. 925588 5 commit-queue 2013-09-06 06:34:54 -0700 The commit-queue encountered the following flaky tests while processing attachment 210723: http/tests/inspector/inspect-element.html bug 78869 (author: pfeldman@chromium.org) ietestcenter/css3/grid/grid-column-002.htm bug 120851 (authors: dtharp@codeaurora.org, jchaffraix@webkit.org, and mrobinson@webkit.org) ietestcenter/css3/multicolumn/column-width-applies-to-004.htm bug 120852 (author: dtharp@codeaurora.org) ietestcenter/css3/multicolumn/column-width-applies-to-014.htm bug 120853 (author: dtharp@codeaurora.org) ietestcenter/css3/multicolumn/column-containing-block-003.htm bug 120854 (author: dtharp@codeaurora.org) ietestcenter/css3/multicolumn/column-width-applies-to-003.htm bug 120855 (author: dtharp@codeaurora.org) ietestcenter/css3/multicolumn/column-width-applies-to-002.htm bug 120856 (author: dtharp@codeaurora.org) ietestcenter/css3/multicolumn/column-width-applies-to-013.htm bug 120857 (author: dtharp@codeaurora.org) ietestcenter/css3/multicolumn/column-width-applies-to-001.htm bug 120858 (author: dtharp@codeaurora.org) ietestcenter/css3/multicolumn/column-block-formatting-context-001.htm bug 120859 (author: dtharp@codeaurora.org) fast/regions/counters/extract-list-items-006.html bug 120736 (author: abucur@adobe.com) fast/regions/counters/extract-list-items-015.html bug 120737 (author: abucur@adobe.com) fast/regions/counters/extract-numbered-paragraphs-divs-002.html bug 120738 (author: abucur@adobe.com) fast/regions/counters/extract-list-items-003.html bug 120739 (author: abucur@adobe.com) fast/regions/counters/extract-list-items-001.html bug 120740 (author: abucur@adobe.com) fast/regions/counters/extract-list-items-013.html bug 120741 (author: abucur@adobe.com) fast/regions/counters/extract-list-items-014.html bug 120742 (author: abucur@adobe.com) fast/shapes/shape-outside-floats/shape-outside-floats-image-002.html bug 120753 (author: giles_joplin@yahoo.com) fast/shapes/shape-outside-floats/shape-outside-floats-image-001.html bug 120754 (author: giles_joplin@yahoo.com) fast/multicol/newmulticol/float-paginate.html bug 120744 (author: hyatt@apple.com) fast/multicol/newmulticol/columns-shorthand-parsing.html bug 120745 fast/multicol/newmulticol/float-paginate-complex.html bug 120746 (author: hyatt@apple.com) fast/multicol/newmulticol/direct-child-column-span-all.html bug 120747 (author: mmaerean@adobe.com) fast/multicol/newmulticol/column-rules-fixed-height.html bug 120748 (author: hyatt@apple.com) fast/multicol/newmulticol/positioned-split.html bug 120749 (author: hyatt@apple.com) fast/multicol/newmulticol/layers-in-multicol.html bug 120750 (author: hyatt@apple.com) fast/multicol/newmulticol/positioned-with-constrained-height.html bug 120751 (author: hyatt@apple.com) loader/go-back-to-different-window-size.html bug 114274 (authors: adachan@apple.com and rniwa@webkit.org) svg/text/add-tspan-position-bug.html bug 120860 (authors: fmalita@chromium.org and zimmermann@kde.org) animations/cross-fade-background-image.html bug 120755 (authors: krit@webkit.org and thorton@apple.com) The commit-queue is continuing to process your patch. 210723 2013-09-06 05:51:43 -0700 2013-09-06 06:32:04 -0700 proposed fix patch43.patch text/plain 5214 abrhm ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZWM3 OTQxLi5lMTI3ODljIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTMtMDktMDYgIEdhYm9yIEFicmFoYW0gIDxhYnJo bUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgW1F0XSBSRUdSRVNTSU9OKHIxNTUxNDApIFBp eGVsIHRlc3RzIGlzIHN0aWxsIGJyb2tlbiBvbiBRdCB3aXRoIFFUX1dFQktJVF9ESVNBQkxFX1VJ UFJPQ0VTU19EVU1QUElYRUxTPTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMDg0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1vdmUgdGhlIGZvcmNlIHJlcGFpbnQgY29kZSBiYWNrIHRvIGlmIChQbGF0 Zm9ybVdlYlZpZXc6OndpbmRvd1NuYXBzaG90RW5hYmxlZCgpKSBibG9jayB0byBzdXBwb3J0IFF0 LgorICAgICAgICBUeXBvIGZpeGVkOiB3aW5kb3dTaGFwc2hvdEVuYWJsZWQgLT4gd2luZG93U25h cHNob3RFbmFibGVkLgorICAgICAgICBBZGQgYSBkZWZhdWx0IFBsYXRmb3JtV2ViVmlldzo6d2lu ZG93U25hcHNob3RFbmFibGVkKCkgdG8gdGhlICFQTEFURk9STShRVCkuCisKKyAgICAgICAgKiBX ZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtV2ViVmlldy5oOgorICAgICAgICAoV1RSOjpQbGF0Zm9y bVdlYlZpZXc6OndpbmRvd1NuYXBzaG90RW5hYmxlZCk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1 bm5lci9UZXN0SW52b2NhdGlvbi5jcHA6CisgICAgICAgIChXVFI6OlRlc3RJbnZvY2F0aW9uOjpk dW1wUmVzdWx0cyk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZp ZXdRdC5jcHA6CisgICAgICAgIChXVFI6OldyYXBwZXJXaW5kb3c6OmhhbmRsZVN0YXR1c0NoYW5n ZWQpOgorICAgICAgICAoV1RSOjpQbGF0Zm9ybVdlYlZpZXc6OndpbmRvd1NuYXBzaG90RW5hYmxl ZCk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9xdC9UZXN0SW52b2NhdGlvblF0LmNwcDoK KyAgICAgICAgKFdUUjo6VGVzdEludm9jYXRpb246OmR1bXBQaXhlbHNBbmRDb21wYXJlV2l0aEV4 cGVjdGVkKToKKwogMjAxMy0wOS0wNiAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVu c2VuQGRpZ2lhLmNvbT4KIAogICAgICAgICBbUXRdW1dLMl0gV2luZG93IHVzZWQgYnkgV2ViS2l0 VGVzdFJ1bm5lciBsb3NlcyBhY3RpdmUgc3RhdHVzCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL1BsYXRmb3JtV2ViVmlldy5oIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0 Zm9ybVdlYlZpZXcuaAppbmRleCA5OGQ4ODI3Li4xNDk3ODI1IDEwMDY0NAotLS0gYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtV2ViVmlldy5oCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvUGxhdGZvcm1XZWJWaWV3LmgKQEAgLTgxLDcgKzgxLDExIEBAIHB1YmxpYzoKICAgICBi b29sIHNlbmRFdmVudChRRXZlbnQqKTsKICAgICB2b2lkIHBvc3RFdmVudChRRXZlbnQqKTsKICAg ICB2b2lkIHNldE1vZGFsRXZlbnRMb29wKFFFdmVudExvb3AqIGV2ZW50TG9vcCkgeyBtX21vZGFs RXZlbnRMb29wID0gZXZlbnRMb29wOyB9Ci0gICAgc3RhdGljIGJvb2wgd2luZG93U2hhcHNob3RF bmFibGVkKCk7CisgICAgLy8gV2luZG93IHNuYXBzaG90IGNhbiBiZSBkaXNhYmxlZCBvbiBRdCB3 aXRoIFFUX1dFQktJVF9ESVNBQkxFX1VJUFJPQ0VTU19EVU1QUElYRUxTPTEgZW52aXJvbm1lbnQg dmFyaWFibGUgKG5lY2Vzc2FyeSBmb3IgeHZmYikKKyAgICBzdGF0aWMgYm9vbCB3aW5kb3dTbmFw c2hvdEVuYWJsZWQoKTsKKyNlbHNlCisgICAgLy8gV2luZG93IHNuYXBzaG90IGlzIGFsd2F5cyBl bmFibGVkIGJ5IGRlZmF1bHQgb24gYWxsIG90aGVyIHBsYXRmb3JtLgorICAgIHN0YXRpYyBib29s IHdpbmRvd1NuYXBzaG90RW5hYmxlZCgpIHsgcmV0dXJuIHRydWU7IH0KICNlbmRpZgogCiAgICAg V0tSZWN0IHdpbmRvd0ZyYW1lKCk7CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L1Rlc3RJbnZvY2F0aW9uLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRp b24uY3BwCmluZGV4IGY1ODQyYWIuLmI0ZmY0NmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv VGVzdEludm9jYXRpb24uY3BwCkBAIC0zMjQsMTMgKzMyNCwxNSBAQCB2b2lkIFRlc3RJbnZvY2F0 aW9uOjpkdW1wUmVzdWx0cygpCiAgICAgICAgIGR1bXBBdWRpbyhtX2F1ZGlvUmVzdWx0LmdldCgp KTsKIAogICAgIGlmIChtX2R1bXBQaXhlbHMgJiYgbV9waXhlbFJlc3VsdCkgewotICAgICAgICBt X2dvdFJlcGFpbnQgPSBmYWxzZTsKLSAgICAgICAgV0tQYWdlRm9yY2VSZXBhaW50KFRlc3RDb250 cm9sbGVyOjpzaGFyZWQoKS5tYWluV2ViVmlldygpLT5wYWdlKCksIHRoaXMsIFRlc3RJbnZvY2F0 aW9uOjpmb3JjZVJlcGFpbnREb25lQ2FsbGJhY2spOwotICAgICAgICBUZXN0Q29udHJvbGxlcjo6 c2hhcmVkKCkucnVuVW50aWwobV9nb3RSZXBhaW50LCBUZXN0Q29udHJvbGxlcjo6U2hvcnRUaW1l b3V0KTsKLSAgICAgICAgaWYgKCFtX2dvdFJlcGFpbnQpIHsKLSAgICAgICAgICAgIG1fZXJyb3JN ZXNzYWdlID0gIlRpbWVkIG91dCB3YWl0aW5nIGZvciBwcmUtcGl4ZWwgZHVtcCByZXBhaW50XG4i OwotICAgICAgICAgICAgbV93ZWJQcm9jZXNzSXNVbnJlc3BvbnNpdmUgPSB0cnVlOwotICAgICAg ICAgICAgcmV0dXJuOworICAgICAgICBpZiAoUGxhdGZvcm1XZWJWaWV3Ojp3aW5kb3dTbmFwc2hv dEVuYWJsZWQoKSkgeworICAgICAgICAgICAgbV9nb3RSZXBhaW50ID0gZmFsc2U7CisgICAgICAg ICAgICBXS1BhZ2VGb3JjZVJlcGFpbnQoVGVzdENvbnRyb2xsZXI6OnNoYXJlZCgpLm1haW5XZWJW aWV3KCktPnBhZ2UoKSwgdGhpcywgVGVzdEludm9jYXRpb246OmZvcmNlUmVwYWludERvbmVDYWxs YmFjayk7CisgICAgICAgICAgICBUZXN0Q29udHJvbGxlcjo6c2hhcmVkKCkucnVuVW50aWwobV9n b3RSZXBhaW50LCBUZXN0Q29udHJvbGxlcjo6U2hvcnRUaW1lb3V0KTsKKyAgICAgICAgICAgIGlm ICghbV9nb3RSZXBhaW50KSB7CisgICAgICAgICAgICAgICAgbV9lcnJvck1lc3NhZ2UgPSAiVGlt ZWQgb3V0IHdhaXRpbmcgZm9yIHByZS1waXhlbCBkdW1wIHJlcGFpbnRcbiI7CisgICAgICAgICAg ICAgICAgbV93ZWJQcm9jZXNzSXNVbnJlc3BvbnNpdmUgPSB0cnVlOworICAgICAgICAgICAgICAg IHJldHVybjsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICBkdW1wUGl4ZWxzQW5k Q29tcGFyZVdpdGhFeHBlY3RlZChtX3BpeGVsUmVzdWx0LmdldCgpLCBtX3JlcGFpbnRSZWN0cy5n ZXQoKSk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0 Zm9ybVdlYlZpZXdRdC5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1BsYXRmb3JtV2Vi Vmlld1F0LmNwcAppbmRleCBmMWM3YjNjLi41MTBiMDQ2IDEwMDY0NAotLS0gYS9Ub29scy9XZWJL aXRUZXN0UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcAorKysgYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcApAQCAtNjUsNyArNjUsNyBAQCBwcml2 YXRlIFFfU0xPVFM6CiAgICAgICAgIG1fdmlldy0+c2V0UGFyZW50SXRlbShyb290T2JqZWN0KCkp OwogICAgICAgICBRUW1sUHJvcGVydHk6OndyaXRlKG1fdmlldywgImFuY2hvcnMuZmlsbCIsIHFW YXJpYW50RnJvbVZhbHVlKHJvb3RPYmplY3QoKSkpOwogCi0gICAgICAgIGlmIChQbGF0Zm9ybVdl YlZpZXc6OndpbmRvd1NoYXBzaG90RW5hYmxlZCgpKSB7CisgICAgICAgIGlmIChQbGF0Zm9ybVdl YlZpZXc6OndpbmRvd1NuYXBzaG90RW5hYmxlZCgpKSB7CiAgICAgICAgICAgICBzZXRTdXJmYWNl VHlwZShPcGVuR0xTdXJmYWNlKTsKICAgICAgICAgICAgIGNyZWF0ZSgpOwogI2lmIFFUX1ZFUlNJ T04gPCBRVF9WRVJTSU9OX0NIRUNLKDUsIDEsIDApCkBAIC0xNzUsNyArMTc1LDcgQEAgV0tSZXRh aW5QdHI8V0tJbWFnZVJlZj4gUGxhdGZvcm1XZWJWaWV3Ojp3aW5kb3dTbmFwc2hvdEltYWdlKCkK ICAgICByZXR1cm4gYWRvcHRXSyhXS0ltYWdlQ3JlYXRlRnJvbVFJbWFnZShtX3dpbmRvdy0+Z3Jh YldpbmRvdygpKSk7CiB9CiAKLWJvb2wgUGxhdGZvcm1XZWJWaWV3Ojp3aW5kb3dTaGFwc2hvdEVu YWJsZWQoKQorYm9vbCBQbGF0Zm9ybVdlYlZpZXc6OndpbmRvd1NuYXBzaG90RW5hYmxlZCgpCiB7 CiAgICAgLy8gV2UgbmVlZCBhIHdheSB0byBkaXNhYmxlIFVJIHNpZGUgcmVuZGVyaW5nIGZvciB0 ZXN0cyBiZWNhdXNlIGl0IGlzCiAgICAgLy8gdG9vIHNsb3cgd2l0aG91dCBhcHByb3ByaWF0ZSBo YXJkd2FyZS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvVGVzdEludm9j YXRpb25RdC5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1Rlc3RJbnZvY2F0aW9uUXQu Y3BwCmluZGV4IDhmN2JlMDkuLmFjNmFhZjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvcXQvVGVzdEludm9jYXRpb25RdC5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9xdC9UZXN0SW52b2NhdGlvblF0LmNwcApAQCAtNjcsNyArNjcsNyBAQCBzdGF0aWMgdm9pZCBk dW1wSW1hZ2UoY29uc3QgUUltYWdlJiBpbWFnZSkKIHZvaWQgVGVzdEludm9jYXRpb246OmR1bXBQ aXhlbHNBbmRDb21wYXJlV2l0aEV4cGVjdGVkKFdLSW1hZ2VSZWYgaW1hZ2VSZWYsIFdLQXJyYXlS ZWYgcmVwYWludFJlY3RzKQogewogICAgIFFJbWFnZSBpbWFnZTsKLSAgICBpZiAoUGxhdGZvcm1X ZWJWaWV3Ojp3aW5kb3dTaGFwc2hvdEVuYWJsZWQoKSkgeworICAgIGlmIChQbGF0Zm9ybVdlYlZp ZXc6OndpbmRvd1NuYXBzaG90RW5hYmxlZCgpKSB7CiAgICAgICAgIGltYWdlID0gV0tJbWFnZUNy ZWF0ZVFJbWFnZShUZXN0Q29udHJvbGxlcjo6c2hhcmVkKCkubWFpbldlYlZpZXcoKS0+d2luZG93 U25hcHNob3RJbWFnZSgpLmdldCgpKTsKICAgICB9IGVsc2UKICAgICAgICAgaW1hZ2UgPSBXS0lt YWdlQ3JlYXRlUUltYWdlKGltYWdlUmVmKTsK