120843 2013-09-06 03:29:23 -0700 REGRESSION(r155140) Broke pixel tests on EFL/GTK/Qt 2013-09-06 08:54:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 120715 1 allan.jensen allan.jensen abrhm commit-queue ossy simon.fraser thorton oldest_to_newest 925486 0 allan.jensen 2013-09-06 03:29:23 -0700 The new common implementatino of forceRepaintDoneCallback is missing the important notifyDone() callback which the non-Apple ports use. 925490 1 abrhm 2013-09-06 03:34:42 -0700 I'm on it, I have the fix soon. 925491 2 210718 allan.jensen 2013-09-06 03:36:00 -0700 Created attachment 210718 Patch 925494 3 abrhm 2013-09-06 03:46:06 -0700 I found another bug, I will upload the fix soon. 925497 4 abrhm 2013-09-06 03:50:31 -0700 Additionally the whole force repaint code should be in if (PlatformWebView::windowShapshotEnabled()) block, as the previous Qt implementation. By the way I think it should be windowSnapshotEnabled. 925499 5 210718 ossy 2013-09-06 03:53:34 -0700 Comment on attachment 210718 Patch LGTM, r=me 925500 6 ossy 2013-09-06 03:54:42 -0700 (In reply to comment #4) > Additionally the whole force repaint code should be in if (PlatformWebView::windowShapshotEnabled()) block, as the previous Qt implementation. > By the way I think it should be windowSnapshotEnabled. Nice catch. I think it can be done in a separated patch. Could you file a bug report and upload your fix? 925508 7 210718 commit-queue 2013-09-06 05:06:47 -0700 Comment on attachment 210718 Patch Clearing flags on attachment: 210718 Committed r155187: <http://trac.webkit.org/changeset/155187> 925509 8 commit-queue 2013-09-06 05:06:50 -0700 All reviewed patches have been landed. Closing bug. 925602 9 simon.fraser 2013-09-06 08:54:06 -0700 Sorry about that. It wasn't obvious to me whether the notifyDone was needed. 210718 2013-09-06 03:36:00 -0700 2013-09-06 05:06:47 -0700 Patch bug-120843-20130906123558.patch text/plain 1497 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MTgzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2VjNzk0MTdmMmFjMmI1NWM4MjViOTRkMzc4ZTkyMjNi ZTQ4MTQyYi4uZDMwYjgwOWM0YjJiYmE5YmNlNzcxODJkZTFkZjdlNmM5NmI2ODMxNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDEzLTA5LTA2ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGln aWEuY29tPgogCisgICAgICAgIFJFR1JFU1NJT04ocjE1NTE0MCkgQnJva2UgcGl4ZWwgdGVzdHMg b24gRUZML0dUSy9RdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTIwODQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ2FsbCBub3RpZnlEb25lIGxpa2UgdGhlIHBsYXRmb3JtIHNwZWNpZmljIGZvcmNlUmVw YWludERvbmVDYWxsYmFjayBtZXRob2RzCisgICAgICAgIGl0IHJlcGxhY2VkIGRpZC4gVGhlIG1l dGhvZCBpcyBlbXB0eSBvbiB0aGUgQXBwbGUgcG9ydHMuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0 UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdEludm9jYXRpb246 OmZvcmNlUmVwYWludERvbmVDYWxsYmFjayk6CisKKzIwMTMtMDktMDYgIEFsbGFuIFNhbmRmZWxk IEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKICAgICAgICAgW1F0XVtXSzJdIFdp bmRvdyB1c2VkIGJ5IFdlYktpdFRlc3RSdW5uZXIgbG9zZXMgYWN0aXZlIHN0YXR1cwogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwNzc0CiAKZGlmZiAt LWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5jcHAKaW5kZXggZjU4NDJhYjY0YWVkZGZm OTljYmZhYWFjZWMxMGRlYTQ3MTZiM2ExZi4uZGZiZmYxYjg5ZjlhNjFmNzg0MmZkZTRkM2MxMjcx NWQwOTQ2ZjFhZSAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2Nh dGlvbi5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5jcHAK QEAgLTMxNCw2ICszMTQsNyBAQCB2b2lkIFRlc3RJbnZvY2F0aW9uOjpmb3JjZVJlcGFpbnREb25l Q2FsbGJhY2soV0tFcnJvclJlZiwgdm9pZCogY29udGV4dCkKIHsKICAgICBUZXN0SW52b2NhdGlv biogdGVzdEludm9jYXRpb24gPSBzdGF0aWNfY2FzdDxUZXN0SW52b2NhdGlvbio+KGNvbnRleHQp OwogICAgIHRlc3RJbnZvY2F0aW9uLT5tX2dvdFJlcGFpbnQgPSB0cnVlOworICAgIFRlc3RDb250 cm9sbGVyOjpzaGFyZWQoKS5ub3RpZnlEb25lKCk7CiB9CiAKIHZvaWQgVGVzdEludm9jYXRpb246 OmR1bXBSZXN1bHRzKCkK