120763 2013-09-05 02:10:00 -0700 [GTK][WK2] Update ContextMenu Download API 2013-09-09 06:04:32 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 brian.holt brian.holt cgarcia commit-queue gustavo mrobinson pnormand oldest_to_newest 924933 0 brian.holt 2013-09-05 02:10:00 -0700 From https://bugs.webkit.org/show_bug.cgi?id=120459. The new tags to download media to disk should be merged into the 2.2 release so the docs need updating. Also, a new unit test for the audio tag should be added. 925074 1 210627 brian.holt 2013-09-05 09:24:30 -0700 Created attachment 210627 Patch 925075 2 210627 brian.holt 2013-09-05 09:27:07 -0700 Comment on attachment 210627 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210627&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.h:75 > + * @WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK: Download video to disk. Since 2.2 Unfortunately this doesn't result in the enum appearing under the Since 2.2 section of the docs... Perhaps there is a different way, or it doesn't matter? > Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp:324 > + iter = checkCurrentItemIsStockActionAndGetNext(iter, WEBKIT_CONTEXT_MENU_ACTION_ENTER_VIDEO_FULLSCREEN, Visible); This surprised me, but without it the test will not pass! 925076 3 commit-queue 2013-09-05 09:27:39 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 926671 4 210627 commit-queue 2013-09-09 06:04:27 -0700 Comment on attachment 210627 Patch Clearing flags on attachment: 210627 Committed r155345: <http://trac.webkit.org/changeset/155345> 926672 5 commit-queue 2013-09-09 06:04:32 -0700 All reviewed patches have been landed. Closing bug. 210627 2013-09-05 09:24:30 -0700 2013-09-09 06:04:27 -0700 Patch bug-120763-20130905172517.patch text/plain 6000 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDMxOGEyODExY2I3NGFi ZjZiMmUyNzM5NWM3NWMwMTdjYTMxNWI2Ny4uMGMxOThkOWQzZTNhNTIzODNjYjU3Yzg3ODFmZTk2 NmUyNDU3ZjBmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA5LTA1ICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXVtXSzJdIFVw ZGF0ZSBDb250ZXh0TWVudSBEb3dubG9hZCBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDc2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1hcmsgdGhlIG5ldyBEb3dubG9hZCBpdGVtcyBpbiB0aGUg Q29udGV4dCBNZW51IHdpdGggdGhlIFNpbmNlCisgICAgICAgIHRhZywgYW5kIGluY2x1ZGUgYSB1 bml0IHRlc3QgZm9yIENvbnRleHQgTWVudSBhdWRpby4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdENvbnRleHRNZW51QWN0aW9ucy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZ3RrL3Rlc3RzL1Rlc3RDb250ZXh0TWVudS5jcHA6CisgICAgICAgICh0ZXN0Q29udGV4dE1l bnVEZWZhdWx0TWVudSk6CisKIDIwMTMtMDktMDMgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNTQ5NjcpIHdpbmRvdyByZXNpemUgaXMgdmVy eSBjaG9wcHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdENvbnRleHRNZW51QWN0aW9ucy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0Q29udGV4dE1lbnVBY3Rpb25zLmgKaW5kZXggNWExNzlkZmE1ZWMwNGEzZGRmNTA2 MmQ4ZDMwMGI3YTBjNTAyNzYzOC4uYzhjOWEwZGFkZDc2ZDZlMmU4YzY2N2VkMzEzODJjYjJlYTMy ZmQzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 Q29udGV4dE1lbnVBY3Rpb25zLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0Q29udGV4dE1lbnVBY3Rpb25zLmgKQEAgLTcyLDggKzcyLDggQEAgR19CRUdJTl9E RUNMUwogICogQFdFQktJVF9DT05URVhUX01FTlVfQUNUSU9OX01FRElBX1BMQVk6IFBsYXkgY3Vy cmVudCBtZWRpYSBlbGVtZW50LgogICogQFdFQktJVF9DT05URVhUX01FTlVfQUNUSU9OX01FRElB X1BBVVNFOiBQYXVzZSBjdXJyZW50IG1lZGlhIGVsZW1lbnQuCiAgKiBAV0VCS0lUX0NPTlRFWFRf TUVOVV9BQ1RJT05fTUVESUFfTVVURTogTXV0ZSBjdXJyZW50IG1lZGlhIGVsZW1lbnQuCi0gKiBA V0VCS0lUX0NPTlRFWFRfTUVOVV9BQ1RJT05fRE9XTkxPQURfVklERU9fVE9fRElTSzogRG93bmxv YWQgdmlkZW8gdG8gZGlzay4KLSAqIEBXRUJLSVRfQ09OVEVYVF9NRU5VX0FDVElPTl9ET1dOTE9B RF9BVURJT19UT19ESVNLOiBEb3dubG9hZCBhdWRpbyB0byBkaXNrLgorICogQFdFQktJVF9DT05U RVhUX01FTlVfQUNUSU9OX0RPV05MT0FEX1ZJREVPX1RPX0RJU0s6IERvd25sb2FkIHZpZGVvIHRv IGRpc2suIFNpbmNlIDIuMgorICogQFdFQktJVF9DT05URVhUX01FTlVfQUNUSU9OX0RPV05MT0FE X0FVRElPX1RPX0RJU0s6IERvd25sb2FkIGF1ZGlvIHRvIGRpc2suIFNpbmNlIDIuMgogICogQFdF QktJVF9DT05URVhUX01FTlVfQUNUSU9OX0NVU1RPTTogQ3VzdG9tIGFjdGlvbiBkZWZpbmVkIGJ5 IGFwcGxpY2F0aW9ucy4KICAqCiAgKiBFbnVtIHZhbHVlcyB1c2VkIHRvIGRlbm90ZSB0aGUgc3Rv Y2sgYWN0aW9ucyBmb3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL3Rlc3RzL1Rlc3RDb250ZXh0TWVudS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay90ZXN0cy9UZXN0Q29udGV4dE1lbnUuY3BwCmluZGV4IGQzZTQyYWY0MWVkYTIwYjlj OGQxODkxOTlhMzdlOTI1MmE4MDc4YjEuLjE1NzVjMTQ2ZDE5NTQ2ZWY1MmIxYjgwYmMxNDJlYWJk YWU4ODFkNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rl c3RzL1Rlc3RDb250ZXh0TWVudS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvdGVzdHMvVGVzdENvbnRleHRNZW51LmNwcApAQCAtMjM4LDYgKzIzOCw3IEBAIHB1Ymxp YzoKICAgICAgICAgSW1hZ2UsCiAgICAgICAgIExpbmtJbWFnZSwKICAgICAgICAgVmlkZW8sCisg ICAgICAgIEF1ZGlvLAogICAgICAgICBFZGl0YWJsZQogICAgIH07CiAKQEAgLTMxMSw2ICszMTIs MjEgQEAgcHVibGljOgogICAgICAgICAgICAgaXRlciA9IGNoZWNrQ3VycmVudEl0ZW1Jc1N0b2Nr QWN0aW9uQW5kR2V0TmV4dChpdGVyLCBXRUJLSVRfQ09OVEVYVF9NRU5VX0FDVElPTl9PUEVOX1ZJ REVPX0lOX05FV19XSU5ET1csIFZpc2libGUgfCBFbmFibGVkKTsKICAgICAgICAgICAgIGl0ZXIg PSBjaGVja0N1cnJlbnRJdGVtSXNTdG9ja0FjdGlvbkFuZEdldE5leHQoaXRlciwgV0VCS0lUX0NP TlRFWFRfTUVOVV9BQ1RJT05fRE9XTkxPQURfVklERU9fVE9fRElTSywgVmlzaWJsZSB8IEVuYWJs ZWQpOwogICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgQXVkaW86CisgICAgICAgICAg ICBnX2Fzc2VydCghd2Via2l0X2hpdF90ZXN0X3Jlc3VsdF9jb250ZXh0X2lzX2xpbmsoaGl0VGVz dFJlc3VsdCkpOworICAgICAgICAgICAgZ19hc3NlcnQoIXdlYmtpdF9oaXRfdGVzdF9yZXN1bHRf Y29udGV4dF9pc19pbWFnZShoaXRUZXN0UmVzdWx0KSk7CisgICAgICAgICAgICBnX2Fzc2VydCh3 ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2NvbnRleHRfaXNfbWVkaWEoaGl0VGVzdFJlc3VsdCkpOwor ICAgICAgICAgICAgZ19hc3NlcnQoIXdlYmtpdF9oaXRfdGVzdF9yZXN1bHRfY29udGV4dF9pc19l ZGl0YWJsZShoaXRUZXN0UmVzdWx0KSk7CisgICAgICAgICAgICBpdGVyID0gY2hlY2tDdXJyZW50 SXRlbUlzU3RvY2tBY3Rpb25BbmRHZXROZXh0KGl0ZXIsIFdFQktJVF9DT05URVhUX01FTlVfQUNU SU9OX01FRElBX1BMQVksIFZpc2libGUgfCBFbmFibGVkKTsKKyAgICAgICAgICAgIGl0ZXIgPSBj aGVja0N1cnJlbnRJdGVtSXNTdG9ja0FjdGlvbkFuZEdldE5leHQoaXRlciwgV0VCS0lUX0NPTlRF WFRfTUVOVV9BQ1RJT05fTUVESUFfTVVURSwgVmlzaWJsZSk7CisgICAgICAgICAgICBpdGVyID0g Y2hlY2tDdXJyZW50SXRlbUlzU3RvY2tBY3Rpb25BbmRHZXROZXh0KGl0ZXIsIFdFQktJVF9DT05U RVhUX01FTlVfQUNUSU9OX1RPR0dMRV9NRURJQV9DT05UUk9MUywgVmlzaWJsZSB8IEVuYWJsZWQg fCBDaGVja2VkKTsKKyAgICAgICAgICAgIGl0ZXIgPSBjaGVja0N1cnJlbnRJdGVtSXNTdG9ja0Fj dGlvbkFuZEdldE5leHQoaXRlciwgV0VCS0lUX0NPTlRFWFRfTUVOVV9BQ1RJT05fVE9HR0xFX01F RElBX0xPT1AsIFZpc2libGUgfCBFbmFibGVkKTsKKyAgICAgICAgICAgIGl0ZXIgPSBjaGVja0N1 cnJlbnRJdGVtSXNTdG9ja0FjdGlvbkFuZEdldE5leHQoaXRlciwgV0VCS0lUX0NPTlRFWFRfTUVO VV9BQ1RJT05fRU5URVJfVklERU9fRlVMTFNDUkVFTiwgVmlzaWJsZSk7CisgICAgICAgICAgICBp dGVyID0gY2hlY2tDdXJyZW50SXRlbUlzU2VwYXJhdG9yQW5kR2V0TmV4dChpdGVyKTsKKyAgICAg ICAgICAgIGl0ZXIgPSBjaGVja0N1cnJlbnRJdGVtSXNTdG9ja0FjdGlvbkFuZEdldE5leHQoaXRl ciwgV0VCS0lUX0NPTlRFWFRfTUVOVV9BQ1RJT05fQ09QWV9BVURJT19MSU5LX1RPX0NMSVBCT0FS RCwgVmlzaWJsZSB8IEVuYWJsZWQpOworICAgICAgICAgICAgaXRlciA9IGNoZWNrQ3VycmVudEl0 ZW1Jc1N0b2NrQWN0aW9uQW5kR2V0TmV4dChpdGVyLCBXRUJLSVRfQ09OVEVYVF9NRU5VX0FDVElP Tl9PUEVOX0FVRElPX0lOX05FV19XSU5ET1csIFZpc2libGUgfCBFbmFibGVkKTsKKyAgICAgICAg ICAgIGl0ZXIgPSBjaGVja0N1cnJlbnRJdGVtSXNTdG9ja0FjdGlvbkFuZEdldE5leHQoaXRlciwg V0VCS0lUX0NPTlRFWFRfTUVOVV9BQ1RJT05fRE9XTkxPQURfQVVESU9fVE9fRElTSywgVmlzaWJs ZSB8IEVuYWJsZWQpOworICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgRWRpdGFibGU6 CiAgICAgICAgICAgICBnX2Fzc2VydCghd2Via2l0X2hpdF90ZXN0X3Jlc3VsdF9jb250ZXh0X2lz X2xpbmsoaGl0VGVzdFJlc3VsdCkpOwogICAgICAgICAgICAgZ19hc3NlcnQoIXdlYmtpdF9oaXRf dGVzdF9yZXN1bHRfY29udGV4dF9pc19pbWFnZShoaXRUZXN0UmVzdWx0KSk7CkBAIC0zNTcsNiAr MzczLDcgQEAgc3RhdGljIHZvaWQgdGVzdENvbnRleHRNZW51RGVmYXVsdE1lbnUoQ29udGV4dE1l bnVEZWZhdWx0VGVzdCogdGVzdCwgZ2NvbnN0cG9pbnQKICAgICAgICAgIiA8YSBzdHlsZT0ncG9z aXRpb246YWJzb2x1dGU7IGxlZnQ6MTsgdG9wOjIwJyBocmVmPSdodHRwOi8vd3d3LndlYmtpdGd0 ay5vcmcvbG9nbycgdGl0bGU9J1dlYktpdEdUSysgTG9nbyc+PGltZyBzcmM9JzB4ZGVhZGJlZWYn IHdpZHRoPTUgaGVpZ2h0PTU+PC9pbWc+PC9hPiIKICAgICAgICAgIiA8aW5wdXQgc3R5bGU9J3Bv c2l0aW9uOmFic29sdXRlOyBsZWZ0OjE7IHRvcDozMCcgc2l6ZT0nMTAnPjwvaW5wdXQ+IgogICAg ICAgICAiIDx2aWRlbyBzdHlsZT0ncG9zaXRpb246YWJzb2x1dGU7IGxlZnQ6MTsgdG9wOjUwJyB3 aWR0aD0nMzAwJyBoZWlnaHQ9JzMwMCcgY29udHJvbHM9J2NvbnRyb2xzJyBwcmVsb2FkPSdub25l Jz48c291cmNlIHNyYz0nbW92aWUub2dnJyB0eXBlPSd2aWRlby9vZ2cnIC8+PC92aWRlbz4iCisg ICAgICAgICIgPGF1ZGlvIHN0eWxlPSdwb3NpdGlvbjphYnNvbHV0ZTsgbGVmdDoxOyB0b3A6NjAn IHdpZHRoPSc1MCcgaGVpZ2h0PScyMCcgY29udHJvbHM9J2NvbnRyb2xzJyBwcmVsb2FkPSdub25l Jz48c291cmNlIHNyYz0ndHJhY2subXAzJyB0eXBlPSdhdWRpby9tcDMnIC8+PC9hdWRpbz4iCiAg ICAgICAgICI8L2JvZHk+PC9odG1sPiI7CiAgICAgdGVzdC0+bG9hZEh0bWwobGlua3NIVE1MLCAi ZmlsZTovLy8iKTsKICAgICB0ZXN0LT53YWl0VW50aWxMb2FkRmluaXNoZWQoKTsKQEAgLTM4MSwx MCArMzk4LDE0IEBAIHN0YXRpYyB2b2lkIHRlc3RDb250ZXh0TWVudURlZmF1bHRNZW51KENvbnRl eHRNZW51RGVmYXVsdFRlc3QqIHRlc3QsIGdjb25zdHBvaW50CiAgICAgdGVzdC0+bV9leHBlY3Rl ZE1lbnVUeXBlID0gQ29udGV4dE1lbnVEZWZhdWx0VGVzdDo6TGlua0ltYWdlOwogICAgIHRlc3Qt PnNob3dDb250ZXh0TWVudUF0UG9zaXRpb25BbmRXYWl0VW50aWxGaW5pc2hlZCgxLCAyMCk7CiAK LSAgICAvLyBDb250ZXh0IG1lbnUgZm9yIGltYWdlIHZpZGVvLgorICAgIC8vIENvbnRleHQgbWVu dSBmb3IgdmlkZW8uCiAgICAgdGVzdC0+bV9leHBlY3RlZE1lbnVUeXBlID0gQ29udGV4dE1lbnVE ZWZhdWx0VGVzdDo6VmlkZW87CiAgICAgdGVzdC0+c2hvd0NvbnRleHRNZW51QXRQb3NpdGlvbkFu ZFdhaXRVbnRpbEZpbmlzaGVkKDEsIDUwKTsKIAorICAgIC8vIENvbnRleHQgbWVudSBmb3IgYXVk aW8uCisgICAgdGVzdC0+bV9leHBlY3RlZE1lbnVUeXBlID0gQ29udGV4dE1lbnVEZWZhdWx0VGVz dDo6QXVkaW87CisgICAgdGVzdC0+c2hvd0NvbnRleHRNZW51QXRQb3NpdGlvbkFuZFdhaXRVbnRp bEZpbmlzaGVkKDEsIDYwKTsKKwogICAgIC8vIENvbnRleHQgbWVudSBmb3IgZWRpdGFibGUuCiAg ICAgdGVzdC0+bV9leHBlY3RlZE1lbnVUeXBlID0gQ29udGV4dE1lbnVEZWZhdWx0VGVzdDo6RWRp dGFibGU7CiAgICAgdGVzdC0+c2hvd0NvbnRleHRNZW51QXRQb3NpdGlvbkFuZFdhaXRVbnRpbEZp bmlzaGVkKDUsIDM1KTsK