120759 2013-09-05 00:53:53 -0700 Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly 2013-09-05 08:11:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 120696 1 fpizlo ossy barraclough bfulgham ggaren gyuyoung.kim mark.lam mhahnenberg msaboff oliver ossy sam zan oldest_to_newest 924914 0 fpizlo 2013-09-05 00:53:53 -0700 The issues are: - run-fast-jsc is a shell script; it needs a shell that is sufficiently compatible with Darwin /bin/sh. We should either change the script or make sure that we use the right shell on other platforms. - I'm not sure if all of the perl-foo is compatible with the perl's on other platforms, though I think I should have fixed this in http://trac.webkit.org/changeset/155101. 924926 1 zan 2013-09-05 01:50:47 -0700 Most if not all of the Linux builders are running Debian-based systems, meaning /bin/sh links to the dash shell which is not really Bourne-compatible. http://en.wikipedia.org/wiki/Debian_Almquist_shell /bin/bash should still be available, and the script runs fine when that's used. Is /bin/bash available on Mac OSs? 924962 2 ossy 2013-09-05 04:18:57 -0700 I have a fix for it. 924964 3 210599 ossy 2013-09-05 04:24:52 -0700 Created attachment 210599 Patch tested on Linux bash and dash and Darwin's /bin/sh 924965 4 ossy 2013-09-05 04:29:30 -0700 just a note: /bin/sh on Darwin is bash too: $ /bin/sh --version GNU bash, version 3.2.48(1)-release (x86_64-apple-darwin11) Copyright (C) 2007 Free Software Foundation, Inc. 925036 5 210599 ossy 2013-09-05 08:11:01 -0700 Comment on attachment 210599 Patch Clearing flags on attachment: 210599 Committed r155118: <http://trac.webkit.org/changeset/155118> 925037 6 ossy 2013-09-05 08:11:10 -0700 All reviewed patches have been landed. Closing bug. 210599 2013-09-05 04:24:52 -0700 2013-09-05 08:11:00 -0700 Patch bug-120759-20130905042503.patch text/plain 3099 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MTA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjYzNDFhZGExMmZjZDhjYmVjMGNmYjEwYjhkOWU1NzQx ZTkyODU1OS4uN2UyYjI3ZGQxZTI0MzdjYWQ4OWI1YTI1YTljZGIxNjZmYzRlM2IyZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTA5LTA1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgTWFrZSBydW4tZmFzdC1qc2Mgc2NyaXB0IGJhc2gsIGRhc2ggYW5kIERhcndpbidz IC9iaW4vc2ggZnJpZW5kbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMDc1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy9ydW4tZmFzdC1qc2M6IFJlbW92ZSBiYXNoaXNtcyB0byBtYWtl IGJhc2gsIGRhc2ggYW5kIERhcndpbidzIC9iaW4vc2ggaGFwcHkuCisgICAgICAgICogU2NyaXB0 cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6IEVuYWJsZSBydW4tZmFzdC1qc2MgdGVzdHMgZXZl cnl3aGVyZSwgZXhjZXB0IFdpbmRvd3MuCisKIDIwMTMtMDktMDUgIEZpbGlwIFBpemxvICA8ZnBp emxvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBkb24ndCBydW4gZmFzdC9qcyB0 ZXN0cyBpbiBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgb24gcGxhdGZvcm1zIHRoYXQKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWZhc3QtanNjIGIvVG9vbHMvU2NyaXB0cy9ydW4tZmFz dC1qc2MKaW5kZXggOGUwMDRjNDQ3YzI0N2Q2ZjBmNmU4NjBhOGVjZWE2ZDllZTlkMGU5Zi4uOGUz YmUzYzRjMTI0NzVhY2I3ZjY2YWMxMjVlMjI2ZGUyMjQ5ODg1MSAxMDA3NTUKLS0tIGEvVG9vbHMv U2NyaXB0cy9ydW4tZmFzdC1qc2MKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tZmFzdC1qc2MKQEAg LTMyLDcgKzMyLDcgQEAgdGVzdExpc3Q9InVuc2V0IgogCiBjbWROYW1lPWBiYXNlbmFtZSAkMGAK IAotZnVuY3Rpb24gdXNhZ2UoKQordXNhZ2UoKQogewogICAgIGVjaG8gInVzYWdlOiAkY21kTmFt ZSBbWy0tanNjIHwgLWpdIDxwYXRoLXRvLWpzYz5dIFtbLS1yZXN1bHRzLWRpciB8IC1yXSA8cmVz dWx0cy1wYXRoPl0iCiAgICAgZWNobyAiICAgICAgICAgICAgICAgICAgICBbWy0tdGVzdC1yb290 IHwgLXRdIDx0ZXN0LXJvb3QtcGF0aD5dIFtbLS10ZXN0LWxpc3QgfCAtbF0gPHRlc3QtbGlzdC1m aWxlPl0iCkBAIC0xMDgsOCArMTA4LDEyIEBAIGRvCiAKICAgICBpZiBbIC1mICRleHBlY3RlZE91 dCAtYSAtZiAkanNUZXN0IF0KICAgICB0aGVuCi0gICAgICAgIGVjaG8gIlRlc3RpbmcgJHRlc3Qg Li4uIFxjIgotICAgICAgICBsZXQgbnVtVGVzdHNSdW49JG51bVRlc3RzUnVuKzEKKyAgICAgICAg aWYgWyBgdW5hbWVgID0gJ0RhcndpbicgXTsgdGhlbgorICAgICAgICAgICAgZWNobyAiVGVzdGlu ZyAkdGVzdCAuLi4gXGMiCisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGVjaG8gLW4gIlRlc3Rp bmcgJHRlc3QgLi4uIgorICAgICAgICBmaQorICAgICAgICBudW1UZXN0c1J1bj0kKCgkbnVtVGVz dHNSdW4rMSkpCiAgICAgICAgICRqc2NDbWQgJHByZVNjcmlwdCAkanNUZXN0ICRwb3N0U2NyaXB0 IDI+JGFjdHVhbEVyciA+ICRhY3R1YWxPdXQKICAgICAgICAgSlNDX1JFUz0kPwogICAgICAgICAK QEAgLTEzOCwxNCArMTQyLDE0IEBAIGRvCiAgICAgICAgIGlmIFsgJHRlc3RQYXNzZWQgLWVxIDEg XQogICAgICAgICB0aGVuCiAgICAgICAgICAgICBlY2hvICIkdGVzdCIgPj4gJHBhc3NMaXN0Ci0g ICAgICAgICAgICBsZXQgbnVtUGFzc2VkPSRudW1QYXNzZWQrMQorICAgICAgICAgICAgbnVtUGFz c2VkPSQoKCRudW1QYXNzZWQrMSkpCiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGVjaG8gIiR0 ZXN0IiA+PiAkZmFpbExpc3QKLSAgICAgICAgICAgIGxldCBudW1GYWlsZWQ9JG51bUZhaWxlZCsx CisgICAgICAgICAgICBudW1GYWlsZWQ9JCgoJG51bUZhaWxlZCsxKSkKICAgICAgICAgICAgIGlm IFsgJHRlc3RDcmFzaGVkIC1lcSAxIF0KICAgICAgICAgICAgIHRoZW4KICAgICAgICAgICAgICAg ICBlY2hvICIkdGVzdCIgPj4gJGNyYXNoTGlzdAotICAgICAgICAgICAgICAgIGxldCBudW1DcmFz aGVkPSRudW1DcmFzaGVkKzEKKyAgICAgICAgICAgICAgICBudW1DcmFzaGVkPSQoKCRudW1DcmFz aGVkKzEpKQogICAgICAgICAgICAgZmkKICAgICAgICAgZmkKICAgICBmaQpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1 bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwppbmRleCA4ZDZlM2E3NjQzN2MyMzU2ZjBiNGQ1OTEzNTIx YmMxMjBlOTZmYmU5Li45OTQ4NDUzZWU4OWUzNzViNmEyOWYwMDc3N2E2ZDY1MTZjNjU3YzM0IDEw MDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cworKysgYi9U b29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwpAQCAtMTkxLDcgKzE5MSwxMSBA QCBjbG9zZSBBQ1RVQUw7CiAKIGNoZGlyV2ViS2l0KCk7CiBteSAkZmFzdEpTUmVzdWx0c0RpciA9 ICRwcm9kdWN0RGlyIC4gIi9mYXN0LWpzYy1yZXN1bHRzIjsKLW15ICRydW5GYXN0SlMgPSBpc0Fw cGxlTWFjV2ViS2l0KCk7CisKKyMgRklYTUU6IHJ1bi1mYXN0LWpzYyB0ZXN0cyBkb2Vzbid0IHdv cmsgcHJvcGVybHkgb24gV2luZG93cworIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTIwNzY1CitteSAkcnVuRmFzdEpTID0gIWlzQXBwbGVXaW5XZWJLaXQoKTsKKwog aWYgKCRydW5GYXN0SlMpIHsKICAgICAjIFJ1biB0aGUgZmFzdC9qcyB0ZXN0cy4KICAgICBteSBA ZmFzdEpTRHJpdmVyQ21kID0gKCIvYmluL3NoIiwgIlRvb2xzL1NjcmlwdHMvcnVuLWZhc3QtanNj IiwgIi1qIiwganNjUGF0aCgkcHJvZHVjdERpciksICItciIsICRmYXN0SlNSZXN1bHRzRGlyLCAi LXQiLCAiTGF5b3V0VGVzdHMiKTsK