120653 2013-09-03 15:36:23 -0700 REGRESSION (r154967) window resize is very choppy 2013-09-03 21:26:59 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 simon.fraser darin ap commit-queue darin kling simon.fraser oldest_to_newest 924199 0 simon.fraser 2013-09-03 15:36:23 -0700 Window resize with a very simple no-JS testcase is terrible after r154967. People say that tab switching is also impacted. 924204 1 darin 2013-09-03 16:09:56 -0700 If the symptom is that bad, maybe we should just roll out! I assume I just got one of the conditions backwards in the patch somewhere, or removed an early return I should not have. 924211 2 ap 2013-09-03 16:32:21 -0700 If rolling out, r154981 should be rolled out too. 924238 3 darin 2013-09-03 19:03:32 -0700 Is this in release builds, or only debug builds? 924240 4 darin 2013-09-03 19:04:40 -0700 I tried to find things I did wrong in the patch, especially ones that could possibly have anything to do with window resizing. So far, all I found was bug 120659. 924256 5 darin 2013-09-03 20:16:23 -0700 *** Bug 120660 has been marked as a duplicate of this bug. *** 924257 6 210424 darin 2013-09-03 20:18:08 -0700 Created attachment 210424 Patch 924258 7 commit-queue 2013-09-03 20:19:26 -0700 Attachment 210424 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/Connection.cpp']" exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.cpp:420: Missing spaces around >> [whitespace/operators] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 924259 8 210424 kling 2013-09-03 20:19:41 -0700 Comment on attachment 210424 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210424&action=review > Source/WebKit2/Platform/CoreIPC/Connection.cpp:420 > + HashMap<std::pair<std::pair<StringReference, StringReference>, uint64_t>, OwnPtr<MessageDecoder>>::iterator it = m_waitForMessageMap.find(messageAndDestination); No auto? ;-) 924266 9 210424 commit-queue 2013-09-03 21:26:56 -0700 Comment on attachment 210424 Patch Clearing flags on attachment: 210424 Committed r155017: <http://trac.webkit.org/changeset/155017> 924267 10 commit-queue 2013-09-03 21:26:59 -0700 All reviewed patches have been landed. Closing bug. 210424 2013-09-03 20:18:08 -0700 2013-09-03 21:26:56 -0700 Patch bug-120653-20130903201807.patch text/plain 1902 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzVhNzg3NDI1ZDliMGRm OTk4MjEwNGFiMjM4NmQyNmY0ZmIwODkxMi4uODg2ZDVmNjJmOThlMzBmMzZkOGUxODk3OTEyNDAw OTUwZTEyNjgwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA5LTAzICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTU0OTY3 KSB3aW5kb3cgcmVzaXplIGlzIHZlcnkgY2hvcHB5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA2NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBbmRyZWFzIEtsaW5nIHNwb3R0ZWQgdGhlIGJhZCBjaGFu Z2UuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwOgorICAgICAg ICAoQ29yZUlQQzo6Q29ubmVjdGlvbjo6d2FpdEZvck1lc3NhZ2UpOiBSb2xsIG91dCB0aGlzIGlu Y29ycmVjdCBjaGFuZ2UuCisgICAgICAgIFRoZSBjb2RlIGhlcmUgaXMgbm90IHRoZSBzYW1lIGFz IGEgY2FsbCB0byB0YWtlLgorCiAyMDEzLTA5LTAzICBBbnRvbiBPYnpoaXJvdiAgPGEub2J6aGly b3ZAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0dUS10gZ2RrIHRocmVhZHMgZGVwcmVjYXRlZCBm dW5jdGlvbnMgY2FsbHMgc2hvdWxkIGJlIHJlZmFjdG9yZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9Q bGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCmluZGV4IDg5ZjA2YjU1N2RmNjgxYzljMGU5 N2EwYjM0YTMyYjQ4M2JkYTNhZWUuLjE3MGVjMzI1MWI3NjQwY2QzNzA4ODZmZWM0ZjNmMWFkZjJl ZjlmZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVj dGlvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9u LmNwcApAQCAtNDE3LDggKzQxNywxMyBAQCBQYXNzT3duUHRyPE1lc3NhZ2VEZWNvZGVyPiBDb25u ZWN0aW9uOjp3YWl0Rm9yTWVzc2FnZShTdHJpbmdSZWZlcmVuY2UgbWVzc2FnZVJlYwogICAgIHdo aWxlICh0cnVlKSB7CiAgICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX3dhaXRGb3JNZXNzYWdl TXV0ZXgpOwogCi0gICAgICAgIGlmIChPd25QdHI8TWVzc2FnZURlY29kZXI+IGRlY29kZXIgPSBt X3dhaXRGb3JNZXNzYWdlTWFwLnRha2UobWVzc2FnZUFuZERlc3RpbmF0aW9uKSkKKyAgICAgICAg SGFzaE1hcDxzdGQ6OnBhaXI8c3RkOjpwYWlyPFN0cmluZ1JlZmVyZW5jZSwgU3RyaW5nUmVmZXJl bmNlPiwgdWludDY0X3Q+LCBPd25QdHI8TWVzc2FnZURlY29kZXI+Pjo6aXRlcmF0b3IgaXQgPSBt X3dhaXRGb3JNZXNzYWdlTWFwLmZpbmQobWVzc2FnZUFuZERlc3RpbmF0aW9uKTsKKyAgICAgICAg aWYgKGl0LT52YWx1ZSkgeworICAgICAgICAgICAgT3duUHRyPE1lc3NhZ2VEZWNvZGVyPiBkZWNv ZGVyID0gaXQtPnZhbHVlLnJlbGVhc2UoKTsKKyAgICAgICAgICAgIG1fd2FpdEZvck1lc3NhZ2VN YXAucmVtb3ZlKGl0KTsKKwogICAgICAgICAgICAgcmV0dXJuIGRlY29kZXIucmVsZWFzZSgpOwor ICAgICAgICB9CiAgICAgICAgIAogICAgICAgICAvLyBOb3cgd2Ugd2FpdC4KICAgICAgICAgaWYg KCFtX3dhaXRGb3JNZXNzYWdlQ29uZGl0aW9uLnRpbWVkV2FpdChtX3dhaXRGb3JNZXNzYWdlTXV0 ZXgsIGFic29sdXRlVGltZSkpIHsK