120221 2013-08-23 12:25:22 -0700 copy-webkitlibraries-to-product-directory should accept command-line arguments for extra work required for optional features rather than relying on environment variables 2014-01-30 16:37:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo mrowe oliver oldest_to_newest 920361 0 fpizlo 2013-08-23 12:25:22 -0700 Using environment variables is a bit too magical - it's never quite clear who sets the environment variable or who consumes it. An argument is more explicit. 974085 1 222756 fpizlo 2014-01-30 16:28:05 -0800 Created attachment 222756 the patch 974088 2 222756 mhahnenberg 2014-01-30 16:33:37 -0800 Comment on attachment 222756 the patch r=me 974090 3 fpizlo 2014-01-30 16:37:55 -0800 Landed in http://trac.webkit.org/changeset/163133 222756 2014-01-30 16:28:05 -0800 2014-01-30 16:33:37 -0800 the patch blah.patch text/plain 4958 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MzEzMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE0LTAxLTMwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgY29weS13ZWJraXRsaWJyYXJpZXMtdG8tcHJvZHVjdC1kaXJlY3Rvcnkgc2hvdWxk IGFjY2VwdCBjb21tYW5kLWxpbmUgYXJndW1lbnRzIGZvciBleHRyYSB3b3JrIHJlcXVpcmVkIGZv ciBvcHRpb25hbCBmZWF0dXJlcyByYXRoZXIgdGhhbiByZWx5aW5nIG9uIGVudmlyb25tZW50IHZh cmlhYmxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTIwMjIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL2J1aWxkLWpzYzoKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKyAg ICAgICAgKiBTY3JpcHRzL2NvcHktd2Via2l0bGlicmFyaWVzLXRvLXByb2R1Y3QtZGlyZWN0b3J5 OgorCiAyMDE0LTAxLTMwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIGEgd2ViVmlldzpkaWRTdGFydFByb3Zpc2lvbmFsTmF2aWdhdGlvbjogZGVs ZWdhdGUgbWV0aG9kCkluZGV4OiBUb29scy9TY3JpcHRzL2J1aWxkLWpzYwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL2J1aWxkLWpzYwkocmV2aXNpb24gMTYzMTI5KQorKysgVG9vbHMvU2Ny aXB0cy9idWlsZC1qc2MJKHdvcmtpbmcgY29weSkKQEAgLTg0LDE0ICs4NCwxNyBAQCBpZiAoY21h a2VCYXNlZFBvcnROYW1lKCkpIHsKIAogaWYgKGlzQXBwbGVNYWNXZWJLaXQoKSkgewogICAgIGlm ICgkZnRsSklUKSB7Ci0gICAgICAgICRFTlZ7RU5BQkxFX0ZUTF9KSVR9ID0gMTsKICAgICAgICAg cHVzaCBAb3B0aW9ucywgIkVOQUJMRV9GVExfSklUPUVOQUJMRV9GVExfSklUIjsKICAgICB9CiAg ICAgaWYgKCRmb3JjZUNMb29wKSB7Ci0gICAgICAgICRFTlZ7RU5BQkxFX0xMSU5UX0NfTE9PUH0g PSAxOwogICAgICAgICBwdXNoIEBvcHRpb25zLCAiRU5BQkxFX0xMSU5UX0NfTE9PUD1FTkFCTEVf TExJTlRfQ19MT09QIjsKICAgICB9Ci0gICAgKHN5c3RlbSgicGVybCIsICJUb29scy9TY3JpcHRz L2NvcHktd2Via2l0bGlicmFyaWVzLXRvLXByb2R1Y3QtZGlyZWN0b3J5IiwgcHJvZHVjdERpcigp KSA9PSAwKSBvciBkaWU7CisgICAgbXkgQGNvcHlMaWJyYXJpZXNBcmdzID0gKCJwZXJsIiwgIlRv b2xzL1NjcmlwdHMvY29weS13ZWJraXRsaWJyYXJpZXMtdG8tcHJvZHVjdC1kaXJlY3RvcnkiKTsK KyAgICBpZiAoJGZ0bEpJVCkgeworICAgICAgICBwdXNoIEBjb3B5TGlicmFyaWVzQXJncywgIi0t ZnRsLWppdCI7CisgICAgfQorICAgIHB1c2ggQGNvcHlMaWJyYXJpZXNBcmdzLCBwcm9kdWN0RGly KCk7CisgICAgKHN5c3RlbShAY29weUxpYnJhcmllc0FyZ3MpID09IDApIG9yIGRpZTsKIH0KIAog c3ViIGJ1aWxkTXlQcm9qZWN0CkluZGV4OiBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAkocmV2aXNpb24gMTYzMTI5KQor KysgVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQJKHdvcmtpbmcgY29weSkKQEAgLTE3Nyw3ICsx NzcsNiBAQCBpZiAoIWlzSU9TV2ViS2l0KCkgJiYgIS1kICJXZWJLaXRMaWJyYXJpCiAKIG15IEBv cHRpb25zID0gKCk7CiBteSAkaGFzRlRMSklUID0gMDsKLW15ICRmb3JjZUNMb29wID0gMDsKIAog aWYgKGlzQXBwbGVNYWNXZWJLaXQoKSkgewogICAgIHB1c2ggQG9wdGlvbnMsIFhjb2RlT3B0aW9u cygpOwpAQCAtMTkxLDExICsxOTAsOCBAQCBpZiAoaXNBcHBsZU1hY1dlYktpdCgpKSB7CiAgICAg Zm9yZWFjaCAoQGZlYXR1cmVzKSB7CiAgICAgICAgIG15ICRvcHRpb24gPSBvcHRpb24oJF8tPntk ZWZpbmV9LCAkeyRfLT57dmFsdWV9fSwgJF8tPntkZWZhdWx0fSk7CiAgICAgICAgICRoYXNGVExK SVQgPSAxIGlmICgkXy0+e2RlZmluZX0gZXEgIkVOQUJMRV9GVExfSklUIikgYW5kICgkeyRfLT57 dmFsdWV9fSk7Ci0gICAgICAgICRmb3JjZUNMb29wID0gMSBpZiAoJF8tPntkZWZpbmV9IGVxICJF TkFCTEVfTExJTlRfQ19MT09QIikgYW5kICgkeyRfLT57dmFsdWV9fSk7CiAgICAgICAgIHB1c2gg QG9wdGlvbnMsICRvcHRpb24gdW5sZXNzICRvcHRpb24gZXEgIiI7CiAgICAgfQotICAgICRFTlZ7 RU5BQkxFX0ZUTF9KSVR9ID0gMSBpZiAkaGFzRlRMSklUOwotICAgICRFTlZ7RU5BQkxFX0xMSU5U X0NfTE9PUH0gPSAxIGlmICRmb3JjZUNMb29wOwogCiAgICAgaWYgKGlzSU9TV2ViS2l0KCkpIHsK ICAgICAgICAgIyBGSVhNRTogUmVtb3ZlIHRoZSBpbmNsdXNpb24gb2YgYm90aCBXZWJLaXQgU3lz dGVtIEludGVyZmFjZSBhbmQgV2ViS2l0IEFkZGl0aW9ucyBwcm9qZWN0cwpAQCAtMjIwLDcgKzIx NiwxMiBAQCBpZiAoaXNBcHBsZU1hY1dlYktpdCgpKSB7CiAgICAgICAgIHVuc2hpZnQgQHByb2pl Y3RzLCAoIlNvdXJjZS9XZWJJbnNwZWN0b3JVSSIpOwogCiAgICAgICAgICMgQ29weSBsaWJyYXJ5 IGFuZCBoZWFkZXIgZnJvbSBXZWJLaXRMaWJyYXJpZXMgdG8gYSBmaW5kYWJsZSBwbGFjZSBpbiB0 aGUgcHJvZHVjdCBkaXJlY3RvcnkuCi0gICAgICAgIChzeXN0ZW0oInBlcmwiLCAiVG9vbHMvU2Ny aXB0cy9jb3B5LXdlYmtpdGxpYnJhcmllcy10by1wcm9kdWN0LWRpcmVjdG9yeSIsICRwcm9kdWN0 RGlyKSA9PSAwKSBvciBkaWU7CisgICAgICAgIG15IEBjb3B5TGlicmFyaWVzQXJncyA9ICgicGVy bCIsICJUb29scy9TY3JpcHRzL2NvcHktd2Via2l0bGlicmFyaWVzLXRvLXByb2R1Y3QtZGlyZWN0 b3J5Iik7CisgICAgICAgIGlmICgkaGFzRlRMSklUKSB7CisgICAgICAgICAgICBwdXNoIEBjb3B5 TGlicmFyaWVzQXJncywgIi0tZnRsLWppdCI7CisgICAgICAgIH0KKyAgICAgICAgcHVzaCBAY29w eUxpYnJhcmllc0FyZ3MsIHByb2R1Y3REaXIoKTsKKyAgICAgICAgKHN5c3RlbShAY29weUxpYnJh cmllc0FyZ3MpID09IDApIG9yIGRpZTsKICAgICB9IGVsc2UgewogICAgICAgICBwdXNoIEBwcm9q ZWN0cywgKCJTb3VyY2UvV2ViS2l0MiIpIGlmICEkbm9XZWJLaXQyOwogICAgIH0KSW5kZXg6IFRv b2xzL1NjcmlwdHMvY29weS13ZWJraXRsaWJyYXJpZXMtdG8tcHJvZHVjdC1kaXJlY3RvcnkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9jb3B5LXdlYmtpdGxpYnJhcmllcy10by1wcm9kdWN0 LWRpcmVjdG9yeQkocmV2aXNpb24gMTYzMTI5KQorKysgVG9vbHMvU2NyaXB0cy9jb3B5LXdlYmtp dGxpYnJhcmllcy10by1wcm9kdWN0LWRpcmVjdG9yeQkod29ya2luZyBjb3B5KQpAQCAtMSw2ICsx LDYgQEAKICMhL3Vzci9iaW4vcGVybCAtdwogCi0jIENvcHlyaWdodCAoQykgMjAwNSwgMjAwOCwg MjAxMCwgMjAxMSwgMjAxMiwgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisj IENvcHlyaWdodCAoQykgMjAwNSwgMjAwOCwgMjAxMCwgMjAxMSwgMjAxMiwgMjAxMywgMjAxNCBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1 c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKQEAgLTI1LDkgKzI1LDMwIEBACiAKIHVzZSBzdHJpY3Q7CiB1c2UgRmluZEJpbjsKK3VzZSBH ZXRvcHQ6OkxvbmcgcXcoOmNvbmZpZyBwYXNzX3Rocm91Z2gpOwogdXNlIGxpYiAkRmluZEJpbjo6 QmluOwogdXNlIHdlYmtpdGRpcnM7CiAKK215ICRzaG93SGVscCA9IDA7CitteSAkZnRsSklUID0g MDsKKworbXkgJHByb2dyYW1OYW1lID0gYmFzZW5hbWUoJDApOworbXkgJHVzYWdlID0gPDxFT0Y7 CitVc2FnZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXQorICAtLWhlbHAgICAgICAgICAgICAgICAg ICAgICAgICBTaG93IHRoaXMgaGVscCBtZXNzYWdlCisgIC0tW25vLV1mdGwtaml0ICAgICAgICAg ICAgICAgIFRvZ2dsZSBGVEwgSklUIHN1cHBvcnQgKGRlZmF1bHQ6ICRmdGxKSVQpCitFT0YKKwor R2V0T3B0aW9ucygKKyAgICAnaGVscCcgPT4gXCRzaG93SGVscCwKKyAgICAnZnRsLWppdCEnID0+ IFwkZnRsSklULAorKTsKKworaWYgKCRzaG93SGVscCkgeworICAgcHJpbnQgU1RERVJSICR1c2Fn ZTsKKyAgIGV4aXQgMTsKK30KKwogbXkgJHByb2R1Y3REaXIgPSBzaGlmdCBAQVJHVjsKICRwcm9k dWN0RGlyID0gJEVOVntCVUlMVF9QUk9EVUNUU19ESVJ9IGlmICEkcHJvZHVjdERpcjsKIApAQCAt ODIsNyArMTAzLDcgQEAgc3ViIGRpdHRvSGVhZGVycwogCiBkaXR0b0hlYWRlcnMoIldlYktpdExp YnJhcmllcy9XZWJLaXRTeXN0ZW1JbnRlcmZhY2UuaCIsICIkcHJvZHVjdERpci91c3IvbG9jYWwv aW5jbHVkZS9XZWJLaXRTeXN0ZW1JbnRlcmZhY2UuaCIpOwogCi1pZiAoJEVOVntFTkFCTEVfRlRM X0pJVH0pIHsKK2lmICgkZnRsSklUKSB7CiAgICAgIyBEZXRlcm1pbmUgd2hlcmUgdG8gZ2V0IExM Vk0gYmluYXJpZXMgYW5kIGhlYWRlcnMuCiAgICAgbXkgJG1ham9yRGFyd2luVmVyc2lvbiA9IChz cGxpdCAvXC4vLCBgdW5hbWUgLXJgKVswXTsKICAgICBteSAkbGx2bUxpYnJhcnlQYWNrYWdlOwo=