120107 2013-08-21 00:51:42 -0700 [mips][arm EABI] Fix P_DFGOperation_EJS call in DFG. 2013-08-22 05:36:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue fpizlo fu ggaren kilvadyb oliver ossy rgabor yong.li.webkit oldest_to_newest 919362 0 jbriance 2013-08-21 00:51:42 -0700 EncodedJSValue parameters must be aligned to even registers for MIPS and ARM EABI. This constraint is not followed in JITCompiler::Call callOperation(P_DFGOperation_EJS operation, GPRReg result, JSValueRegs value, size_t index) implementation. 919363 1 209255 jbriance 2013-08-21 00:57:47 -0700 Created attachment 209255 Fix P_DFGOperation_EJS call for MIPS and ARM EABI Please note that I found this issue by reading the code, but I didn't have time to validate it on a MIPS or ARM environment. 919750 2 209329 jbriance 2013-08-22 00:43:42 -0700 Created attachment 209329 Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format) 919809 3 209329 yong.li.webkit 2013-08-22 05:14:47 -0700 Comment on attachment 209329 Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format) looks good to me 919816 4 209329 commit-queue 2013-08-22 05:36:51 -0700 Comment on attachment 209329 Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format) Clearing flags on attachment: 209329 Committed r154442: <http://trac.webkit.org/changeset/154442> 919817 5 commit-queue 2013-08-22 05:36:53 -0700 All reviewed patches have been landed. Closing bug. 209255 2013-08-21 00:57:47 -0700 2013-08-22 00:43:42 -0700 Fix P_DFGOperation_EJS call for MIPS and ARM EABI bug-120107.patch text/plain 1410 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0MzgwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTA4LTIxICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjAxMDc+IEZpeCBQX0RGR09wZXJhdGlvbl9F SlMgY2FsbCBmb3IgTUlQUyBhbmQgQVJNIEVBQkkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRW5jb2RlZEpTVmFsdWUgcGFyYW1ldGVycyBtdXN0IGJl IGFsaWduZWQgdG8gZXZlbiByZWdpc3RlcnMgZm9yIE1JUFMgYW5kIEFSTSBFQUJJLgorCisgICAg ICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmg6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3Vs YXRpdmVKSVQ6OmNhbGxPcGVyYXRpb24pOgorCiAyMDEzLTA4LTIwICBHYXZpbiBCYXJyYWNsb3Vn aCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMDkzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklULmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCShyZXZpc2lvbiAxNTQzNzkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJKHdvcmtpbmcgY29weSkKQEAg LTE0OTEsNyArMTQ5MSw3IEBAIHB1YmxpYzoKIAogICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGxP cGVyYXRpb24oUF9ERkdPcGVyYXRpb25fRUpTIG9wZXJhdGlvbiwgR1BSUmVnIHJlc3VsdCwgSlNW YWx1ZVJlZ3MgdmFsdWUsIHNpemVfdCBpbmRleCkKICAgICB7Ci0gICAgICAgIG1faml0LnNldHVw QXJndW1lbnRzV2l0aEV4ZWNTdGF0ZSh2YWx1ZS5wYXlsb2FkR1BSKCksIHZhbHVlLnRhZ0dQUigp LCBUcnVzdGVkSW1tUHRyKGluZGV4KSk7CisgICAgICAgIG1faml0LnNldHVwQXJndW1lbnRzV2l0 aEV4ZWNTdGF0ZShFQUJJXzMyQklUX0RVTU1ZX0FSRyB2YWx1ZS5wYXlsb2FkR1BSKCksIHZhbHVl LnRhZ0dQUigpLCBUcnVzdGVkSW1tUHRyKGluZGV4KSk7CiAgICAgICAgIHJldHVybiBhcHBlbmRD YWxsU2V0UmVzdWx0KG9wZXJhdGlvbiwgcmVzdWx0KTsKICAgICB9CiAK 209329 2013-08-22 00:43:42 -0700 2013-08-22 05:36:51 -0700 Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format) bug-120107_2.patch text/plain 1419 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0NDM3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA4LTIyICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIEZpeCBQX0RGR09wZXJhdGlvbl9FSlMgY2FsbCBmb3IgTUlQUyBhbmQgQVJNIEVBQkku CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjAxMDcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmNvZGVk SlNWYWx1ZSBwYXJhbWV0ZXJzIG11c3QgYmUgYWxpZ25lZCB0byBldmVuIHJlZ2lzdGVycyBmb3Ig TUlQUyBhbmQgQVJNIEVBQkkuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuaDoK KyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y2FsbE9wZXJhdGlvbik6CisKIDIw MTMtMDgtMjEgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNTQ0MTYuCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCShyZXZpc2lvbiAxNTQ0MzcpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJKHdvcmtpbmcg Y29weSkKQEAgLTE0OTcsNyArMTQ5Nyw3IEBAIHB1YmxpYzoKIAogICAgIEpJVENvbXBpbGVyOjpD YWxsIGNhbGxPcGVyYXRpb24oUF9ERkdPcGVyYXRpb25fRUpTIG9wZXJhdGlvbiwgR1BSUmVnIHJl c3VsdCwgSlNWYWx1ZVJlZ3MgdmFsdWUsIHNpemVfdCBpbmRleCkKICAgICB7Ci0gICAgICAgIG1f aml0LnNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZSh2YWx1ZS5wYXlsb2FkR1BSKCksIHZhbHVl LnRhZ0dQUigpLCBUcnVzdGVkSW1tUHRyKGluZGV4KSk7CisgICAgICAgIG1faml0LnNldHVwQXJn dW1lbnRzV2l0aEV4ZWNTdGF0ZShFQUJJXzMyQklUX0RVTU1ZX0FSRyB2YWx1ZS5wYXlsb2FkR1BS KCksIHZhbHVlLnRhZ0dQUigpLCBUcnVzdGVkSW1tUHRyKGluZGV4KSk7CiAgICAgICAgIHJldHVy biBhcHBlbmRDYWxsU2V0UmVzdWx0KG9wZXJhdGlvbiwgcmVzdWx0KTsKICAgICB9CiAK