11993 2006-12-27 00:57:14 -0800 REGRESSION(r18320): Web Inspector scroll bars not drawn 2006-12-27 16:02:31 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 420+ Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P2 Normal --- 1 dev+webkit webkit-unassigned ggaren mrowe oldest_to_newest 39491 0 dev+webkit 2006-12-27 00:57:14 -0800 The Javascript error changes in r18320 caused the web inspector's scroll bars to not draw and spew DOM Exception 12 errors in the console. From what I can tell, this was caused by AppleVerticalScrollbar's computeTrackLength method sometimes returning NaN which totally throws off all the calculations based on that and it eventually trys to set NaN as the scroll bar height in the _setObjectLength method (which WebKit didn't care about before the change). My patch overrides the _setObjectLength method and checks if length is a number before setting it which fixes it (on Tiger at least, don't know about what changes have been made to this on Leopard, though I doubt this breaks anything). 39492 1 12054 dev+webkit 2006-12-27 00:58:38 -0800 Created attachment 12054 attempted patch 39499 2 dev+webkit 2006-12-27 01:42:17 -0800 This fix would probably be better off in inspector.js with a note about why its there wouldn't it? I'll leave it up for comments on the logic and upload a new patch in the morning.. 39501 3 mrowe 2006-12-27 02:42:49 -0800 Matt, can you file a bug in radar at http://bugreporter.apple.com/ mentioning the breakage that this covers so that it can be tracked internally by Apple? 39480 4 dev+webkit 2006-12-27 08:35:21 -0800 Filed as radar 4901491 39478 5 12061 dev+webkit 2006-12-27 09:04:49 -0800 Created attachment 12061 better patch 39388 6 sam 2006-12-27 16:02:31 -0800 Landed in r18444. 12054 2006-12-27 00:58:38 -0800 2006-12-27 09:04:02 -0800 attempted patch InspectorScrollPatch.txt text/plain 1541 dev+webkit SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTg0MjkpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTIgQEAKKzIwMDYtMTItMjcgIE1hdHQgTGlsZWsgIDxwZXd0ZXJtb29zZUBnbWFpbC5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAg ICAgICBPdmVycmlkZSBBcHBsZVZlcnRpY2FsU2Nyb2xsYmFyLnByb3RvdHlwZS5fc2V0T2JqZWN0 TGVuZ3RoIHNvIHRoYXQgaXQKKyAgICAgICAgZG9lc24ndCB0cnkgdG8gc2V0IGEgbm9uLW51bWJl ciBzY3JvbGxiYXIgaGVpZ2h0IGFuZCBjYXVzZSBET00gZXhjZXB0aW9ucy4KKworICAgICAgICAq IFdlYkluc3BlY3Rvci93ZWJJbnNwZWN0b3IvaW5zcGVjdG9yLmh0bWw6CisKIDIwMDYtMTItMjYg IEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYktpdC9XZWJJbnNwZWN0b3Ivd2ViSW5zcGVjdG9yL2lu c3BlY3Rvci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9XZWJJbnNwZWN0b3Ivd2ViSW5zcGVj dG9yL2luc3BlY3Rvci5odG1sCShyZXZpc2lvbiAxODQyMCkKKysrIFdlYktpdC9XZWJJbnNwZWN0 b3Ivd2ViSW5zcGVjdG9yL2luc3BlY3Rvci5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICsz MywxMiBAQCBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPCiAgICAgPHNj cmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iaW5zcGVjdG9yLmpzIj48L3NjcmlwdD4g CiAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iZmlsZTovLy9TeXN0ZW0v TGlicmFyeS9XaWRnZXRSZXNvdXJjZXMvQXBwbGVDbGFzc2VzL0FwcGxlU2Nyb2xsYmFyLmpzIj48 L3NjcmlwdD4gICAgCiAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iZmls ZTovLy9TeXN0ZW0vTGlicmFyeS9XaWRnZXRSZXNvdXJjZXMvQXBwbGVDbGFzc2VzL0FwcGxlU2Ny b2xsQXJlYS5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQi IGNoYXJzZXQ9InV0Zi04Ij4KKyAgICAgICAgQXBwbGVWZXJ0aWNhbFNjcm9sbGJhci5wcm90b3R5 cGUuX3NldE9iamVjdExlbmd0aCA9IGZ1bmN0aW9uKG9iamVjdCwgbGVuZ3RoKSB7CisgICAgICAg IAlpZiAoIWlzTmFOKGxlbmd0aCkpCisgICAgICAgIAkJb2JqZWN0LnN0eWxlLmhlaWdodCA9IGxl bmd0aCArICJweCI7CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KICAgICA8c3R5bGUgdHlwZT0i dGV4dC9jc3MiPgogICAgICAgICBAaW1wb3J0ICJpbnNwZWN0b3IuY3NzIjsKICAgICA8L3N0eWxl Pgo= 12061 2006-12-27 09:04:49 -0800 2006-12-27 14:07:21 -0800 better patch InspcScroll2.txt text/plain 2508 dev+webkit SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTg0MzIpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTcgQEAKKzIwMDYtMTItMjcgIE1hdHQgTGlsZWsgIDxwZXd0ZXJtb29zZUBnbWFpbC5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAg ICAgICBCdWcgMTE5OTM6IFJFR1JFU1NJT04ocjE4MzIwKTogV2ViIEluc3BlY3RvciBzY3JvbGwg YmFycyBub3QgZHJhd24KKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE5OTMKKyAgICAgICAgCisgICAgICAgIEFwcGxlVmVydGljYWxTY3JvbGxiYXIgdHJp ZXMgdG8gc2V0IGEgTmFOIHZhbHVlIGFzIHRoZSBzY3JvbGwgaGVpZ2h0IHdoaWNoCisgICAgICAg IGNhdXNlcyBET00gRXhjZXB0aW9ucyBhZnRlciByMTgzMjAuICBUaGlzIG92ZXJyaWRlcyB0aGUg X3NldE9iamVjdExlbmd0aAorICAgICAgICBtZXRob2QgYW5kIGNoZWNrcyBmb3IgTmFOIHVudGls IGEgc3lzdGVtIHVwZGF0ZSBjYW4gZml4IHRoaXMuICBTZWUgcmRhcjovLzQ5MDE0OTEKKworICAg ICAgICAqIFdlYkluc3BlY3Rvci93ZWJJbnNwZWN0b3IvaW5zcGVjdG9yLmh0bWw6CisgICAgICAg ICogV2ViSW5zcGVjdG9yL3dlYkluc3BlY3Rvci9pbnNwZWN0b3IuanM6CisKIDIwMDYtMTItMjYg IEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYktpdC9XZWJJbnNwZWN0b3Ivd2ViSW5zcGVjdG9yL2lu c3BlY3Rvci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9XZWJJbnNwZWN0b3Ivd2ViSW5zcGVj dG9yL2luc3BlY3Rvci5odG1sCShyZXZpc2lvbiAxODQyMCkKKysrIFdlYktpdC9XZWJJbnNwZWN0 b3Ivd2ViSW5zcGVjdG9yL2luc3BlY3Rvci5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw5ICsz MCw5IEBAIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE8KIDxoZWFkPgog ICAgIDxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQtdHlwZSIgY29udGVudD0idGV4dC9odG1sOyBj aGFyc2V0PXV0Zi04IiAvPgogICAgIDx0aXRsZT5XZWIgSW5zcGVjdG9yPC90aXRsZT4KLSAgICA8 c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgc3JjPSJpbnNwZWN0b3IuanMiPjwvc2NyaXB0 PiAKLSAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgc3JjPSJmaWxlOi8vL1N5c3Rl bS9MaWJyYXJ5L1dpZGdldFJlc291cmNlcy9BcHBsZUNsYXNzZXMvQXBwbGVTY3JvbGxiYXIuanMi Pjwvc2NyaXB0PiAgICAKKyAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgc3JjPSJm aWxlOi8vL1N5c3RlbS9MaWJyYXJ5L1dpZGdldFJlc291cmNlcy9BcHBsZUNsYXNzZXMvQXBwbGVT Y3JvbGxiYXIuanMiPjwvc2NyaXB0PgogICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0 IiBzcmM9ImZpbGU6Ly8vU3lzdGVtL0xpYnJhcnkvV2lkZ2V0UmVzb3VyY2VzL0FwcGxlQ2xhc3Nl cy9BcHBsZVNjcm9sbEFyZWEuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgdHlwZT0idGV4dC9q YXZhc2NyaXB0IiBzcmM9Imluc3BlY3Rvci5qcyI+PC9zY3JpcHQ+CiAgICAgPHN0eWxlIHR5cGU9 InRleHQvY3NzIj4KICAgICAgICAgQGltcG9ydCAiaW5zcGVjdG9yLmNzcyI7CiAgICAgPC9zdHls ZT4KSW5kZXg6IFdlYktpdC9XZWJJbnNwZWN0b3Ivd2ViSW5zcGVjdG9yL2luc3BlY3Rvci5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvV2ViSW5zcGVjdG9yL3dlYkluc3BlY3Rvci9pbnNwZWN0b3Iu anMJKHJldmlzaW9uIDE4NDIwKQorKysgV2ViS2l0L1dlYkluc3BlY3Rvci93ZWJJbnNwZWN0b3Iv aW5zcGVjdG9yLmpzCSh3b3JraW5nIGNvcHkpCkBAIC05MjcsMyArOTI3LDEwIEBAIGZ1bmN0aW9u IHVwZGF0ZVByb3BlcnRpZXNQYW5lKCkKIAogICAgIGpzUHJvcGVydGllc1Njcm9sbEFyZWEucmVm cmVzaCgpOwogfQorCisvLyBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgcmRhcjovLzQ5MDE0OTEg LSBEYXNoYm9hcmQgQXBwbGVDbGFzc2VzIHRyeSB0byBzZXQgYSBOYU4gdmFsdWUgYW5kIGJyZWFr IHRoZSBzY3JvbGxiYXIuCitBcHBsZVZlcnRpY2FsU2Nyb2xsYmFyLnByb3RvdHlwZS5fc2V0T2Jq ZWN0TGVuZ3RoID0gZnVuY3Rpb24ob2JqZWN0LCBsZW5ndGgpCit7CisgICAgaWYgKCFpc05hTihs ZW5ndGgpKQorICAgICAgICBvYmplY3Quc3R5bGUuaGVpZ2h0ID0gbGVuZ3RoICsgInB4IjsKK30K