119433 2013-08-01 23:55:04 -0700 REGRESSION: ARM Still crashes after change set r153612 2013-10-31 13:27:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified All RESOLVED FIXED P1 Blocker --- 119140 119569 108645 1 msaboff webkit-unassigned allan.jensen barraclough cgarcia commit-queue fpizlo ggaren hausmann jbriance loki mark.lam mhahnenberg msaboff oliver ossy rgabor xinchao.peng zan zherczeg oldest_to_newest 914028 0 msaboff 2013-08-01 23:55:04 -0700 The fix https://bugs.webkit.org/show_bug.cgi?id=119140 "REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer" didn't completely resolve the crashes on ARM. 914030 1 207987 msaboff 2013-08-02 00:04:40 -0700 Created attachment 207987 Patch to set callFrameRegister to value returned by cti_vm_throw_slowpath 914032 2 commit-queue 2013-08-02 00:13:03 -0700 Attachment 207987 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITStubsARM.h', u'Source/JavaScriptCore/jit/JITStubsARMv7.h']" exit_code: 1 Source/JavaScriptCore/jit/JITStubsARM.h:211: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 914042 3 ossy 2013-08-02 00:54:53 -0700 I tried this patch, but unfortunately it didn't help. - ARM traditional results: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9252 - ARM Thumb2 results: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9253 I'll try to collect some debug infos a little bit later. 914057 4 207994 jbriance 2013-08-02 01:22:23 -0700 Created attachment 207994 ctiVMThrowTrampolineSlowpath fix for ARM and ARMv7 architectures. I think this would work better. This patch is similar to what I've done for sh4 architecture (in http://trac.webkit.org/changeset/153583). 914103 5 ossy 2013-08-02 06:08:43 -0700 (In reply to comment #4) > Created an attachment (id=207994) [details] > ctiVMThrowTrampolineSlowpath fix for ARM and ARMv7 architectures. > > I think this would work better. This patch is similar to what I've done for sh4 architecture (in http://trac.webkit.org/changeset/153583). It seems it works: - ARM Thumb2: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9254 (still runs ...) - ARM Traditional: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/9255 (will start in an hour ...) 914147 6 207994 commit-queue 2013-08-02 07:58:17 -0700 Comment on attachment 207994 ctiVMThrowTrampolineSlowpath fix for ARM and ARMv7 architectures. Clearing flags on attachment: 207994 Committed r153648: <http://trac.webkit.org/changeset/153648> 914148 7 ggaren 2013-08-02 08:03:57 -0700 > Update call frame and do not restore registers from JIT stack frame in ARM and ARMv7 implementations of ctiVMThrowTrampolineSlowpath. Can you comment on why we should not restore these registers? 914162 8 jbriance 2013-08-02 08:49:00 -0700 (In reply to comment #7) > > Can you comment on why we should not restore these registers? From what I saw with gdb, the handler address retrieved in ctiVMThrowTrampolineSlowpath function in r1 register is likely to be the address of ctiOpThrowNotCaught, where registers are restored from JIT stack frame. So without this patch, we did the work twice, leading to unexpected values and misplaced stack pointer during the "second restore from JIT stack frame" in ctiOpThrowNotCaught. 945655 9 207987 ossy 2013-10-31 13:27:10 -0700 Comment on attachment 207987 Patch to set callFrameRegister to value returned by cti_vm_throw_slowpath The bug is closed and the fix already landed. 207987 2013-08-02 00:04:40 -0700 2013-10-31 13:27:10 -0700 Patch to set callFrameRegister to value returned by cti_vm_throw_slowpath 119433.patch text/plain 2073 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUzNjM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA4LTAxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEVHUkVTU0lPTjogQVJNIFN0aWxsIGNyYXNoZXMgYWZ0ZXIgY2hhbmdlIHNldCByMTUzNjEy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTk0MzMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBuZWVk IHRvIHNldCB0aGUgY2FsbEZyYW1lUmVnaXN0ZXIgKHI1IG9uIEFSTSkgZnJvbSByMCByZXR1cm5l ZCBjdGlfdm1fdGhyb3dfc2xvd3BhdGguCisKKyAgICAgICAgKiBqaXQvSklUU3R1YnNBUk0uaDoK KyAgICAgICAgKiBqaXQvSklUU3R1YnNBUk12Ny5oOgorCiAyMDEzLTA4LTAxICBSdXRoIEZvbmcg IDxydXRoX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFtGb3JtczogY29sb3JdIDxpbnB1dCB0 eXBlPSdjb2xvcic+IHBvcG92ZXIgY29sb3Igd2VsbCBpbXBsZW1lbnRhdGlvbgpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVic0FSTS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnNBUk0uaAkocmV2aXNpb24gMTUzNjEyKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVic0FSTS5oCSh3b3JraW5nIGNvcHkpCkBA IC0yMDgsNiArMjA4LDcgQEAgU1lNQk9MX1NUUklORyhjdGlWTVRocm93VHJhbXBvbGluZVNsb3dw YQogICAgICAiYWRkIHNwLCBzcCwgIyIgU1RSSU5HSVpFX1ZBTFVFX09GKFBSRVNFUlZFRFI0X09G RlNFVCkgIlxuIgogICAgICAibGRtaWEgc3AhLCB7cjQtcjYsIHI4LXIxMSwgbHJ9IiAiXG4iCiAg ICAgICJhZGQgc3AsIHNwLCAjMTIiICJcbiIKKyAgICAgIm1vdiByNSwgcjAiICJcbiIKICAgICAg ImJ4IHIxIiAiXG4iCiApOwogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0 dWJzQVJNdjcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0 dWJzQVJNdjcuaAkocmV2aXNpb24gMTUzNjEyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRTdHVic0FSTXY3LmgJKHdvcmtpbmcgY29weSkKQEAgLTI4NCwxMCArMjg0LDEwIEBAIFNZ TUJPTF9TVFJJTkcoY3RpVk1UaHJvd1RyYW1wb2xpbmVTbG93cGEKICAgICAibGRyIHI4LCBbc3As ICMiIFNUUklOR0laRV9WQUxVRV9PRihQUkVTRVJWRURfUjhfT0ZGU0VUKSAiXSIgIlxuIgogICAg ICJsZHIgcjcsIFtzcCwgIyIgU1RSSU5HSVpFX1ZBTFVFX09GKFBSRVNFUlZFRF9SN19PRkZTRVQp ICJdIiAiXG4iCiAgICAgImxkciByNiwgW3NwLCAjIiBTVFJJTkdJWkVfVkFMVUVfT0YoUFJFU0VS VkVEX1I2X09GRlNFVCkgIl0iICJcbiIKLSAgICAibGRyIHI1LCBbc3AsICMiIFNUUklOR0laRV9W QUxVRV9PRihQUkVTRVJWRURfUjVfT0ZGU0VUKSAiXSIgIlxuIgogICAgICJsZHIgcjQsIFtzcCwg IyIgU1RSSU5HSVpFX1ZBTFVFX09GKFBSRVNFUlZFRF9SNF9PRkZTRVQpICJdIiAiXG4iCiAgICAg ImxkciBsciwgW3NwLCAjIiBTVFJJTkdJWkVfVkFMVUVfT0YoUFJFU0VSVkVEX1JFVFVSTl9BRERS RVNTX09GRlNFVCkgIl0iICJcbiIKICAgICAiYWRkIHNwLCBzcCwgIyIgU1RSSU5HSVpFX1ZBTFVF X09GKEZJUlNUX1NUQUNLX0FSR1VNRU5UKSAiXG4iCisgICAgIm1vdiByNSwgcjAiICJcbiIKICAg ICAiYnggcjEiICJcbiIKICk7CiAK 207994 2013-08-02 01:22:23 -0700 2013-08-02 07:58:16 -0700 ctiVMThrowTrampolineSlowpath fix for ARM and ARMv7 architectures. bug-119433.patch text/plain 3068 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUzNjM3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEzLTA4LTAyICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIFJFR1JFU1NJT046IEFSTSBzdGlsbCBjcmFzaGVzIGFmdGVyIGNoYW5nZSBzZXQgcjE1 MzYxMi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx OTQzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVw ZGF0ZSBjYWxsIGZyYW1lIGFuZCBkbyBub3QgcmVzdG9yZSByZWdpc3RlcnMgZnJvbSBKSVQgc3Rh Y2sgZnJhbWUgaW4gQVJNIGFuZCBBUk12NworICAgICAgICBpbXBsZW1lbnRhdGlvbnMgb2YgY3Rp Vk1UaHJvd1RyYW1wb2xpbmVTbG93cGF0aC4gVGhpcyBjaGFuZ2UgaXMgc2ltaWxhciB0byByMTUz NTgzCisgICAgICAgIGZvciBzaDQgYXJjaGl0ZWN0dXJlLgorCisgICAgICAgICogaml0L0pJVFN0 dWJzQVJNLmg6CisgICAgICAgICogaml0L0pJVFN0dWJzQVJNdjcuaDoKKwogMjAxMy0wOC0wMSAg UnV0aCBGb25nICA8cnV0aF9mb25nQGFwcGxlLmNvbT4KIAogICAgICAgICBbRm9ybXM6IGNvbG9y XSA8aW5wdXQgdHlwZT0nY29sb3InPiBwb3BvdmVyIGNvbG9yIHdlbGwgaW1wbGVtZW50YXRpb24K SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnNBUk0uaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzQVJNLmgJKHJldmlzaW9uIDE1 MzYzNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnNBUk0uaAkod29ya2lu ZyBjb3B5KQpAQCAtMjA0LDExICsyMDQsOSBAQCBJTkxJTkVfQVJNX0ZVTkNUSU9OKGN0aVZNVGhy b3dUcmFtcG9saW5lCiBTWU1CT0xfU1RSSU5HKGN0aVZNVGhyb3dUcmFtcG9saW5lU2xvd3BhdGgp ICI6IiAiXG4iCiAgICAgIm1vdiByMCwgcjUiICJcbiIKICAgICAiYmwgIiBTWU1CT0xfU1RSSU5H KGN0aV92bV90aHJvd19zbG93cGF0aCkgIlxuIgotICAgICAvLyBXaGVuIGN0aV92bV90aHJvd19z bG93cGF0aCByZXR1cm5zLCByMCBoYXMgY2FsbEZyYW1lIGFuZCByMSBoYXMgaGFuZGxlciBhZGRy ZXNzCi0gICAgICJhZGQgc3AsIHNwLCAjIiBTVFJJTkdJWkVfVkFMVUVfT0YoUFJFU0VSVkVEUjRf T0ZGU0VUKSAiXG4iCi0gICAgICJsZG1pYSBzcCEsIHtyNC1yNiwgcjgtcjExLCBscn0iICJcbiIK LSAgICAgImFkZCBzcCwgc3AsICMxMiIgIlxuIgotICAgICAiYnggcjEiICJcbiIKKyAgICAvLyBX aGVuIGN0aV92bV90aHJvd19zbG93cGF0aCByZXR1cm5zLCByMCBoYXMgY2FsbEZyYW1lIGFuZCBy MSBoYXMgaGFuZGxlciBhZGRyZXNzCisgICAgIm1vdiByNSwgcjAiICJcbiIKKyAgICAiYnggcjEi ICJcbiIKICk7CiAKICNpZiBVU0UoTUFTTV9QUk9CRSkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvSklUU3R1YnNBUk12Ny5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvSklUU3R1YnNBUk12Ny5oCShyZXZpc2lvbiAxNTM2MzcpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzQVJNdjcuaAkod29ya2luZyBjb3B5KQpAQCAtMjc3LDE3 ICsyNzcsOCBAQCBISURFX1NZTUJPTChjdGlWTVRocm93VHJhbXBvbGluZVNsb3dwYXRoCiBTWU1C T0xfU1RSSU5HKGN0aVZNVGhyb3dUcmFtcG9saW5lU2xvd3BhdGgpICI6IiAiXG4iCiAgICAgIm1v diByMCwgcjUiICJcbiIKICAgICAiYmwgIiBMT0NBTF9SRUZFUkVOQ0UoY3RpX3ZtX3Rocm93X3Ns b3dwYXRoKSAiXG4iCi0gICAgIC8vIFdoZW4gY3RpX3ZtX3Rocm93X3Nsb3dwYXRoIHJldHVybnMs IHIwIGhhcyBjYWxsRnJhbWUgYW5kIHIxIGhhcyBoYW5kbGVyIGFkZHJlc3MKLSAgICAibGRyIHIx MSwgW3NwLCAjIiBTVFJJTkdJWkVfVkFMVUVfT0YoUFJFU0VSVkVEX1IxMV9PRkZTRVQpICJdIiAi XG4iCi0gICAgImxkciByMTAsIFtzcCwgIyIgU1RSSU5HSVpFX1ZBTFVFX09GKFBSRVNFUlZFRF9S MTBfT0ZGU0VUKSAiXSIgIlxuIgotICAgICJsZHIgcjksIFtzcCwgIyIgU1RSSU5HSVpFX1ZBTFVF X09GKFBSRVNFUlZFRF9SOV9PRkZTRVQpICJdIiAiXG4iCi0gICAgImxkciByOCwgW3NwLCAjIiBT VFJJTkdJWkVfVkFMVUVfT0YoUFJFU0VSVkVEX1I4X09GRlNFVCkgIl0iICJcbiIKLSAgICAibGRy IHI3LCBbc3AsICMiIFNUUklOR0laRV9WQUxVRV9PRihQUkVTRVJWRURfUjdfT0ZGU0VUKSAiXSIg IlxuIgotICAgICJsZHIgcjYsIFtzcCwgIyIgU1RSSU5HSVpFX1ZBTFVFX09GKFBSRVNFUlZFRF9S Nl9PRkZTRVQpICJdIiAiXG4iCi0gICAgImxkciByNSwgW3NwLCAjIiBTVFJJTkdJWkVfVkFMVUVf T0YoUFJFU0VSVkVEX1I1X09GRlNFVCkgIl0iICJcbiIKLSAgICAibGRyIHI0LCBbc3AsICMiIFNU UklOR0laRV9WQUxVRV9PRihQUkVTRVJWRURfUjRfT0ZGU0VUKSAiXSIgIlxuIgotICAgICJsZHIg bHIsIFtzcCwgIyIgU1RSSU5HSVpFX1ZBTFVFX09GKFBSRVNFUlZFRF9SRVRVUk5fQUREUkVTU19P RkZTRVQpICJdIiAiXG4iCi0gICAgImFkZCBzcCwgc3AsICMiIFNUUklOR0laRV9WQUxVRV9PRihG SVJTVF9TVEFDS19BUkdVTUVOVCkgIlxuIgorICAgIC8vIFdoZW4gY3RpX3ZtX3Rocm93X3Nsb3dw YXRoIHJldHVybnMsIHIwIGhhcyBjYWxsRnJhbWUgYW5kIHIxIGhhcyBoYW5kbGVyIGFkZHJlc3MK KyAgICAibW92IHI1LCByMCIgIlxuIgogICAgICJieCByMSIgIlxuIgogKTsKIAo=