119122 2013-07-25 20:43:10 -0700 REGRESSION(r139282): Fix document leak when selection is created inside the document 2015-06-20 09:06:03 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate, InRadar, Regression P2 Normal --- 103955 146182 1 rniwa rniwa darin enrica webkit-bug-importer oldest_to_newest 911851 0 rniwa 2013-07-25 20:43:10 -0700 The FrameSelection::m_previousCaretNode may hold onto a Node inside the document with the selection. Merge https://chromium.googlesource.com/chromium/blink/+/b908cb4c8da93316d787de31c93f2a43de332a10 911853 1 207505 rniwa 2013-07-25 20:50:08 -0700 Created attachment 207505 Fixes the bug 911855 2 webkit-bug-importer 2013-07-25 20:50:42 -0700 <rdar://problem/14556358> 911857 3 rniwa 2013-07-25 20:56:03 -0700 Clearly, this is a regression from http://trac.webkit.org/changeset/146403. 911858 4 rniwa 2013-07-25 20:57:18 -0700 Rather http://trac.webkit.org/changeset/139282. 911859 5 rniwa 2013-07-25 20:58:01 -0700 Committed r153366: <http://trac.webkit.org/changeset/153366> 913005 6 ap 2013-07-30 13:28:35 -0700 The test added here is super flaky (maybe b/f cache)? I can reproduce locally with run-webkit-tests editing/selection/leak-document-with-selection-inside.html --repeat-each 2 913044 7 ap 2013-07-30 15:16:26 -0700 Added a gc() call in <http://trac.webkit.org/r153498>, let's see how much this helps. 1103627 8 ddkilzer 2015-06-20 09:06:03 -0700 (In reply to comment #7) > Added a gc() call in <http://trac.webkit.org/r153498>, let's see how much > this helps. Test is flaking a bit more in June 2015: Bug 146182: editing/selection/leak-document-with-selection-inside.html is flaky (always fails on Apple Win 7) <https://bugs.webkit.org/show_bug.cgi?id=146182> 207505 2013-07-25 20:50:08 -0700 2013-07-25 20:54:32 -0700 Fixes the bug bug-119122-20130725205007.patch text/plain 5014 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzM2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA3LTI1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEZpeCBkb2N1bWVudCBsZWFrIHdo ZW4gc2VsZWN0aW9uIGlzIGNyZWF0ZWQgaW5zaWRlIHRoZSBkb2N1bWVudAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5MTIyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVyZ2UgaHR0cHM6Ly9jaHJvbWl1 bS5nb29nbGVzb3VyY2UuY29tL2Nocm9taXVtL2JsaW5rLysvYjkwOGNiNGM4ZGE5MzMxNmQ3ODdk ZTMxYzkzZjJhNDNkZTMzMmExMAorCisgICAgICAgIFRoZSBidWcgd2FzIGNhdXNlZCBieSBGcmFt ZVNlbGVjdGlvbjo6bV9wcmV2aW91c0NhcmV0Tm9kZSBob2xkaW5nIG9udG8gYSBOb2RlLCBsZWFr aW5nIGl0cyBkb2N1bWVudC4KKyAgICAgICAgRml4ZWQgdGhlIGJ1ZyBieSBleHBsaWNpdGx5IGNs ZWFyaW5nIGl0IGluIEZyYW1lU2VsZWN0aW9uOjpwcmVwYXJlRm9yRGVzdHJ1Y3Rpb24uCisKKyAg ICAgICAgVGVzdDogZWRpdGluZy9zZWxlY3Rpb24vbGVhay1kb2N1bWVudC13aXRoLXNlbGVjdGlv bi1pbnNpZGUuaHRtbAorCisgICAgICAgICogZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGcmFtZVNlbGVjdGlvbjo6cHJlcGFyZUZvckRlc3RydWN0aW9uKToK KwogMjAxMy0wNy0yNSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAg ICAgQ2hyb21lQ2xpZW50Ojpmb2N1c2VkTm9kZUNoYW5nZWQoKSBzaG91bGQgYmUgZm9jdXNlZEVs ZW1lbnRDaGFuZ2VkKCkuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0 aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0 aW9uLmNwcAkocmV2aXNpb24gMTUzMzY1KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFt ZVNlbGVjdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMDksNiArMTIwOSw3IEBAIHZvaWQg RnJhbWVTZWxlY3Rpb246OnByZXBhcmVGb3JEZXN0cnVjdGkKICAgICAgICAgdmlldy0+Y2xlYXJT ZWxlY3Rpb24oKTsKIAogICAgIHNldFNlbGVjdGlvbihWaXNpYmxlU2VsZWN0aW9uKCksIENsb3Nl VHlwaW5nIHwgQ2xlYXJUeXBpbmdTdHlsZSB8IERvTm90VXBkYXRlQXBwZWFyYW5jZSk7CisgICAg bV9wcmV2aW91c0NhcmV0Tm9kZS5jbGVhcigpOwogfQogCiB2b2lkIEZyYW1lU2VsZWN0aW9uOjpz ZXRTdGFydChjb25zdCBWaXNpYmxlUG9zaXRpb24gJnBvcywgRVVzZXJUcmlnZ2VyZWQgdHJpZ2dl cikKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzM2NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTI1ICBSeW9zdWtlIE5pd2Eg IDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEZpeCBkb2N1bWVudCBsZWFrIHdoZW4gc2Vs ZWN0aW9uIGlzIGNyZWF0ZWQgaW5zaWRlIHRoZSBkb2N1bWVudAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5MTIyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSByZWdyZXNzaW9uIHRlc3QuCisK KyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9sZWFrLWRvY3VtZW50LXdpdGgtc2VsZWN0aW9u LWluc2lkZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9u L2xlYWstZG9jdW1lbnQtd2l0aC1zZWxlY3Rpb24taW5zaWRlLmh0bWw6IEFkZGVkLgorCiAyMDEz LTA3LTI1ICBCZW0gSm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgogCiAgICAgICAgIFtD U1MgU2hhcGVzXSBOZXcgcG9zaXRpb25pbmcgbW9kZWw6IHN1cHBvcnQgZm9yIGluc2V0IHJlY3Rh bmdsZSBzaGFwZS1vdXRzaWRlCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9s ZWFrLWRvY3VtZW50LXdpdGgtc2VsZWN0aW9uLWluc2lkZS1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbGVhay1kb2N1bWVudC13aXRoLXNl bGVjdGlvbi1pbnNpZGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMv ZWRpdGluZy9zZWxlY3Rpb24vbGVhay1kb2N1bWVudC13aXRoLXNlbGVjdGlvbi1pbnNpZGUtZXhw ZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTIgQEAKK1RoaXMgdGVzdCBhc3Nl cnRzIHRoYXQgZG9jdW1lbnQgZG9lc24ndCBsZWFrIHdoZW4gYSBzZWxlY3Rpb24gaXMgY3JlYXRl ZCBpbnNpZGUgdGhlIGRvY3VtZW50LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKwor UEFTUyBpbnRlcm5hbHMubnVtYmVyT2ZMaXZlRG9jdW1lbnRzKCkgaXMgb3JpZ2luYWxOdW1iZXJP ZkxpdmVEb2N1bWVudHMKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBD T01QTEVURQorVGhpcyB0ZXN0IG9ubHkgcnVucyBvbiBEdW1wUmVuZGVyVHJlZSwgYXMgaXQgcmVx dWlyZXMgZXhpc3RlbmNlIG9mIHdpbmRvdy5pbnRlcm5hbHMgYW5kIGNyb3NzLWRvbWFpbiByZXNv dXJjZSBhY2Nlc3MgY2hlY2sgZGlzYWJsZWQuCisKKwpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGlu Zy9zZWxlY3Rpb24vbGVhay1kb2N1bWVudC13aXRoLXNlbGVjdGlvbi1pbnNpZGUuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9sZWFrLWRvY3VtZW50LXdp dGgtc2VsZWN0aW9uLWluc2lkZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRp dGluZy9zZWxlY3Rpb24vbGVhay1kb2N1bWVudC13aXRoLXNlbGVjdGlvbi1pbnNpZGUuaHRtbAko d29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDQ4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPHA+VGhpcyB0ZXN0IG9ubHkgcnVucyBvbiBEdW1w UmVuZGVyVHJlZSwgYXMgaXQgcmVxdWlyZXMgZXhpc3RlbmNlIG9mIHdpbmRvdy5pbnRlcm5hbHMg YW5kIGNyb3NzLWRvbWFpbiByZXNvdXJjZSBhY2Nlc3MgY2hlY2sgZGlzYWJsZWQuPC9wPgorPGlm cmFtZSBpZD0iZnJhbWUiIHNyYz0nYWJvdXQ6YmxhbmsnPjwvaWZyYW1lPgorPHNjcmlwdCBzcmM9 Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3Jp cHQ+CitkZXNjcmlwdGlvbigiVGhpcyB0ZXN0IGFzc2VydHMgdGhhdCBkb2N1bWVudCBkb2Vzbid0 IGxlYWsgd2hlbiBhIHNlbGVjdGlvbiBpcyBjcmVhdGVkIGluc2lkZSB0aGUgZG9jdW1lbnQuIik7 CisKK2lmICh3aW5kb3cuaW50ZXJuYWxzKQorICAgIGpzVGVzdElzQXN5bmMgPSB0cnVlOworCit2 YXIgb3JpZ2luYWxOdW1iZXJPZkxpdmVEb2N1bWVudHMgPSAwOworCit2YXIgZnJhbWUgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgnZnJhbWUnKTsKK2ZyYW1lLm9ubG9hZCA9IGZ1bmN0aW9uKCkg eworICAgIGlmIChmcmFtZS5zcmMgPT09ICdhYm91dDpibGFuaycpCisgICAgICAgIHJldHVybiB0 cnVlOworCisgICAgKGZ1bmN0aW9uKCkgeworICAgICAgICB2YXIgY29udGVudFdpbmRvdyA9IGZy YW1lLmNvbnRlbnRXaW5kb3c7CisgICAgICAgIHZhciBlbGVtZW50ID0gY29udGVudFdpbmRvdy5k b2N1bWVudC5nZXRFbGVtZW50QnlJZCgidCIpOworICAgICAgICBjb250ZW50V2luZG93LmdldFNl bGVjdGlvbigpLnNldFBvc2l0aW9uKGVsZW1lbnQsIDApOworICAgIH0pKCk7CisKKyAgICBmcmFt ZS5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgZ2MoKTsKKyAgICAgICAgc2V0VGltZW91 dChmdW5jdGlvbiAoKSB7CisgICAgICAgICAgICBzaG91bGRCZSgiaW50ZXJuYWxzLm51bWJlck9m TGl2ZURvY3VtZW50cygpIiwgIm9yaWdpbmFsTnVtYmVyT2ZMaXZlRG9jdW1lbnRzIik7CisgICAg ICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAgICAgICAgfSwgMCk7CisgICAgfQorICAgIGZyYW1l LnNyYyA9ICdhYm91dDpibGFuayc7Cit9CisKK2Z1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgaWYg KCF3aW5kb3cuaW50ZXJuYWxzKQorICAgICAgICByZXR1cm47CisgICAgb3JpZ2luYWxOdW1iZXJP ZkxpdmVEb2N1bWVudHMgPSBpbnRlcm5hbHMubnVtYmVyT2ZMaXZlRG9jdW1lbnRzKCk7CisgICAg ZnJhbWUuc3JjID0gJ2RhdGE6dGV4dC9odG1sO2NoYXJzZXQ9dXRmLTgsPHNwYW4gaWQ9InQiPjwv c3Bhbj4nOworfQorCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKworPC9zY3JpcHQ+ Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48 L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==