118818 2013-07-17 15:11:36 -0700 Account for zoom when computing SVG font size 2024-08-06 15:19:14 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199236 https://bugs.webkit.org/show_bug.cgi?id=259435 https://jsfiddle.net/mEZq8/5/ BlinkMergeCandidate, InRadar, LayerBasedSVGEngine P2 Normal --- 1 rniwa fujii ahmad.saleem792 fujii krit pdr sabouhallawa simon.fraser webkit-bug-importer zimmermann oldest_to_newest 909478 0 rniwa 2013-07-17 15:11:36 -0700 Consider merging https://chromium.googlesource.com/chromium/blink/+/5624c6e475af92d541edc8a3394602e320d00323 Previously, text that was zoomed appeared larger than geometry under the same zoom value. This was caused by two bugs: 1) When setting the computed font size, we incorrectly referenced the computedTextSize instead of the specified size. 2) Text with GeometricPrecision did not set a computed size but instead relied on the text size being correct. This change addresses both of these issues and adds a test to prove correctness. 1899215 1 simon.fraser 2022-09-17 09:28:20 -0700 https://github.com/WebKit/WebKit/pull/4011 1899435 2 ahmad.saleem792 2022-09-19 00:52:01 -0700 There is an issue in this patch as it is and cause following regression: https://src.chromium.org/viewvc/blink?view=revision&revision=180995 1899759 3 ahmad.saleem792 2022-09-20 02:50:55 -0700 Just to document my PR attempt: https://github.com/WebKit/WebKit/pull/4011 ____________ 1) ScalingFactor can go below '1' so restricting it at "1" is not ideal. Someone need to think about on how to add this to the code and manage it. 2) iOS-wk2 has "text-size-adjst" in svg.css as "UA" stylesheet, so "font-small-enlarged-minimum-larger-expected.svg" does not work and have to add "platform" specific expectations. 3) font-small-enlarged-minimum-larger-expected.svg has "Script" in it, while it can be hardcoded to "80" to work perfectly fine except (2). 4) Due to LBSE work, GeometricPrecision work is now handled differently. ___________ Further, this patch had issue, which was resolved further in Comment 02 patch, so when merging, you had to account for both. I am waiting on final response but if I am not able to tackle it. I will close my PR 4011 and then leave it to someone else to finish it. Just wanted to summarise the work here. 1982244 4 ahmad.saleem792 2023-10-03 15:03:02 -0700 It is reproducible in LBSE only for 'purple' container, where the text 'A' does not go out of 'yellow' constraint but 'purple' container does get bigger. Adding tag to flag following issue. 1987361 5 ahmad.saleem792 2023-10-25 04:03:00 -0700 Might have to add this into mix: https://src.chromium.org/viewvc/blink?view=revision&revision=154004 2048126 6 fujii 2024-07-24 13:07:10 -0700 *** Bug 276984 has been marked as a duplicate of this bug. *** 2049395 7 fujii 2024-07-30 00:42:22 -0700 Pull request: https://github.com/WebKit/WebKit/pull/31452 2051037 8 ews-feeder 2024-08-06 15:18:59 -0700 Committed 281919@main (6639b68a68a6): <https://commits.webkit.org/281919@main> Reviewed commits have been landed. Closing PR #31452 and removing active labels. 2051038 9 webkit-bug-importer 2024-08-06 15:19:14 -0700 <rdar://problem/133331984>