118532 2013-07-10 09:07:48 -0700 [Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont 2013-08-15 09:22:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 119740 110211 0 fsemeria allan.jensen alikhtarev allan.jensen commit-queue jbriance jturcotte milian.wolff noam oldest_to_newest 907381 0 fsemeria 2013-07-10 09:07:48 -0700 memory leak in WebCore::FontCache::getLastResortFallbackFont 907382 1 206393 fsemeria 2013-07-10 09:12:27 -0700 Created attachment 206393 fix memory leak in FontCache::getLastResortFallbackFont 907585 2 206393 commit-queue 2013-07-11 03:29:39 -0700 Comment on attachment 206393 fix memory leak in FontCache::getLastResortFallbackFont Clearing flags on attachment: 206393 Committed r152563: <http://trac.webkit.org/changeset/152563> 907586 3 commit-queue 2013-07-11 03:29:42 -0700 All reviewed patches have been landed. Closing bug. 911006 4 alikhtarev 2013-07-23 05:53:33 -0700 It looks like after applying this patch any QtWebKit-based browser crashing on loading this site: http://www.kevs3d.co.uk/dev/canvasmark Tested on Ubuntu 12.04 64bit 911057 5 fsemeria 2013-07-23 09:06:30 -0700 Indeed, it looks like the Qt version of FontCache::getLastResortFallbackFont may now return a null pointer in some cases. It may be safer to revert the patch until a fix for this is available. 916656 6 commit-queue 2013-08-13 04:44:28 -0700 Re-opened since this is blocked by bug 119740 916661 7 208619 allan.jensen 2013-08-13 05:22:09 -0700 Created attachment 208619 Patch 916666 8 fsemeria 2013-08-13 05:37:06 -0700 (In reply to comment #7) > Created an attachment (id=208619) [details] > Patch We tested a patch similar to this one, and it works for us. 916668 9 allan.jensen 2013-08-13 05:41:18 -0700 (In reply to comment #8) > (In reply to comment #7) > > Created an attachment (id=208619) [details] [details] > > Patch > > We tested a patch similar to this one, and it works for us. Great. We also had a case where the old fix crashed Qt browser-demo on 32bit, and the new version doesn't. I never got Alex' example to crash though, can anyone confirm that also works? 917083 10 milian.wolff 2013-08-14 04:53:17 -0700 This patch works fine for me (see bug 119740 and bug 119088). 917493 11 208619 jturcotte 2013-08-15 06:37:09 -0700 Comment on attachment 208619 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208619&action=review > Source/WebCore/ChangeLog:8 > + Allocate FontPlatformData on the stack instead on the heap. A note that getCachedFontData does a deep copy of FontPlatformData could be useful to explain why this change is necessary. 917533 12 allan.jensen 2013-08-15 09:22:55 -0700 Committed r154103: <http://trac.webkit.org/changeset/154103> 206393 2013-07-10 09:12:27 -0700 2013-08-13 05:21:59 -0700 fix memory leak in FontCache::getLastResortFallbackFont bug_118532.patch text/plain 1500 fsemeria SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjUzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA3LTEwICBGYWJpZW5u ZSBTZW1lcmlhICAgPGZzZW1lcmlhQG5kcy5jb20+CisKKyAgICAgICAgW1F0XSBtZW1vcnkgbGVh ayBpbiBXZWJDb3JlOjpGb250Q2FjaGU6OmdldExhc3RSZXNvcnRGYWxsYmFja0ZvbnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODUzMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvRm9udENhY2hlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpn ZXRMYXN0UmVzb3J0RmFsbGJhY2tGb250KToKKwogMjAxMy0wNy0xMCAgU2VyZ2lvIENvcnJlaWEg IDxzZXJnaW8uY29ycmVpYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJlbW92ZSB0aGUgbWVz aFR5cGUgZnJvbSBDb29yZGluYXRlZEN1c3RvbUZpbHRlck9wZXJhdGlvbgpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udENhY2hlUXQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRDYWNoZVF0LmNwcAko cmV2aXNpb24gMTUyNTM1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQv Rm9udENhY2hlUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03Niw3ICs3Niw3IEBAIFBhc3NSZWZQ dHI8U2ltcGxlRm9udERhdGE+IEZvbnRDYWNoZTo6c3kKIFBhc3NSZWZQdHI8U2ltcGxlRm9udERh dGE+IEZvbnRDYWNoZTo6Z2V0TGFzdFJlc29ydEZhbGxiYWNrRm9udChjb25zdCBGb250RGVzY3Jp cHRpb24mIGZvbnREZXNjcmlwdGlvbiwgU2hvdWxkUmV0YWluIHNob3VsZFJldGFpbikKIHsKICAg ICBjb25zdCBBdG9taWNTdHJpbmcgZmFsbGJhY2tGYW1pbHkgPSBRRm9udChmb250RGVzY3JpcHRp b24uZmlyc3RGYW1pbHkoKSkubGFzdFJlc29ydEZhbWlseSgpOwotICAgIHJldHVybiBnZXRDYWNo ZWRGb250RGF0YShuZXcgRm9udFBsYXRmb3JtRGF0YShmb250RGVzY3JpcHRpb24sIGZhbGxiYWNr RmFtaWx5KSwgc2hvdWxkUmV0YWluKTsKKyAgICByZXR1cm4gZ2V0Q2FjaGVkRm9udERhdGEoZm9u dERlc2NyaXB0aW9uLCBmYWxsYmFja0ZhbWlseSwgZmFsc2UsIHNob3VsZFJldGFpbik7CiB9CiAK IHZvaWQgRm9udENhY2hlOjpnZXRUcmFpdHNJbkZhbWlseShjb25zdCBBdG9taWNTdHJpbmcmLCBW ZWN0b3I8dW5zaWduZWQ+JikK 208619 2013-08-13 05:22:09 -0700 2013-08-15 06:37:09 -0700 Patch bug-118532-20130813142208.patch text/plain 1752 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzOTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk2YWEzMjU0NmFkNmQx MzBkYjcxMjE0YjA5YWQ1Y2I1MDk5ZjA4Mi4uNzYyNTA2NGJkNWJjMjBlNDM4NmFiMjc5MDc2Mzhm YmRjYWE5MTNlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTEzICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gbWVtb3J5IGxlYWsgaW4gV2ViQ29yZTo6Rm9udENhY2hlOjpnZXRMYXN0UmVzb3J0RmFsbGJh Y2tGb250CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTg1MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB bGxvY2F0ZSBGb250UGxhdGZvcm1EYXRhIG9uIHRoZSBzdGFjayBpbnN0ZWFkIG9uIHRoZSBoZWFw LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udENhY2hlUXQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpnZXRMYXN0UmVzb3J0RmFsbGJhY2tGb250KToKKwog MjAxMy0wOC0xMyAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE1MjU2My4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRDYWNoZVF0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRDYWNoZVF0LmNwcAppbmRleCBhYzE1Yzlm NmZhM2JlYTNhNjE5YWRlYTVkODk4ZmRjZDU2ZmI4MDRkLi44YTk4N2M3ZWViMTIyNjAzNmE1ZjBl ZjE2OGQ1ZDdjZjM5NGJhOGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9Gb250Q2FjaGVRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvRm9udENhY2hlUXQuY3BwCkBAIC03Niw3ICs3Niw4IEBAIFBhc3NSZWZQdHI8 U2ltcGxlRm9udERhdGE+IEZvbnRDYWNoZTo6c3lzdGVtRmFsbGJhY2tGb3JDaGFyYWN0ZXJzKGNv bnN0IEZvbnREZXNjCiBQYXNzUmVmUHRyPFNpbXBsZUZvbnREYXRhPiBGb250Q2FjaGU6OmdldExh c3RSZXNvcnRGYWxsYmFja0ZvbnQoY29uc3QgRm9udERlc2NyaXB0aW9uJiBmb250RGVzY3JpcHRp b24sIFNob3VsZFJldGFpbiBzaG91bGRSZXRhaW4pCiB7CiAgICAgY29uc3QgQXRvbWljU3RyaW5n IGZhbGxiYWNrRmFtaWx5ID0gUUZvbnQoZm9udERlc2NyaXB0aW9uLmZpcnN0RmFtaWx5KCkpLmxh c3RSZXNvcnRGYW1pbHkoKTsKLSAgICByZXR1cm4gZ2V0Q2FjaGVkRm9udERhdGEobmV3IEZvbnRQ bGF0Zm9ybURhdGEoZm9udERlc2NyaXB0aW9uLCBmYWxsYmFja0ZhbWlseSksIHNob3VsZFJldGFp bik7CisgICAgRm9udFBsYXRmb3JtRGF0YSBwbGF0Zm9ybURhdGEoZm9udERlc2NyaXB0aW9uLCBm YWxsYmFja0ZhbWlseSk7CisgICAgcmV0dXJuIGdldENhY2hlZEZvbnREYXRhKCZwbGF0Zm9ybURh dGEsIHNob3VsZFJldGFpbik7CiB9CiAKIHZvaWQgRm9udENhY2hlOjpnZXRUcmFpdHNJbkZhbWls eShjb25zdCBBdG9taWNTdHJpbmcmLCBWZWN0b3I8dW5zaWduZWQ+JikK