118337 2013-07-02 19:48:59 -0700 Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch 2013-07-24 14:53:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser allan.jensen benjamin commit-queue dbates esprehn+autocc glenn jeffrey+webkit macpherson menard simon.fraser oldest_to_newest 905672 0 simon.fraser 2013-07-02 19:48:59 -0700 Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch 905674 1 205964 simon.fraser 2013-07-02 19:57:09 -0700 Created attachment 205964 Patch 905675 2 205964 benjamin 2013-07-02 20:01:56 -0700 Comment on attachment 205964 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205964&action=review > Source/WebCore/css/StyleResolver.cpp:1534 > + if ((isScrollableOverflow(style->overflowX()) || isScrollableOverflow(style->overflowY())) && style->useTouchOverflowScrolling()) Can you move style->useTouchOverflowScrolling() to be the first condition? (for readability). 905679 3 simon.fraser 2013-07-02 20:22:24 -0700 http://trac.webkit.org/changeset/152335 911429 4 dbates 2013-07-24 14:53:07 -0700 (In reply to comment #3) > http://trac.webkit.org/changeset/152335 This regressed both the rendering and the ability to scroll on <http://www.apple.com/mac-pro/index1.html>. See bug #119066 for more details. 205964 2013-07-02 19:57:09 -0700 2013-07-02 20:01:55 -0700 Patch bug-118337-20130702195507.patch text/plain 3721 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDAzZTA1ZjdiNjlhNGNj ZjllYWNlNzI4NzE1NjQyMDAxZTMyM2MwNy4uNGVlNDI4ODhhOTU1OGI2ODg3YzhiMDAyNTI5OTlj ZDI1YWJlOTI1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEzLTA3LTAyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IHNldCB6 LWluZGV4OiAwIG9uIGxvdHMgb2YgZWxlbWVudHMgd2l0aCAtd2Via2l0LW92ZXJmbG93LXNjcm9s bGluZzogdG91Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExODMzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIC13ZWJraXQtb3ZlcmZsb3ctc2Nyb2xsaW5nOiB0b3VjaCBpcyBhbiBpbmhlcml0ZWQgcHJv cGVydHkgdGhhdCwgb24gaU9TLCBjb250cm9scworICAgICAgICB0aGUgYmVoYXZpb3Igb2Ygb3Zl cmZsb3cgc2Nyb2xsaW5nIGNvbnRlbnQsIGFuZCBjYXVzZXMgb3ZlcmZsb3cgc2Nyb2xsaW5nIGVs ZW1lbnRzCisgICAgICAgIHRvIGJlY29tZSBDU1Mgc3RhY2tpbmcgY29udGV4dHMuCisgICAgICAg ICAKKyAgICAgICAgSG93ZXZlciwgdGhlIGNvZGUgd2FzIHRvbyBhZ2dyZXNzaXZlIGluIHNldHRp bmcgc3R5bGUtPnNldFpJbmRleCgwKSwgZG9pbmcgc28KKyAgICAgICAgZm9yIGFueSBlbGVtZW50 IHdpdGggb3ZlcmZsb3cgIT0gaGlkZGVuLiBTaW5jZSB0aGUgZGVmYXVsdCBmb3Igb3ZlcmZsb3cg aXMgdmlzaWJsZSwKKyAgICAgICAgdGhhdCBtZWFudCBhbG1vc3QgZXZlcnkgZWxlbWVudC4KKyAg ICAgICAgCisgICAgICAgIFByZXZpb3VzbHksIHRoaXMgZGlkbid0IHJlYWxseSBtYXR0ZXIuIEhv d2V2ZXIsIHNpbmNlIHIxMjU2OTMsIGFueSByZW5kZXJlciB3aXRoIG5vbi1hdXRvCisgICAgICAg IHotaW5kZXggZ2V0cyBhIFJlbmRlckxheWVyLCBhbmQgdGhhdCBSZW5kZXJMYXllciB3aWxsIGJl Y29tZSBhIHN0YWNraW5nIGNvbnRleHQuIFRoZSByZXN1bHQKKyAgICAgICAgd2FzIHRvbyBtYW55 IFJlbmRlckxheWVycyBhbmQgaW5jb3JyZWN0IHN0YWNraW5nIGNvbnRleHQgYmVoYXZpb3IuCisg ICAgICAgIAorICAgICAgICBGaXggYnkgZW5zdXJpbmcgdGhhdCAtd2Via2l0LW92ZXJmbG93LXNj cm9sbGluZzogdG91Y2ggIG9ubHkgYWZmZWN0cyBlbGVtZW50cyB3aGljaAorICAgICAgICBhcmUg YWN0dWFsbHkgc2Nyb2xsYWJsZS4KKyAgICAgICAgCisgICAgICAgIEFsc28gbW92ZSB0aGUgY29k ZSB0aGF0IGRvZXMgdGhpcyB0byBiZWxvdyB0aGUgY29kZSB0aGF0IGFkanVzdCBvdmVyZmxvdyBz dHlsZQorICAgICAgICBmb3IgZGlmZmVyZW50IGVsZW1lbnRzLgorCisgICAgICAgICogY3NzL1N0 eWxlUmVzb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNTY3JvbGxhYmxlT3ZlcmZsb3cp OgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVSZXNvbHZlcjo6YWRqdXN0UmVuZGVyU3R5bGUpOgor CiAyMDEzLTA3LTAxICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgogCiAg ICAgICAgIFtXaW5dIENyYXNoIHdoZW4gc2Nyb2xsaW5nIHBhZ2Ugd2l0aCBpbWFnZXMuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKaW5kZXggYTA3YWMzYWJjYTNhZDY4ZWI2ODg0MGU3 NmEzOTE4NTViYzM3MDA1Ny4uZWVmYmFlOTVlZjJiZGMyODhjM2JiMTBiMTQxYTMyZmJhMzc5MWFk MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAtMTM1Miw2ICsxMzUyLDEz IEBAIHN0YXRpYyBib29sIGlzRGlzcGxheUZsZXhpYmxlQm94KEVEaXNwbGF5IGRpc3BsYXkpCiAg ICAgcmV0dXJuIGRpc3BsYXkgPT0gRkxFWCB8fCBkaXNwbGF5ID09IElOTElORV9GTEVYOwogfQog CisjaWYgRU5BQkxFKEFDQ0VMRVJBVEVEX09WRVJGTE9XX1NDUk9MTElORykKK3N0YXRpYyBib29s IGlzU2Nyb2xsYWJsZU92ZXJmbG93KEVPdmVyZmxvdyBvdmVyZmxvdykKK3sKKyAgICByZXR1cm4g b3ZlcmZsb3cgPT0gT1NDUk9MTCB8fCBvdmVyZmxvdyA9PSBPQVVUTyB8fCBvdmVyZmxvdyA9PSBP T1ZFUkxBWTsKK30KKyNlbmRpZgorCiB2b2lkIFN0eWxlUmVzb2x2ZXI6OmFkanVzdFJlbmRlclN0 eWxlKFJlbmRlclN0eWxlKiBzdHlsZSwgUmVuZGVyU3R5bGUqIHBhcmVudFN0eWxlLCBFbGVtZW50 ICplKQogewogICAgIEFTU0VSVChwYXJlbnRTdHlsZSk7CkBAIC0xNDcwLDEwICsxNDc3LDYgQEAg dm9pZCBTdHlsZVJlc29sdmVyOjphZGp1c3RSZW5kZXJTdHlsZShSZW5kZXJTdHlsZSogc3R5bGUs IFJlbmRlclN0eWxlKiBwYXJlbnRTdHkKICAgICAgICAgfHwgc3R5bGUtPmhhc0JsZW5kTW9kZSgp CiAgICAgICAgIHx8IHN0eWxlLT5wb3NpdGlvbigpID09IFN0aWNreVBvc2l0aW9uCiAgICAgICAg IHx8IChzdHlsZS0+cG9zaXRpb24oKSA9PSBGaXhlZFBvc2l0aW9uICYmIGUgJiYgZS0+ZG9jdW1l bnQoKS0+cGFnZSgpICYmIGUtPmRvY3VtZW50KCktPnBhZ2UoKS0+c2V0dGluZ3MoKS0+Zml4ZWRQ b3NpdGlvbkNyZWF0ZXNTdGFja2luZ0NvbnRleHQoKSkKLSNpZiBFTkFCTEUoQUNDRUxFUkFURURf T1ZFUkZMT1dfU0NST0xMSU5HKQotICAgICAgICAvLyBUb3VjaCBvdmVyZmxvdyBzY3JvbGxpbmcg Y3JlYXRlcyBhIHN0YWNraW5nIGNvbnRleHQuCi0gICAgICAgIHx8ICgoc3R5bGUtPm92ZXJmbG93 WCgpICE9IE9ISURERU4gfHwgc3R5bGUtPm92ZXJmbG93WSgpICE9IE9ISURERU4pICYmIHN0eWxl LT51c2VUb3VjaE92ZXJmbG93U2Nyb2xsaW5nKCkpCi0jZW5kaWYKICNpZiBFTkFCTEUoRElBTE9H X0VMRU1FTlQpCiAgICAgICAgIHx8IChlICYmIGUtPmlzSW5Ub3BMYXllcigpKQogI2VuZGlmCkBA IC0xNTI2LDYgKzE1MjksMTIgQEAgdm9pZCBTdHlsZVJlc29sdmVyOjphZGp1c3RSZW5kZXJTdHls ZShSZW5kZXJTdHlsZSogc3R5bGUsIFJlbmRlclN0eWxlKiBwYXJlbnRTdHkKICAgICAgICAgc3R5 bGUtPnNldE92ZXJmbG93WShPVklTSUJMRSk7CiAgICAgfQogCisjaWYgRU5BQkxFKEFDQ0VMRVJB VEVEX09WRVJGTE9XX1NDUk9MTElORykKKyAgICAvLyBUb3VjaCBvdmVyZmxvdyBzY3JvbGxpbmcg Y3JlYXRlcyBhIHN0YWNraW5nIGNvbnRleHQuCisgICAgaWYgKChpc1Njcm9sbGFibGVPdmVyZmxv dyhzdHlsZS0+b3ZlcmZsb3dYKCkpIHx8IGlzU2Nyb2xsYWJsZU92ZXJmbG93KHN0eWxlLT5vdmVy Zmxvd1koKSkpICYmIHN0eWxlLT51c2VUb3VjaE92ZXJmbG93U2Nyb2xsaW5nKCkpCisgICAgICAg IHN0eWxlLT5zZXRaSW5kZXgoMCk7CisjZW5kaWYKKwogICAgIC8vIEN1bGwgb3V0IGFueSB1c2Vs ZXNzIGxheWVycyBhbmQgYWxzbyByZXBlYXQgcGF0dGVybnMgaW50byBhZGRpdGlvbmFsIGxheWVy cy4KICAgICBzdHlsZS0+YWRqdXN0QmFja2dyb3VuZExheWVycygpOwogICAgIHN0eWxlLT5hZGp1 c3RNYXNrTGF5ZXJzKCk7Cg==