118335 2013-07-02 19:24:29 -0700 fourthTier: Have fewer Arrayify's 2013-07-02 20:46:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 905670 0 fpizlo 2013-07-02 19:24:29 -0700 This affects the FTL because it's hard to do meaningful low-level optimizations when you have the control flow diamond that Arrayify causes. 905671 1 205963 fpizlo 2013-07-02 19:28:50 -0700 Created attachment 205963 the patch 905677 2 205963 mhahnenberg 2013-07-02 20:10:11 -0700 Comment on attachment 205963 the patch r=me 905680 3 fpizlo 2013-07-02 20:46:29 -0700 Landed in http://trac.webkit.org/changeset/152336 205963 2013-07-02 19:28:50 -0700 2013-07-02 20:10:11 -0700 the patch blah.patch text/plain 5110 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyMzMzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM1IEBA CisyMDEzLTA3LTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Zm91cnRoVGllcjogSGF2ZSBmZXdlciBBcnJheWlmeSdzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgzMzUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEEgbG90IG9mIEFycmF5aWZ5J3MgYXJp c2UgYmVjYXVzZSBzb21lIHByb2dyYW0gc2F3IEludDMyIGFycmF5cyBlYXJseSBvbiBpbgorICAg ICAgICBleGVjdXRpb24sIGJ1dCB0aGVuIHRoZXkgYWxsIGdvdCBjb252ZXJ0ZWQgdG8gRG91Ymxl IGFycmF5cyBhbmQgdGhlIHByb2dyYW0KKyAgICAgICAgd2lsbCBuZXZlciBzZWUgSW50MzIgYXJy YXlzIGV2ZXIgYWdhaW4uIFByaW9yIHRvIHRoaXMgY2hhbmdlIHlvdSB3b3VsZCBhbHdheXMKKyAg ICAgICAgaGF2ZSBhbiBBcnJheWlmeSBpbiB0aGlzIGNhc2UuIEJ1dCB3aXRoIHRoaXMgY2hhbmdl LCB0aGUgZmlyc3QgdGltZSB0aGF0IGFuCisgICAgICAgIEFycmF5UHJvZmlsZSBpcyBhYm91dCB0 byBnbyBwb2x5bW9ycGhpYyBpbiBjb21wdXRlVXBkYXRlZFByZWRpY3Rpb24oKSwgaXQKKyAgICAg ICAgaW5zdGVhZCBmb3JjaWJseSBtb25vbW9ycGhpc2VzIGl0c2VsZiB0byB0aGUgbGF0ZXN0LXNl ZW4gc3RydWN0dXJlLgorICAgICAgICBUaGVyZWFmdGVyIGl0IHdpbGwgbmV2ZXIgYWdhaW4gcGVy Zm9ybSB0aGlzIG1vbm9tb3JwaGlzYXRpb24uIFRoaXMgaXMKKyAgICAgICAgY29udHJvbGxlZCBi eSBBcnJheVByb2ZpbGU6Om1fZGlkUGVyZm9ybUZpcnN0UnVuUHJ1bmluZy4gVGhpcyBpcyBhIDUl CisgICAgICAgIHNwZWVkLXVwIG9uIEtyYWtlbi9pbWFnaW5nLWdhdXNzaWFuLWJsdXIgd2l0aCB0 aGUgRlRMIGVuYWJsZWQsIGFuZCBpdAorICAgICAgICB1bmJsb2NrcyBhIGJ1bmNoIG9mIHN0dWZm IHdlIHdhbnQgdG8gZG8gaW4gdGhlIGZ1dHVyZSBiZWNhdXNlIGl0IG1ha2VzIGEKKyAgICAgICAg YnVuY2ggb2YgbG9vcHMgZWZmZWN0LWZyZWUuCisgICAgICAgIAorICAgICAgICBXZSB3aWxsIHN0 aWxsIHdhbnQgdG8gaW1wbGVtZW50IEFycmF5aWZ5IGhvaXN0aW5nIGluIHRoZSBmdXR1cmUsIGJ1 dCB0aGlzIGlzCisgICAgICAgIGdyZWF0IGFueXdheSBiZWNhdXNlIGl0J3MgYmV0dGVyIHRvIG5v dCBoYXZlIEFycmF5aWZpY2F0aW9ucyB0aGFuIGl0IGlzIHRvCisgICAgICAgIGhhdmUgaG9pc3Rl ZCBBcnJheWlmaWNhdGlvbnMuCisKKyAgICAgICAgKiBieXRlY29kZS9BcnJheVByb2ZpbGUuY3Bw OgorICAgICAgICAoSlNDOjpBcnJheVByb2ZpbGU6OmNvbXB1dGVVcGRhdGVkUHJlZGljdGlvbik6 CisgICAgICAgIChKU0M6OkFycmF5UHJvZmlsZTo6YnJpZWZEZXNjcmlwdGlvbik6CisgICAgICAg IChKU0MpOgorICAgICAgICAoSlNDOjpBcnJheVByb2ZpbGU6OmJyaWVmRGVzY3JpcHRpb25XaXRo b3V0VXBkYXRpbmcpOgorICAgICAgICAqIGJ5dGVjb2RlL0FycmF5UHJvZmlsZS5oOgorICAgICAg ICAoSlNDOjpBcnJheVByb2ZpbGU6OkFycmF5UHJvZmlsZSk6CisgICAgICAgIChBcnJheVByb2Zp bGUpOgorCiAyMDEzLTA3LTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAg ICAgICAgZm91cnRoVGllcjogYWRkIG9wdGlvbiB0byBkaXNhYmxlIE9TUiBlbnRyeSBpbiBsb29w cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0FycmF5UHJvZmlsZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0FycmF5UHJvZmls ZS5jcHAJKHJldmlzaW9uIDE1MjMzMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k ZS9BcnJheVByb2ZpbGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OCw2ICs3OCwxNCBAQCB2b2lk IEFycmF5UHJvZmlsZTo6Y29tcHV0ZVVwZGF0ZWRQcmVkaWN0CiB7CiAgICAgaWYgKG1fbGFzdFNl ZW5TdHJ1Y3R1cmUpIHsKICAgICAgICAgbV9vYnNlcnZlZEFycmF5TW9kZXMgfD0gYXJyYXlNb2Rl RnJvbVN0cnVjdHVyZShtX2xhc3RTZWVuU3RydWN0dXJlKTsKKworICAgICAgICBpZiAoIW1fZGlk UGVyZm9ybUZpcnN0UnVuUHJ1bmluZworICAgICAgICAgICAgJiYgaGFzVHdvT3JNb3JlQml0c1Nl dChtX29ic2VydmVkQXJyYXlNb2RlcykpIHsKKyAgICAgICAgICAgIG1fb2JzZXJ2ZWRBcnJheU1v ZGVzID0gYXJyYXlNb2RlRnJvbVN0cnVjdHVyZShtX2xhc3RTZWVuU3RydWN0dXJlKTsKKyAgICAg ICAgICAgIG1fZXhwZWN0ZWRTdHJ1Y3R1cmUgPSAwOworICAgICAgICAgICAgbV9kaWRQZXJmb3Jt Rmlyc3RSdW5QcnVuaW5nID0gdHJ1ZTsKKyAgICAgICAgfQorICAgICAgICAKICAgICAgICAgbV9t YXlJbnRlcmNlcHRJbmRleGVkQWNjZXNzZXMgfD0KICAgICAgICAgICAgIG1fbGFzdFNlZW5TdHJ1 Y3R1cmUtPnR5cGVJbmZvKCkuaW50ZXJjZXB0c0dldE93blByb3BlcnR5U2xvdEJ5SW5kZXhFdmVu V2hlbkxlbmd0aElzTm90WmVybygpOwogICAgICAgICBpZiAoIWNvZGVCbG9jay0+Z2xvYmFsT2Jq ZWN0KCktPmlzT3JpZ2luYWxBcnJheVN0cnVjdHVyZShtX2xhc3RTZWVuU3RydWN0dXJlKSkKQEAg LTEwMyw3ICsxMTEsMTEgQEAgdm9pZCBBcnJheVByb2ZpbGU6OmNvbXB1dGVVcGRhdGVkUHJlZGlj dAogQ1N0cmluZyBBcnJheVByb2ZpbGU6OmJyaWVmRGVzY3JpcHRpb24oY29uc3QgQ29uY3VycmVu dEpJVExvY2tlciYgbG9ja2VyLCBDb2RlQmxvY2sqIGNvZGVCbG9jaykKIHsKICAgICBjb21wdXRl VXBkYXRlZFByZWRpY3Rpb24obG9ja2VyLCBjb2RlQmxvY2spOwotICAgIAorICAgIHJldHVybiBi cmllZkRlc2NyaXB0aW9uV2l0aG91dFVwZGF0aW5nKGxvY2tlcik7Cit9CisKK0NTdHJpbmcgQXJy YXlQcm9maWxlOjpicmllZkRlc2NyaXB0aW9uV2l0aG91dFVwZGF0aW5nKGNvbnN0IENvbmN1cnJl bnRKSVRMb2NrZXImIGxvY2tlcikKK3sKICAgICBTdHJpbmdQcmludFN0cmVhbSBvdXQ7CiAgICAg CiAgICAgYm9vbCBoYXNQcmludGVkID0gZmFsc2U7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYnl0ZWNvZGUvQXJyYXlQcm9maWxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL0FycmF5UHJvZmlsZS5oCShyZXZpc2lvbiAxNTIzMzIpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQXJyYXlQcm9maWxlLmgJKHdvcmtpbmcgY29weSkK QEAgLTEyNiw2ICsxMjYsNyBAQCBwdWJsaWM6CiAgICAgICAgICwgbV9vdXRPZkJvdW5kcyhmYWxz ZSkKICAgICAgICAgLCBtX21heUludGVyY2VwdEluZGV4ZWRBY2Nlc3NlcyhmYWxzZSkKICAgICAg ICAgLCBtX3VzZXNPcmlnaW5hbEFycmF5U3RydWN0dXJlcyh0cnVlKQorICAgICAgICAsIG1fZGlk UGVyZm9ybUZpcnN0UnVuUHJ1bmluZyhmYWxzZSkKICAgICAgICAgLCBtX29ic2VydmVkQXJyYXlN b2RlcygwKQogICAgIHsKICAgICB9CkBAIC0xMzgsNiArMTM5LDcgQEAgcHVibGljOgogICAgICAg ICAsIG1fb3V0T2ZCb3VuZHMoZmFsc2UpCiAgICAgICAgICwgbV9tYXlJbnRlcmNlcHRJbmRleGVk QWNjZXNzZXMoZmFsc2UpCiAgICAgICAgICwgbV91c2VzT3JpZ2luYWxBcnJheVN0cnVjdHVyZXMo dHJ1ZSkKKyAgICAgICAgLCBtX2RpZFBlcmZvcm1GaXJzdFJ1blBydW5pbmcoZmFsc2UpCiAgICAg ICAgICwgbV9vYnNlcnZlZEFycmF5TW9kZXMoMCkKICAgICB7CiAgICAgfQpAQCAtMTc5LDYgKzE4 MSw3IEBAIHB1YmxpYzoKICAgICBib29sIHVzZXNPcmlnaW5hbEFycmF5U3RydWN0dXJlcyhjb25z dCBDb25jdXJyZW50SklUTG9ja2VyJikgY29uc3QgeyByZXR1cm4gbV91c2VzT3JpZ2luYWxBcnJh eVN0cnVjdHVyZXM7IH0KICAgICAKICAgICBDU3RyaW5nIGJyaWVmRGVzY3JpcHRpb24oY29uc3Qg Q29uY3VycmVudEpJVExvY2tlciYsIENvZGVCbG9jayopOworICAgIENTdHJpbmcgYnJpZWZEZXNj cmlwdGlvbldpdGhvdXRVcGRhdGluZyhjb25zdCBDb25jdXJyZW50SklUTG9ja2VyJik7CiAgICAg CiBwcml2YXRlOgogICAgIGZyaWVuZCBjbGFzcyBMTEludE9mZnNldHNFeHRyYWN0b3I7CkBAIC0x OTAsOCArMTkzLDkgQEAgcHJpdmF0ZToKICAgICBTdHJ1Y3R1cmUqIG1fZXhwZWN0ZWRTdHJ1Y3R1 cmU7CiAgICAgYm9vbCBtX21heVN0b3JlVG9Ib2xlOyAvLyBUaGlzIGZsYWcgbWF5IGJlY29tZSBv dmVybG9hZGVkIHRvIGluZGljYXRlIG90aGVyIHNwZWNpYWwgY2FzZXMgdGhhdCB3ZXJlIGVuY291 bnRlcmVkIGR1cmluZyBhcnJheSBhY2Nlc3MsIGFzIGl0IGRlcGVuZHMgb24gaW5kZXhpbmcgdHlw ZS4gU2luY2Ugd2UgY3VycmVudGx5IGhhdmUgYmFzaWNhbGx5IGp1c3Qgb25lIGluZGV4aW5nIHR5 cGUgKHR3byB2YXJpYW50cyBvZiBBcnJheVN0b3JhZ2UpLCB0aGlzIGZsYWcgZm9yIG5vdyBqdXN0 IG1lYW5zIGV4YWN0bHkgd2hhdCBpdHMgbmFtZSBpbXBsaWVzLgogICAgIGJvb2wgbV9vdXRPZkJv dW5kczsKLSAgICBib29sIG1fbWF5SW50ZXJjZXB0SW5kZXhlZEFjY2Vzc2VzOwotICAgIGJvb2wg bV91c2VzT3JpZ2luYWxBcnJheVN0cnVjdHVyZXM7CisgICAgYm9vbCBtX21heUludGVyY2VwdElu ZGV4ZWRBY2Nlc3NlcyA6IDE7CisgICAgYm9vbCBtX3VzZXNPcmlnaW5hbEFycmF5U3RydWN0dXJl cyA6IDE7CisgICAgYm9vbCBtX2RpZFBlcmZvcm1GaXJzdFJ1blBydW5pbmcgOiAxOwogICAgIEFy cmF5TW9kZXMgbV9vYnNlcnZlZEFycmF5TW9kZXM7CiB9OwogCg==