118303 2013-07-02 06:58:59 -0700 [Curl] Crash after download. 2013-07-02 11:20:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned bfulgham commit-queue galpeter oldest_to_newest 905407 0 peavo 2013-07-02 06:58:59 -0700 I sometimes get a crash in Curl after a download has finished. The reason is that the Curl easy handle for the download has been deleted before it has been removed from the Curl multi handle. We need to make sure that the easy handle is removed from the Curl multi handle before it's freed. 905410 1 205909 peavo 2013-07-02 07:08:19 -0700 Created attachment 205909 Patch 905462 2 205909 bfulgham 2013-07-02 09:22:47 -0700 Comment on attachment 205909 Patch r=me. A nice solution to this problem! 905464 3 205909 commit-queue 2013-07-02 09:26:45 -0700 Comment on attachment 205909 Patch Clearing flags on attachment: 205909 Committed r152297: <http://trac.webkit.org/changeset/152297> 905465 4 commit-queue 2013-07-02 09:26:47 -0700 All reviewed patches have been landed. Closing bug. 905504 5 peavo 2013-07-02 11:20:17 -0700 (In reply to comment #2) > (From update of attachment 205909 [details]) > r=me. A nice solution to this problem! Thanks for the review ;) 205909 2013-07-02 07:08:19 -0700 2013-07-02 09:26:45 -0700 Patch bug-118303-20130702160551.patch text/plain 4071 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjI5MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA3LTAyICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBDcmFzaCBh ZnRlciBkb3dubG9hZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExODMwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlIG5lZWQgdG8gbWFrZSBzdXJlIHRoYXQgdGhlIEN1cmwgZWFzeSBoYW5kbGUgaXMg cmVtb3ZlZCBmcm9tIHRoZSBDdXJsIG11bHRpIGhhbmRsZSBiZWZvcmUgaXQncyBmcmVlZC4KKwor ICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuY3BwOgorICAgICAg ICAoQ3VybERvd25sb2FkTWFuYWdlcjo6dXBkYXRlSGFuZGxlTGlzdCk6IFVzZSBhZGRUb0N1cmwo KSBhbmQgcmVtb3ZlRnJvbUN1cmwoKSBtZXRob2RzLgorICAgICAgICAoQ3VybERvd25sb2FkTWFu YWdlcjo6YWRkVG9DdXJsKTogQWRkIG1ldGhvZCB0byBhZGQgZWFzeSBoYW5kbGUgdG8gbXVsdGkg aGFuZGxlLgorICAgICAgICAoQ3VybERvd25sb2FkTWFuYWdlcjo6cmVtb3ZlRnJvbUN1cmwpOiBB ZGQgbWV0aG9kIHRvIHJlbW92ZSBlYXN5IGhhbmRsZSBmcm9tIG11bHRpIGhhbmRsZSwgYW5kIHRo ZW4gZGVsZXRlIHRoZSBoYW5kbGUuCisgICAgICAgIChDdXJsRG93bmxvYWRNYW5hZ2VyOjpkb3du bG9hZFRocmVhZCk6IFVzZSByZW1vdmVGcm9tQ3VybCgpIG1ldGhvZC4KKyAgICAgICAgKEN1cmxE b3dubG9hZDo6fkN1cmxEb3dubG9hZCk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJs L0N1cmxEb3dubG9hZC5oOiBBdm9pZCBkZWxldGluZyBDdXJsIGVhc3kgaGFuZGxlIGluIGRlc3Ry dWN0b3IuCisKIDIwMTMtMDctMDIgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29t PgogCiAgICAgICAgIGlzL3RvSFRNTFN0eWxlRWxlbWVudCBzaG91bGQgdXNlIEVsZW1lbnQqIGZv ciBpdHMgYXJndW1lbnQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3Vy bC9DdXJsRG93bmxvYWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuY3BwCShyZXZpc2lvbiAxNTIyODApCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTIxLDIyICsxMjEsMzQgQEAgdm9pZCBDdXJsRG93bmxvYWRNYW5hZ2VyOjp1 cGRhdGVIYW5kbGVMaQogICAgIC8vIEFkZCBwZW5kaW5nIGN1cmwgZWFzeSBoYW5kbGVzIHRvIG11 bHRpIGxpc3QgCiAgICAgaW50IHNpemUgPSBtX3BlbmRpbmdIYW5kbGVMaXN0LnNpemUoKTsKICAg ICBmb3IgKGludCBpID0gMDsgaSA8IHNpemU7IGkrKykgewotICAgICAgICBDVVJMTWNvZGUgcmV0 dmFsID0gY3VybF9tdWx0aV9hZGRfaGFuZGxlKG1fY3VybE11bHRpSGFuZGxlLCBtX3BlbmRpbmdI YW5kbGVMaXN0WzBdKTsKLQotICAgICAgICBpZiAocmV0dmFsID09IENVUkxNX09LKQorICAgICAg ICBpZiAoYWRkVG9DdXJsKG1fcGVuZGluZ0hhbmRsZUxpc3RbMF0pKQogICAgICAgICAgICAgbV9w ZW5kaW5nSGFuZGxlTGlzdC5yZW1vdmUoMCk7CiAgICAgfQogCiAgICAgLy8gUmVtb3ZlIGN1cmwg ZWFzeSBoYW5kbGVzIGZyb20gbXVsdGkgbGlzdCAKICAgICBzaXplID0gbV9yZW1vdmVkSGFuZGxl TGlzdC5zaXplKCk7CiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBzaXplOyBpKyspIHsKLSAgICAg ICAgQ1VSTE1jb2RlIHJldHZhbCA9IGN1cmxfbXVsdGlfcmVtb3ZlX2hhbmRsZShtX2N1cmxNdWx0 aUhhbmRsZSwgbV9yZW1vdmVkSGFuZGxlTGlzdFswXSk7Ci0KLSAgICAgICAgaWYgKHJldHZhbCA9 PSBDVVJMTV9PSykKKyAgICAgICAgaWYgKHJlbW92ZUZyb21DdXJsKG1fcmVtb3ZlZEhhbmRsZUxp c3RbMF0pKQogICAgICAgICAgICAgbV9yZW1vdmVkSGFuZGxlTGlzdC5yZW1vdmUoMCk7CiAgICAg fQogfQogCitib29sIEN1cmxEb3dubG9hZE1hbmFnZXI6OmFkZFRvQ3VybChDVVJMKiBjdXJsSGFu ZGxlKQoreworICAgIENVUkxNY29kZSByZXR2YWwgPSBjdXJsX211bHRpX2FkZF9oYW5kbGUobV9j dXJsTXVsdGlIYW5kbGUsIGN1cmxIYW5kbGUpOworICAgIHJldHVybiByZXR2YWwgPT0gQ1VSTE1f T0s7Cit9CisKK2Jvb2wgQ3VybERvd25sb2FkTWFuYWdlcjo6cmVtb3ZlRnJvbUN1cmwoQ1VSTCog Y3VybEhhbmRsZSkKK3sKKyAgICBDVVJMTWNvZGUgcmV0dmFsID0gY3VybF9tdWx0aV9yZW1vdmVf aGFuZGxlKG1fY3VybE11bHRpSGFuZGxlLCBjdXJsSGFuZGxlKTsKKyAgICBpZiAocmV0dmFsID09 IENVUkxNX09LKSB7CisgICAgICAgIGN1cmxfZWFzeV9jbGVhbnVwKGN1cmxIYW5kbGUpOworICAg ICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisgICAgcmV0dXJuIGZhbHNlOworfQorCiB2b2lkIEN1 cmxEb3dubG9hZE1hbmFnZXI6OmRvd25sb2FkVGhyZWFkKHZvaWQqIGRhdGEpCiB7CiAgICAgQ3Vy bERvd25sb2FkTWFuYWdlciogZG93bmxvYWRNYW5hZ2VyID0gcmVpbnRlcnByZXRfY2FzdDxDdXJs RG93bmxvYWRNYW5hZ2VyKj4oZGF0YSk7CkBAIC0xODgsNyArMjAwLDcgQEAgdm9pZCBDdXJsRG93 bmxvYWRNYW5hZ2VyOjpkb3dubG9hZFRocmVhZAogICAgICAgICAgICAgZWxzZQogICAgICAgICAg ICAgICAgIGNhbGxPbk1haW5UaHJlYWQ8Q3VybERvd25sb2FkKiwgQ3VybERvd25sb2FkKj4oQ3Vy bERvd25sb2FkOjpkb3dubG9hZEZhaWxlZENhbGxiYWNrLCBkb3dubG9hZCk7CiAKLSAgICAgICAg ICAgIGN1cmxfbXVsdGlfcmVtb3ZlX2hhbmRsZShkb3dubG9hZE1hbmFnZXItPmdldE11bHRpSGFu ZGxlKCksIG1zZy0+ZWFzeV9oYW5kbGUpOworICAgICAgICAgICAgZG93bmxvYWRNYW5hZ2VyLT5y ZW1vdmVGcm9tQ3VybChtc2ctPmVhc3lfaGFuZGxlKTsKICAgICAgICAgfQogCiAgICAgICAgIGRv d25sb2FkTWFuYWdlci0+c3RvcFRocmVhZElmSWRsZSgpOwpAQCAtMjEyLDkgKzIyNCw2IEBAIEN1 cmxEb3dubG9hZDo6fkN1cmxEb3dubG9hZCgpCiB7CiAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1f bXV0ZXgpOwogCi0gICAgaWYgKG1fY3VybEhhbmRsZSkKLSAgICAgICAgY3VybF9lYXN5X2NsZWFu dXAobV9jdXJsSGFuZGxlKTsKLQogICAgIGlmIChtX3VybCkKICAgICAgICAgZmFzdEZyZWUobV91 cmwpOwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERv d25sb2FkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j dXJsL0N1cmxEb3dubG9hZC5oCShyZXZpc2lvbiAxNTIyODApCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmgJKHdvcmtpbmcgY29weSkKQEAgLTU5 LDYgKzU5LDkgQEAgcHJpdmF0ZToKICAgICBib29sIHJ1blRocmVhZCgpIGNvbnN0IHsgcmV0dXJu IG1fcnVuVGhyZWFkOyB9CiAgICAgdm9pZCBzZXRSdW5UaHJlYWQoYm9vbCBydW5UaHJlYWQpIHsg bV9ydW5UaHJlYWQgPSBydW5UaHJlYWQ7IH0KIAorICAgIGJvb2wgYWRkVG9DdXJsKENVUkwqIGN1 cmxIYW5kbGUpOworICAgIGJvb2wgcmVtb3ZlRnJvbUN1cmwoQ1VSTCogY3VybEhhbmRsZSk7CisK ICAgICBzdGF0aWMgdm9pZCBkb3dubG9hZFRocmVhZCh2b2lkKiBkYXRhKTsKIAogICAgIFRocmVh ZElkZW50aWZpZXIgbV90aHJlYWRJZDsK