118075 2013-06-26 13:41:44 -0700 fourthTier: FTL should support PutByVal 2013-06-26 13:59:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 903871 0 fpizlo 2013-06-26 13:41:44 -0700 Patch forthcoming. 903874 1 205523 fpizlo 2013-06-26 13:44:37 -0700 Created attachment 205523 the patch 903880 2 205523 mhahnenberg 2013-06-26 13:58:34 -0700 Comment on attachment 205523 the patch r=me 903881 3 fpizlo 2013-06-26 13:59:14 -0700 Landed in http://trac.webkit.org/changeset/152014 205523 2013-06-26 13:44:37 -0700 2013-06-26 13:58:34 -0700 the patch blah.patch text/plain 7351 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyMDA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEzLTA2LTI2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Zm91cnRoVGllcjogRlRMIHNob3VsZCBzdXBwb3J0IFB1dEJ5VmFsCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgwNzUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZ0bC9GVExDYXBhYmlsaXRpZXMuY3Bw OgorICAgICAgICAoSlNDOjpGVEw6OmNhbkNvbXBpbGUpOgorICAgICAgICAqIGZ0bC9GVExMb3dl ckRGR1RvTExWTS5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06Omxvd2Vy KToKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZU5vZGUpOgorICAg ICAgICAoSlNDOjpGVEw6Okxvd2VyREZHVG9MTFZNOjpjb21waWxlR2V0QnlWYWwpOgorICAgICAg ICAoTG93ZXJERkdUb0xMVk0pOgorICAgICAgICAoSlNDOjpGVEw6Okxvd2VyREZHVG9MTFZNOjpj b21waWxlUHV0QnlWYWwpOgorCiAyMDEzLTA2LTI1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBs ZS5jb20+CiAKICAgICAgICAgZm91cnRoVGllcjogQ29udmVydCB2ZXJzdXMgQXNJcyBzaG91bGQg aGF2ZSBubyBiZWFyaW5nIG9uIHdoZXRoZXIgd2UgY2FuIGRvIHRoZSBTYW5lQ2hhaW4gb3B0aW1p emF0aW9uIGZvciBkb3VibGUgYXJyYXkgR2V0QnlWYWxzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZnRsL0ZUTENhcGFiaWxpdGllcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCShyZXZpc2lvbiAxNTE5OTkpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTENhcGFiaWxpdGllcy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTExMCw2ICsxMTAsMjYgQEAgaW5saW5lIGJvb2wgY2FuQ29tcGlsZShOb2RlKiBub2Rl KQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9CiAgICAgICAgIGJyZWFrOwor ICAgIGNhc2UgUHV0QnlWYWw6CisgICAgY2FzZSBQdXRCeVZhbEFsaWFzOgorICAgICAgICBzd2l0 Y2ggKG5vZGUtPmFycmF5TW9kZSgpLnR5cGUoKSkgeworICAgICAgICBjYXNlIEFycmF5OjpGb3Jj ZUV4aXQ6CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgY2FzZSBBcnJheTo6SW50 MzI6CisgICAgICAgIGNhc2UgQXJyYXk6OkRvdWJsZToKKyAgICAgICAgY2FzZSBBcnJheTo6Q29u dGlndW91czoKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBkZWZhdWx0OgorICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9CisgICAgICAgIHN3aXRjaCAobm9kZS0+YXJyYXlN b2RlKCkuc3BlY3VsYXRpb24oKSkgeworICAgICAgICBjYXNlIEFycmF5OjpTYW5lQ2hhaW46Cisg ICAgICAgIGNhc2UgQXJyYXk6OkluQm91bmRzOgorICAgICAgICAgICAgYnJlYWs7CisgICAgICAg IGRlZmF1bHQ6CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0KKyAgICAgICAg YnJlYWs7CiAgICAgY2FzZSBDb21wYXJlRXE6CiAgICAgY2FzZSBDb21wYXJlU3RyaWN0RXE6CiAg ICAgICAgIGlmIChub2RlLT5pc0JpbmFyeVVzZUtpbmQoSW50MzJVc2UpKQpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHJldmlzaW9u IDE1MTk5OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0u Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NCwxMiArNzQsMTEgQEAgcHVibGljOgogICAgIAogICAg IHZvaWQgbG93ZXIoKQogICAgIHsKLSAgICAgICAgQ1N0cmluZyBuYW1lID0gdG9DU3RyaW5nKGNv ZGVCbG9jaygpLT5oYXNoKCkpOwogICAgICAgICBtX2Z0bFN0YXRlLm1vZHVsZSA9Ci0gICAgICAg ICAgICBMTFZNTW9kdWxlQ3JlYXRlV2l0aE5hbWVJbkNvbnRleHQobmFtZS5kYXRhKCksIG1fZnRs U3RhdGUuY29udGV4dCk7CisgICAgICAgICAgICBMTFZNTW9kdWxlQ3JlYXRlV2l0aE5hbWVJbkNv bnRleHQoImpzQm9keSIsIG1fZnRsU3RhdGUuY29udGV4dCk7CiAgICAgICAgIAogICAgICAgICBt X2Z0bFN0YXRlLmZ1bmN0aW9uID0gYWRkRnVuY3Rpb24oCi0gICAgICAgICAgICBtX2Z0bFN0YXRl Lm1vZHVsZSwgbmFtZS5kYXRhKCksIGZ1bmN0aW9uVHlwZShtX291dC5pbnQ2NCwgbV9vdXQuaW50 UHRyKSk7CisgICAgICAgICAgICBtX2Z0bFN0YXRlLm1vZHVsZSwgImpzQm9keSIsIGZ1bmN0aW9u VHlwZShtX291dC5pbnQ2NCwgbV9vdXQuaW50UHRyKSk7CiAgICAgICAgIHNldEZ1bmN0aW9uQ2Fs bGluZ0NvbnYobV9mdGxTdGF0ZS5mdW5jdGlvbiwgTExWTUNDYWxsQ29udik7CiAgICAgICAgIAog ICAgICAgICBtX291dC5pbml0aWFsaXplKG1fZnRsU3RhdGUubW9kdWxlLCBtX2Z0bFN0YXRlLmZ1 bmN0aW9uLCBtX2hlYXBzKTsKQEAgLTM2OSw2ICszNjgsMTAgQEAgcHJpdmF0ZToKICAgICAgICAg Y2FzZSBHZXRCeVZhbDoKICAgICAgICAgICAgIGNvbXBpbGVHZXRCeVZhbCgpOwogICAgICAgICAg ICAgYnJlYWs7CisgICAgICAgIGNhc2UgUHV0QnlWYWw6CisgICAgICAgIGNhc2UgUHV0QnlWYWxB bGlhczoKKyAgICAgICAgICAgIGNvbXBpbGVQdXRCeVZhbCgpOworICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgIGNhc2UgR2V0QnlPZmZzZXQ6CiAgICAgICAgICAgICBjb21waWxlR2V0QnlPZmZz ZXQoKTsKICAgICAgICAgICAgIGJyZWFrOwpAQCAtMTE3OCwxMSArMTE4MSwxMyBAQCBwcml2YXRl OgogICAgICAgICAgICAgICAgICAgICBtX3N0YXRlLmZvck5vZGUobV9ub2RlLT5jaGlsZDIoKSku bV92YWx1ZSkpOwogICAgICAgICAgICAgICAgIHNwZWN1bGF0ZShMb2FkRnJvbUhvbGUsIG5vVmFs dWUoKSwgMCwgbV9vdXQuaXNaZXJvNjQocmVzdWx0KSk7CiAgICAgICAgICAgICAgICAgbV9qc1Zh bHVlVmFsdWVzLmFkZChtX25vZGUsIHJlc3VsdCk7Ci0gICAgICAgICAgICAgICAgYnJlYWs7Cisg ICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgCisgICAg ICAgICAgICAvLyBGSVhNRTogSW1wbGVtZW50IGhvbGUvT09CIGxvYWRzIGluIHRoZSBGVEwuCisg ICAgICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4 MDc3CiAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgICAgICAg ICAgYnJlYWs7CisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAgICAgICAgIAog ICAgICAgICBjYXNlIEFycmF5OjpEb3VibGU6IHsKQEAgLTEyMTEsMTMgKzEyMTYsOTcgQEAgcHJp dmF0ZToKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgICAg IAorICAgICAgICAgICAgLy8gRklYTUU6IEltcGxlbWVudCBob2xlL09PQiBsb2FkcyBpbiB0aGUg RlRMLgorICAgICAgICAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExODA3NwogICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAg ICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgICAg ICAgICAKICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9S RUFDSEVEKCk7Ci0gICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAg ICAgfQorICAgIH0KKyAgICAKKyAgICB2b2lkIGNvbXBpbGVQdXRCeVZhbCgpCisgICAgeworICAg ICAgICBFZGdlIGNoaWxkMSA9IG1fZ3JhcGgudmFyQXJnQ2hpbGQobV9ub2RlLCAwKTsKKyAgICAg ICAgRWRnZSBjaGlsZDIgPSBtX2dyYXBoLnZhckFyZ0NoaWxkKG1fbm9kZSwgMSk7CisgICAgICAg IEVkZ2UgY2hpbGQzID0gbV9ncmFwaC52YXJBcmdDaGlsZChtX25vZGUsIDIpOworICAgICAgICBF ZGdlIGNoaWxkNCA9IG1fZ3JhcGgudmFyQXJnQ2hpbGQobV9ub2RlLCAzKTsKKworICAgICAgICBM VmFsdWUgaW5kZXggPSBsb3dJbnQzMihjaGlsZDIpOworICAgICAgICBMVmFsdWUgc3RvcmFnZSA9 IGxvd1N0b3JhZ2UoY2hpbGQ0KTsKKyAgICAgICAgCisgICAgICAgIHN3aXRjaCAobV9ub2RlLT5h cnJheU1vZGUoKS50eXBlKCkpIHsKKyAgICAgICAgY2FzZSBBcnJheTo6SW50MzI6CisgICAgICAg IGNhc2UgQXJyYXk6OkNvbnRpZ3VvdXM6IHsKKyAgICAgICAgICAgIExWYWx1ZSB2YWx1ZSA9IGxv d0pTVmFsdWUoY2hpbGQzLCBNYW51YWxPcGVyYW5kU3BlY3VsYXRpb24pOworICAgICAgICAgICAg CisgICAgICAgICAgICBpZiAobV9ub2RlLT5hcnJheU1vZGUoKS50eXBlKCkgPT0gQXJyYXk6Oklu dDMyKQorICAgICAgICAgICAgICAgIEZUTF9UWVBFX0NIRUNLKGpzVmFsdWVWYWx1ZSh2YWx1ZSks IGNoaWxkMywgU3BlY0ludDMyLCBpc05vdEludDMyKHZhbHVlKSk7CisgICAgICAgICAgICAKKyAg ICAgICAgICAgIFR5cGVkUG9pbnRlciBlbGVtZW50UG9pbnRlciA9IG1fb3V0LmJhc2VJbmRleCgK KyAgICAgICAgICAgICAgICBtX25vZGUtPmFycmF5TW9kZSgpLnR5cGUoKSA9PSBBcnJheTo6SW50 MzIgPworICAgICAgICAgICAgICAgIG1faGVhcHMuaW5kZXhlZEludDMyUHJvcGVydGllcyA6IG1f aGVhcHMuaW5kZXhlZENvbnRpZ3VvdXNQcm9wZXJ0aWVzLAorICAgICAgICAgICAgICAgIHN0b3Jh Z2UsIG1fb3V0Lnplcm9FeHQoaW5kZXgsIG1fb3V0LmludFB0ciksCisgICAgICAgICAgICAgICAg bV9zdGF0ZS5mb3JOb2RlKGNoaWxkMikubV92YWx1ZSk7CisgICAgICAgICAgICAKKyAgICAgICAg ICAgIGlmIChtX25vZGUtPm9wKCkgPT0gUHV0QnlWYWxBbGlhcykgeworICAgICAgICAgICAgICAg IG1fb3V0LnN0b3JlNjQodmFsdWUsIGVsZW1lbnRQb2ludGVyKTsKKyAgICAgICAgICAgICAgICBy ZXR1cm47CisgICAgICAgICAgICB9CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmIChtX25v ZGUtPmFycmF5TW9kZSgpLmlzSW5Cb3VuZHMoKSkgeworICAgICAgICAgICAgICAgIHNwZWN1bGF0 ZSgKKyAgICAgICAgICAgICAgICAgICAgU3RvcmVUb0hvbGVPck91dE9mQm91bmRzLCBub1ZhbHVl KCksIDAsCisgICAgICAgICAgICAgICAgICAgIG1fb3V0LmFib3ZlT3JFcXVhbCgKKyAgICAgICAg ICAgICAgICAgICAgICAgIGluZGV4LCBtX291dC5sb2FkMzIoc3RvcmFnZSwgbV9oZWFwcy5CdXR0 ZXJmbHlfcHVibGljTGVuZ3RoKSkpOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAg ICAgICAvLyBGSVhNRTogSW1wbGVtZW50IGhvbGUvT09CIHN0b3JlcyBpbiB0aGUgRlRMLgorICAg ICAgICAgICAgICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTgwNzcKKyAgICAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAg ICAgICAgICAgfQorICAgICAgICAgICAgCisgICAgICAgICAgICBtX291dC5zdG9yZTY0KHZhbHVl LCBlbGVtZW50UG9pbnRlcik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICAg ICAgICAgIAorICAgICAgICBjYXNlIEFycmF5OjpEb3VibGU6IHsKKyAgICAgICAgICAgIExWYWx1 ZSB2YWx1ZSA9IGxvd0RvdWJsZShjaGlsZDMpOworICAgICAgICAgICAgCisgICAgICAgICAgICBG VExfVFlQRV9DSEVDSygKKyAgICAgICAgICAgICAgICBkb3VibGVWYWx1ZSh2YWx1ZSksIGNoaWxk MywgU3BlY1JlYWxOdW1iZXIsCisgICAgICAgICAgICAgICAgbV9vdXQuZG91YmxlTm90RXF1YWxP clVub3JkZXJlZCh2YWx1ZSwgdmFsdWUpKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgVHlw ZWRQb2ludGVyIGVsZW1lbnRQb2ludGVyID0gbV9vdXQuYmFzZUluZGV4KAorICAgICAgICAgICAg ICAgIG1faGVhcHMuaW5kZXhlZERvdWJsZVByb3BlcnRpZXMsCisgICAgICAgICAgICAgICAgc3Rv cmFnZSwgbV9vdXQuemVyb0V4dChpbmRleCwgbV9vdXQuaW50UHRyKSwKKyAgICAgICAgICAgICAg ICBtX3N0YXRlLmZvck5vZGUoY2hpbGQyKS5tX3ZhbHVlKTsKKworICAgICAgICAgICAgaWYgKG1f bm9kZS0+b3AoKSA9PSBQdXRCeVZhbEFsaWFzKSB7CisgICAgICAgICAgICAgICAgbV9vdXQuc3Rv cmVEb3VibGUodmFsdWUsIGVsZW1lbnRQb2ludGVyKTsKKyAgICAgICAgICAgICAgICByZXR1cm47 CisgICAgICAgICAgICB9CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmIChtX25vZGUtPmFy cmF5TW9kZSgpLmlzSW5Cb3VuZHMoKSkgeworICAgICAgICAgICAgICAgIHNwZWN1bGF0ZSgKKyAg ICAgICAgICAgICAgICAgICAgU3RvcmVUb0hvbGVPck91dE9mQm91bmRzLCBub1ZhbHVlKCksIDAs CisgICAgICAgICAgICAgICAgICAgIG1fb3V0LmFib3ZlT3JFcXVhbCgKKyAgICAgICAgICAgICAg ICAgICAgICAgIGluZGV4LCBtX291dC5sb2FkMzIoc3RvcmFnZSwgbV9oZWFwcy5CdXR0ZXJmbHlf cHVibGljTGVuZ3RoKSkpOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICAv LyBGSVhNRTogSW1wbGVtZW50IGhvbGUvT09CIHN0b3JlcyBpbiB0aGUgRlRMLgorICAgICAgICAg ICAgICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgwNzcK KyAgICAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAg ICAgfQorICAgICAgICAgICAgCisgICAgICAgICAgICBtX291dC5zdG9yZURvdWJsZSh2YWx1ZSwg ZWxlbWVudFBvaW50ZXIpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgICAg ICAgICAKKyAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9S RUFDSEVEKCk7CisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICB9CiAgICAgCg==