117731 2013-06-18 03:14:06 -0700 [WebSpeech] Speech Recognition requires convertValue support in JSDictionary 2014-04-24 16:46:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 praveen.j webkit-unassigned cfleizach commit-queue dev_sachin haraken thorton oldest_to_newest 901331 0 praveen.j 2013-06-18 03:14:06 -0700 Build error occurs while after enabling Speech Recognition feature. In file included from /home/praveen.j/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSSpeechRecognitionEvent.cpp:28:0: /home/praveen.j/WebKit/Source/WebCore/bindings/js/JSDictionary.h: In member function ‘WebCore::JSDictionary::GetPropertyResult WebCore::JSDictionary::tryGetPropertyAndResult(const char*, T*, void (*)(T*, const Result&)) const [with T = WTF::RefPtr<WebCore::SpeechRecognitionResultList>, Result = WTF::RefPtr<WebCore::SpeechRecognitionResultList>]’: /home/praveen.j/WebKit/Source/WebCore/bindings/js/JSDictionary.h:144:107: instantiated from ‘bool WebCore::JSDictionary::tryGetProperty(const char*, Result&) const [with Result = WTF::RefPtr<WebCore::SpeechRecognitionResultList>]’ /home/praveen.j/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSSpeechRecognitionEvent.cpp:98:64: instantiated from here /home/praveen.j/WebKit/Source/WebCore/bindings/js/JSDictionary.h:163:9: error: no matching function for call to ‘WebCore::JSDictionary::convertValue(JSC::ExecState* const&, JSC::JSValue&, WTF::RefPtr<WebCore::SpeechRecognitionResultList>&) const’ 901333 1 204894 praveen.j 2013-06-18 03:33:04 -0700 Created attachment 204894 Patch 901338 2 204894 cdumez 2013-06-18 03:48:48 -0700 Comment on attachment 204894 Patch LGTM, r=me. 901352 3 commit-queue 2013-06-18 04:22:41 -0700 The commit-queue encountered the following flaky tests while processing attachment 204894: media/track/track-remove-crash.html bug 115892 (author: eric.carlson@apple.com) svg/batik/filters/feTile.svg bug 114375 (authors: krit@webkit.org and zimmermann@kde.org) The commit-queue is continuing to process your patch. 901353 4 204894 commit-queue 2013-06-18 04:23:57 -0700 Comment on attachment 204894 Patch Clearing flags on attachment: 204894 Committed r151680: <http://trac.webkit.org/changeset/151680> 901354 5 commit-queue 2013-06-18 04:24:00 -0700 All reviewed patches have been landed. Closing bug. 1003876 6 darin 2014-04-24 16:46:01 -0700 Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. 204894 2013-06-18 03:33:04 -0700 2013-06-18 04:23:57 -0700 Patch WebSpeech-117731.txt text/plain 2640 praveen.j SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTY3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA2LTE4ICBQcmF2ZWVu IFIgSmFkaGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXZWJTcGVlY2hd IFNwZWVjaCBSZWNvZ25pdGlvbiByZXF1aXJlcyBjb252ZXJ0VmFsdWUgc3VwcG9ydCBpbiBKU0Rp Y3Rpb25hcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNzczMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEJ1aWxkIGZhaWxzIGFmdGVyIGVuYWJsaW5nIEVOQUJMRV9TQ1JJUFRFRF9TUEVFQ0ggZmVhdHVy ZS4gVGhpcyBwYXRjaAorICAgICAgICByZXNvbHZlcyB0aGUgaXNzdWUuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3VyLgorCisgICAgICAgICogYmluZGluZ3Mv anMvSlNEaWN0aW9uYXJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRGljdGlvbmFyeTo6Y29u dmVydFZhbHVlKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaDoKKwogMjAx My0wNi0xOCAgTWFyeSBXdSAgPG1hcnkud3VAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAg IFtCbGFja0JlcnJ5XSBvbmx5IG5vdGlmeSBkb3dubG9hZCBjbGllbnQgd2hlbiBkb3dubG9hZCBl cnJvcgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNEaWN0aW9uYXJ5LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuY3Bw CShyZXZpc2lvbiAxNTE2NjUpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rp b25hcnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Miw2ICs1MiwxMCBAQAogI2luY2x1ZGUgIkpT TWVkaWFTdHJlYW0uaCIKICNlbmRpZgogCisjaWYgRU5BQkxFKFNDUklQVEVEX1NQRUVDSCkKKyNp bmNsdWRlICJKU1NwZWVjaFJlY29nbml0aW9uUmVzdWx0TGlzdC5oIgorI2VuZGlmCisKIHVzaW5n IG5hbWVzcGFjZSBKU0M7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTI0OSw2ICsyNTMsMTMg QEAgdm9pZCBKU0RpY3Rpb25hcnk6OmNvbnZlcnRWYWx1ZShKU0M6OkV4ZQogfQogI2VuZGlmCiAK KyNpZiBFTkFCTEUoU0NSSVBURURfU1BFRUNIKQordm9pZCBKU0RpY3Rpb25hcnk6OmNvbnZlcnRW YWx1ZShKU0M6OkV4ZWNTdGF0ZSosIEpTQzo6SlNWYWx1ZSB2YWx1ZSwgUmVmUHRyPFNwZWVjaFJl Y29nbml0aW9uUmVzdWx0TGlzdD4mIHJlc3VsdCkKK3sKKyAgICByZXN1bHQgPSB0b1NwZWVjaFJl Y29nbml0aW9uUmVzdWx0TGlzdCh2YWx1ZSk7Cit9CisjZW5kaWYKKwogYm9vbCBKU0RpY3Rpb25h cnk6OmdldFdpdGhVbmRlZmluZWRPck51bGxDaGVjayhjb25zdCBTdHJpbmcmIHByb3BlcnR5TmFt ZSwgU3RyaW5nJiByZXN1bHQpIGNvbnN0CiB7CiAgICAgQVNTRVJUKGlzVmFsaWQoKSk7CkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaAkocmV2aXNpb24gMTUx NjY1KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNEaWN0aW9uYXJ5LmgJKHdvcmtp bmcgY29weSkKQEAgLTUwLDYgKzUwLDEwIEBAIGNsYXNzIFN0b3JhZ2U7CiBjbGFzcyBUcmFja0Jh c2U7CiBjbGFzcyBWb2lkQ2FsbGJhY2s7CiAKKyNpZiBFTkFCTEUoU0NSSVBURURfU1BFRUNIKQor Y2xhc3MgU3BlZWNoUmVjb2duaXRpb25SZXN1bHRMaXN0OworI2VuZGlmCisKIGNsYXNzIEpTRGlj dGlvbmFyeSB7CiBwdWJsaWM6CiAgICAgSlNEaWN0aW9uYXJ5KEpTQzo6RXhlY1N0YXRlKiBleGVj LCBKU0M6OkpTT2JqZWN0KiBpbml0aWFsaXplck9iamVjdCkKQEAgLTEyNyw2ICsxMzEsOSBAQCBw cml2YXRlOgogICAgIHN0YXRpYyB2b2lkIGNvbnZlcnRWYWx1ZShKU0M6OkV4ZWNTdGF0ZSosIEpT Qzo6SlNWYWx1ZSwgUmVmUHRyPERPTUVycm9yPiYgcmVzdWx0KTsKICAgICBzdGF0aWMgdm9pZCBj b252ZXJ0VmFsdWUoSlNDOjpFeGVjU3RhdGUqLCBKU0M6OkpTVmFsdWUsIFJlZlB0cjxWb2lkQ2Fs bGJhY2s+JiByZXN1bHQpOwogI2VuZGlmCisjaWYgRU5BQkxFKFNDUklQVEVEX1NQRUVDSCkKKyAg ICBzdGF0aWMgdm9pZCBjb252ZXJ0VmFsdWUoSlNDOjpFeGVjU3RhdGUqLCBKU0M6OkpTVmFsdWUs IFJlZlB0cjxTcGVlY2hSZWNvZ25pdGlvblJlc3VsdExpc3Q+Jik7CisjZW5kaWYKIAogICAgIEpT Qzo6RXhlY1N0YXRlKiBtX2V4ZWM7CiAgICAgSlNDOjpTdHJvbmc8SlNDOjpKU09iamVjdD4gbV9p bml0aWFsaXplck9iamVjdDsK