117441 2013-06-10 16:40:24 -0700 Fix build error and warning 2013-06-10 17:46:51 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ljaehun.lim webkit-unassigned cmarcelo commit-queue luiz noam seokju zeno oldest_to_newest 898824 0 ljaehun.lim 2013-06-10 16:40:24 -0700 Error: WebKit/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp: In static member function ‘static WTF::PassRefPtr<WebKit::WebView> WebKit::WebView::create(WebKit::WebContext*, WebKit::WebPageGroup*)’: WebKit/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp:49:54: error: cannot allocate an object of abstract type ‘WebKit::WebViewEfl’ WebKit/Source/WebKit2/UIProcess/efl/WebViewEfl.h:35:7: note: because the following virtual functions are pure within ‘WebKit::WebViewEfl’: WebKit/Source/WebKit2/UIProcess/PageClient.h:115:18: note: virtual void WebKit::PageClient::preferencesDidChange() WebKit/Source/WebKit2/UIProcess/efl/WebViewEfl.cpp:50:1: error: control reaches end of non-void function [-Werror=return-type] Warning: WebKit/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:392:31: warning: unused parameter ‘page’ [-Wunused-parameter] 898828 1 204225 ljaehun.lim 2013-06-10 16:44:33 -0700 Created attachment 204225 Patch 898835 2 seokju 2013-06-10 16:48:54 -0700 *** Bug 117445 has been marked as a duplicate of this bug. *** 898920 3 commit-queue 2013-06-10 17:45:53 -0700 The commit-queue encountered the following flaky tests while processing attachment 204225: platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org, krit@webkit.org, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) http/tests/inspector/inspect-element.html bug 78869 (author: pfeldman@chromium.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) compositing/overflow/overflow-compositing-descendant.html bug 116485 (authors: mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) compositing/reflections/load-video-in-reflection.html bug 117427 (authors: mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) The commit-queue is continuing to process your patch. 898921 4 204225 commit-queue 2013-06-10 17:46:48 -0700 Comment on attachment 204225 Patch Clearing flags on attachment: 204225 Committed r151413: <http://trac.webkit.org/changeset/151413> 898922 5 commit-queue 2013-06-10 17:46:51 -0700 All reviewed patches have been landed. Closing bug. 204225 2013-06-10 16:44:33 -0700 2013-06-10 17:46:47 -0700 Patch bug-117441-20130611084255.patch text/plain 2433 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmQ5ZjhmYmRjOWIzZTM3 NWMyYjdhYWQ5NWJmNjg4MGI4YTExOWNhYi4uZDAyMTFkMzMyYzc0ZTFiYTRiNDRlMWFhMGI2YmJl NWYyNGFjMzY1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTEwICBKYWVo dW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIGVy cm9yIGFuZCB3YXJuaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTc0NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJWaWV3OjpwcmVmZXJlbmNlc0RpZENoYW5nZSk6IEFkZGVkLgorICAg ICAgICAoV2ViS2l0OjpXZWJWaWV3OjpjcmVhdGVQb3B1cE1lbnVQcm94eSk6IFJlbW92ZSAncGFn ZScuCisgICAgICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5oOgor CiAyMDEzLTA2LTEwICBTZXJnaW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5v cmc+CiAKICAgICAgICAgW1dLMl1bQ29vcmRpbmF0ZWRHcmFwaGljc10gQWRkIGRlZmF1bHQgY2Fz ZSB0byBzd2l0Y2hlcyB0byBmaXggc3RyaWN0IGJ1aWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwCmluZGV4IGNm NzRmOWZhMjI5YTUxNzJmM2M4NTcyOGM5M2ZlNTVlMmZjZjYxYWQuLmU1NjA2YTlhNTQyY2FhM2U5 OTcxOGVmYjEzYjQwOWRhMjQ2YWI4Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwCkBAIC0zMjUsNiArMzI1 LDExIEBAIHZvaWQgV2ViVmlldzo6cGFnZUNsb3NlZCgpCiAgICAgbm90SW1wbGVtZW50ZWQoKTsK IH0KIAordm9pZCBXZWJWaWV3OjpwcmVmZXJlbmNlc0RpZENoYW5nZSgpCit7CisgICAgbm90SW1w bGVtZW50ZWQoKTsKK30KKwogdm9pZCBXZWJWaWV3Ojp0b29sVGlwQ2hhbmdlZChjb25zdCBTdHJp bmcmLCBjb25zdCBTdHJpbmcmIG5ld1Rvb2xUaXApCiB7CiAgICAgbV9jbGllbnQuZGlkQ2hhbmdl VG9vbHRpcCh0aGlzLCBuZXdUb29sVGlwKTsKQEAgLTM4NCw3ICszODksNyBAQCB2b2lkIFdlYlZp ZXc6OmRvbmVXaXRoVG91Y2hFdmVudChjb25zdCBOYXRpdmVXZWJUb3VjaEV2ZW50JiwgYm9vbCAv Kndhc0V2ZW50SGFuZAogfQogI2VuZGlmCiAKLVBhc3NSZWZQdHI8V2ViUG9wdXBNZW51UHJveHk+ IFdlYlZpZXc6OmNyZWF0ZVBvcHVwTWVudVByb3h5KFdlYlBhZ2VQcm94eSogcGFnZSkKK1Bhc3NS ZWZQdHI8V2ViUG9wdXBNZW51UHJveHk+IFdlYlZpZXc6OmNyZWF0ZVBvcHVwTWVudVByb3h5KFdl YlBhZ2VQcm94eSopCiB7CiAgICAgbm90SW1wbGVtZW50ZWQoKTsKICAgICByZXR1cm4gMDsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dl YlZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dl YlZpZXcuaAppbmRleCBmOTgyODMyYjg5ODM2ZjdjMWM5NDQ4MWU0MTIzZjE2Yzk1M2VjOTVlLi40 M2E1MWVlZjM5YWQ3YzQxNzhlODhiYWYyZTY3ZGUyMTY5MmYwMWE4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmgKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5oCkBA IC0xMzUsNiArMTM1LDggQEAgcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWxhdW5j aFByb2Nlc3MoKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgcGFnZUNsb3NlZCgpIE9WRVJS SURFOwogCisgICAgdmlydHVhbCB2b2lkIHByZWZlcmVuY2VzRGlkQ2hhbmdlKCkgT1ZFUlJJREU7 CisKICAgICB2aXJ0dWFsIHZvaWQgdG9vbFRpcENoYW5nZWQoY29uc3QgU3RyaW5nJiwgY29uc3Qg U3RyaW5nJikgT1ZFUlJJREU7CiAKICAgICB2aXJ0dWFsIHZvaWQgcGFnZURpZFJlcXVlc3RTY3Jv bGwoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmKSBPVkVSUklERTsK