117308 2013-06-06 10:33:04 -0700 [CSS Shapes] Rename updateLineBoundariesForExclusions to updateLineBoundariesForShapes 2013-06-06 15:49:22 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89256 1 zoltan zoltan commit-queue esprehn+autocc glenn oldest_to_newest 897844 0 zoltan 2013-06-06 10:33:04 -0700 We have a standalone specification for CSS Shapes now: ​http://dev.w3.org/csswg/css-shapes/ so this change renames updateLineBoundariesForExclusions to updateLineBoundariesForShapes. 897846 1 203949 zoltan 2013-06-06 10:36:23 -0700 Created attachment 203949 proposed patch 897934 2 203949 achicu 2013-06-06 14:53:14 -0700 Comment on attachment 203949 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=203949&action=review > Source/WebCore/rendering/RenderBlock.h:1087 > + void updateLineBoundariesForShapes(ExclusionShapeInsideInfo*, LayoutUnit&, LineLayoutState&, bool&); nit: the name is a little confusing. what about updateShapeAndSegmentsForCurrentLine ? 897960 3 zoltan 2013-06-06 15:49:22 -0700 (In reply to comment #2) > nit: the name is a little confusing. what about updateShapeAndSegmentsForCurrentLine ? Thanks for the review! Updated and landed in: http://trac.webkit.org/changeset/151295 203949 2013-06-06 10:36:23 -0700 2013-06-06 14:54:57 -0700 proposed patch rename.patch text/plain 3859 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZWMxMTI3Li41OWZkNGZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDYtMDYgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NTUyBTaGFwZXNdIFJlbmFtZSB1cGRhdGVMaW5lQm91bmRhcmllc0ZvckV4Y2x1c2lv bnMgdG8gdXBkYXRlTGluZUJvdW5kYXJpZXNGb3JTaGFwZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzMwOAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGhhdmUgYSBzdGFuZGFsb25lIHNwZWNpZmlj YXRpb24gZm9yIENTUyBTaGFwZXMgbm93OiBodHRwOi8vZGV2LnczLm9yZy9jc3N3Zy9jc3Mtc2hh cGVzLworICAgICAgICB0aGlzIGNoYW5nZSByZW5hbWVzIHVwZGF0ZUxpbmVCb3VuZGFyaWVzRm9y RXhjbHVzaW9ucyB0byB1cGRhdGVMaW5lQm91bmRhcmllc0ZvclNoYXBlcy4KKworICAgICAgICBO byBiZWhhdmlvciBjaGFuZ2UsIG5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyQmxvY2suaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5l TGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjp1cGRhdGVMaW5lQm91 bmRhcmllc0ZvclNoYXBlcyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6bGF5b3V0 UnVuc0FuZEZsb2F0c0luUmFuZ2UpOgorCiAyMDEzLTA2LTA2ICBSYWR1IFN0YXZpbGEgIDxzdGF2 aWxhQGFkb2JlLmNvbT4KIAogICAgICAgICA6aG92ZXIgc3R5bGUgbm90IGFwcGxpZWQgb24gaG92 ZXIgaWYgaXRzIGRpc3BsYXkgcHJvcGVydHkgaXMgZGlmZmVyZW50IGZyb20gb3JpZ2luYWwgc3R5 bGUncwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAppbmRleCBkM2RjYTNmLi5m ZTM2ZjFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2su aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaApAQCAtMTA4NCw3 ICsxMDg0LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGxheW91dFJ1bnNBbmRGbG9hdHMoTGluZUxh eW91dFN0YXRlJiwgYm9vbCBoYXNJbmxpbmVDaGlsZCk7CiAgICAgdm9pZCBsYXlvdXRSdW5zQW5k RmxvYXRzSW5SYW5nZShMaW5lTGF5b3V0U3RhdGUmLCBJbmxpbmVCaWRpUmVzb2x2ZXImLCBjb25z dCBJbmxpbmVJdGVyYXRvciYgY2xlYW5MaW5lU3RhcnQsIGNvbnN0IEJpZGlTdGF0dXMmIGNsZWFu TGluZUJpZGlTdGF0dXMsIHVuc2lnbmVkIGNvbnNlY3V0aXZlSHlwaGVuYXRlZExpbmVzKTsKICNp ZiBFTkFCTEUoQ1NTX1NIQVBFUykKLSAgICB2b2lkIHVwZGF0ZUxpbmVCb3VuZGFyaWVzRm9yRXhj bHVzaW9ucyhFeGNsdXNpb25TaGFwZUluc2lkZUluZm8qLCBMYXlvdXRVbml0JiwgTGluZUxheW91 dFN0YXRlJiwgYm9vbCYpOworICAgIHZvaWQgdXBkYXRlTGluZUJvdW5kYXJpZXNGb3JTaGFwZXMo RXhjbHVzaW9uU2hhcGVJbnNpZGVJbmZvKiwgTGF5b3V0VW5pdCYsIExpbmVMYXlvdXRTdGF0ZSYs IGJvb2wmKTsKICAgICBib29sIGFkanVzdExvZ2ljYWxMaW5lVG9wQW5kTG9naWNhbEhlaWdodElm TmVlZGVkKEV4Y2x1c2lvblNoYXBlSW5zaWRlSW5mbyosIExheW91dFVuaXQsIExpbmVMYXlvdXRT dGF0ZSYsIElubGluZUJpZGlSZXNvbHZlciYsIEZsb2F0aW5nT2JqZWN0KiwgSW5saW5lSXRlcmF0 b3ImLCBXb3JkTWVhc3VyZW1lbnRzJik7CiAjZW5kaWYKICAgICBjb25zdCBJbmxpbmVJdGVyYXRv ciYgcmVzdGFydExheW91dFJ1bnNBbmRGbG9hdHNJblJhbmdlKExheW91dFVuaXQgb2xkTG9naWNh bEhlaWdodCwgTGF5b3V0VW5pdCBuZXdMb2dpY2FsSGVpZ2h0LCAgRmxvYXRpbmdPYmplY3QqIGxh c3RGbG9hdEZyb21QcmV2aW91c0xpbmUsIElubGluZUJpZGlSZXNvbHZlciYsICBjb25zdCBJbmxp bmVJdGVyYXRvciYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrTGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxv Y2tMaW5lTGF5b3V0LmNwcAppbmRleCBmZDljN2M5Li5kY2YzMzM0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcApAQCAtMTY0NCw3 ICsxNjQ0LDcgQEAgc3RhdGljIGlubGluZSBMYXlvdXRVbml0IGFkanVzdExvZ2ljYWxMaW5lVG9w KEV4Y2x1c2lvblNoYXBlSW5zaWRlSW5mbyogZXhjbHVzaW8KICAgICByZXR1cm4gZXhjbHVzaW9u U2hhcGVJbnNpZGVJbmZvLT5zaGFwZUxvZ2ljYWxCb3R0b20oKTsKIH0KIAotdm9pZCBSZW5kZXJC bG9jazo6dXBkYXRlTGluZUJvdW5kYXJpZXNGb3JFeGNsdXNpb25zKEV4Y2x1c2lvblNoYXBlSW5z aWRlSW5mbyogZXhjbHVzaW9uU2hhcGVJbnNpZGVJbmZvLCBMYXlvdXRVbml0JiBhYnNvbHV0ZUxv Z2ljYWxUb3AsIExpbmVMYXlvdXRTdGF0ZSYgbGF5b3V0U3RhdGUsIGJvb2wmIGxpbmVPdmVyZmxv d3NGcm9tU2hhcGVJbnNpZGUpCit2b2lkIFJlbmRlckJsb2NrOjp1cGRhdGVMaW5lQm91bmRhcmll c0ZvclNoYXBlcyhFeGNsdXNpb25TaGFwZUluc2lkZUluZm8qIGV4Y2x1c2lvblNoYXBlSW5zaWRl SW5mbywgTGF5b3V0VW5pdCYgYWJzb2x1dGVMb2dpY2FsVG9wLCBMaW5lTGF5b3V0U3RhdGUmIGxh eW91dFN0YXRlLCBib29sJiBsaW5lT3ZlcmZsb3dzRnJvbVNoYXBlSW5zaWRlKQogewogICAgIExh eW91dFVuaXQgbG9naWNhbEhlaWdodCA9IHRoaXMtPmxvZ2ljYWxIZWlnaHQoKTsKICAgICBSZW5k ZXJSZWdpb24qIGN1cnJlbnRSZWdpb24gPSByZWdpb25BdEJsb2NrT2Zmc2V0KGxvZ2ljYWxIZWln aHQpOwpAQCAtMTc2OSw3ICsxNzY5LDcgQEAgdm9pZCBSZW5kZXJCbG9jazo6bGF5b3V0UnVuc0Fu ZEZsb2F0c0luUmFuZ2UoTGluZUxheW91dFN0YXRlJiBsYXlvdXRTdGF0ZSwgSW5saW4KICAgICAg ICAgRmxvYXRpbmdPYmplY3QqIGxhc3RGbG9hdEZyb21QcmV2aW91c0xpbmUgPSAoY29udGFpbnNG bG9hdHMoKSkgPyBtX2Zsb2F0aW5nT2JqZWN0cy0+c2V0KCkubGFzdCgpIDogMDsKIAogI2lmIEVO QUJMRShDU1NfU0hBUEVTKQotICAgICAgICB1cGRhdGVMaW5lQm91bmRhcmllc0ZvckV4Y2x1c2lv bnMoZXhjbHVzaW9uU2hhcGVJbnNpZGVJbmZvLCBhYnNvbHV0ZUxvZ2ljYWxUb3AsIGxheW91dFN0 YXRlLCBsaW5lT3ZlcmZsb3dzRnJvbVNoYXBlSW5zaWRlKTsKKyAgICAgICAgdXBkYXRlTGluZUJv dW5kYXJpZXNGb3JTaGFwZXMoZXhjbHVzaW9uU2hhcGVJbnNpZGVJbmZvLCBhYnNvbHV0ZUxvZ2lj YWxUb3AsIGxheW91dFN0YXRlLCBsaW5lT3ZlcmZsb3dzRnJvbVNoYXBlSW5zaWRlKTsKICNlbmRp ZgogICAgICAgICBXb3JkTWVhc3VyZW1lbnRzIHdvcmRNZWFzdXJlbWVudHM7CiAgICAgICAgIGVu ZCA9IGxpbmVCcmVha2VyLm5leHRMaW5lQnJlYWsocmVzb2x2ZXIsIGxheW91dFN0YXRlLmxpbmVJ bmZvKCksIHJlbmRlclRleHRJbmZvLCBsYXN0RmxvYXRGcm9tUHJldmlvdXNMaW5lLCBjb25zZWN1 dGl2ZUh5cGhlbmF0ZWRMaW5lcywgd29yZE1lYXN1cmVtZW50cyk7Cg==