116828 2013-05-27 08:08:54 -0700 [CSSRegions] Prevent unnecessary copy of LayoutRect objects 2013-05-27 08:51:48 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mihnea webkit-unassigned commit-queue esprehn+autocc glenn WebkitBugTracker oldest_to_newest 894030 0 mihnea 2013-05-27 08:08:54 -0700 Use const references for parameter passing for LayoutRect objects. 894032 1 202985 mihnea 2013-05-27 08:11:30 -0700 Created attachment 202985 Patch 894034 2 202985 kling 2013-05-27 08:16:57 -0700 Comment on attachment 202985 Patch r=me 894060 3 commit-queue 2013-05-27 08:50:25 -0700 The commit-queue encountered the following flaky tests while processing attachment 202985: media/track/track-remove-crash.html bug 115892 (author: eric.carlson@apple.com) The commit-queue is continuing to process your patch. 894063 4 202985 commit-queue 2013-05-27 08:51:46 -0700 Comment on attachment 202985 Patch Clearing flags on attachment: 202985 Committed r150761: <http://trac.webkit.org/changeset/150761> 894064 5 commit-queue 2013-05-27 08:51:48 -0700 All reviewed patches have been landed. Closing bug. 202985 2013-05-27 08:11:30 -0700 2013-05-27 08:51:46 -0700 Patch 116828.patch text/plain 6146 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNGVmODVkLi5kODE1NDUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDUtMjcgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTU1JlZ2lvbnNdIFByZXZlbnQgdW5uZWNlc3NhcnkgY29weSBvZiBMYXlvdXRSZWN0 IG9iamVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNjgyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVzZSBjb25zdCByZWZlcmVuY2VzIGZvciBwYXJhbWV0ZXIgcGFzc2luZy4KKyAgICAgICAgTm8g ZnVuY3Rpb25hbCBjaGFuZ2UsIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJGbG93VGhyZWFkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZsb3dUaHJlYWQ6 OnBhaW50Rmxvd1RocmVhZFBvcnRpb25JblJlZ2lvbik6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJGbG93VGhyZWFkOjpoaXRUZXN0Rmxvd1RocmVhZFBvcnRpb25JblJlZ2lvbik6CisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyUmVnaW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclJlZ2lvbjo6b3ZlcmZsb3dS ZWN0Rm9yRmxvd1RocmVhZFBvcnRpb24pOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJSZWdp b24uaDoKKwogMjAxMy0wNS0yNyAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgRG9jdW1lbnQ6OnNldEhvdmVyZWROb2RlKCkgc2hvdWxkIGJlIHNldEhvdmVyZWRF bGVtZW50KCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxv d1RocmVhZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5j cHAKaW5kZXggOGIxNGQ2Ny4uMTQ2N2ZjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJGbG93VGhyZWFkLmNwcApAQCAtMjYzLDcgKzI2Myw3IEBAIExheW91dFJlY3QgUmVu ZGVyRmxvd1RocmVhZDo6Y29tcHV0ZVJlZ2lvbkNsaXBwaW5nUmVjdChjb25zdCBMYXlvdXRQb2lu dCYgb2Zmc2V0CiAgICAgcmV0dXJuIHJlZ2lvbkNsaXBwaW5nUmVjdDsKIH0KIAotdm9pZCBSZW5k ZXJGbG93VGhyZWFkOjpwYWludEZsb3dUaHJlYWRQb3J0aW9uSW5SZWdpb24oUGFpbnRJbmZvJiBw YWludEluZm8sIFJlbmRlclJlZ2lvbiogcmVnaW9uLCBMYXlvdXRSZWN0IGZsb3dUaHJlYWRQb3J0 aW9uUmVjdCwgTGF5b3V0UmVjdCBmbG93VGhyZWFkUG9ydGlvbk92ZXJmbG93UmVjdCwgY29uc3Qg TGF5b3V0UG9pbnQmIHBhaW50T2Zmc2V0KSBjb25zdAordm9pZCBSZW5kZXJGbG93VGhyZWFkOjpw YWludEZsb3dUaHJlYWRQb3J0aW9uSW5SZWdpb24oUGFpbnRJbmZvJiBwYWludEluZm8sIFJlbmRl clJlZ2lvbiogcmVnaW9uLCBjb25zdCBMYXlvdXRSZWN0JiBmbG93VGhyZWFkUG9ydGlvblJlY3Qs IGNvbnN0IExheW91dFJlY3QmIGZsb3dUaHJlYWRQb3J0aW9uT3ZlcmZsb3dSZWN0LCBjb25zdCBM YXlvdXRQb2ludCYgcGFpbnRPZmZzZXQpIGNvbnN0CiB7CiAgICAgR3JhcGhpY3NDb250ZXh0KiBj b250ZXh0ID0gcGFpbnRJbmZvLmNvbnRleHQ7CiAgICAgaWYgKCFjb250ZXh0KQpAQCAtMzE2LDcg KzMxNiw3IEBAIGJvb2wgUmVuZGVyRmxvd1RocmVhZDo6bm9kZUF0UG9pbnQoY29uc3QgSGl0VGVz dFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQmCiAgICAgcmV0dXJuIFJlbmRlckJsb2Nr Ojpub2RlQXRQb2ludChyZXF1ZXN0LCByZXN1bHQsIGxvY2F0aW9uSW5Db250YWluZXIsIGFjY3Vt dWxhdGVkT2Zmc2V0LCBoaXRUZXN0QWN0aW9uKTsKIH0KIAotYm9vbCBSZW5kZXJGbG93VGhyZWFk OjpoaXRUZXN0Rmxvd1RocmVhZFBvcnRpb25JblJlZ2lvbihSZW5kZXJSZWdpb24qIHJlZ2lvbiwg TGF5b3V0UmVjdCBmbG93VGhyZWFkUG9ydGlvblJlY3QsIExheW91dFJlY3QgZmxvd1RocmVhZFBv cnRpb25PdmVyZmxvd1JlY3QsIGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiByZXF1ZXN0LCBIaXRUZXN0 UmVzdWx0JiByZXN1bHQsIGNvbnN0IEhpdFRlc3RMb2NhdGlvbiYgbG9jYXRpb25JbkNvbnRhaW5l ciwgY29uc3QgTGF5b3V0UG9pbnQmIGFjY3VtdWxhdGVkT2Zmc2V0KSBjb25zdAorYm9vbCBSZW5k ZXJGbG93VGhyZWFkOjpoaXRUZXN0Rmxvd1RocmVhZFBvcnRpb25JblJlZ2lvbihSZW5kZXJSZWdp b24qIHJlZ2lvbiwgY29uc3QgTGF5b3V0UmVjdCYgZmxvd1RocmVhZFBvcnRpb25SZWN0LCBjb25z dCBMYXlvdXRSZWN0JiBmbG93VGhyZWFkUG9ydGlvbk92ZXJmbG93UmVjdCwgY29uc3QgSGl0VGVz dFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwgY29uc3QgSGl0VGVzdExv Y2F0aW9uJiBsb2NhdGlvbkluQ29udGFpbmVyLCBjb25zdCBMYXlvdXRQb2ludCYgYWNjdW11bGF0 ZWRPZmZzZXQpIGNvbnN0CiB7CiAgICAgTGF5b3V0UmVjdCByZWdpb25DbGlwcGluZ1JlY3QgPSBj b21wdXRlUmVnaW9uQ2xpcHBpbmdSZWN0KGFjY3VtdWxhdGVkT2Zmc2V0LCBmbG93VGhyZWFkUG9y dGlvblJlY3QsIGZsb3dUaHJlYWRQb3J0aW9uT3ZlcmZsb3dSZWN0KTsKICAgICBpZiAoIXJlZ2lv bkNsaXBwaW5nUmVjdC5jb250YWlucyhsb2NhdGlvbkluQ29udGFpbmVyLnBvaW50KCkpKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuaCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmgKaW5kZXggMjBhZWE5ZC4u MGMyMmY0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dU aHJlYWQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5o CkBAIC03Nyw4ICs3Nyw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlTG9naWNh bFdpZHRoKCkgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIGNvbXB1dGVMb2dpY2FsSGVpZ2h0 KExheW91dFVuaXQgbG9naWNhbEhlaWdodCwgTGF5b3V0VW5pdCBsb2dpY2FsVG9wLCBMb2dpY2Fs RXh0ZW50Q29tcHV0ZWRWYWx1ZXMmKSBjb25zdCBPVkVSUklERTsKIAotICAgIHZvaWQgcGFpbnRG bG93VGhyZWFkUG9ydGlvbkluUmVnaW9uKFBhaW50SW5mbyYsIFJlbmRlclJlZ2lvbiosIExheW91 dFJlY3QgZmxvd1RocmVhZFBvcnRpb25SZWN0LCBMYXlvdXRSZWN0IGZsb3dUaHJlYWRQb3J0aW9u T3ZlcmZsb3dSZWN0LCBjb25zdCBMYXlvdXRQb2ludCYpIGNvbnN0OwotICAgIGJvb2wgaGl0VGVz dEZsb3dUaHJlYWRQb3J0aW9uSW5SZWdpb24oUmVuZGVyUmVnaW9uKiwgTGF5b3V0UmVjdCBmbG93 VGhyZWFkUG9ydGlvblJlY3QsIExheW91dFJlY3QgZmxvd1RocmVhZFBvcnRpb25PdmVyZmxvd1Jl Y3QsIGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiwgSGl0VGVzdFJlc3VsdCYsIGNvbnN0IEhpdFRlc3RM b2NhdGlvbiYgbG9jYXRpb25JbkNvbnRhaW5lciwgY29uc3QgTGF5b3V0UG9pbnQmIGFjY3VtdWxh dGVkT2Zmc2V0KSBjb25zdDsKKyAgICB2b2lkIHBhaW50Rmxvd1RocmVhZFBvcnRpb25JblJlZ2lv bihQYWludEluZm8mLCBSZW5kZXJSZWdpb24qLCBjb25zdCBMYXlvdXRSZWN0JiBmbG93VGhyZWFk UG9ydGlvblJlY3QsIGNvbnN0IExheW91dFJlY3QmIGZsb3dUaHJlYWRQb3J0aW9uT3ZlcmZsb3dS ZWN0LCBjb25zdCBMYXlvdXRQb2ludCYpIGNvbnN0OworICAgIGJvb2wgaGl0VGVzdEZsb3dUaHJl YWRQb3J0aW9uSW5SZWdpb24oUmVuZGVyUmVnaW9uKiwgY29uc3QgTGF5b3V0UmVjdCYgZmxvd1Ro cmVhZFBvcnRpb25SZWN0LCBjb25zdCBMYXlvdXRSZWN0JiBmbG93VGhyZWFkUG9ydGlvbk92ZXJm bG93UmVjdCwgY29uc3QgSGl0VGVzdFJlcXVlc3QmLCBIaXRUZXN0UmVzdWx0JiwgY29uc3QgSGl0 VGVzdExvY2F0aW9uJiBsb2NhdGlvbkluQ29udGFpbmVyLCBjb25zdCBMYXlvdXRQb2ludCYgYWNj dW11bGF0ZWRPZmZzZXQpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBub2RlQXRQb2ludChjb25z dCBIaXRUZXN0UmVxdWVzdCYsIEhpdFRlc3RSZXN1bHQmLCBjb25zdCBIaXRUZXN0TG9jYXRpb24m IGxvY2F0aW9uSW5Db250YWluZXIsIGNvbnN0IExheW91dFBvaW50JiBhY2N1bXVsYXRlZE9mZnNl dCwgSGl0VGVzdEFjdGlvbikgT1ZFUlJJREU7CiAKICAgICBib29sIGhhc1JlZ2lvbnMoKSBjb25z dCB7IHJldHVybiBtX3JlZ2lvbkxpc3Quc2l6ZSgpOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJSZWdpb24uY3BwCmluZGV4IDlkNzM1NWUuLjI2MTE5Y2IgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwCkBAIC05OCw3ICs5OCw3IEBAIExheW91dFJl Y3QgUmVuZGVyUmVnaW9uOjpmbG93VGhyZWFkUG9ydGlvbk92ZXJmbG93UmVjdCgpIGNvbnN0CiAg ICAgcmV0dXJuIG92ZXJmbG93UmVjdEZvckZsb3dUaHJlYWRQb3J0aW9uKGZsb3dUaHJlYWRQb3J0 aW9uUmVjdCgpLCBpc0ZpcnN0UmVnaW9uKCksIGlzTGFzdFJlZ2lvbigpKTsKIH0KIAotTGF5b3V0 UmVjdCBSZW5kZXJSZWdpb246Om92ZXJmbG93UmVjdEZvckZsb3dUaHJlYWRQb3J0aW9uKExheW91 dFJlY3QgZmxvd1RocmVhZFBvcnRpb25SZWN0LCBib29sIGlzRmlyc3RQb3J0aW9uLCBib29sIGlz TGFzdFBvcnRpb24pIGNvbnN0CitMYXlvdXRSZWN0IFJlbmRlclJlZ2lvbjo6b3ZlcmZsb3dSZWN0 Rm9yRmxvd1RocmVhZFBvcnRpb24oY29uc3QgTGF5b3V0UmVjdCYgZmxvd1RocmVhZFBvcnRpb25S ZWN0LCBib29sIGlzRmlyc3RQb3J0aW9uLCBib29sIGlzTGFzdFBvcnRpb24pIGNvbnN0CiB7CiAg ICAgQVNTRVJUKGlzVmFsaWQoKSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJSZWdpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdp b24uaAppbmRleCBlMmY1NWVlLi5hMzFmMTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclJlZ2lvbi5oCkBAIC0xMzYsNyArMTM2LDcgQEAgcHJvdGVjdGVkOgogICAgIHZpcnR1YWwg dm9pZCBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocygpIE9WRVJSSURFOwogICAgIHZpcnR1 YWwgdm9pZCBjb21wdXRlSW50cmluc2ljTG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5Mb2dp Y2FsV2lkdGgsIExheW91dFVuaXQmIG1heExvZ2ljYWxXaWR0aCkgY29uc3QgT1ZFUlJJREU7CiAK LSAgICBMYXlvdXRSZWN0IG92ZXJmbG93UmVjdEZvckZsb3dUaHJlYWRQb3J0aW9uKExheW91dFJl Y3QgZmxvd1RocmVhZFBvcnRpb25SZWN0LCBib29sIGlzRmlyc3RQb3J0aW9uLCBib29sIGlzTGFz dFBvcnRpb24pIGNvbnN0OworICAgIExheW91dFJlY3Qgb3ZlcmZsb3dSZWN0Rm9yRmxvd1RocmVh ZFBvcnRpb24oY29uc3QgTGF5b3V0UmVjdCYgZmxvd1RocmVhZFBvcnRpb25SZWN0LCBib29sIGlz Rmlyc3RQb3J0aW9uLCBib29sIGlzTGFzdFBvcnRpb24pIGNvbnN0OwogICAgIHZvaWQgcmVwYWlu dEZsb3dUaHJlYWRDb250ZW50UmVjdGFuZ2xlKGNvbnN0IExheW91dFJlY3QmIHJlcGFpbnRSZWN0 LCBib29sIGltbWVkaWF0ZSwgY29uc3QgTGF5b3V0UmVjdCYgZmxvd1RocmVhZFBvcnRpb25SZWN0 LAogICAgICAgICBjb25zdCBMYXlvdXRSZWN0JiBmbG93VGhyZWFkUG9ydGlvbk92ZXJmbG93UmVj dCwgY29uc3QgTGF5b3V0UG9pbnQmIHJlZ2lvbkxvY2F0aW9uKSBjb25zdDsKIAo=